79194 2012-02-21 22:04:56 -0800 [EFL] Build warning: Fix warn_unused_result warnings 2012-03-07 01:24:26 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 bw80.lee webkit-unassigned gyuyoung.kim lucas.de.marchi rakuco s.choi webkit.review.bot oldest_to_newest 561607 0 bw80.lee 2012-02-21 22:04:56 -0800 Hi, I met some build warnings on building webkit efl port. ** On release build ($ ./Tools/Scripts/build-webkit --efl) ... [ 49%] Building CXX object Source/WebCore/CMakeFiles/webcore_efl.dir/platform/ContextMenu.cpp.o /WebKit/Source/WebCore/platform/ContextMenu.cpp: In function const WebCore::ContextMenuItem* WebCore::findItemWithAction(unsigned int, const WTF::Vector<WebCore::ContextMenuItem, 0u>&): /WebKit/Source/WebCore/platform/ContextMenu.cpp:41: warning: comparison between signed and unsigned integer expressions ... [ 96%] Building CXX object Source/WebCore/CMakeFiles/webcore_efl.dir/platform/efl/SharedTimerEfl.cpp.o /WebKit/Source/WebCore/platform/efl/SharedBufferEfl.cpp: In static member function static WTF::PassRefPtr<WebCore::SharedBuffer> WebCore::SharedBuffer::createWithContentsOfFile(const WTF::String&): /WebKit/Source/WebCore/platform/efl/SharedBufferEfl.cpp:64: warning: ignoring return value of size_t fread(void*, size_t, size_t, FILE*), declared with attribute warn_unused_result ... [100%] Building CXX object Source/WebKit/CMakeFiles/ewebkit.dir/efl/ewk/ewk_window_features.cpp.o /WebKit/Source/WebKit/efl/ewk/ewk_view_single.cpp: In function void _ewk_view_screen_move(uint32_t*, size_t, size_t, size_t, size_t, size_t, size_t, size_t): /WebKit/Source/WebKit/efl/ewk/ewk_view_single.cpp:109: warning: comparison between signed and unsigned integer expressions /WebKit/Source/WebKit/efl/ewk/ewk_view_single.cpp:116: warning: comparison between signed and unsigned integer expressions ... [100%] Building C object Tools/EWebLauncher/CMakeFiles/bin/EWebLauncher.dir/main.c.o /WebKit/Tools/DumpRenderTree/efl/ImageDiff.cpp: In function void printImage(Evas_Object*): /WebKit/Tools/DumpRenderTree/efl/ImageDiff.cpp:213: warning: ignoring return value of ssize_t write(int, const void*, size_t), declared with attribute warn_unused_result ... ** On build for DRT test ($ ./Tools/Scripts/build-webkit --efl --touch-events --touch-icon-loading \ --blob --device-orientation --fullscreen-api \ --geolocation --notifications --orientation-events \ --video --workers --shared-workers --request-animation-frame \ --page-visibility-api --cmakearg="-DSHARED_CORE=ON") ... [ 74%] Building CXX object Source/WebCore/CMakeFiles/webcore_efl.dir/bindings/js/JSEventCustom.cpp.o /WebKit/Source/WebCore/bindings/js/JSDocumentCustom.cpp: In member function JSC::JSValue WebCore::JSDocument::createTouchList(JSC::ExecState*): /WebKit/Source/WebCore/bindings/js/JSDocumentCustom.cpp:122: warning: comparison between signed and unsigned integer expressions ... [ 96%] Building CXX object Source/WebCore/CMakeFiles/webcore_efl.dir/platform/efl/SharedBufferEfl.cpp.o /WebKit/Source/WebCore/platform/efl/SharedBufferEfl.cpp: In static member function static WTF::PassRefPtr<WebCore::SharedBuffer> WebCore::SharedBuffer::createWithContentsOfFile(const WTF::String&): /WebKit/Source/WebCore/platform/efl/SharedBufferEfl.cpp:64: warning: ignoring return value of size_t fread(void*, size_t, size_t, FILE*), declared with attribute warn_unused_result ... 563003 1 bw80.lee 2012-02-23 03:04:55 -0800 Changed title to '[EFL] Build warning: Fix warn_unused_result warnings'. And re-scoping this bug only for warn_unused_result warning. ** On release build ($ ./Tools/Scripts/build-webkit --efl) ... [100%] Building C object Tools/EWebLauncher/CMakeFiles/bin/EWebLauncher.dir/main.c.o /WebKit/Tools/DumpRenderTree/efl/ImageDiff.cpp: In function void printImage(Evas_Object*): /WebKit/Tools/DumpRenderTree/efl/ImageDiff.cpp:213: warning: ignoring return value of ssize_t write(int, const void*, size_t), declared with attribute warn_unused_result ... ** On build for DRT test ($ ./Tools/Scripts/build-webkit --efl --touch-events --touch-icon-loading \ --blob --device-orientation --fullscreen-api \ --geolocation --notifications --orientation-events \ --video --workers --shared-workers --request-animation-frame \ --page-visibility-api --cmakearg="-DSHARED_CORE=ON") ... [ 96%] Building CXX object Source/WebCore/CMakeFiles/webcore_efl.dir/platform/efl/SharedBufferEfl.cpp.o /WebKit/Source/WebCore/platform/efl/SharedBufferEfl.cpp: In static member function static WTF::PassRefPtr<WebCore::SharedBuffer> WebCore::SharedBuffer::createWithContentsOfFile(const WTF::String&): /WebKit/Source/WebCore/platform/efl/SharedBufferEfl.cpp:64: warning: ignoring return value of size_t fread(void*, size_t, size_t, FILE*), declared with attribute warn_unused_result ... 571352 2 130263 bw80.lee 2012-03-05 18:46:38 -0800 Created attachment 130263 Patch 571365 3 130263 rakuco 2012-03-05 19:13:00 -0800 Comment on attachment 130263 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130263&action=review > Source/WebCore/platform/efl/SharedBufferEfl.cpp:71 > - fread(result->m_buffer.data(), 1, fileStat.st_size, file); > + if (static_cast<unsigned>(fileStat.st_size) != fread(result->m_buffer.data(), 1, fileStat.st_size, file)) { > + fclose(file); > + return 0; > + } > + > fclose(file); > > return result.release(); How about const size_t freadResult = fread(...); fclose(file); const bool readSuccessful = (freadResult == static_cast<size_t>(fileStat.st_size)); return readSucessful ? result.relase() : 0; > Tools/DumpRenderTree/efl/ImageDiff.cpp:218 > + } while ((bytesWritten += count) < bytesRead); Personally, I find (bytesWritten += count) here weird to read (no pun intended :-). How about moving the increase operation inside the do-while loop? 571437 4 bw80.lee 2012-03-05 21:00:26 -0800 Thanks for your comment. > How about > > const size_t freadResult = fread(...); > fclose(file); > > const bool readSuccessful = (freadResult == static_cast<size_t>(fileStat.st_size)); > > return readSucessful ? result.relase() : 0; This looks better for me also, and I think 'readSuccessful' is redundant. How about the below? - fread(result->m_buffer.data(), 1, fileStat.st_size, file); + const size_t bytesRead = fread(result->m_buffer.data(), 1, fileStat.st_size, file); fclose(file); - return result.release(); + return bytesRead == static_cast<unsigned>(fileStat.st_size) ? result.release() : 0; > > Tools/DumpRenderTree/efl/ImageDiff.cpp:218 > > + } while ((bytesWritten += count) < bytesRead); > > Personally, I find (bytesWritten += count) here weird to read (no pun intended :-). How about moving the increase operation inside the do-while loop? Ok~ I'll fix as below + bytesWritten += count; + } while (bytesWritten < bytesRead); 571732 5 rakuco 2012-03-06 04:42:53 -0800 (In reply to comment #4) > How about the below? > > - fread(result->m_buffer.data(), 1, fileStat.st_size, file); > + const size_t bytesRead = fread(result->m_buffer.data(), 1, fileStat.st_size, file); > fclose(file); > > - return result.release(); > + return bytesRead == static_cast<unsigned>(fileStat.st_size) ? result.release() : 0; That's OK too. 571753 6 130358 bw80.lee 2012-03-06 05:05:35 -0800 Created attachment 130358 Patch 572623 7 130358 fpizlo 2012-03-07 00:06:03 -0800 Comment on attachment 130358 Patch r=me. 572685 8 130358 webkit.review.bot 2012-03-07 01:24:22 -0800 Comment on attachment 130358 Patch Clearing flags on attachment: 130358 Committed r110035: <http://trac.webkit.org/changeset/110035> 572686 9 webkit.review.bot 2012-03-07 01:24:26 -0800 All reviewed patches have been landed. Closing bug. 130263 2012-03-05 18:46:38 -0800 2012-03-06 05:05:25 -0800 Patch bug-79194-20120306114636.patch text/plain 3371 bw80.lee U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5ODMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWQzNTYwZTU3YWY3NDMz ZTQ2MGEzOTdiNDJjMTI5OGViOWE5OGRjYy4uY2EwMmM1MmJmYzY3OWRhOTJjNjlhZjZiOTIwNTk3 YzdiMzZlMDdjZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAzLTA1ICBCeXVu Z3dvbyBMZWUgIDxidzgwLmxlZUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSBCdWlsZCB3 YXJuaW5nOiBGaXggd2Fybl91bnVzZWRfcmVzdWx0IHdhcm5pbmdzLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzkxOTQKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXhlZCBidWlsZCB3YXJuaW5nIHdoaWNo IGlzIGdldHRpbmcgZ2VuZXJhdGVkIHdoZW4gbm90IHVzaW5nIHJldHVybgorICAgICAgICB2YWx1 ZSBvZiBhIGZ1Y3Rpb24sIGVzcGVjaWFsbHkgZGVjbGFyZWQgd2l0aCB3YXJuX3VudXNlZF9yZXN1 bHQKKyAgICAgICAgYXR0cmlidXRlLgorCisgICAgICAgICogcGxhdGZvcm0vZWZsL1NoYXJlZEJ1 ZmZlckVmbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTaGFyZWRCdWZmZXI6OmNyZWF0ZVdpdGhD b250ZW50c09mRmlsZSk6CisKIDIwMTItMDMtMDUgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0 Lm9yZz4KIAogICAgICAgICBXb3JrZXJDb250ZXh0IHNob3VsZG4ndCBuZWVkIHRvIGtub3cgYWJv dXQgU1FMRGF0YWJhc2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9T aGFyZWRCdWZmZXJFZmwuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1NoYXJlZEJ1 ZmZlckVmbC5jcHAKaW5kZXggYTQzMzdhMGIyYjMxMWM5NTg2Zjk4N2Y1YmU3ODFiNzBlNTkwMDlm OC4uNTU2OTlkMDhiOTM4MmRhZDg2ODhmYmQ1YWMyY2ZhOTQzN2QyNjczMiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1NoYXJlZEJ1ZmZlckVmbC5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1NoYXJlZEJ1ZmZlckVmbC5jcHAKQEAgLTYxLDcgKzYx LDExIEBAIFBhc3NSZWZQdHI8U2hhcmVkQnVmZmVyPiBTaGFyZWRCdWZmZXI6OmNyZWF0ZVdpdGhD b250ZW50c09mRmlsZShjb25zdCBTdHJpbmcmIGZpCiAgICAgICAgIHJldHVybiAwOwogICAgIH0K IAotICAgIGZyZWFkKHJlc3VsdC0+bV9idWZmZXIuZGF0YSgpLCAxLCBmaWxlU3RhdC5zdF9zaXpl LCBmaWxlKTsKKyAgICBpZiAoc3RhdGljX2Nhc3Q8dW5zaWduZWQ+KGZpbGVTdGF0LnN0X3NpemUp ICE9IGZyZWFkKHJlc3VsdC0+bV9idWZmZXIuZGF0YSgpLCAxLCBmaWxlU3RhdC5zdF9zaXplLCBm aWxlKSkgeworICAgICAgICBmY2xvc2UoZmlsZSk7CisgICAgICAgIHJldHVybiAwOworICAgIH0K KwogICAgIGZjbG9zZShmaWxlKTsKIAogICAgIHJldHVybiByZXN1bHQucmVsZWFzZSgpOwpkaWZm IC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDM0MmYxNGM1 YzBiZDIxMjQ3NmVmYzQwYzFlNzg2NWVjYjRjNDcwMjcuLmYzMTZhZWI4MWUzNzQxMTNmNGM5NDNj NTQwNDg4MTRjNDgwZmQ5ZmQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29s cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMi0wMy0wNSAgQnl1bmd3b28gTGVlICA8 Ync4MC5sZWVAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gQnVpbGQgd2FybmluZzogRml4 IHdhcm5fdW51c2VkX3Jlc3VsdCB3YXJuaW5ncy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTc5MTk0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgRml4ZWQgYnVpbGQgd2FybmluZyB3aGljaCBpcyBnZXR0aW5n IGdlbmVyYXRlZCB3aGVuIG5vdCB1c2luZyByZXR1cm4KKyAgICAgICAgdmFsdWUgb2YgYSBmdWN0 aW9uLCBlc3BlY2lhbGx5IGRlY2xhcmVkIHdpdGggd2Fybl91bnVzZWRfcmVzdWx0CisgICAgICAg IGF0dHJpYnV0ZS4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2VmbC9JbWFnZURpZmYuY3Bw OgorICAgICAgICAocHJpbnRJbWFnZSk6CisKIDIwMTItMDMtMDUgIERpcmsgUHJhbmtlICA8ZHBy YW5rZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVGhlcmUgc2hvdWxkIGJlIGEgd2F5IHRvIGRp c2FibGUgb3B0aW1pemVyIGluIHdlYmtpdC1wYXRjaCByZWJhc2VsaW5lLWV4cGVjdGF0aW9ucwpk aWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvZWZsL0ltYWdlRGlmZi5jcHAgYi9Ub29s cy9EdW1wUmVuZGVyVHJlZS9lZmwvSW1hZ2VEaWZmLmNwcAppbmRleCA3NTRlY2IyMmFhOGNjZGZi YzFmOTE0MGQ5MjcwMTAxZDJiYTMzYjI1Li41NjhjZjdjODE4OTQ1N2I2OTQ3YjAzNmJiY2QyMjJj OGE0ZDkwY2YwIDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9lZmwvSW1hZ2VEaWZm LmNwcAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9lZmwvSW1hZ2VEaWZmLmNwcApAQCAtMjA5 LDggKzIwOSwxNCBAQCBzdGF0aWMgdm9pZCBwcmludEltYWdlKEV2YXNfT2JqZWN0KiBpbWFnZSkK IAogICAgICAgICAgICAgdW5zaWduZWQgY2hhciBidWZmZXJbMjA0OF07CiAgICAgICAgICAgICBz c2l6ZV90IGJ5dGVzUmVhZDsKLSAgICAgICAgICAgIHdoaWxlICgoYnl0ZXNSZWFkID0gcmVhZCh0 ZW1wSW1hZ2VGZCwgYnVmZmVyLCBzaXplb2YoYnVmZmVyKSkpID4gMCkKLSAgICAgICAgICAgICAg ICB3cml0ZSgxLCBidWZmZXIsIGJ5dGVzUmVhZCk7CisgICAgICAgICAgICB3aGlsZSAoKGJ5dGVz UmVhZCA9IHJlYWQodGVtcEltYWdlRmQsIGJ1ZmZlciwgc2l6ZW9mKGJ1ZmZlcikpKSA+IDApIHsK KyAgICAgICAgICAgICAgICBzc2l6ZV90IGJ5dGVzV3JpdHRlbiA9IDA7CisgICAgICAgICAgICAg ICAgc3NpemVfdCBjb3VudDsKKyAgICAgICAgICAgICAgICBkbyB7CisgICAgICAgICAgICAgICAg ICAgIGlmICgoY291bnQgPSB3cml0ZSgxLCBidWZmZXIgKyBieXRlc1dyaXR0ZW4sIGJ5dGVzUmVh ZCAtIGJ5dGVzV3JpdHRlbikpIDw9IDApCisgICAgICAgICAgICAgICAgICAgICAgICBicmVhazsK KyAgICAgICAgICAgICAgICB9IHdoaWxlICgoYnl0ZXNXcml0dGVuICs9IGNvdW50KSA8IGJ5dGVz UmVhZCk7CisgICAgICAgICAgICB9CiAgICAgICAgIH0KICAgICB9CiAgICAgY2xvc2UodGVtcElt YWdlRmQpOwo= 130358 2012-03-06 05:05:35 -0800 2012-03-07 01:24:22 -0800 Patch bug-79194-20120306220532.patch text/plain 3448 bw80.lee U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5ODMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWQzNTYwZTU3YWY3NDMz ZTQ2MGEzOTdiNDJjMTI5OGViOWE5OGRjYy4uY2EwMmM1MmJmYzY3OWRhOTJjNjlhZjZiOTIwNTk3 YzdiMzZlMDdjZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAzLTA1ICBCeXVu Z3dvbyBMZWUgIDxidzgwLmxlZUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSBCdWlsZCB3 YXJuaW5nOiBGaXggd2Fybl91bnVzZWRfcmVzdWx0IHdhcm5pbmdzLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzkxOTQKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXhlZCBidWlsZCB3YXJuaW5nIHdoaWNo IGlzIGdldHRpbmcgZ2VuZXJhdGVkIHdoZW4gbm90IHVzaW5nIHJldHVybgorICAgICAgICB2YWx1 ZSBvZiBhIGZ1Y3Rpb24sIGVzcGVjaWFsbHkgZGVjbGFyZWQgd2l0aCB3YXJuX3VudXNlZF9yZXN1 bHQKKyAgICAgICAgYXR0cmlidXRlLgorCisgICAgICAgICogcGxhdGZvcm0vZWZsL1NoYXJlZEJ1 ZmZlckVmbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTaGFyZWRCdWZmZXI6OmNyZWF0ZVdpdGhD b250ZW50c09mRmlsZSk6CisKIDIwMTItMDMtMDUgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0 Lm9yZz4KIAogICAgICAgICBXb3JrZXJDb250ZXh0IHNob3VsZG4ndCBuZWVkIHRvIGtub3cgYWJv dXQgU1FMRGF0YWJhc2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9T aGFyZWRCdWZmZXJFZmwuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1NoYXJlZEJ1 ZmZlckVmbC5jcHAKaW5kZXggYTQzMzdhMGIyYjMxMWM5NTg2Zjk4N2Y1YmU3ODFiNzBlNTkwMDlm OC4uOWU3NjQ2ZDFjMDc5NDM0ZTJhMmNiZjE1Njk1MTNmMWNmMmYzNTBhNSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1NoYXJlZEJ1ZmZlckVmbC5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1NoYXJlZEJ1ZmZlckVmbC5jcHAKQEAgLTYxLDEwICs2 MSwxMCBAQCBQYXNzUmVmUHRyPFNoYXJlZEJ1ZmZlcj4gU2hhcmVkQnVmZmVyOjpjcmVhdGVXaXRo Q29udGVudHNPZkZpbGUoY29uc3QgU3RyaW5nJiBmaQogICAgICAgICByZXR1cm4gMDsKICAgICB9 CiAKLSAgICBmcmVhZChyZXN1bHQtPm1fYnVmZmVyLmRhdGEoKSwgMSwgZmlsZVN0YXQuc3Rfc2l6 ZSwgZmlsZSk7CisgICAgY29uc3Qgc2l6ZV90IGJ5dGVzUmVhZCA9IGZyZWFkKHJlc3VsdC0+bV9i dWZmZXIuZGF0YSgpLCAxLCBmaWxlU3RhdC5zdF9zaXplLCBmaWxlKTsKICAgICBmY2xvc2UoZmls ZSk7CiAKLSAgICByZXR1cm4gcmVzdWx0LnJlbGVhc2UoKTsKKyAgICByZXR1cm4gYnl0ZXNSZWFk ID09IHN0YXRpY19jYXN0PHVuc2lnbmVkPihmaWxlU3RhdC5zdF9zaXplKSA/IHJlc3VsdC5yZWxl YXNlKCkgOiAwOwogfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCmRpZmYgLS1naXQgYS9Ub29s cy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzQyZjE0YzVjMGJkMjEyNDc2ZWZj NDBjMWU3ODY1ZWNiNGM0NzAyNy4uZjMxNmFlYjgxZTM3NDExM2Y0Yzk0M2M1NDA0ODgxNGM0ODBm ZDlmZCAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE3IEBACisyMDEyLTAzLTA1ICBCeXVuZ3dvbyBMZWUgIDxidzgwLmxlZUBzYW1z dW5nLmNvbT4KKworICAgICAgICBbRUZMXSBCdWlsZCB3YXJuaW5nOiBGaXggd2Fybl91bnVzZWRf cmVzdWx0IHdhcm5pbmdzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NzkxOTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBGaXhlZCBidWlsZCB3YXJuaW5nIHdoaWNoIGlzIGdldHRpbmcgZ2VuZXJhdGVkIHdo ZW4gbm90IHVzaW5nIHJldHVybgorICAgICAgICB2YWx1ZSBvZiBhIGZ1Y3Rpb24sIGVzcGVjaWFs bHkgZGVjbGFyZWQgd2l0aCB3YXJuX3VudXNlZF9yZXN1bHQKKyAgICAgICAgYXR0cmlidXRlLgor CisgICAgICAgICogRHVtcFJlbmRlclRyZWUvZWZsL0ltYWdlRGlmZi5jcHA6CisgICAgICAgIChw cmludEltYWdlKToKKwogMjAxMi0wMy0wNSAgRGlyayBQcmFua2UgIDxkcHJhbmtlQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBUaGVyZSBzaG91bGQgYmUgYSB3YXkgdG8gZGlzYWJsZSBvcHRpbWl6 ZXIgaW4gd2Via2l0LXBhdGNoIHJlYmFzZWxpbmUtZXhwZWN0YXRpb25zCmRpZmYgLS1naXQgYS9U b29scy9EdW1wUmVuZGVyVHJlZS9lZmwvSW1hZ2VEaWZmLmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJU cmVlL2VmbC9JbWFnZURpZmYuY3BwCmluZGV4IDc1NGVjYjIyYWE4Y2NkZmJjMWY5MTQwZDkyNzAx MDFkMmJhMzNiMjUuLjg4YTBlNGExZjQyMzQwNjYyYTZmMTA1MjE0MGRiYzU3NTQwMTRjODcgMTAw NjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9JbWFnZURpZmYuY3BwCisrKyBiL1Rv b2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9JbWFnZURpZmYuY3BwCkBAIC0yMDksOCArMjA5LDE1IEBA IHN0YXRpYyB2b2lkIHByaW50SW1hZ2UoRXZhc19PYmplY3QqIGltYWdlKQogCiAgICAgICAgICAg ICB1bnNpZ25lZCBjaGFyIGJ1ZmZlclsyMDQ4XTsKICAgICAgICAgICAgIHNzaXplX3QgYnl0ZXNS ZWFkOwotICAgICAgICAgICAgd2hpbGUgKChieXRlc1JlYWQgPSByZWFkKHRlbXBJbWFnZUZkLCBi dWZmZXIsIHNpemVvZihidWZmZXIpKSkgPiAwKQotICAgICAgICAgICAgICAgIHdyaXRlKDEsIGJ1 ZmZlciwgYnl0ZXNSZWFkKTsKKyAgICAgICAgICAgIHdoaWxlICgoYnl0ZXNSZWFkID0gcmVhZCh0 ZW1wSW1hZ2VGZCwgYnVmZmVyLCBzaXplb2YoYnVmZmVyKSkpID4gMCkgeworICAgICAgICAgICAg ICAgIHNzaXplX3QgYnl0ZXNXcml0dGVuID0gMDsKKyAgICAgICAgICAgICAgICBzc2l6ZV90IGNv dW50OworICAgICAgICAgICAgICAgIGRvIHsKKyAgICAgICAgICAgICAgICAgICAgaWYgKChjb3Vu dCA9IHdyaXRlKDEsIGJ1ZmZlciArIGJ5dGVzV3JpdHRlbiwgYnl0ZXNSZWFkIC0gYnl0ZXNXcml0 dGVuKSkgPD0gMCkKKyAgICAgICAgICAgICAgICAgICAgICAgIGJyZWFrOworICAgICAgICAgICAg ICAgICAgICBieXRlc1dyaXR0ZW4gKz0gY291bnQ7CisgICAgICAgICAgICAgICAgfSB3aGlsZSAo Ynl0ZXNXcml0dGVuIDwgYnl0ZXNSZWFkKTsKKyAgICAgICAgICAgIH0KICAgICAgICAgfQogICAg IH0KICAgICBjbG9zZSh0ZW1wSW1hZ2VGZCk7Cg==