79183 2012-02-21 19:03:55 -0800 [chromium] Avoid culling work for fully-non-opaque tiles, and add tracing for draw culling 2012-03-02 11:44:35 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 danakj danakj backer cc-bugs commit-queue enne jamesr piman vangelis webkit.review.bot wjmaclean oldest_to_newest 561480 0 danakj 2012-02-21 19:03:55 -0800 [chromium] Avoid culling work for fully-non-opaque tiles, and add tracing for draw culling 561485 1 128109 danakj 2012-02-21 19:07:38 -0800 Created attachment 128109 Patch 561597 2 128109 vangelis 2012-02-21 21:52:15 -0800 Comment on attachment 128109 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128109&action=review (Unofficially) LGTM > Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:244 > + TRACE_EVENT("CCLayerTreeHostImpl::optimizeRenderPasses()", this, 0); Maybe a good opportunity to also report the # of passes here too? 561606 3 128109 jamesr 2012-02-21 22:04:47 -0800 Comment on attachment 128109 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128109&action=review >> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:244 >> + TRACE_EVENT("CCLayerTreeHostImpl::optimizeRenderPasses()", this, 0); > > Maybe a good opportunity to also report the # of passes here too? We haven't been putting the '()' in traces for functions before. There's no really strong reason for or against this convention, but it's what we've been using so I'd like to stay consistent. I believe you can pass parameters efficiently now by using the TRACE_EVENT1() macro instead of TRACE_EVENT. See the comments in TraceEvent.h for details 561991 4 128109 vangelis 2012-02-22 08:02:48 -0800 Comment on attachment 128109 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128109&action=review > Source/WebCore/platform/graphics/chromium/cc/CCQuadCuller.cpp:104 > + if (keepQuad && drawQuad->isLayerAxisAlignedIntRect() && !drawQuad->opaqueRect().isEmpty()) { One more quick comment: I think this loop could be simplified if you add an early out ("continue") after line 96: if (!keepQuad) continue; That way you won't need to keep checking that keepQuad == true 563764 5 128621 danakj 2012-02-23 17:48:09 -0800 Created attachment 128621 Patch Looking for review again to make sure I got this TRACE_EVENT foo correct. I had to cast the passes.size() to make it compile, as size_t confused it and it wasn't sure if "unsigned long" should be an "unsigned long long" or an "unsigned int", etc. @vangelis good call with the continue! 563769 6 128621 jamesr 2012-02-23 17:55:44 -0800 Comment on attachment 128621 Patch Thumbsup! 564148 7 webkit.review.bot 2012-02-24 02:59:05 -0800 The commit-queue encountered the following flaky tests while processing attachment 128621: perf/mouse-event.html bug 78736 (author: eae@chromium.org) The commit-queue is continuing to process your patch. 564149 8 128621 webkit.review.bot 2012-02-24 03:01:09 -0800 Comment on attachment 128621 Patch Clearing flags on attachment: 128621 Committed r108764: <http://trac.webkit.org/changeset/108764> 564150 9 webkit.review.bot 2012-02-24 03:01:14 -0800 All reviewed patches have been landed. Closing bug. 569804 10 danakj 2012-03-02 11:44:35 -0800 *** Bug 76578 has been marked as a duplicate of this bug. *** 128109 2012-02-21 19:07:38 -0800 2012-02-23 17:48:05 -0800 Patch bug-79183-20120221220736.patch text/plain 2920 danakj U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4NDEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTU1OTczZWQ0M2ZmNmUz MDg0YTBjZWViOTkxODlhMGExYjYwNmUzOS4uYzE3Yjc3Zjk4YjdlNDVhOTAwOGIxMWQyM2E2NzQ5 NDhhMDc1ZjcyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTAyLTIxICBEYW5h IEphbnNlbnMgIDxkYW5ha2pAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gQXZv aWQgY3VsbGluZyB3b3JrIGZvciBmdWxseS1ub24tb3BhcXVlIHRpbGVzLCBhbmQgYWRkIHRyYWNp bmcgZm9yIGRyYXcgY3VsbGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NzkxODMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBBZGRyZXNzZXMgcGVyZm9ybWFuY2UgaXNzdWVzIHdpdGggZHJhdyBjdWxsaW5n IGJ5IGF2b2lkaW5nIHRoZSB3b3JrCisgICAgICAgIG9mIG1hcFJlY3QgYW5kIG90aGVyIGZ1bmN0 aW9uIGNhbGxzIHdoZW4gdGhlIHF1YWQgaGFzIG5vIG9wYXF1ZSBhcmVhLgorICAgICAgICBBbmQg YWRkcyBhIFRSQUNFX0VWRU5UIHRvIHdhdGNoIHRoZSB0aW1lIHNwZW5kIGluIGRyYXcgY3VsbGlu Zy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJUcmVl SG9zdEltcGwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q0NMYXllclRyZWVIb3N0SW1wbDo6b3B0 aW1pemVSZW5kZXJQYXNzZXMpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVt L2NjL0NDUXVhZEN1bGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDQ1F1YWRDdWxsZXI6OmN1 bGxPY2NsdWRlZFF1YWRzKToKKwogMjAxMi0wMi0yMSAgTHVrZSBNYWNwaGVyc29uICAgPG1hY3Bo ZXJzb25AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEltcGxlbWVudCBtYW55IGluc3RhbmNlcyBv ZiBIQU5ETEVfSU5IRVJJVF9BTkRfSU5JVElBTF9BTkRfUFJJTUlUSVZFIGluIENTU1N0eWxlQXBw bHlQcm9wZXJ0eS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2Nocm9taXVtL2NjL0NDTGF5ZXJUcmVlSG9zdEltcGwuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NMYXllclRyZWVIb3N0SW1wbC5jcHAKaW5kZXgg MDU0YmViMzJlZTUzNTljYmM1YmE1NGY5MWI2YTk2YzE1NDBmZjViNS4uNmZhMWZjYTZiNDRhZjgw NTczYzI1YmY3OWYzMWIzMjE1NmYzOGNhNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NMYXllclRyZWVIb3N0SW1wbC5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NMYXllclRyZWVI b3N0SW1wbC5jcHAKQEAgLTI0MSw2ICsyNDEsOCBAQCB2b2lkIENDTGF5ZXJUcmVlSG9zdEltcGw6 OmNhbGN1bGF0ZVJlbmRlclBhc3NlcyhDQ1JlbmRlclBhc3NMaXN0JiBwYXNzZXMsIENDTGF5ZQog CiB2b2lkIENDTGF5ZXJUcmVlSG9zdEltcGw6Om9wdGltaXplUmVuZGVyUGFzc2VzKENDUmVuZGVy UGFzc0xpc3QmIHBhc3NlcykKIHsKKyAgICBUUkFDRV9FVkVOVCgiQ0NMYXllclRyZWVIb3N0SW1w bDo6b3B0aW1pemVSZW5kZXJQYXNzZXMoKSIsIHRoaXMsIDApOworCiAgICAgZm9yICh1bnNpZ25l ZCBpID0gMDsgaSA8IHBhc3Nlcy5zaXplKCk7ICsraSkKICAgICAgICAgcGFzc2VzW2ldLT5vcHRp bWl6ZVF1YWRzKCk7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9jaHJvbWl1bS9jYy9DQ1F1YWRDdWxsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NRdWFkQ3VsbGVyLmNwcAppbmRleCBjOGJkOWIwZjM2 MzI0YWY2ZThhNGJjMWZiNWEyNDA4ZmYwMzE0NTRkLi40NTFlNjQ3MmY5OTc3YTU1NmNlZDI1ZDQw ODJjZTMxMTcyZmEyZTVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9jaHJvbWl1bS9jYy9DQ1F1YWRDdWxsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDUXVhZEN1bGxlci5jcHAKQEAgLTEwMSw3ICsx MDEsNyBAQCB2b2lkIENDUXVhZEN1bGxlcjo6Y3VsbE9jY2x1ZGVkUXVhZHMoQ0NRdWFkTGlzdCYg cXVhZExpc3QpCiAgICAgICAgICAgICBkcmF3UXVhZC0+c2V0UXVhZFZpc2libGVSZWN0KGRyYXdR dWFkLT5xdWFkVHJhbnNmb3JtKCkuaW52ZXJzZSgpLm1hcFJlY3QodHJhbnNmb3JtZWRWaXNpYmxl UXVhZFJlY3QpKTsKIAogICAgICAgICAvLyBXaGVuIGFkZGluZyByZWN0IHRvIG9wYXF1ZSByZWdp b24sIGRlZmxhdGUgaXQgdG8gc3RheSBjb25zZXJ2YXRpdmUuCi0gICAgICAgIGlmIChrZWVwUXVh ZCAmJiBkcmF3UXVhZC0+aXNMYXllckF4aXNBbGlnbmVkSW50UmVjdCgpKSB7CisgICAgICAgIGlm IChrZWVwUXVhZCAmJiBkcmF3UXVhZC0+aXNMYXllckF4aXNBbGlnbmVkSW50UmVjdCgpICYmICFk cmF3UXVhZC0+b3BhcXVlUmVjdCgpLmlzRW1wdHkoKSkgewogICAgICAgICAgICAgRmxvYXRSZWN0 IGZsb2F0T3BhcXVlUmVjdCA9IGRyYXdRdWFkLT5xdWFkVHJhbnNmb3JtKCkubWFwUmVjdChGbG9h dFJlY3QoZHJhd1F1YWQtPm9wYXF1ZVJlY3QoKSkpOwogICAgICAgICAgICAgb3BhcXVlQ292ZXJh Z2VUaHVzRmFyLnVuaXRlKFJlZ2lvbihlbmNsb3NlZEludFJlY3QoZmxvYXRPcGFxdWVSZWN0KSkp OwogICAgICAgICB9Cg== 128621 2012-02-23 17:48:09 -0800 2012-02-24 03:01:09 -0800 Patch bug-79183-20120223204808.patch text/plain 3790 danakj U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4NjY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmUzNjIyMzVmMDg3MmJh NTYwMzk0Y2M2MmU2NWI3ZGU1NDZhNjJiZC4uNTE5NmRjMzUwY2IwZWVkMTdkMzk1NWU4NzgyYmFh NjJlNTVlNTQwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTAyLTIxICBEYW5h IEphbnNlbnMgIDxkYW5ha2pAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gQXZv aWQgY3VsbGluZyB3b3JrIGZvciBmdWxseS1ub24tb3BhcXVlIHRpbGVzLCBhbmQgYWRkIHRyYWNp bmcgZm9yIGRyYXcgY3VsbGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NzkxODMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBBZGRyZXNzZXMgcGVyZm9ybWFuY2UgaXNzdWVzIHdpdGggZHJhdyBjdWxsaW5n IGJ5IGF2b2lkaW5nIHRoZSB3b3JrCisgICAgICAgIG9mIG1hcFJlY3QgYW5kIG90aGVyIGZ1bmN0 aW9uIGNhbGxzIHdoZW4gdGhlIHF1YWQgaGFzIG5vIG9wYXF1ZSBhcmVhLgorICAgICAgICBBbmQg YWRkcyBhIFRSQUNFX0VWRU5UIHRvIHdhdGNoIHRoZSB0aW1lIHNwZW50IGluIGRyYXcgY3VsbGlu Zy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJUcmVl SG9zdEltcGwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q0NMYXllclRyZWVIb3N0SW1wbDo6b3B0 aW1pemVSZW5kZXJQYXNzZXMpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVt L2NjL0NDUXVhZEN1bGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDQ1F1YWRDdWxsZXI6OmN1 bGxPY2NsdWRlZFF1YWRzKToKKwogMjAxMi0wMi0yMyAgS2V2aW4gT2xsaXZpZXIgIDxrZXZpbm9A dGhlb2xsaXZpZXJzLmNvbT4KIAogICAgICAgICBbd3hdIEJ1aWxkIGZpeCwgdXNlIHRoZSBzdHJp bmdzIGluIExvY2FsaXplZFN0cmluZ3MuY3BwLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NMYXllclRyZWVIb3N0SW1wbC5jcHAgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVyVHJlZUhv c3RJbXBsLmNwcAppbmRleCBjZTMxOTUxYTczMTllMTVjNmMzNjVkNGYwNDVjN2ZjZWYwNDY2ZjA5 Li45YWIyMTY4N2UxNzlmN2YwMTNjODk0Y2NlNTQwZjdlNjIzNTA2YjU3IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVyVHJlZUhv c3RJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1 bS9jYy9DQ0xheWVyVHJlZUhvc3RJbXBsLmNwcApAQCAtMjMwLDYgKzIzMCw4IEBAIHZvaWQgQ0NM YXllclRyZWVIb3N0SW1wbDo6Y2FsY3VsYXRlUmVuZGVyUGFzc2VzKENDUmVuZGVyUGFzc0xpc3Qm IHBhc3NlcywgQ0NMYXllCiAKIHZvaWQgQ0NMYXllclRyZWVIb3N0SW1wbDo6b3B0aW1pemVSZW5k ZXJQYXNzZXMoQ0NSZW5kZXJQYXNzTGlzdCYgcGFzc2VzKQogeworICAgIFRSQUNFX0VWRU5UMSgi d2Via2l0IiwgIkNDTGF5ZXJUcmVlSG9zdEltcGw6Om9wdGltaXplUmVuZGVyUGFzc2VzIiwgInBh c3Nlcy5zaXplKCkiLCBzdGF0aWNfY2FzdDxsb25nIGxvbmcgdW5zaWduZWQ+KHBhc3Nlcy5zaXpl KCkpKTsKKwogICAgIGJvb2wgaGF2ZURhbWFnZVJlY3QgPSBsYXllclJlbmRlcmVyQ2FwYWJpbGl0 aWVzKCkudXNpbmdQYXJ0aWFsU3dhcDsKIAogICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBw YXNzZXMuc2l6ZSgpOyArK2kpIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDUXVhZEN1bGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ1F1YWRDdWxsZXIuY3BwCmluZGV4IDIxMjEx NGY3NzM1MWZhNzNjZTk1MDBkNGU3MjE5ZjdiMjU4MDA1OTkuLjRmNjQzNWRjMGYyNjI2MTgyNDA2 YjI4NmRjZDc5ZWU3NThiNmMwYjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDUXVhZEN1bGxlci5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NRdWFkQ3VsbGVyLmNwcApAQCAtOTYs MjAgKzk2LDIxIEBAIHZvaWQgQ0NRdWFkQ3VsbGVyOjpjdWxsT2NjbHVkZWRRdWFkcyhDQ1F1YWRM aXN0JiBxdWFkTGlzdCwgYm9vbCBoYXZlRGFtYWdlUmVjdCwKIAogICAgICAgICBJbnRSZWN0IHRy YW5zZm9ybWVkVmlzaWJsZVF1YWRSZWN0ID0gcmVjdFN1YnRyYWN0UmVnaW9uKG9wYXF1ZUNvdmVy YWdlVGh1c0ZhciwgdHJhbnNmb3JtZWRRdWFkUmVjdCk7CiAgICAgICAgIGJvb2wga2VlcFF1YWQg PSAhdHJhbnNmb3JtZWRWaXNpYmxlUXVhZFJlY3QuaXNFbXB0eSgpOworICAgICAgICBpZiAoIWtl ZXBRdWFkKQorICAgICAgICAgICAgY29udGludWU7CiAKICAgICAgICAgLy8gU2VlIGlmIHdlIGNh biByZWR1Y2UgdGhlIG51bWJlciBvZiBwaXhlbHMgdG8gZHJhdyBieSByZWR1Y2luZyB0aGUgc2l6 ZSBvZiB0aGUgZHJhdwogICAgICAgICAvLyBxdWFkIC0gd2UgZG8gdGhpcyBieSBjaGFuZ2luZyBp dHMgdmlzaWJsZSByZWN0LgotICAgICAgICBpZiAoa2VlcFF1YWQgJiYgdHJhbnNmb3JtZWRWaXNp YmxlUXVhZFJlY3QgIT0gdHJhbnNmb3JtZWRRdWFkUmVjdCAmJiBkcmF3UXVhZC0+aXNMYXllckF4 aXNBbGlnbmVkSW50UmVjdCgpKQorICAgICAgICBpZiAodHJhbnNmb3JtZWRWaXNpYmxlUXVhZFJl Y3QgIT0gdHJhbnNmb3JtZWRRdWFkUmVjdCAmJiBkcmF3UXVhZC0+aXNMYXllckF4aXNBbGlnbmVk SW50UmVjdCgpKQogICAgICAgICAgICAgZHJhd1F1YWQtPnNldFF1YWRWaXNpYmxlUmVjdChkcmF3 UXVhZC0+cXVhZFRyYW5zZm9ybSgpLmludmVyc2UoKS5tYXBSZWN0KHRyYW5zZm9ybWVkVmlzaWJs ZVF1YWRSZWN0KSk7CiAKICAgICAgICAgLy8gV2hlbiBhZGRpbmcgcmVjdCB0byBvcGFxdWUgcmVn aW9uLCBkZWZsYXRlIGl0IHRvIHN0YXkgY29uc2VydmF0aXZlLgotICAgICAgICBpZiAoa2VlcFF1 YWQgJiYgZHJhd1F1YWQtPmlzTGF5ZXJBeGlzQWxpZ25lZEludFJlY3QoKSkgeworICAgICAgICBp ZiAoZHJhd1F1YWQtPmlzTGF5ZXJBeGlzQWxpZ25lZEludFJlY3QoKSAmJiAhZHJhd1F1YWQtPm9w YXF1ZVJlY3QoKS5pc0VtcHR5KCkpIHsKICAgICAgICAgICAgIEZsb2F0UmVjdCBmbG9hdE9wYXF1 ZVJlY3QgPSBkcmF3UXVhZC0+cXVhZFRyYW5zZm9ybSgpLm1hcFJlY3QoRmxvYXRSZWN0KGRyYXdR dWFkLT5vcGFxdWVSZWN0KCkpKTsKICAgICAgICAgICAgIG9wYXF1ZUNvdmVyYWdlVGh1c0Zhci51 bml0ZShSZWdpb24oZW5jbG9zZWRJbnRSZWN0KGZsb2F0T3BhcXVlUmVjdCkpKTsKICAgICAgICAg fQogCi0gICAgICAgIGlmIChrZWVwUXVhZCkKLSAgICAgICAgICAgIGN1bGxlZExpc3QuYXBwZW5k KHF1YWRMaXN0W2ldLnJlbGVhc2UoKSk7CisgICAgICAgIGN1bGxlZExpc3QuYXBwZW5kKHF1YWRM aXN0W2ldLnJlbGVhc2UoKSk7CiAgICAgfQogICAgIHF1YWRMaXN0LmNsZWFyKCk7IC8vIFJlbGVh c2UgYW55dGhpbmcgdGhhdCByZW1haW5zLgogCg==