79174 2012-02-21 18:05:26 -0800 Early-out in Region::unite() for adding an empty region. 2012-02-21 18:58:43 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 danakj danakj andersca backer jamesr piman vangelis webkit.review.bot oldest_to_newest 561440 0 danakj 2012-02-21 18:05:26 -0800 Early-out in Region::unite() for adding an empty region. 561442 1 128099 danakj 2012-02-21 18:06:27 -0800 Created attachment 128099 Patch We've noticed that unite() with an empty region ends up making a copy of the entire current Region, and may also add an empty rect in the return from rects(). This early out saves a lot of work for this case, and fixes Region uniqueness for the given area it covers. 561477 2 128099 webkit.review.bot 2012-02-21 18:58:39 -0800 Comment on attachment 128099 Patch Clearing flags on attachment: 128099 Committed r108433: <http://trac.webkit.org/changeset/108433> 561478 3 webkit.review.bot 2012-02-21 18:58:43 -0800 All reviewed patches have been landed. Closing bug. 128099 2012-02-21 18:06:27 -0800 2012-02-21 18:58:39 -0800 Patch bug-79174-20120221210626.patch text/plain 1283 danakj U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4NDEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTU1OTczZWQ0M2ZmNmUz MDg0YTBjZWViOTkxODlhMGExYjYwNmUzOS4uYWU4Yjg4MGI5Y2JiZWEyNTllNWNkNzk3OWQxYTE1 YjIxNTcxZDY5NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAyLTIxICBEYW5h IEphbnNlbnMgIDxkYW5ha2pAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEVhcmx5LW91dCBpbiBS ZWdpb246OnVuaXRlKCkgZm9yIGFkZGluZyBhbiBlbXB0eSByZWdpb24uCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03OTE3NAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvUmVn aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlZ2lvbjo6dW5pdGUpOgorCiAyMDEyLTAyLTIx ICBMdWtlIE1hY3BoZXJzb24gICA8bWFjcGhlcnNvbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg SW1wbGVtZW50IG1hbnkgaW5zdGFuY2VzIG9mIEhBTkRMRV9JTkhFUklUX0FORF9JTklUSUFMX0FO RF9QUklNSVRJVkUgaW4gQ1NTU3R5bGVBcHBseVByb3BlcnR5LgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvUmVnaW9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL1JlZ2lvbi5jcHAKaW5kZXggNTg0YTNhNWZkNTM3MjBhMzMyZDk3OTRl ZjQxNWFkNjljNmRkODFiZi4uNzg5NTU2NDk2N2Y2MDM1NGE5ZjlmZGVmYWQ0M2ZlMzdiMzgwZGVm NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvUmVnaW9uLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9SZWdpb24uY3BwCkBAIC00 NDMsNiArNDQzLDkgQEAgdm9pZCBSZWdpb246OmludGVyc2VjdChjb25zdCBSZWdpb24mIHJlZ2lv bikKIAogdm9pZCBSZWdpb246OnVuaXRlKGNvbnN0IFJlZ2lvbiYgcmVnaW9uKQogeworICAgIGlm IChyZWdpb24uaXNFbXB0eSgpKQorICAgICAgICByZXR1cm47CisKICAgICBTaGFwZSB1bml0ZWRT aGFwZSA9IFNoYXBlOjp1bmlvblNoYXBlcyhtX3NoYXBlLCByZWdpb24ubV9zaGFwZSk7CiAKICAg ICBtX3NoYXBlLnN3YXAodW5pdGVkU2hhcGUpOwo=