79162 2012-02-21 16:11:03 -0800 ContainerNode::childrenChanged must be called immediately after removing children 2012-02-21 16:34:03 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 adamk adamk rniwa oldest_to_newest 561333 0 adamk 2012-02-21 16:11:03 -0800 ContainerNode::childrenChanged must be called immediately after removing children 561336 1 128071 adamk 2012-02-21 16:13:12 -0800 Created attachment 128071 Patch 561361 2 128071 rniwa 2012-02-21 16:30:14 -0800 Comment on attachment 128071 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128071&action=review > LayoutTests/fast/dom/title-directionality-removeChild.html:21 > + var dir = window.layoutTestController ? > + layoutTestController.titleTextDirection > + : 'layoutTestController unavailable'; Why is this statement split into 3 lines? It seems like it can fit in one line. 561365 3 adamk 2012-02-21 16:34:03 -0800 Committed r108415: <http://trac.webkit.org/changeset/108415> 128071 2012-02-21 16:13:12 -0800 2012-02-21 16:30:14 -0800 Patch bug-79162-20120221161311.patch text/plain 4950 adamk U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4MzU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjY4ZmZkZWM3NDkyMjlh N2NkY2M5MzM2MThhNTc4M2U4ZGFkYTRmMy4uNTkzYzhhZjBjMjA3MjM3NWE1YzQ5YmQwMTI2Mjcz ZGI4MmJhYzNjNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTAyLTIxICBBZGFt IEtsZWluICA8YWRhbWtAY2hyb21pdW0ub3JnPgorCisgICAgICAgIENvbnRhaW5lck5vZGU6OmNo aWxkcmVuQ2hhbmdlZCBtdXN0IGJlIGNhbGxlZCBpbW1lZGlhdGVseSBhZnRlciByZW1vdmluZyBj aGlsZHJlbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NzkxNjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJ biByMTA4MTUyLCBhIGNhbGwgdG8gY2hpbGRyZW5DaGFuZ2VkKCkgd2FzIGVycm9uZW91c2x5IG1v dmVkCisgICAgICAgIGJlbG93IHRoZSBjYWxsIHRvIGNoaWxkLT5yZW1vdmVkRnJvbURvY3VtZW50 KCkuIFRoaXMgYnJlYWtzLCBhdCB0aGUKKyAgICAgICAgbGVhc3QsIHRoZSBiZWhhdmlvciBvZiB0 aGUgPHRpdGxlPiBlbGVtZW50LiBUaGlzIHBhdGNoIGNvcnJlY3RzIHRoZQorICAgICAgICBtaXN0 YWtlIGFuZCBhZGRzIGEgdGVzdC4KKworICAgICAgICBUZXN0OiBmYXN0L2RvbS90aXRsZS1kaXJl Y3Rpb25hbGl0eS1yZW1vdmVDaGlsZC5odG1sCisKKyAgICAgICAgKiBkb20vQ29udGFpbmVyTm9k ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDb250YWluZXJOb2RlOjpyZW1vdmVDaGlsZCk6CisK IDIwMTItMDItMjEgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBnb29nbGUuY29tPgogCiAgICAg ICAgIFdlYiBJbnNwZWN0b3I6IFtjcmFzaF0gdXBvbiBzdHlsZSBtb2RpZmljYXRpb24gYWZ0ZXIg bmF2aWdhdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0NvbnRhaW5lck5vZGUu Y3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0NvbnRhaW5lck5vZGUuY3BwCmluZGV4IDBkYTQ5YmNh NGNkYmU3ZDI3MDZjNDk5NjA3YWY0MDNiZGMyNTc0NjcuLjNiMzU1Mjc1NWVhZDhlMDdkNTA0MmEx OGM5MmYwZTA2YzJiMTE5MDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Db250YWlu ZXJOb2RlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vQ29udGFpbmVyTm9kZS5jcHAKQEAg LTQ3OCwxMyArNDc4LDEzIEBAIGJvb2wgQ29udGFpbmVyTm9kZTo6cmVtb3ZlQ2hpbGQoTm9kZSog b2xkQ2hpbGQsIEV4Y2VwdGlvbkNvZGUmIGVjKQogICAgIE5vZGUqIG5leHQgPSBjaGlsZC0+bmV4 dFNpYmxpbmcoKTsKICAgICByZW1vdmVCZXR3ZWVuKHByZXYsIG5leHQsIGNoaWxkLmdldCgpKTsK IAorICAgIGNoaWxkcmVuQ2hhbmdlZChmYWxzZSwgcHJldiwgbmV4dCwgLTEpOworCiAgICAgaWYg KGNoaWxkLT5pbkRvY3VtZW50KCkpCiAgICAgICAgIGNoaWxkLT5yZW1vdmVkRnJvbURvY3VtZW50 KCk7CiAgICAgZWxzZQogICAgICAgICBjaGlsZC0+cmVtb3ZlZEZyb21UcmVlKHRydWUpOwogCi0g ICAgLy8gRGlzcGF0Y2ggcG9zdC1yZW1vdmFsIG11dGF0aW9uIGV2ZW50cwotICAgIGNoaWxkcmVu Q2hhbmdlZChmYWxzZSwgcHJldiwgbmV4dCwgLTEpOwogICAgIGRpc3BhdGNoU3VidHJlZU1vZGlm aWVkRXZlbnQoKTsKIAogICAgIHJldHVybiBjaGlsZDsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBiNGQzMmI5OTAwZTc2YjIx ZjIwNmMwMDdhYmNkYzYxNTE1ZjJjZDEyLi5iMmJlZGU1ZmI4Nzk2YTQ4ZDA4ODk0N2U2YWYwYWU1 YjViNmQzNTM0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTItMDItMjEgIEFkYW0gS2xlaW4g IDxhZGFta0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgQ29udGFpbmVyTm9kZTo6Y2hpbGRyZW5D aGFuZ2VkIG11c3QgYmUgY2FsbGVkIGltbWVkaWF0ZWx5IGFmdGVyIHJlbW92aW5nIGNoaWxkcmVu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03OTE2Mgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmFzdC9k b20vdGl0bGUtZGlyZWN0aW9uYWxpdHktcmVtb3ZlQ2hpbGQtZXhwZWN0ZWQudHh0OiBBZGRlZC4K KyAgICAgICAgKiBmYXN0L2RvbS90aXRsZS1kaXJlY3Rpb25hbGl0eS1yZW1vdmVDaGlsZC5odG1s OiBBZGRlZC4KKwogMjAxMi0wMi0yMSAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQu b3JnPgogCiAgICAgICAgIFtRdF0gVW5yZXZpZXdlZCBnYXJkZW5pbmcsIHNraXAgbmV3IGZhaWxp bmcgYW5kIGNyYXNoaW5nIHRlc3QgdG8gcGFpbnQgdGhlIGJvdCBncmVlbi4KZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL2Zhc3QvZG9tL3RpdGxlLWRpcmVjdGlvbmFsaXR5LXJlbW92ZUNoaWxkLWV4 cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL3RpdGxlLWRpcmVjdGlvbmFsaXR5LXJl bW92ZUNoaWxkLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5iMjMyNzY4NDBhZGNiN2VjZTg1YzM5 MjUzNGM3YzhhZGY5NmFhZDI4Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9k b20vdGl0bGUtZGlyZWN0aW9uYWxpdHktcmVtb3ZlQ2hpbGQtZXhwZWN0ZWQudHh0CkBAIC0wLDAg KzEsNiBAQAorCis8aHRtbD48dGl0bGU+Zm9vPC90aXRsZT48L2h0bWw+IHNob3VsZCBoYXZlIHRp dGxlIGRpcmVjdGlvbiAibHRyIi4gUEFTUworPGh0bWw+PHRpdGxlIGRpcj1ydGw+Zm9vPC90aXRs ZT48L2h0bWw+IHNob3VsZCBoYXZlIHRpdGxlIGRpcmVjdGlvbiAicnRsIi4gUEFTUworPGh0bWwg ZGlyPXJ0bD48dGl0bGU+Zm9vPC90aXRsZT48L2h0bWw+IHNob3VsZCBoYXZlIHRpdGxlIGRpcmVj dGlvbiAicnRsIi4gUEFTUworPGh0bWwgZGlyPXJ0bD48dGl0bGUgZGlyPWx0cj5mb288L3RpdGxl PjwvaHRtbD4gc2hvdWxkIGhhdmUgdGl0bGUgZGlyZWN0aW9uICJsdHIiLiBQQVNTCisKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL3RpdGxlLWRpcmVjdGlvbmFsaXR5LXJlbW92ZUNo aWxkLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS90aXRsZS1kaXJlY3Rpb25hbGl0eS1yZW1v dmVDaGlsZC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmIyNTE1Mjg4MDEzNTZkZWFjNDU4ZTljOGRkMTVjYTU3 N2M4ZTMxNDkKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS90aXRsZS1k aXJlY3Rpb25hbGl0eS1yZW1vdmVDaGlsZC5odG1sCkBAIC0wLDAgKzEsNDYgQEAKKzwhRE9DVFlQ RSBodG1sPgorPGh0bWw+Cis8aGVhZD4KKzx0aXRsZT5wYWdlIHRpdGxlPC90aXRsZT4KKzwvaGVh ZD4KKzxib2R5PgorPGlmcmFtZSBpZD1pZnJhbWU+PC9pZnJhbWU+Cis8c2NyaXB0PgordmFyIGlm cmFtZSA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdpZnJhbWUnKTsKKworZnVuY3Rpb24gYXNz ZXJ0RGlyZWN0aW9uKGxhYmVsLCBleHBlY3RlZERpcmVjdGlvbiwgaHRtbCkKK3sKKyAgICB2YXIg ZG9jID0gaWZyYW1lLmNvbnRlbnREb2N1bWVudDsKKyAgICBkb2MucmVtb3ZlQ2hpbGQoZG9jLmRv Y3VtZW50RWxlbWVudCk7CisgICAgZG9jLm9wZW4oKTsKKyAgICBkb2Mud3JpdGUoaHRtbCk7Cisg ICAgZG9jLmNsb3NlKCk7CisKKyAgICB2YXIgZGlyID0gd2luZG93LmxheW91dFRlc3RDb250cm9s bGVyID8KKyAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIudGl0bGVUZXh0RGlyZWN0aW9uCisg ICAgICA6ICdsYXlvdXRUZXN0Q29udHJvbGxlciB1bmF2YWlsYWJsZSc7CisgICAgdmFyIHN0YXR1 cyA9IGh0bWwgKyAnIHNob3VsZCBoYXZlIHRpdGxlIGRpcmVjdGlvbiAiJyArIGV4cGVjdGVkRGly ZWN0aW9uICsgJyIuICc7CisgICAgaWYgKGRpciA9PSBleHBlY3RlZERpcmVjdGlvbikgeworICAg ICAgICBzdGF0dXMgKz0gJ1BBU1MnOworICAgIH0gZWxzZSB7CisgICAgICAgIHN0YXR1cyArPSAn RkFJTCAoZ290OiAiJyArIGRpciArICciKSc7CisgICAgfQorICAgIHZhciBkaXYgPSBkb2N1bWVu dC5jcmVhdGVFbGVtZW50KCdkaXYnKTsKKyAgICBkaXYuaW5uZXJUZXh0ID0gc3RhdHVzOworICAg IGRvY3VtZW50LmJvZHkuYXBwZW5kQ2hpbGQoZGl2KTsKK30KKworaWYgKHdpbmRvdy5sYXlvdXRU ZXN0Q29udHJvbGxlcikKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisK K2Fzc2VydERpcmVjdGlvbignbm9ybWFsIGRvYycsICdsdHInLAorICAgICAgICAgICAgICAgICc8 aHRtbD48dGl0bGU+Zm9vPC90aXRsZT48L2h0bWw+Jyk7Cithc3NlcnREaXJlY3Rpb24oJ3RpdGxl IGRpcj1ydGwnLCAncnRsJywKKyAgICAgICAgICAgICAgICAnPGh0bWw+PHRpdGxlIGRpcj1ydGw+ Zm9vPC90aXRsZT48L2h0bWw+Jyk7Cithc3NlcnREaXJlY3Rpb24oJ2h0bWwgZGlyPXJ0bCcsICdy dGwnLAorICAgICAgICAgICAgICAgICc8aHRtbCBkaXI9cnRsPjx0aXRsZT5mb288L3RpdGxlPjwv aHRtbD4nKTsKK2Fzc2VydERpcmVjdGlvbignaHRtbCBkaXI9cnRsLCB0aXRsZSBkaXI9bHRyJywg J2x0cicsCisgICAgICAgICAgICAgICAgJzxodG1sIGRpcj1ydGw+PHRpdGxlIGRpcj1sdHI+Zm9v PC90aXRsZT48L2h0bWw+Jyk7Cis8L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K