79158 2012-02-21 15:49:34 -0800 [chromium] Fix image drag out on Chromium 2012-02-21 16:47:10 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dcheng dcheng oldest_to_newest 561302 0 dcheng 2012-02-21 15:49:34 -0800 [chromium] Fix image drag out on Chromium 561303 1 128064 dcheng 2012-02-21 15:50:01 -0800 Created attachment 128064 Patch 561362 2 128080 dcheng 2012-02-21 16:31:22 -0800 Created attachment 128080 Patch 561369 3 128080 tony 2012-02-21 16:38:47 -0800 Comment on attachment 128080 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128080&action=review > Source/WebKit/chromium/ChangeLog:12 > + > + * src/WebDragData.cpp: Nit: Please name the test that covers this. 561378 4 dcheng 2012-02-21 16:47:10 -0800 Committed r108419: <http://trac.webkit.org/changeset/108419> 128064 2012-02-21 15:50:01 -0800 2012-02-21 16:31:19 -0800 Patch bug-79158-20120221155000.patch text/plain 1386 dcheng U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4NDA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDdjMWM5NDA1MGJjZGQ4OTU3YzVhY2RmYzFkOTA1ZWVhOTgzYzk2ZTQuLmViZGVjYjEwOTc1YWMw YjUyZGQwOWJlNTM1ZjYyMjI3MzAxYWIwYmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTItMDItMjEgIERhbmllbCBDaGVuZyAgPGRjaGVuZ0BjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBGaXggaW1hZ2UgZHJhZyBvdXQgb24gQ2hyb21p dW0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc5MTU4 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBzcmMv V2ViRHJhZ0RhdGEuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJEcmFnRGF0YTo6aXRlbXMpOgor CiAyMDEyLTAyLTIxICBEYXZpZCBHcm9nYW4gIDxkZ3JvZ2FuQGNocm9taXVtLm9yZz4KIAogICAg ICAgICBJbmRleGVkREI6IHdlYkZyYW1lIGlzbid0IHRocmVhZHNhZmUsIGRvbid0IHVzZSBpdCBm cm9tIGEgd29ya2VyIHRocmVhZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9z cmMvV2ViRHJhZ0RhdGEuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRHJhZ0Rh dGEuY3BwCmluZGV4IDViOGJmYzQ3MGRjOTA0NGUzNjU3ODcwOWY0ZjQ0ZjdlM2U4OWVlMDUuLjM3 ODg3OWE4YzI4YmM2NDUxNzEzYjMwYTU2ZGQ2YzM1YjMzZGU4MDMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkRyYWdEYXRhLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3NyYy9XZWJEcmFnRGF0YS5jcHAKQEAgLTExNyw2ICsxMTcsNyBAQCBXZWJWZWN0 b3I8V2ViRHJhZ0RhdGE6Okl0ZW0+IFdlYkRyYWdEYXRhOjppdGVtcygpIGNvbnN0CiAgICAgICAg IGl0ZW0uc3RvcmFnZVR5cGUgPSBJdGVtOjpTdG9yYWdlVHlwZUJpbmFyeURhdGE7CiAgICAgICAg IGl0ZW0uYmluYXJ5RGF0YSA9IG1fcHJpdmF0ZS0+ZmlsZUNvbnRlbnQoKTsKICAgICAgICAgaXRl bS50aXRsZSA9IG1fcHJpdmF0ZS0+ZmlsZUNvbnRlbnRGaWxlbmFtZSgpOworICAgICAgICBpdGVt TGlzdC5hcHBlbmQoaXRlbSk7CiAgICAgfQogICAgIC8vIFdlIGRvbid0IGhhbmRsZSBmaWxlbmFt ZXMgaGVyZSwgc2luY2UgdGhleSBhcmUgbmV2ZXIgdXNlZCBmb3IgZHJhZ2dpbmcgb3V0LgogICAg IHJldHVybiBpdGVtTGlzdDsK 128080 2012-02-21 16:31:22 -0800 2012-02-21 16:38:47 -0800 Patch bug-79158-20120221163121.patch text/plain 4971 dcheng U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4NDA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDdjMWM5NDA1MGJjZGQ4OTU3YzVhY2RmYzFkOTA1ZWVhOTgzYzk2ZTQuLjg2NzRmZDVjYzI3MmRj ZTZiNTRlMGU1Nzg0NjZmODBjZjc5M2QzMDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTItMDItMjEgIERhbmllbCBDaGVuZyAgPGRjaGVuZ0BjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBGaXggaW1hZ2UgZHJhZyBvdXQgb24gQ2hyb21p dW0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc5MTU4 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgY29u c3RydWN0ZWQgdGhlIFdlYkRyYWdEYXRhOjpJdGVtIGZvciBkcmFnZ2luZyBvdXQgYW4gaW1hZ2Ug YnV0IG5ldmVyIGFkZGVkIGl0IHRvIHRoZQorICAgICAgICBpdGVtIGxpc3QuIFRoZSBidWcgZHVl IHRvIHRoZSBtaXNzaW5nIGxpbmUgd2Fzbid0IGNhdWdodCBpbiB0aGUgb3JpZ2luYWwgcGF0Y2gg c2luY2UgdGhlCisgICAgICAgIGltcGxlbWVudGF0aW9ucyBpbiBDaHJvbWUgYW5kIERSVCBoYWQg ZGl2ZXJnZWQuCisKKyAgICAgICAgKiBzcmMvV2ViRHJhZ0RhdGEuY3BwOgorICAgICAgICAoV2Vi S2l0OjpXZWJEcmFnRGF0YTo6aXRlbXMpOgorCiAyMDEyLTAyLTIxICBEYXZpZCBHcm9nYW4gIDxk Z3JvZ2FuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBJbmRleGVkREI6IHdlYkZyYW1lIGlzbid0 IHRocmVhZHNhZmUsIGRvbid0IHVzZSBpdCBmcm9tIGEgd29ya2VyIHRocmVhZApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRHJhZ0RhdGEuY3BwIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9zcmMvV2ViRHJhZ0RhdGEuY3BwCmluZGV4IDViOGJmYzQ3MGRjOTA0NGUz NjU3ODcwOWY0ZjQ0ZjdlM2U4OWVlMDUuLjM3ODg3OWE4YzI4YmM2NDUxNzEzYjMwYTU2ZGQ2YzM1 YjMzZGU4MDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkRyYWdE YXRhLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJEcmFnRGF0YS5jcHAK QEAgLTExNyw2ICsxMTcsNyBAQCBXZWJWZWN0b3I8V2ViRHJhZ0RhdGE6Okl0ZW0+IFdlYkRyYWdE YXRhOjppdGVtcygpIGNvbnN0CiAgICAgICAgIGl0ZW0uc3RvcmFnZVR5cGUgPSBJdGVtOjpTdG9y YWdlVHlwZUJpbmFyeURhdGE7CiAgICAgICAgIGl0ZW0uYmluYXJ5RGF0YSA9IG1fcHJpdmF0ZS0+ ZmlsZUNvbnRlbnQoKTsKICAgICAgICAgaXRlbS50aXRsZSA9IG1fcHJpdmF0ZS0+ZmlsZUNvbnRl bnRGaWxlbmFtZSgpOworICAgICAgICBpdGVtTGlzdC5hcHBlbmQoaXRlbSk7CiAgICAgfQogICAg IC8vIFdlIGRvbid0IGhhbmRsZSBmaWxlbmFtZXMgaGVyZSwgc2luY2UgdGhleSBhcmUgbmV2ZXIg dXNlZCBmb3IgZHJhZ2dpbmcgb3V0LgogICAgIHJldHVybiBpdGVtTGlzdDsKZGlmZiAtLWdpdCBh L1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA0NzMyYWE1MmU1ZWIzMWQy ZjMxOThlMWI3OTM1NzM0ODc2ZDhjMjYwLi42OTMyZjJhNTU3Nzg4OTFiYThlOTNlZDY4NTA2M2Y0 ZDc5OGJmMmEzIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDItMjEgIERhbmllbCBDaGVuZyAgPGRjaGVuZ0Bj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBGaXggaW1hZ2UgZHJhZyBvdXQgb24g Q2hyb21pdW0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTc5MTU4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBEdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9FdmVudFNlbmRlci5jcHA6CisgICAgICAgIChFdmVu dFNlbmRlcjo6ZHVtcEZpbGVuYW1lQmVpbmdEcmFnZ2VkKToKKyAgICAgICAgKEV2ZW50U2VuZGVy OjpiZWdpbkRyYWdXaXRoRmlsZXMpOgorICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2Nocm9taXVt L1dlYlZpZXdIb3N0LmNwcDoKKyAgICAgICAgKGFkZERSVEZha2VGaWxlVG9EYXRhT2JqZWN0KToK KwogMjAxMi0wMi0yMSAgS2VudGFybyBIYXJhICA8aGFyYWtlbkBjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgRW5hYmxlIHRoZSBJREwgYXR0cmlidXRlIGNoZWNrZXIgaW4gcnVuLWJpbmRpbmdzLXRl c3RzCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9FdmVudFNlbmRl ci5jcHAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9FdmVudFNlbmRlci5jcHAKaW5k ZXggOWFjYzQyZGZiZTBjMTM3NTY2MzIyMGY1ZTkzOTJiOGE3YjI5ZGQzNC4uY2M3M2IyZGJkM2U0 NGZkMDMxM2IxMDU0YjBmMWQwNDRmMDNiNjI1MCAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRl clRyZWUvY2hyb21pdW0vRXZlbnRTZW5kZXIuY3BwCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVl L2Nocm9taXVtL0V2ZW50U2VuZGVyLmNwcApAQCAtMzU0LDcgKzM1NCwxNSBAQCB2b2lkIEV2ZW50 U2VuZGVyOjpkb0RyYWdEcm9wKGNvbnN0IFdlYkRyYWdEYXRhJiBkcmFnRGF0YSwgV2ViRHJhZ09w ZXJhdGlvbnNNYXNrCiAKIHZvaWQgRXZlbnRTZW5kZXI6OmR1bXBGaWxlbmFtZUJlaW5nRHJhZ2dl ZChjb25zdCBDcHBBcmd1bWVudExpc3QmLCBDcHBWYXJpYW50KikKIHsKLSAgICBwcmludGYoIkZp bGVuYW1lIGJlaW5nIGRyYWdnZWQ6ICVzXG4iLCBjdXJyZW50RHJhZ0RhdGEuZmlsZUNvbnRlbnRG aWxlbmFtZSgpLnV0ZjgoKS5kYXRhKCkpOworICAgIFdlYlN0cmluZyBmaWxlbmFtZTsKKyAgICBX ZWJWZWN0b3I8V2ViRHJhZ0RhdGE6Okl0ZW0+IGl0ZW1zID0gY3VycmVudERyYWdEYXRhLml0ZW1z KCk7CisgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBpdGVtcy5zaXplKCk7ICsraSkgeworICAg ICAgICBpZiAoaXRlbXNbaV0uc3RvcmFnZVR5cGUgPT0gV2ViRHJhZ0RhdGE6Okl0ZW06OlN0b3Jh Z2VUeXBlQmluYXJ5RGF0YSkgeworICAgICAgICAgICAgZmlsZW5hbWUgPSBpdGVtc1tpXS50aXRs ZTsKKyAgICAgICAgICAgIGJyZWFrOworICAgICAgICB9CisgICAgfQorICAgIHByaW50ZigiRmls ZW5hbWUgYmVpbmcgZHJhZ2dlZDogJXNcbiIsIGZpbGVuYW1lLnV0ZjgoKS5kYXRhKCkpOwogfQog CiBXZWJNb3VzZUV2ZW50OjpCdXR0b24gRXZlbnRTZW5kZXI6OmdldEJ1dHRvblR5cGVGcm9tQnV0 dG9uTnVtYmVyKGludCBidXR0b25Db2RlKQpAQCAtODY5LDggKzg3NywxMiBAQCB2b2lkIEV2ZW50 U2VuZGVyOjpiZWdpbkRyYWdXaXRoRmlsZXMoY29uc3QgQ3BwQXJndW1lbnRMaXN0JiBhcmd1bWVu dHMsIENwcFZhcmlhbgogewogICAgIGN1cnJlbnREcmFnRGF0YS5pbml0aWFsaXplKCk7CiAgICAg VmVjdG9yPHN0cmluZz4gZmlsZXMgPSBhcmd1bWVudHNbMF0udG9TdHJpbmdWZWN0b3IoKTsKLSAg ICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IGZpbGVzLnNpemUoKTsgKytpKQotICAgICAgICBjdXJy ZW50RHJhZ0RhdGEuYXBwZW5kVG9GaWxlbmFtZXMod2Via2l0X3N1cHBvcnQ6OkdldEFic29sdXRl V2ViU3RyaW5nRnJvbVVURjhQYXRoKGZpbGVzW2ldKSk7CisgICAgZm9yIChzaXplX3QgaSA9IDA7 IGkgPCBmaWxlcy5zaXplKCk7ICsraSkgeworICAgICAgICBXZWJEcmFnRGF0YTo6SXRlbSBpdGVt OworICAgICAgICBpdGVtLnN0b3JhZ2VUeXBlID0gV2ViRHJhZ0RhdGE6Okl0ZW06OlN0b3JhZ2VU eXBlRmlsZW5hbWU7CisgICAgICAgIGl0ZW0uZmlsZW5hbWVEYXRhID0gd2Via2l0X3N1cHBvcnQ6 OkdldEFic29sdXRlV2ViU3RyaW5nRnJvbVVURjhQYXRoKGZpbGVzW2ldKTsKKyAgICAgICAgY3Vy cmVudERyYWdEYXRhLmFkZEl0ZW0oaXRlbSk7CisgICAgfQogICAgIGN1cnJlbnREcmFnRWZmZWN0 c0FsbG93ZWQgPSBXZWJLaXQ6OldlYkRyYWdPcGVyYXRpb25Db3B5OwogCiAgICAgLy8gUHJvdmlk ZSBhIGRyYWcgc291cmNlLgpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21p dW0vV2ViVmlld0hvc3QuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vV2ViVmll d0hvc3QuY3BwCmluZGV4IDBlNGM4M2RiNTI4ZTA4OTIwYTkxYjk0ZmUzMDIzYTc5ZWJlYjBlMWIu LjkyMjAzOTE0ODNjNjIyZWQ0YWY0MmFmYTY0MzljZDU1Mjc1NjM5MTcgMTAwNjQ0Ci0tLSBhL1Rv b2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlZpZXdIb3N0LmNwcAorKysgYi9Ub29scy9E dW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJWaWV3SG9zdC5jcHAKQEAgLTEzNyw3ICsxMzcsMTAg QEAgc3RhdGljIHN0cmluZyBkZXNjcmlwdGlvblN1aXRhYmxlRm9yVGVzdFJlc3VsdChjb25zdCBz dHJpbmcmIHVybCkKIC8vIGRyYWdnaW5nIGEgZmlsZS4KIHN0YXRpYyB2b2lkIGFkZERSVEZha2VG aWxlVG9EYXRhT2JqZWN0KFdlYkRyYWdEYXRhKiBkcmFnRGF0YSkKIHsKLSAgICBkcmFnRGF0YS0+ YXBwZW5kVG9GaWxlbmFtZXMoV2ViU3RyaW5nOjpmcm9tVVRGOCgiRFJURmFrZUZpbGUiKSk7Cisg ICAgV2ViRHJhZ0RhdGE6Okl0ZW0gaXRlbTsKKyAgICBpdGVtLnN0b3JhZ2VUeXBlID0gV2ViRHJh Z0RhdGE6Okl0ZW06OlN0b3JhZ2VUeXBlRmlsZW5hbWU7CisgICAgaXRlbS5maWxlbmFtZURhdGEg PSBXZWJTdHJpbmc6OmZyb21VVEY4KCJEUlRGYWtlRmlsZSIpOworICAgIGRyYWdEYXRhLT5hZGRJ dGVtKGl0ZW0pOwogfQogCiAvLyBHZXQgYSBkZWJ1Z2dpbmcgc3RyaW5nIGZyb20gYSBXZWJOYXZp Z2F0aW9uVHlwZS4K