79157 2012-02-21 15:42:01 -0800 [chromium] Painting a layer clears opaque rect in untouched tiles 2012-02-21 18:45:06 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 danakj danakj backer enne jamesr piman webkit.review.bot oldest_to_newest 561297 0 danakj 2012-02-21 15:42:01 -0800 [chromium] Painting a layer clears opaque rect in untouched tiles 561376 1 128084 danakj 2012-02-21 16:46:12 -0800 Created attachment 128084 Patch 561380 2 jamesr 2012-02-21 16:50:54 -0800 Is this fixing a correctness bug or a performance improvement? I would expect that throwing away opaqueness could never result in an incorrect rendering, but might cause you to go slower sometimes. 561433 3 danakj 2012-02-21 17:58:11 -0800 Yes, performance. I noticed it while fixing the G+ bug, as many tiles were being drawn correctly when they should have stayed (incorrectly) opaque from the bug. 561443 4 128084 jamesr 2012-02-21 18:08:20 -0800 Comment on attachment 128084 Patch Gotcha, thanks for the clarification. Looks good. 561464 5 128084 webkit.review.bot 2012-02-21 18:45:02 -0800 Comment on attachment 128084 Patch Clearing flags on attachment: 128084 Committed r108431: <http://trac.webkit.org/changeset/108431> 561465 6 webkit.review.bot 2012-02-21 18:45:06 -0800 All reviewed patches have been landed. Closing bug. 128084 2012-02-21 16:46:12 -0800 2012-02-21 18:45:02 -0800 Patch bug-79157-20120221194611.patch text/plain 7458 danakj U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4NDEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTU1OTczZWQ0M2ZmNmUz MDg0YTBjZWViOTkxODlhMGExYjYwNmUzOS4uMjg1Y2E5YWU4NTVjMDdkNmFmYmNkMWRhODc4OGI1 ZDNjMzRkYTg0MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTAyLTIxICBEYW5h IEphbnNlbnMgIDxkYW5ha2pAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gUGFp bnRpbmcgYSBsYXllciBjbGVhcnMgb3BhcXVlIHJlY3QgaW4gdW50b3VjaGVkIHRpbGVzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03OTE1NworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gcGFpbnRpbmcg YSB0aWxlZCBsYXllciwgd2Ugd291bGQgdGhyb3cgYXdheSB0aGUgc2F2ZWQgb3BhcXVlIHJlY3QK KyAgICAgICAgZm9yIGFueSB0aWxlcyB0aGF0IHdlcmUgbm90IHBhcnQgb2YgdGhlIHBhaW50LiBT byBub3cgd2UgY2hlY2sKKyAgICAgICAgaWYgd2UgYXJlIGFibGUgdG8gc2F2ZSB0aGUgZXhpc3Rp bmcgc2F2ZWQgb3BhcXVlIHJlY3QgaW4gYSBtb3JlCisgICAgICAgIHByb3BlciB3YXk6CisgICAg ICAgIDEuIElmIGFueSBwaXhlbHMgb2YgdGhlIHNhdmVkIHJlY3QgYXJlIHBhaW50ZWQgbm9uLW9w YXF1ZSwgd2UgcmVwbGFjZQorICAgICAgICB0aGUgc2F2ZWQgcmVjdC4KKyAgICAgICAgMi4gSWYg YW4gb3BhcXVlIHJlY3QgaXMgZHJhd24gb3V0c2lkZSBvZiB0aGUgc2F2ZWQgcmVjdCwgd2UgcmVw bGFjZQorICAgICAgICB0aGUgc2F2ZWQgcmVjdC4KKworICAgICAgICBVbml0IHRlc3Q6IFRpbGVk TGF5ZXJDaHJvbWl1bVRlc3QuY3BwCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJv bWl1bS9UaWxlZExheWVyQ2hyb21pdW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6VGlsZWRMYXll ckNocm9taXVtOjpwcmVwYXJlVG9VcGRhdGVUaWxlcyk6CisgICAgICAgIChXZWJDb3JlOjpUaWxl ZExheWVyQ2hyb21pdW06OmFkZFNlbGZUb09jY2x1ZGVkU2NyZWVuU3BhY2UpOgorCiAyMDEyLTAy LTIxICBMdWtlIE1hY3BoZXJzb24gICA8bWFjcGhlcnNvbkBjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgSW1wbGVtZW50IG1hbnkgaW5zdGFuY2VzIG9mIEhBTkRMRV9JTkhFUklUX0FORF9JTklUSUFM X0FORF9QUklNSVRJVkUgaW4gQ1NTU3R5bGVBcHBseVByb3BlcnR5LgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0No YW5nZUxvZwppbmRleCA3YzFjOTQwNTBiY2RkODk1N2M1YWNkZmMxZDkwNWVlYTk4M2M5NmU0Li45 MzViMzRjNjYyODVmNTg1OTRmMmM4YTliZDIwOGJiYmRkMGJiM2ZiIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAyLTIxICBEYW5hIEphbnNlbnMgIDxk YW5ha2pAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gUGFpbnRpbmcgYSBsYXll ciBjbGVhcnMgb3BhcXVlIHJlY3QgaW4gdW50b3VjaGVkIHRpbGVzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03OTE1NworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogdGVzdHMvVGlsZWRMYXllckNocm9taXVt VGVzdC5jcHA6CisgICAgICAgIChXVEY6OlRFU1QpOgorCiAyMDEyLTAyLTIxICBEYXZpZCBHcm9n YW4gIDxkZ3JvZ2FuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBJbmRleGVkREI6IHdlYkZyYW1l IGlzbid0IHRocmVhZHNhZmUsIGRvbid0IHVzZSBpdCBmcm9tIGEgd29ya2VyIHRocmVhZApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vVGlsZWRM YXllckNocm9taXVtLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9t aXVtL1RpbGVkTGF5ZXJDaHJvbWl1bS5jcHAKaW5kZXggYTdlYmIxNDhmMzhjOTRkYTc1YzVjMGVi YjI0NmY1OGI5YTcxYmM4MC4uYTljZjdkNmZkMmNkZTY5ZTNkMzFkYjA5MGI1NjhmMjFkMTM1M2M5 YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0v VGlsZWRMYXllckNocm9taXVtLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9jaHJvbWl1bS9UaWxlZExheWVyQ2hyb21pdW0uY3BwCkBAIC00NzQsMTIgKzQ3NCwxOCBA QCB2b2lkIFRpbGVkTGF5ZXJDaHJvbWl1bTo6cHJlcGFyZVRvVXBkYXRlVGlsZXMoYm9vbCBpZGxl LCBpbnQgbGVmdCwgaW50IHRvcCwgaW50CiAKICAgICAgICAgICAgIEludFJlY3QgdGlsZVJlY3Qg PSBtX3RpbGVyLT50aWxlQm91bmRzKGksIGopOwogCi0gICAgICAgICAgICAvLyBTYXZlIHdoYXQg d2FzIHBhaW50ZWQgb3BhcXVlIGluIHRoZSB0aWxlLiBJZiBldmVyeXRoaW5nIHBhaW50ZWQgaW4g dGhlIHRpbGUgd2FzIG9wYXF1ZSwgYW5kIHRoZSBhcmVhIGlzIGEgc3Vic2V0IG9mIGFuCi0gICAg ICAgICAgICAvLyBhbHJlYWR5IG9wYXF1ZSBhcmVhLCBrZWVwIHRoZSBvbGQgYXJlYS4KKyAgICAg ICAgICAgIC8vIFNhdmUgd2hhdCB3YXMgcGFpbnRlZCBvcGFxdWUgaW4gdGhlIHRpbGUuIEtlZXAg dGhlIG9sZCBhcmVhIGlmIHRoZSBwYWludCBkaWRuJ3QgdG91Y2ggaXQsIGFuZCBkaWRuJ3QgcGFp bnQgc29tZQorICAgICAgICAgICAgLy8gb3RoZXIgcGFydCBvZiB0aGUgdGlsZSBvcGFxdWUuCiAg ICAgICAgICAgICBJbnRSZWN0IHRpbGVQYWludGVkUmVjdCA9IGludGVyc2VjdGlvbih0aWxlUmVj dCwgbV9wYWludFJlY3QpOwogICAgICAgICAgICAgSW50UmVjdCB0aWxlUGFpbnRlZE9wYXF1ZVJl Y3QgPSBpbnRlcnNlY3Rpb24odGlsZVJlY3QsIHBhaW50ZWRPcGFxdWVSZWN0KTsKLSAgICAgICAg ICAgIGlmICh0aWxlUGFpbnRlZE9wYXF1ZVJlY3QgIT0gdGlsZVBhaW50ZWRSZWN0IHx8ICF0aWxl LT5tX29wYXF1ZVJlY3QuY29udGFpbnModGlsZVBhaW50ZWRPcGFxdWVSZWN0KSkKLSAgICAgICAg ICAgICAgICB0aWxlLT5tX29wYXF1ZVJlY3QgPSB0aWxlUGFpbnRlZE9wYXF1ZVJlY3Q7CisgICAg ICAgICAgICBpZiAoIXRpbGVQYWludGVkUmVjdC5pc0VtcHR5KCkpIHsKKyAgICAgICAgICAgICAg ICBJbnRSZWN0IHBhaW50SW5zaWRlVGlsZU9wYXF1ZVJlY3QgPSBpbnRlcnNlY3Rpb24odGlsZS0+ bV9vcGFxdWVSZWN0LCB0aWxlUGFpbnRlZFJlY3QpOworICAgICAgICAgICAgICAgIGJvb2wgcGFp bnRJbnNpZGVUaWxlT3BhcXVlUmVjdElzTm9uT3BhcXVlID0gIXRpbGVQYWludGVkT3BhcXVlUmVj dC5jb250YWlucyhwYWludEluc2lkZVRpbGVPcGFxdWVSZWN0KTsKKyAgICAgICAgICAgICAgICBi b29sIG9wYXF1ZVBhaW50Tm90SW5zaWRlVGlsZU9wYXF1ZVJlY3QgPSAhdGlsZVBhaW50ZWRPcGFx dWVSZWN0LmlzRW1wdHkoKSAmJiAhdGlsZS0+bV9vcGFxdWVSZWN0LmNvbnRhaW5zKHRpbGVQYWlu dGVkT3BhcXVlUmVjdCk7CisKKyAgICAgICAgICAgICAgICBpZiAocGFpbnRJbnNpZGVUaWxlT3Bh cXVlUmVjdElzTm9uT3BhcXVlIHx8IG9wYXF1ZVBhaW50Tm90SW5zaWRlVGlsZU9wYXF1ZVJlY3Qp CisgICAgICAgICAgICAgICAgICAgIHRpbGUtPm1fb3BhcXVlUmVjdCA9IHRpbGVQYWludGVkT3Bh cXVlUmVjdDsKKyAgICAgICAgICAgIH0KIAogICAgICAgICAgICAgLy8gVXNlIG1fdXBkYXRlUmVj dCBhcyBjb3B5QW5kQ2xlYXJEaXJ0eSBhYm92ZSBtb3ZlZCB0aGUgZXhpc3RpbmcgZGlydHkgcmVj dCB0byBtX3VwZGF0ZVJlY3QuCiAgICAgICAgICAgICBjb25zdCBJbnRSZWN0JiBkaXJ0eVJlY3Qg PSB0aWxlLT5tX3VwZGF0ZVJlY3Q7CkBAIC01NTIsNyArNTU4LDkgQEAgdm9pZCBUaWxlZExheWVy Q2hyb21pdW06OmFkZFNlbGZUb09jY2x1ZGVkU2NyZWVuU3BhY2UoUmVnaW9uJiBvY2NsdWRlZFNj cmVlblNwYWMKICAgICAgICAgICAgIGlmICh0aWxlKSB7CiAgICAgICAgICAgICAgICAgSW50UmVj dCB2aXNpYmxlVGlsZU9wYXF1ZVJlY3QgPSBpbnRlcnNlY3Rpb24odmlzaWJsZVJlY3QsIHRpbGUt Pm1fb3BhcXVlUmVjdCk7CiAgICAgICAgICAgICAgICAgRmxvYXRSZWN0IHNjcmVlblJlY3QgPSBj b250ZW50VHJhbnNmb3JtLm1hcFJlY3QoRmxvYXRSZWN0KHZpc2libGVUaWxlT3BhcXVlUmVjdCkp OwotICAgICAgICAgICAgICAgIG9jY2x1ZGVkU2NyZWVuU3BhY2UudW5pdGUoZW5jbG9zZWRJbnRS ZWN0KHNjcmVlblJlY3QpKTsKKyAgICAgICAgICAgICAgICBJbnRSZWN0IHNjcmVlbkludFJlY3Qg PSBlbmNsb3NlZEludFJlY3Qoc2NyZWVuUmVjdCk7CisgICAgICAgICAgICAgICAgaWYgKCFzY3Jl ZW5JbnRSZWN0LmlzRW1wdHkoKSkKKyAgICAgICAgICAgICAgICAgICAgb2NjbHVkZWRTY3JlZW5T cGFjZS51bml0ZShzY3JlZW5JbnRSZWN0KTsKICAgICAgICAgICAgIH0KICAgICAgICAgfQogICAg IH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvVGlsZWRMYXllckNo cm9taXVtVGVzdC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL1RpbGVkTGF5ZXJD aHJvbWl1bVRlc3QuY3BwCmluZGV4IGQ1MzA0MDA0MzVjNjRmNGM1MzIyMjA4MGRmOWRkZWFjMDk2 YWU4MzMuLmUwMzU1OTA0NjdhNjQyN2JmY2I2MDQ3ZGFkNDQ0YTM2YTI3MGM4OGQgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvVGlsZWRMYXllckNocm9taXVtVGVzdC5j cHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9UaWxlZExheWVyQ2hyb21pdW1U ZXN0LmNwcApAQCAtNTg0LDcgKzU4NCw3IEBAIFRFU1QoVGlsZWRMYXllckNocm9taXVtVGVzdCwg bGF5ZXJBZGRzU2VsZlRvT2NjbHVkZWRSZWdpb24pCiAgICAgb2NjbHVkZWQgPSBSZWdpb24oKTsK ICAgICBsYXllci0+YWRkU2VsZlRvT2NjbHVkZWRTY3JlZW5TcGFjZShvY2NsdWRlZCk7CiAgICAg RVhQRUNUX0VRX1JFQ1QoSW50UmVjdCgpLCBvY2NsdWRlZC5ib3VuZHMoKSk7Ci0gICAgRVhQRUNU X0VRKDF1LCBvY2NsdWRlZC5yZWN0cygpLnNpemUoKSk7CisgICAgRVhQRUNUX0VRKDB1LCBvY2Ns dWRlZC5yZWN0cygpLnNpemUoKSk7CiAKICAgICAvLyBJZiB0aGUgbGF5ZXIgcGFpbnRzIG9wYXF1 ZSBjb250ZW50LCB0aGVuIHRoZSBvY2NsdWRlZCByZWdpb24gc2hvdWxkIG1hdGNoIHRoZSB2aXNp YmxlIG9wYXF1ZSBjb250ZW50LgogICAgIEludFJlY3Qgb3BhcXVlUGFpbnRSZWN0ID0gSW50UmVj dCgxMCwgMTAsIDkwLCAxOTApOwpAQCAtNjA2LDYgKzYwNiwyOCBAQCBURVNUKFRpbGVkTGF5ZXJD aHJvbWl1bVRlc3QsIGxheWVyQWRkc1NlbGZUb09jY2x1ZGVkUmVnaW9uKQogICAgIEVYUEVDVF9F UV9SRUNUKGludGVyc2VjdGlvbihvcGFxdWVQYWludFJlY3QsIHZpc2libGVCb3VuZHMpLCBvY2Ns dWRlZC5ib3VuZHMoKSk7CiAgICAgRVhQRUNUX0VRKDF1LCBvY2NsdWRlZC5yZWN0cygpLnNpemUo KSk7CiAKKyAgICAvLyBJZiB3ZSByZXBhaW50IGEgbm9uLW9wYXF1ZSBwYXJ0IG9mIHRoZSB0aWxl LCB0aGVuIGl0IHNob3VsZG4ndCBsb3NlIGl0cyBvcGFxdWUtbmVzcy4gQW5kIG90aGVyIHRpbGVz IHNob3VsZAorICAgIC8vIG5vdCBiZSBhZmZlY3RlZC4KKyAgICBsYXllci0+ZmFrZUxheWVyVGV4 dHVyZVVwZGF0ZXIoKS0+c2V0T3BhcXVlUGFpbnRSZWN0KEludFJlY3QoKSk7CisgICAgbGF5ZXIt PmludmFsaWRhdGVSZWN0KEludFJlY3QoMCwgMCwgMSwgMSkpOworICAgIGxheWVyLT5wcmVwYXJl VG9VcGRhdGUoY29udGVudEJvdW5kcyk7CisKKyAgICBvY2NsdWRlZCA9IFJlZ2lvbigpOworICAg IGxheWVyLT5hZGRTZWxmVG9PY2NsdWRlZFNjcmVlblNwYWNlKG9jY2x1ZGVkKTsKKyAgICBFWFBF Q1RfRVFfUkVDVChpbnRlcnNlY3Rpb24ob3BhcXVlUGFpbnRSZWN0LCB2aXNpYmxlQm91bmRzKSwg b2NjbHVkZWQuYm91bmRzKCkpOworICAgIEVYUEVDVF9FUSgxdSwgb2NjbHVkZWQucmVjdHMoKS5z aXplKCkpOworCisgICAgLy8gSWYgd2UgcmVwYWludCBhbiBvcGFxdWUgcGFydCBvZiB0aGUgdGls ZSwgdGhlbiBpdCBzaG91bGQgbG9zZSBpdHMgb3BhcXVlLW5lc3MuIEJ1dCBvdGhlciB0aWxlcyBz aG91bGQgc3RpbGwKKyAgICAvLyBub3QgYmUgYWZmZWN0ZWQuCisgICAgbGF5ZXItPmZha2VMYXll clRleHR1cmVVcGRhdGVyKCktPnNldE9wYXF1ZVBhaW50UmVjdChJbnRSZWN0KCkpOworICAgIGxh eWVyLT5pbnZhbGlkYXRlUmVjdChJbnRSZWN0KDEwLCAxMCwgMSwgMSkpOworICAgIGxheWVyLT5w cmVwYXJlVG9VcGRhdGUoY29udGVudEJvdW5kcyk7CisKKyAgICBvY2NsdWRlZCA9IFJlZ2lvbigp OworICAgIGxheWVyLT5hZGRTZWxmVG9PY2NsdWRlZFNjcmVlblNwYWNlKG9jY2x1ZGVkKTsKKyAg ICBFWFBFQ1RfRVFfUkVDVChpbnRlcnNlY3Rpb24oSW50UmVjdCgxMCwgMTAwLCA5MCwgMTAwKSwg dmlzaWJsZUJvdW5kcyksIG9jY2x1ZGVkLmJvdW5kcygpKTsKKyAgICBFWFBFQ1RfRVEoMXUsIG9j Y2x1ZGVkLnJlY3RzKCkuc2l6ZSgpKTsKKwogICAgIC8vIElmIHRoZSBsYXllciBpcyB0cmFuc2Zv cm1lZCB0aGVuIHRoZSByZXN1bHRpbmcgb2NjbHVkZWQgYXJlYSBuZWVkcyB0byBiZSB0cmFuc2Zv cm1lZCB0byBpdHMgdGFyZ2V0IHNwYWNlLgogICAgIFRyYW5zZm9ybWF0aW9uTWF0cml4IHRyYW5z Zm9ybTsKICAgICB0cmFuc2Zvcm0udHJhbnNsYXRlKGNvbnRlbnRCb3VuZHMud2lkdGgoKSAvIDIu MCwgY29udGVudEJvdW5kcy5oZWlnaHQoKSAvIDIuMCk7CkBAIC02MTYsNiArNjM4LDggQEAgVEVT VChUaWxlZExheWVyQ2hyb21pdW1UZXN0LCBsYXllckFkZHNTZWxmVG9PY2NsdWRlZFJlZ2lvbikK ICAgICBzY3JlZW5TcGFjZVRyYW5zZm9ybSAqPSB0cmFuc2Zvcm07CiAgICAgc2NyZWVuU3BhY2VU cmFuc2Zvcm0udHJhbnNsYXRlKC1jb250ZW50Qm91bmRzLndpZHRoKCkgLyAyLjAsIC1jb250ZW50 Qm91bmRzLmhlaWdodCgpIC8gMi4wKTsKICAgICBsYXllci0+c2V0U2NyZWVuU3BhY2VUcmFuc2Zv cm0oc2NyZWVuU3BhY2VUcmFuc2Zvcm0pOworICAgIGxheWVyLT5mYWtlTGF5ZXJUZXh0dXJlVXBk YXRlcigpLT5zZXRPcGFxdWVQYWludFJlY3Qob3BhcXVlUGFpbnRSZWN0KTsKKyAgICBsYXllci0+ aW52YWxpZGF0ZVJlY3Qob3BhcXVlUGFpbnRSZWN0KTsKICAgICBsYXllci0+cHJlcGFyZVRvVXBk YXRlKGNvbnRlbnRCb3VuZHMpOwogCiAgICAgb2NjbHVkZWQgPSBSZWdpb24oKTsK