79148 2012-02-21 14:07:34 -0800 nrwt: make the delay between starting workers configurable per-port 2012-02-21 16:29:13 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dpranke dpranke abarth eric ojan tony oldest_to_newest 561206 0 dpranke 2012-02-21 14:07:34 -0800 nrwt: make the delay between starting workers configurable per-port 561208 1 128041 dpranke 2012-02-21 14:08:57 -0800 Created attachment 128041 Patch 561211 2 dpranke 2012-02-21 14:10:06 -0800 See bug 79147 for the underlying problem we're working around. 561350 3 128041 eric 2012-02-21 16:18:56 -0800 Comment on attachment 128041 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128041&action=review > Tools/Scripts/webkitpy/layout_tests/port/base.py:177 > + # FIXME: If we start workers up too quickly, DumpRenderTree appears > + # to thrash on something and time out its first few tests. Until > + # we can figure out what's going on, sleep a bit in between > + # workers. See https://bugs.webkit.org/show_bug.cgi?id=79147 . > + return 0.1 On which ports does this occur? Can we do this only on some ports? 561357 4 dpranke 2012-02-21 16:23:43 -0800 (In reply to comment #3) > (From update of attachment 128041 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=128041&action=review > > > Tools/Scripts/webkitpy/layout_tests/port/base.py:177 > > + # FIXME: If we start workers up too quickly, DumpRenderTree appears > > + # to thrash on something and time out its first few tests. Until > > + # we can figure out what's going on, sleep a bit in between > > + # workers. See https://bugs.webkit.org/show_bug.cgi?id=79147 . > > + return 0.1 > > On which ports does this occur? Can we do this only on some ports? I'm not sure ... hopefully? My plan was to land this so we can speed up test-webkitpy, and then start hunting, port-by-port. I'm only fairly certainly about the delay on apple mac; it may be that that's the only one, or others also have, or in fact no one does any more. 561360 5 dpranke 2012-02-21 16:29:13 -0800 Committed r108413: <http://trac.webkit.org/changeset/108413> 128041 2012-02-21 14:08:57 -0800 2012-02-21 16:23:55 -0800 Patch bug-79148-20120221140855.patch text/plain 3788 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4Mzc5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTUzY2VkYjFlZDZhYTgyNTVjYjJkOTM1ZGFlNzhmNWE4 OTA4N2JlMS4uMjkwOTdjODI0NDM0MWUwZTlmODA4MDczZjRiZDA4ODE4M2E4ZWNlNiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0 IEBACiAyMDEyLTAyLTIxICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCisg ICAgICAgIG5yd3Q6IG1ha2UgdGhlIGRlbGF5IGJldHdlZW4gc3RhcnRpbmcgd29ya2VycyBjb25m aWd1cmFibGUgcGVyLXBvcnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTc5MTQ4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQmVjYXVzZSBvZiBidWcgNzkxNDcsIHdlIGhhdmUgdG8gc2xlZXAgYSBiaXQgaW4g YmV0d2VlbiBzdGFydGluZworICAgICAgICBEUlRzOyBob3dldmVyLCBkb2luZyBzbyBhY3Jvc3Mg dGhlIGJvYXJkIHNsb3dzIGRvd24gdGhlIFRlc3QKKyAgICAgICAgcG9ydC4gTWFraW5nIHRoaXMg Y29uZmlndXJhYmxlIHNoYXZlcyAxMCBzZWNvbmRzIG9mZiBvZgorICAgICAgICBydW5fd2Via2l0 X3Rlc3RzX2ludGVncmF0aW9udGVzdC5weQorICAgICAgICAKKyAgICAgICAgKiBTY3JpcHRzL3dl YmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVycy9tYW5hZ2VyLnB5OgorICAgICAgICAoTWFu YWdlci5fcnVuX3Rlc3RzKToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0 cy9wb3J0L2Jhc2UucHk6CisgICAgICAgIChQb3J0Lndvcmtlcl9zdGFydHVwX2RlbGF5X3NlY3Mp OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvdGVzdC5weToK KyAgICAgICAgKFRlc3RQb3J0Lndvcmtlcl9zdGFydHVwX2RlbGF5X3NlY3MpOgorCisyMDEyLTAy LTIxICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCiAgICAgICAgIHdlYmtp dHB5OiB1cGRhdGUgbmFtZXMgYWZ0ZXIgZGVsZXRpbmcgbWVzc2FnZV9icm9rZXIKICAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc5MDAwCiAKZGlmZiAtLWdp dCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2NvbnRyb2xsZXJzL21hbmFn ZXIucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVycy9t YW5hZ2VyLnB5CmluZGV4IDFlMmExNWNiYTY0ZGQ5MDA4NGQxYWQzY2MwZTVjOGNlZWY5NjFmYzUu LjE1MGE1MGE0ZDY1ZjY5MGYzOGJmYzU0OGY0MDhkMGY2M2EzM2IwZGMgMTAwNjQ0Ci0tLSBhL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2NvbnRyb2xsZXJzL21hbmFnZXIucHkK KysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMvbWFu YWdlci5weQpAQCAtNzc0LDExICs3NzQsNyBAQCBjbGFzcyBNYW5hZ2VyKG9iamVjdCk6CiAgICAg ICAgICAgICB3b3JrZXJfc3RhdGUgPSBfV29ya2VyU3RhdGUod29ya2VyX251bWJlciwgd29ya2Vy X2Nvbm5lY3Rpb24pCiAgICAgICAgICAgICBzZWxmLl93b3JrZXJfc3RhdGVzW3dvcmtlcl9jb25u ZWN0aW9uLm5hbWUoKV0gPSB3b3JrZXJfc3RhdGUKIAotICAgICAgICAgICAgIyBGSVhNRTogSWYg d2Ugc3RhcnQgd29ya2VycyB1cCB0b28gcXVpY2tseSwgRHVtcFJlbmRlclRyZWUgYXBwZWFycwot ICAgICAgICAgICAgIyB0byB0aHJhc2ggb24gc29tZXRoaW5nIGFuZCB0aW1lIG91dCBpdHMgZmly c3QgZmV3IHRlc3RzLiBVbnRpbAotICAgICAgICAgICAgIyB3ZSBjYW4gZmlndXJlIG91dCB3aGF0 J3MgZ29pbmcgb24sIHNsZWVwIGEgYml0IGluIGJldHdlZW4KLSAgICAgICAgICAgICMgd29ya2Vy cy4gVGhpcyBuZWVkcyBhIGJ1ZyBmaWxlZC4KLSAgICAgICAgICAgIHRpbWUuc2xlZXAoMC4xKQor ICAgICAgICAgICAgdGltZS5zbGVlcChzZWxmLl9wb3J0Lndvcmtlcl9zdGFydHVwX2RlbGF5X3Nl Y3MoKSkKIAogICAgICAgICBzZWxmLl9wcmludGVyLnByaW50X3VwZGF0ZSgiU3RhcnRpbmcgdGVz dGluZyAuLi4iKQogICAgICAgICBmb3Igc2hhcmQgaW4gYWxsX3NoYXJkczoKZGlmZiAtLWdpdCBh L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvYmFzZS5weSBiL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvYmFzZS5weQppbmRleCA4MDUwYWYz MDY4MjMzYjgyZGE3YWVhMDNlYzQ3OWJjYzgxMjczZWQyLi4xYjg2YmZlMGQzZGRmZDlkNGYzMzA2 NDg2NTMxYzA1NGE5NDU2NDk0IDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xh eW91dF90ZXN0cy9wb3J0L2Jhc2UucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvcG9ydC9iYXNlLnB5CkBAIC0xNjksNiArMTY5LDEzIEBAIGNsYXNzIFBvcnQob2Jq ZWN0KToKICAgICBkZWYgZGVmYXVsdF93b3JrZXJfbW9kZWwoc2VsZik6CiAgICAgICAgIHJldHVy biAncHJvY2Vzc2VzJwogCisgICAgZGVmIHdvcmtlcl9zdGFydHVwX2RlbGF5X3NlY3Moc2VsZik6 CisgICAgICAgICMgRklYTUU6IElmIHdlIHN0YXJ0IHdvcmtlcnMgdXAgdG9vIHF1aWNrbHksIER1 bXBSZW5kZXJUcmVlIGFwcGVhcnMKKyAgICAgICAgIyB0byB0aHJhc2ggb24gc29tZXRoaW5nIGFu ZCB0aW1lIG91dCBpdHMgZmlyc3QgZmV3IHRlc3RzLiBVbnRpbAorICAgICAgICAjIHdlIGNhbiBm aWd1cmUgb3V0IHdoYXQncyBnb2luZyBvbiwgc2xlZXAgYSBiaXQgaW4gYmV0d2VlbgorICAgICAg ICAjIHdvcmtlcnMuIFNlZSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NzkxNDcgLgorICAgICAgICByZXR1cm4gMC4xCisKICAgICBkZWYgYmFzZWxpbmVfcGF0aChzZWxm KToKICAgICAgICAgIiIiUmV0dXJuIHRoZSBhYnNvbHV0ZSBwYXRoIHRvIHRoZSBkaXJlY3Rvcnkg dG8gc3RvcmUgbmV3IGJhc2VsaW5lcyBpbiBmb3IgdGhpcyBwb3J0LiIiIgogICAgICAgICBiYXNl bGluZV9zZWFyY2hfcGF0aHMgPSBzZWxmLmdldF9vcHRpb24oJ2FkZGl0aW9uYWxfcGxhdGZvcm1f ZGlyZWN0b3J5JywgW10pICsgc2VsZi5iYXNlbGluZV9zZWFyY2hfcGF0aCgpCmRpZmYgLS1naXQg YS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3Rlc3QucHkgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3Rlc3QucHkKaW5kZXggMzdmMTdk NWM1OWM4NGUzYzdmZmFlZWRlZDI0NjhhZGEyYTcyZDE4MC4uMTk5NDYwZDU3OTM5YTc3M2NjMjgx YTBjN2RkYzAxYzgxN2ViOWJjOCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9s YXlvdXRfdGVzdHMvcG9ydC90ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL3BvcnQvdGVzdC5weQpAQCAtMzcxLDYgKzM3MSw5IEBAIGNsYXNzIFRlc3RQb3J0 KFBvcnQpOgogICAgIGRlZiBkZWZhdWx0X3dvcmtlcl9tb2RlbChzZWxmKToKICAgICAgICAgcmV0 dXJuICdpbmxpbmUnCiAKKyAgICBkZWYgd29ya2VyX3N0YXJ0dXBfZGVsYXlfc2VjcyhzZWxmKToK KyAgICAgICAgcmV0dXJuIDAKKwogICAgIGRlZiBjaGVja19idWlsZChzZWxmLCBuZWVkc19odHRw KToKICAgICAgICAgcmV0dXJuIFRydWUKIAo=