79129 2012-02-21 11:06:19 -0800 [V8] Bindings for accessors never use the name param 2014-04-11 07:26:28 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 arv webkit-unassigned antonm haraken japhet oldest_to_newest 561046 0 arv 2012-02-21 11:06:19 -0800 The V8 bindings use v8::AccessorGetter and v8::AccessorSetter which takes the name of the property (as a v8::String) as the first argument. This is never[*] used in the binding code so we should get rid of it. [*] There are two instances of these. V8HTMLDocument::allAccessorSetter This one can be fixed by only having a custom getter V8MessageEvent::dataAccessorGetter: This one can be replaced with a new v8::String 561097 1 arv 2012-02-21 11:48:04 -0800 (In reply to comment #0) > V8HTMLDocument::allAccessorSetter > > This one can be fixed by only having a custom getter Actually this one needs to be replaced with the hard coded string "all". 564182 2 antonm 2012-02-24 04:03:24 -0800 (In reply to comment #1) > (In reply to comment #0) > > V8HTMLDocument::allAccessorSetter > > > > This one can be fixed by only having a custom getter > > Actually this one needs to be replaced with the hard coded string "all". Erik, do I understand you right that you want to remove it from public v8 API? If yes, it might be questionable---sometimes it's convenient to have generic accessors. 564363 3 arv 2012-02-24 09:12:00 -0800 The V8 bindings are very slow and even though this is not a big deal it is extra work that we clearly do not need. Would it make sense to have V8 support both? Maybe supporting both would make things slower? 564417 4 antonm 2012-02-24 10:07:44 -0800 (In reply to comment #3) > The V8 bindings are very slow and even though this is not a big deal it is extra work that we clearly do not need. > > Would it make sense to have V8 support both? Maybe supporting both would make things slower? I don't think v8 bindings are very slow :) Name support on ia32 is three additional instructions (push reg, mov reg/reg, mov reg/mem) and two additional slots on the stack. Not sure if it will save us a lot, but it's always worth trying. 564479 5 arv 2012-02-24 11:05:54 -0800 V8 is generally twice as slow as JSC bindings. 564483 6 antonm 2012-02-24 11:09:16 -0800 A year ago we were faster :) Looks like several huge regressions slipped in. (In reply to comment #5) > V8 is generally twice as slow as JSC bindings. 564700 7 haraken 2012-02-24 15:21:26 -0800 (In reply to comment #4) > (In reply to comment #3) > > Would it make sense to have V8 support both? Maybe supporting both would make things slower? > > I don't think v8 bindings are very slow :) I am not yet sure how much the name support has impacted on V8 performance, but V8 is seriously slow. You can find the data in this SpreadSheet (https://docs.google.com/a/google.com/spreadsheet/ccc?key=0ArGPzKNdEGeQdEttZTAxWXJwMVdWeGxjbDgxMExYSEE#gid=0) or the perf-o-matic results (http://webkit-perf.appspot.com/index.html). 564707 8 arv 2012-02-24 15:28:24 -0800 I don't think this would do much but it is clearly doing more work than we need to do.