79126 2012-02-21 10:40:08 -0800 ScrollingCoordinator::coordinatesScrollingForFrameView should be conditional on compositing being active 2012-02-21 13:38:43 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jamesr jamesr abarth andersca enne nduca vangelis oldest_to_newest 561011 0 jamesr 2012-02-21 10:40:08 -0800 ScrollingCoordinator::coordinatesScrollingForFrameView should be conditional on compositing being active 561014 1 127995 jamesr 2012-02-21 10:42:42 -0800 Created attachment 127995 Patch 561032 2 127995 andersca 2012-02-21 10:57:16 -0800 Comment on attachment 127995 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127995&action=review > Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:-205 > + setScrollLayer(scrollLayerForFrameView(frameView)); > frameViewLayoutUpdated(frameView); > recomputeWheelEventHandlerCount(); > updateShouldUpdateScrollLayerPositionOnMainThread(); > - setScrollLayer(scrollLayerForFrameView(frameView)); This change isn't mentioned in the change log; why is it needed? 561132 3 jamesr 2012-02-21 12:28:54 -0800 That slipped into this patch by accident. The idea is to initialize the scroll layer before anything else because in Chromium we're buffering properties on the layer, not on a separate data structure. This raises an interesting question about what happens when calls are made in a different order - for example, if something calls frameViewWheelEventHandlerCountChanged() before frameViewRootLayerDidChange() should it behave the same as if the calls were made in the reverse order or not? Today in the mac implementation it seems that this would vary depending on whether the sync timer fires or not between the calls, although with the way the callsites are coded I don't think it makes a difference. 561184 4 jamesr 2012-02-21 13:38:43 -0800 Committed r108392: <http://trac.webkit.org/changeset/108392> 127995 2012-02-21 10:42:42 -0800 2012-02-21 10:57:16 -0800 Patch bug-79126-20120221104241.patch text/plain 3903 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4MzY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDA5MTg1ODczNzU5Njlm MzIxNzYwZTg0N2RiYThmNzg5ODQ0MDFiNi4uOTZjNDY5Yjg0NTFlZWE2YThlZWQ3NDFjN2VkYWFi MDkwNTc2MDk1NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTAyLTIxICBKYW1l cyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgU2Nyb2xsaW5nQ29v cmRpbmF0b3I6OmNvb3JkaW5hdGVzU2Nyb2xsaW5nRm9yRnJhbWVWaWV3IHNob3VsZCBiZSBjb25k aXRpb25hbCBvbiBjb21wb3NpdGluZyBiZWluZyBhY3RpdmUKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc5MTI2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIFNjcm9sbGluZ0Nvb3JkaW5hdG9yIHNob3Vs ZCBvbmx5IGF0dGVtcHQgdG8gY29vcmRpbmF0ZSBzY3JvbGxpbmcgd2hlbiBjb21wb3NpdGluZyBp cyBhY3RpdmUsIHNpbmNlIGl0J3MgYWxsCisgICAgICAgIGFib3V0IG1hbmlwdWxhdGluZyBHcmFw aGljc0xheWVycy4gQWRkcyBhIHJ1bnRpbWUgY2hlY2suCisKKyAgICAgICAgQWxzbyByZW1vdmVz IHNvbWUgc3RyYXkgI2lmIEVOQUJMRShUSFJFQURFRF9TQ1JPTExJTkcpIGd1YXJkcyB0aGF0IHNu dWNrIGludG8gRnJhbWVWaWV3LgorCisgICAgICAgICogcGFnZS9GcmFtZVZpZXcuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6RnJhbWVWaWV3OjphZGRGaXhlZE9iamVjdCk6CisgICAgICAgIChXZWJD b3JlOjpGcmFtZVZpZXc6OnJlbW92ZUZpeGVkT2JqZWN0KToKKyAgICAgICAgKiBwYWdlL3Njcm9s bGluZy9TY3JvbGxpbmdDb29yZGluYXRvci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxp bmdDb29yZGluYXRvcjo6Y29vcmRpbmF0ZXNTY3JvbGxpbmdGb3JGcmFtZVZpZXcpOgorICAgICAg ICAoV2ViQ29yZTo6U2Nyb2xsaW5nQ29vcmRpbmF0b3I6OmZyYW1lVmlld1Jvb3RMYXllckRpZENo YW5nZSk6CisKIDIwMTItMDItMjEgIEFsZXhpcyBNZW5hcmQgIDxhbGV4aXMubWVuYXJkQG9wZW5i b3NzYS5vcmc+CiAKICAgICAgICAgTGl0dGxlIG9wdGltaXphdGlvbiBmb3IgQ1NTUGFyc2VyOjpw YXJzZUZpbGxTaG9ydGhhbmQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1l Vmlldy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKaW5kZXggNzM0MTBj YzA3NGU3ZGU0MmFkNDk5YmFlYWFiOWJjMDE4ZDU4ZTEzYy4uZDZjZDdkZjA3N2EyNjZiOGRiZjE4 OWZhMGY4MDZiMGQxN2M1NDhjMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFt ZVZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcApAQCAtMTMz OSwxMiArMTMzOSwxMCBAQCB2b2lkIEZyYW1lVmlldzo6YWRkRml4ZWRPYmplY3QoKQogICAgICAg ICBpZiAocGxhdGZvcm1XaWRnZXQoKSkKICAgICAgICAgICAgIHVwZGF0ZUNhbkJsaXRPblNjcm9s bFJlY3Vyc2l2ZWx5KCk7CiAKLSNpZiBFTkFCTEUoVEhSRUFERURfU0NST0xMSU5HKQogICAgICAg ICBpZiAoUGFnZSogcGFnZSA9IG1fZnJhbWUtPnBhZ2UoKSkgewogICAgICAgICAgICAgaWYgKFNj cm9sbGluZ0Nvb3JkaW5hdG9yKiBzY3JvbGxpbmdDb29yZGluYXRvciA9IHBhZ2UtPnNjcm9sbGlu Z0Nvb3JkaW5hdG9yKCkpCiAgICAgICAgICAgICAgICAgc2Nyb2xsaW5nQ29vcmRpbmF0b3ItPmZy YW1lVmlld0hhc0ZpeGVkT2JqZWN0c0RpZENoYW5nZSh0aGlzKTsKICAgICAgICAgfQotI2VuZGlm CiAgICAgfQogfQogCkBAIC0xMzU0LDEyICsxMzUyLDEwIEBAIHZvaWQgRnJhbWVWaWV3OjpyZW1v dmVGaXhlZE9iamVjdCgpCiAgICAgLS1tX2ZpeGVkT2JqZWN0Q291bnQ7CiAKICAgICBpZiAoIW1f Zml4ZWRPYmplY3RDb3VudCkgewotI2lmIEVOQUJMRShUSFJFQURFRF9TQ1JPTExJTkcpCiAgICAg ICAgIGlmIChQYWdlKiBwYWdlID0gbV9mcmFtZS0+cGFnZSgpKSB7CiAgICAgICAgICAgICBpZiAo U2Nyb2xsaW5nQ29vcmRpbmF0b3IqIHNjcm9sbGluZ0Nvb3JkaW5hdG9yID0gcGFnZS0+c2Nyb2xs aW5nQ29vcmRpbmF0b3IoKSkKICAgICAgICAgICAgICAgICBzY3JvbGxpbmdDb29yZGluYXRvci0+ ZnJhbWVWaWV3SGFzRml4ZWRPYmplY3RzRGlkQ2hhbmdlKHRoaXMpOwogICAgICAgICB9Ci0jZW5k aWYKIAogICAgICAgICAvLyBGSVhNRTogSW4gYWRkRml4ZWRPYmplY3QoKSB3ZSBvbmx5IGNhbGwg dGhpcyBpZiB0aGVyZSdzIGEgcGxhdGZvcm0gd2lkZ2V0LAogICAgICAgICAvLyB3aHkgaXNuJ3Qg dGhlIHNhbWUgY2hlY2sgYmVpbmcgbWFkZSBoZXJlPwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nQ29vcmRpbmF0b3IuY3BwIGIvU291cmNlL1dlYkNv cmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nQ29vcmRpbmF0b3IuY3BwCmluZGV4IDg1YjA3ZjE4 NzdmNjFkM2U0ZjQwOTM5MGZhMjRjMWYwODliNjBjMWEuLjNhMjI3ZDBlZTkwOTBmNDc4ZTQ2MmI2 ZTJlOGY2OTMyNTM1MmY5ODggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xs aW5nL1Njcm9sbGluZ0Nvb3JkaW5hdG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Nj cm9sbGluZy9TY3JvbGxpbmdDb29yZGluYXRvci5jcHAKQEAgLTk5LDcgKzk5LDE1IEBAIGJvb2wg U2Nyb2xsaW5nQ29vcmRpbmF0b3I6OmNvb3JkaW5hdGVzU2Nyb2xsaW5nRm9yRnJhbWVWaWV3KEZy YW1lVmlldyogZnJhbWVWaWV3CiAgICAgaWYgKGZyYW1lVmlldy0+ZnJhbWUoKSAhPSBtX3BhZ2Ut Pm1haW5GcmFtZSgpKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKLSAgICByZXR1cm4gdHJ1ZTsK KyAgICAvLyBXZSBjdXJyZW50bHkgb25seSBzdXBwb3J0IGNvbXBvc2l0ZWQgbW9kZS4KKyNpZiBV U0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcpCisgICAgUmVuZGVyVmlldyogcmVuZGVyVmlldyA9 IG1fcGFnZS0+bWFpbkZyYW1lKCktPmNvbnRlbnRSZW5kZXJlcigpOworICAgIGlmICghcmVuZGVy VmlldykKKyAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIHJldHVybiByZW5kZXJWaWV3LT51c2Vz Q29tcG9zaXRpbmcoKTsKKyNlbmRpZgorCisgICAgcmV0dXJuIGZhbHNlOwogfQogCiBzdGF0aWMg UmVnaW9uIGNvbXB1dGVOb25GYXN0U2Nyb2xsYWJsZVJlZ2lvbihGcmFtZVZpZXcqIGZyYW1lVmll dykKQEAgLTE5OSwxMCArMjA3LDEwIEBAIHZvaWQgU2Nyb2xsaW5nQ29vcmRpbmF0b3I6OmZyYW1l Vmlld1Jvb3RMYXllckRpZENoYW5nZShGcmFtZVZpZXcqIGZyYW1lVmlldykKICAgICBpZiAoZnJh bWVWaWV3LT5mcmFtZSgpICE9IG1fcGFnZS0+bWFpbkZyYW1lKCkpCiAgICAgICAgIHJldHVybjsK IAorICAgIHNldFNjcm9sbExheWVyKHNjcm9sbExheWVyRm9yRnJhbWVWaWV3KGZyYW1lVmlldykp OwogICAgIGZyYW1lVmlld0xheW91dFVwZGF0ZWQoZnJhbWVWaWV3KTsKICAgICByZWNvbXB1dGVX aGVlbEV2ZW50SGFuZGxlckNvdW50KCk7CiAgICAgdXBkYXRlU2hvdWxkVXBkYXRlU2Nyb2xsTGF5 ZXJQb3NpdGlvbk9uTWFpblRocmVhZCgpOwotICAgIHNldFNjcm9sbExheWVyKHNjcm9sbExheWVy Rm9yRnJhbWVWaWV3KGZyYW1lVmlldykpOwogfQogCiBib29sIFNjcm9sbGluZ0Nvb3JkaW5hdG9y OjpyZXF1ZXN0U2Nyb2xsUG9zaXRpb25VcGRhdGUoRnJhbWVWaWV3KiBmcmFtZVZpZXcsIGNvbnN0 IEludFBvaW50JiBzY3JvbGxQb3NpdGlvbikK