79117 2012-02-21 08:46:35 -0800 [chromium] Fix issues in visiblePositionForWindowPoint (offscreen points / iframes). 2019-05-02 16:25:32 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 66687 1 olilan olilan abarth ap fishd varunjain vivekjkumar266 webkit.review.bot oldest_to_newest 560917 0 olilan 2012-02-21 08:46:35 -0800 [chromium] Fix issues in visiblePositionForWindowPoint (offscreen points / iframes). 560926 1 127981 olilan 2012-02-21 08:53:16 -0800 Created attachment 127981 Patch 629552 2 127981 eric 2012-05-21 15:05:59 -0700 Comment on attachment 127981 Patch How do we test this? 669507 3 127981 rniwa 2012-07-13 15:36:53 -0700 Comment on attachment 127981 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127981&action=review > Source/WebKit/chromium/ChangeLog:14 > + 1) If the point is off-screen, the visiblePosition is clipped to the screen. > + - The fix is to add HitTestRequest::IgnoreClipping. > + > + 2) The result is incorrect if the point is within an iframe. > + - This is because we are calling convertFromContainingWindow twice: once in windowToContents, > + and then explicitly as well. > + - This patch removes the explicit call to convertFromContainingWindow. We need tests for these two problems. > Source/WebKit/chromium/ChangeLog:16 > + Reviewed by NOBODY (OOPS!). This line should appear before the long description. 680302 4 127981 abarth 2012-07-27 01:43:44 -0700 Comment on attachment 127981 Patch We really should write tests for this sort of patch. I feel a bit like I'm encouraging bad behavior by approving this patch, but I also want you to encourage you to submit patches to WebKit. On balance, I'm going to r+ this patch, but please include tests with future patches. You should also feel encouraged to upload a followup patch that contains a patch. If you're unsure how to write a test for this issue, I'm happy to help. 680347 5 127981 webkit.review.bot 2012-07-27 02:36:40 -0700 Comment on attachment 127981 Patch Clearing flags on attachment: 127981 Committed r123855: <http://trac.webkit.org/changeset/123855> 680348 6 webkit.review.bot 2012-07-27 02:36:44 -0700 All reviewed patches have been landed. Closing bug. 680352 7 olilan 2012-07-27 02:38:50 -0700 Thanks Adam. I meant to come back to this to add tests but hadn't got round to it. I'll add tests for these cases in another patch. 680356 8 abarth 2012-07-27 02:41:06 -0700 Thanks. I figured it just got lost in the shuffle. 127981 2012-02-21 08:53:16 -0800 2012-07-27 02:36:40 -0700 Patch bug-79117-20120221165314.patch text/plain 2219 olilan U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4MzI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDJiZTM1YzBlODBlNjUyNmIwYTI1MzY4MjRhNDg3OWJlNTc1ZGE5OTUuLjAxYTlhOWUwYjNhMzRj NzQxMjI2NGNkZWRjYjQ0NWE5YzJiZjkzMDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjMgQEAKKzIwMTItMDItMjEgIE9saSBMYW4gIDxvbGlsYW5AY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFtjaHJvbWl1bV0gRml4IGlzc3VlcyBpbiB2aXNpYmxlUG9zaXRpb25Gb3JX aW5kb3dQb2ludCAob2Zmc2NyZWVuIHBvaW50cyAvIGlmcmFtZXMpLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzkxMTcKKworICAgICAgICBGaXggdHdv IGlzc3VlcyBpbiBXZWJGcmFtZUltcGw6OnZpc2libGVQb3NpdGlvbkZvcldpbmRvd1BvaW50Lgor CisgICAgICAgIDEpIElmIHRoZSBwb2ludCBpcyBvZmYtc2NyZWVuLCB0aGUgdmlzaWJsZVBvc2l0 aW9uIGlzIGNsaXBwZWQgdG8gdGhlIHNjcmVlbi4KKyAgICAgICAgICAgLSBUaGUgZml4IGlzIHRv IGFkZCBIaXRUZXN0UmVxdWVzdDo6SWdub3JlQ2xpcHBpbmcuCisKKyAgICAgICAgMikgVGhlIHJl c3VsdCBpcyBpbmNvcnJlY3QgaWYgdGhlIHBvaW50IGlzIHdpdGhpbiBhbiBpZnJhbWUuCisgICAg ICAgICAgIC0gVGhpcyBpcyBiZWNhdXNlIHdlIGFyZSBjYWxsaW5nIGNvbnZlcnRGcm9tQ29udGFp bmluZ1dpbmRvdyB0d2ljZTogb25jZSBpbiB3aW5kb3dUb0NvbnRlbnRzLAorICAgICAgICAgICAg IGFuZCB0aGVuIGV4cGxpY2l0bHkgYXMgd2VsbC4KKyAgICAgICAgICAgLSBUaGlzIHBhdGNoIHJl bW92ZXMgdGhlIGV4cGxpY2l0IGNhbGwgdG8gY29udmVydEZyb21Db250YWluaW5nV2luZG93LiAK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHNyYy9X ZWJGcmFtZUltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJGcmFtZUltcGw6OnZpc2libGVQ b3NpdGlvbkZvcldpbmRvd1BvaW50KToKKwogMjAxMi0wMi0yMCAgUGV0ZXIgQmV2ZXJsb28gIDxw ZXRlckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gIFJvbGxlZCBERVBTLgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmNwcCBi L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5jcHAKaW5kZXggMjE3MDRk OTdlMDEyYzkxY2FlMGU0Nzk4ZjMxNGNlYjcyOGI3NzkzNS4uYWM3MzhhMTQyZTQwY2U5MTY0N2Nk N2ZlYmZhYzYxZjAyOWM0YTNiMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9z cmMvV2ViRnJhbWVJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJG cmFtZUltcGwuY3BwCkBAIC0xMzg1LDEwICsxMzg1LDEwIEBAIFZpc2libGVQb3NpdGlvbiBXZWJG cmFtZUltcGw6OnZpc2libGVQb3NpdGlvbkZvcldpbmRvd1BvaW50KGNvbnN0IFdlYlBvaW50JiBw b2luCiAgICAgSGl0VGVzdFJlcXVlc3Q6OkhpdFRlc3RSZXF1ZXN0VHlwZSBoaXRUeXBlID0gSGl0 VGVzdFJlcXVlc3Q6Ok1vdmU7CiAgICAgaGl0VHlwZSB8PSBIaXRUZXN0UmVxdWVzdDo6UmVhZE9u bHk7CiAgICAgaGl0VHlwZSB8PSBIaXRUZXN0UmVxdWVzdDo6QWN0aXZlOworICAgIGhpdFR5cGUg fD0gSGl0VGVzdFJlcXVlc3Q6Oklnbm9yZUNsaXBwaW5nOwogICAgIEhpdFRlc3RSZXF1ZXN0IHJl cXVlc3QoaGl0VHlwZSk7CiAgICAgRnJhbWVWaWV3KiB2aWV3ID0gZnJhbWUoKS0+dmlldygpOwot ICAgIEhpdFRlc3RSZXN1bHQgcmVzdWx0KHZpZXctPndpbmRvd1RvQ29udGVudHMoCi0gICAgICAg IHZpZXctPmNvbnZlcnRGcm9tQ29udGFpbmluZ1dpbmRvdyhJbnRQb2ludChwb2ludC54LCBwb2lu dC55KSkpKTsKKyAgICBIaXRUZXN0UmVzdWx0IHJlc3VsdCh2aWV3LT53aW5kb3dUb0NvbnRlbnRz KEludFBvaW50KHBvaW50LngsIHBvaW50LnkpKSk7CiAKICAgICBmcmFtZSgpLT5kb2N1bWVudCgp LT5yZW5kZXJWaWV3KCktPmxheWVyKCktPmhpdFRlc3QocmVxdWVzdCwgcmVzdWx0KTsKIAo=