79102 2012-02-21 06:53:13 -0800 [Qt] Incremental build problem revealed by r108345 2012-02-24 06:13:23 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P1 Critical --- 1 ossy webkit-unassigned abecsi allan.jensen ossy vestbo oldest_to_newest 560845 0 ossy 2012-02-21 06:53:13 -0800 It seems HTMLDataListElement.o should depends on Source/WebCore/dom/StyledElement.h, but it doesn't. /usr/bin/gold: /home/oszi/WebKit/WebKitBuild/Release/Source/WebCore/debug/libWebCore.a(HTMLDataListElement.o): in function vtable for WebCore::HTMLDataListElement:HTMLDataListElement.cpp(.data.rel.ro._ZTVN7WebCore19HTMLDataListElementE+0xf4): error: undefined reference to 'WebCore::StyledElement::insertedIntoDocument()' /usr/bin/gold: /home/oszi/WebKit/WebKitBuild/Release/Source/WebCore/debug/libWebCore.a(HTMLDataListElement.o): in function vtable for WebCore::HTMLDataListElement:HTMLDataListElement.cpp(.data.rel.ro._ZTVN7WebCore19HTMLDataListElementE+0xf8): error: undefined reference to 'WebCore::StyledElement::removedFromDocument()' /usr/bin/gold: /home/oszi/WebKit/WebKitBuild/Release/Source/WebCore/debug/libWebCore.a(InsertionPoint.o): in function vtable for WebCore::InsertionPoint:InsertionPoint.cpp(.data.rel.ro._ZTVN7WebCore14InsertionPointE+0xf4): error: undefined reference to 'WebCore::StyledElement::insertedIntoDocument()' /usr/bin/gold: /home/oszi/WebKit/WebKitBuild/Release/Source/WebCore/debug/libWebCore.a(InsertionPoint.o): in function vtable for WebCore::InsertionPoint:InsertionPoint.cpp(.data.rel.ro._ZTVN7WebCore14InsertionPointE+0xf8): error: undefined reference to 'WebCore::StyledElement::removedFromDocument()' 560859 1 ossy 2012-02-21 07:09:40 -0800 There some serious bug in the new QtWebKit buildsystem: - dom/StyledElement.h is in WebCore/target.pri - /home/oszi/WebKit/Source/WebCore/dom/StyledElement.h is in /WebKitBuild/Release/Source/WebCore/HTMLDataListElement.d - _BUT_ WebKitBuild/Release/Source/WebCore/Makefile.WebCore.Target includes wrong dependecy files: "-include obj/debug/dom/StyledElement.d" Tor Arne, could you check what happened? I think we got _all_ incremental build bugs nowadays because of this. It means that now almost all dependency is missing. :S 560880 2 ossy 2012-02-21 07:56:17 -0800 I think it is qmake bug near GNUMake option. 560892 3 vestbo 2012-02-21 08:23:00 -0800 (In reply to comment #1) > - /home/oszi/WebKit/Source/WebCore/dom/StyledElement.h is in /WebKitBuild/Release/Source/WebCore/HTMLDataListElement.d The location of this file is wrong. > - _BUT_ WebKitBuild/Release/Source/WebCore/Makefile.WebCore.Target > includes wrong dependecy files: "-include obj/debug/dom/StyledElement.d" That's correct. That's including the expected dependency file for StyledElement (not HTMLDataListElement), and in the right location. 560938 4 ossy 2012-02-21 09:10:51 -0800 OK. And how can we fix it? Or is it possible to disable GNUMake dependency generation on the bots until proper fix? 560941 5 vestbo 2012-02-21 09:15:42 -0800 (In reply to comment #4) > OK. And how can we fix it? Or is it possible to disable GNUMake dependency generation on the bots until proper fix? I'm doing a local build to try to reproduce, let's compare my results with yours on IRC. For the bots you can do CONFIG-=GNUmake to force qmake to deal with all dependency tracking. Requires a clean build after changing the config. 560966 6 vestbo 2012-02-21 09:42:24 -0800 (In reply to comment #4) > OK. And how can we fix it? It appears your .d files are not placed at the same path as the .o files, which should be the effect of passing -MD to gcc. Can you try this and verify that the .o and .d both end up in obj? mkdir -p obj && touch foo.cpp && gcc -c foo.cpp -o obj/foo.o -MD && ls obj 561162 7 ossy 2012-02-21 13:05:59 -0800 Very very strange ... I got different results on our similar servers. (Same distibution, same gcc, etc.) Tomorrow I'll check what happened. 561753 8 ossy 2012-02-22 01:47:51 -0800 We got it, unfortunately it is an icecc bug. original command: gcc -c -MD x/y.c -o x/y.o local preprocess: gcc -E -MD x/y.c --> It generates y.d into the current directory, because icecc consumed the "-o x/y.o" We need a nice workaround to make incremental build work again with icecream. 562257 9 allan.jensen 2012-02-22 12:33:27 -0800 (In reply to comment #8) > We got it, unfortunately it is an icecc bug. > > original command: gcc -c -MD x/y.c -o x/y.o > local preprocess: gcc -E -MD x/y.c > --> It generates y.d into the current directory, > because icecc consumed the "-o x/y.o" > > We need a nice workaround to make incremental build work again with icecream. Remember to also file the bug to icecream. 564265 10 vestbo 2012-02-24 06:08:58 -0800 (In reply to comment #9) > (In reply to comment #8) > > We got it, unfortunately it is an icecc bug. > > > > original command: gcc -c -MD x/y.c -o x/y.o > > local preprocess: gcc -E -MD x/y.c > > --> It generates y.d into the current directory, > > because icecc consumed the "-o x/y.o" > > > > We need a nice workaround to make incremental build work again with icecream. > > Remember to also file the bug to icecream. This issue was fixed in icecream 0.9.7, please upgrade.