79096 2012-02-21 04:13:57 -0800 [GTK] fast/mediastream/peerconnection-argument-types.html fails 2012-02-22 01:02:52 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned abarth webkit.review.bot yanbin.zhang oldest_to_newest 560802 0 pnormand 2012-02-21 04:13:57 -0800 Since checkin in r108299. Consistently. Diff: --- /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/fast/mediastream/peerconnection-argument-types-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/fast/mediastream/peerconnection-argument-types-actual.txt @@ -3,7 +3,7 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -PASS typeof webkitPeerConnection== 'function' is true +FAIL typeof webkitPeerConnection== 'function' should be true. Was false. PASS new webkitPeerConnection() threw exception TypeError: Not enough arguments. PASS new webkitPeerConnection("STUN 203.0.113.2:2478") threw exception TypeError: Not enough arguments. PASS new webkitPeerConnection("STUN relay.example.net:3478") threw exception TypeError: Not enough arguments. @@ -23,8 +23,8 @@ PASS new webkitPeerConnection("STUNS NONE") threw exception TypeError: Not enough arguments. PASS new webkitPeerConnection("undefined") threw exception TypeError: Not enough arguments. PASS new webkitPeerConnection("null") threw exception TypeError: Not enough arguments. -PASS new webkitPeerConnection({})) threw exception SyntaxError: Unexpected token ). -PASS new webkitPeerConnection(42)) threw exception SyntaxError: Unexpected token ). +FAIL new webkitPeerConnection({})) should throw SyntaxError: Unexpected token ). Threw exception SyntaxError: Unexpected token ')'. +FAIL new webkitPeerConnection(42)) should throw SyntaxError: Unexpected token ). Threw exception SyntaxError: Unexpected token ')'. PASS new webkitPeerConnection(Infinity) threw exception TypeError: Not enough arguments. PASS new webkitPeerConnection(-Infinity) threw exception TypeError: Not enough arguments. PASS new webkitPeerConnection(emptyFunction) threw exception TypeError: Not enough arguments. @@ -45,7 +45,7 @@ PASS new webkitPeerConnection("STUN NONE",emptyFunction) did not throw exception. PASS new webkitPeerConnection("STUNS NONE",emptyFunction) did not throw exception. PASS new webkitPeerConnection("TURN NONE",undefined) threw exception Error: TYPE_MISMATCH_ERR: DOM Exception 17. -PASS new webkitPeerConnection("TURNS NONE",{}) did not throw exception. +FAIL new webkitPeerConnection("TURNS NONE",{}) should not throw exception. Threw exception Error: TYPE_MISMATCH_ERR: DOM Exception 17 PASS new webkitPeerConnection("STUN NONE",42) threw exception Error: TYPE_MISMATCH_ERR: DOM Exception 17. PASS new webkitPeerConnection("STUNS NONE",Infinity) threw exception Error: TYPE_MISMATCH_ERR: DOM Exception 17. PASS new webkitPeerConnection("STUNS NONE",-Infinity) threw exception Error: TYPE_MISMATCH_ERR: DOM Exception 17. 560803 1 pnormand 2012-02-21 04:16:39 -0800 I haven't checked, but could the current test results be V8-specific? 561510 2 yanbin.zhang 2012-02-21 19:43:00 -0800 Those test cases are defined according to http://www.w3.org/TR/webrtc/ For failed test cases: new webkitPeerConnection("TURNS NONE",{}) I looked into this failure and think it is a bug for V8. Test case should fail explicitly by throwing an exception, otherwise the code should not run correctly in any case. According to the WebIDL spec for “Callback types” (http://dev.w3.org/2006/webapi/WebIDL/#es-callback): If V is not a Function object, then throw a TypeError. Hi, Adam, Do we need to report a bug entry for this issue for V8 and modify test case? And, I am very sorry to make a slight mistake for following two test cases definition: PASS new webkitPeerConnection({})) threw exception SyntaxError: Unexpected token ). PASS new webkitPeerConnection(42)) threw exception SyntaxError: Unexpected token ) It should be PASS new webkitPeerConnection({}) threw exception TypeError: Not enough arguments. PASS new webkitPeerConnection(42) threw exception TypeError: Not enough arguments. I will upload a new patch to fix them. While, the test result should not failed for original definition. I am not sure why those test cases were failed. Philippe, I guess you should look into why test case typeof webkitPeerConnection== 'function' is failed. Thanks Yanbin 561623 3 128131 yanbin.zhang 2012-02-21 22:29:45 -0800 Created attachment 128131 patch 561632 4 128131 abarth 2012-02-21 22:44:05 -0800 Comment on attachment 128131 patch View in context: https://bugs.webkit.org/attachment.cgi?id=128131&action=review > LayoutTests/ChangeLog:9 > + [GTK] fast/mediastream/peerconnection-argument-types.html fails > + https://bugs.webkit.org/show_bug.cgi?id=79096 > + > + Reviewed by NOBODY (OOPS!). > + > + * fast/mediastream/peerconnection-argument-types-expected.txt: > + * fast/mediastream/script-tests/argument-types.js: Can you explain why you're making this change? 561648 5 yanbin.zhang 2012-02-21 23:05:00 -0800 There is a mistake for following two test cases definition: PASS new webkitPeerConnection({})) threw exception SyntaxError: Unexpected token ). PASS new webkitPeerConnection(42)) threw exception SyntaxError: Unexpected token ) It should be PASS new webkitPeerConnection({}) threw exception TypeError: Not enough arguments. PASS new webkitPeerConnection(42) threw exception TypeError: Not enough arguments. This patch is to fix them. 561653 6 128131 abarth 2012-02-21 23:09:58 -0800 Comment on attachment 128131 patch Ok. In general, it's a good idea to explain why you're making a change in the ChangeLog. 561688 7 pnormand 2012-02-22 00:15:26 -0800 You didn't unskip the test either. 561720 8 128131 webkit.review.bot 2012-02-22 01:02:47 -0800 Comment on attachment 128131 patch Clearing flags on attachment: 128131 Committed r108460: <http://trac.webkit.org/changeset/108460> 561721 9 webkit.review.bot 2012-02-22 01:02:52 -0800 All reviewed patches have been landed. Closing bug. 128131 2012-02-21 22:29:45 -0800 2012-02-22 01:02:47 -0800 patch argument-types.patch text/plain 3188 yanbin.zhang SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDEwODQ0NikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAyLTIyICBZYW5iaW4gWmhhbmcgIDx5 YW5iaW4uemhhbmdAaW50ZWwuY29tPgorCisgICAgICAgIFtHVEtdIGZhc3QvbWVkaWFzdHJlYW0v cGVlcmNvbm5lY3Rpb24tYXJndW1lbnQtdHlwZXMuaHRtbCBmYWlscworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzkwOTYKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvbWVkaWFzdHJlYW0vcGVlcmNv bm5lY3Rpb24tYXJndW1lbnQtdHlwZXMtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGZhc3QvbWVk aWFzdHJlYW0vc2NyaXB0LXRlc3RzL2FyZ3VtZW50LXR5cGVzLmpzOgorCiAyMDEyLTAyLTIxICBN YXggVnVqb3ZpYyAgPG12dWpvdmljQGFkb2JlLmNvbT4KIAogICAgICAgICBnZXRDVE0oKSBvbiBT Vkcgcm9vdCBlbGVtZW50IHdpdGggYm9yZGVycywgcGFkZGluZ3MsIGFuZCB2aWV3Ym94IHJldHVy bnMgaW5jb3JyZWN0IHZhbHVlcwpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9tZWRpYXN0cmVhbS9w ZWVyY29ubmVjdGlvbi1hcmd1bWVudC10eXBlcy1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g TGF5b3V0VGVzdHMvZmFzdC9tZWRpYXN0cmVhbS9wZWVyY29ubmVjdGlvbi1hcmd1bWVudC10eXBl cy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDEwODQ0NikKKysrIExheW91dFRlc3RzL2Zhc3QvbWVk aWFzdHJlYW0vcGVlcmNvbm5lY3Rpb24tYXJndW1lbnQtdHlwZXMtZXhwZWN0ZWQudHh0CSh3b3Jr aW5nIGNvcHkpCkBAIC0yMyw4ICsyMyw4IEBAIFBBU1MgbmV3IHdlYmtpdFBlZXJDb25uZWN0aW9u KCJTVFVOIE5PTkUKIFBBU1MgbmV3IHdlYmtpdFBlZXJDb25uZWN0aW9uKCJTVFVOUyBOT05FIikg dGhyZXcgZXhjZXB0aW9uIFR5cGVFcnJvcjogTm90IGVub3VnaCBhcmd1bWVudHMuCiBQQVNTIG5l dyB3ZWJraXRQZWVyQ29ubmVjdGlvbigidW5kZWZpbmVkIikgdGhyZXcgZXhjZXB0aW9uIFR5cGVF cnJvcjogTm90IGVub3VnaCBhcmd1bWVudHMuCiBQQVNTIG5ldyB3ZWJraXRQZWVyQ29ubmVjdGlv bigibnVsbCIpIHRocmV3IGV4Y2VwdGlvbiBUeXBlRXJyb3I6IE5vdCBlbm91Z2ggYXJndW1lbnRz LgotUEFTUyBuZXcgd2Via2l0UGVlckNvbm5lY3Rpb24oe30pKSB0aHJldyBleGNlcHRpb24gU3lu dGF4RXJyb3I6IFVuZXhwZWN0ZWQgdG9rZW4gKS4KLVBBU1MgbmV3IHdlYmtpdFBlZXJDb25uZWN0 aW9uKDQyKSkgdGhyZXcgZXhjZXB0aW9uIFN5bnRheEVycm9yOiBVbmV4cGVjdGVkIHRva2VuICku CitQQVNTIG5ldyB3ZWJraXRQZWVyQ29ubmVjdGlvbih7fSkgdGhyZXcgZXhjZXB0aW9uIFR5cGVF cnJvcjogTm90IGVub3VnaCBhcmd1bWVudHMuCitQQVNTIG5ldyB3ZWJraXRQZWVyQ29ubmVjdGlv big0MikgdGhyZXcgZXhjZXB0aW9uIFR5cGVFcnJvcjogTm90IGVub3VnaCBhcmd1bWVudHMuCiBQ QVNTIG5ldyB3ZWJraXRQZWVyQ29ubmVjdGlvbihJbmZpbml0eSkgdGhyZXcgZXhjZXB0aW9uIFR5 cGVFcnJvcjogTm90IGVub3VnaCBhcmd1bWVudHMuCiBQQVNTIG5ldyB3ZWJraXRQZWVyQ29ubmVj dGlvbigtSW5maW5pdHkpIHRocmV3IGV4Y2VwdGlvbiBUeXBlRXJyb3I6IE5vdCBlbm91Z2ggYXJn dW1lbnRzLgogUEFTUyBuZXcgd2Via2l0UGVlckNvbm5lY3Rpb24oZW1wdHlGdW5jdGlvbikgdGhy ZXcgZXhjZXB0aW9uIFR5cGVFcnJvcjogTm90IGVub3VnaCBhcmd1bWVudHMuCkluZGV4OiBMYXlv dXRUZXN0cy9mYXN0L21lZGlhc3RyZWFtL3NjcmlwdC10ZXN0cy9hcmd1bWVudC10eXBlcy5qcwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L21lZGlhc3RyZWFtL3NjcmlwdC10ZXN0cy9h cmd1bWVudC10eXBlcy5qcwkocmV2aXNpb24gMTA4NDQ2KQorKysgTGF5b3V0VGVzdHMvZmFzdC9t ZWRpYXN0cmVhbS9zY3JpcHQtdGVzdHMvYXJndW1lbnQtdHlwZXMuanMJKHdvcmtpbmcgY29weSkK QEAgLTU1LDggKzU1LDggQEAgdGVzdCgnbmV3IHdlYmtpdFBlZXJDb25uZWN0aW9uKCJTVFVOIE5P TgogdGVzdCgnbmV3IHdlYmtpdFBlZXJDb25uZWN0aW9uKCJTVFVOUyBOT05FIiknLCB0cnVlLCAn VHlwZUVycm9yOiBOb3QgZW5vdWdoIGFyZ3VtZW50cycpOwogdGVzdCgnbmV3IHdlYmtpdFBlZXJD b25uZWN0aW9uKCJ1bmRlZmluZWQiKScsIHRydWUsICdUeXBlRXJyb3I6IE5vdCBlbm91Z2ggYXJn dW1lbnRzJyk7CiB0ZXN0KCduZXcgd2Via2l0UGVlckNvbm5lY3Rpb24oIm51bGwiKScsIHRydWUs ICdUeXBlRXJyb3I6IE5vdCBlbm91Z2ggYXJndW1lbnRzJyk7Ci10ZXN0KCduZXcgd2Via2l0UGVl ckNvbm5lY3Rpb24oe30pKScsIHRydWUsICdTeW50YXhFcnJvcjogVW5leHBlY3RlZCB0b2tlbiAp Jyk7Ci10ZXN0KCduZXcgd2Via2l0UGVlckNvbm5lY3Rpb24oNDIpKScsIHRydWUsICdTeW50YXhF cnJvcjogVW5leHBlY3RlZCB0b2tlbiApJyk7Cit0ZXN0KCduZXcgd2Via2l0UGVlckNvbm5lY3Rp b24oe30pJywgdHJ1ZSwgJ1R5cGVFcnJvcjogTm90IGVub3VnaCBhcmd1bWVudHMnKTsKK3Rlc3Qo J25ldyB3ZWJraXRQZWVyQ29ubmVjdGlvbig0MiknLCB0cnVlLCAnVHlwZUVycm9yOiBOb3QgZW5v dWdoIGFyZ3VtZW50cycpOwogdGVzdCgnbmV3IHdlYmtpdFBlZXJDb25uZWN0aW9uKEluZmluaXR5 KScsIHRydWUsICdUeXBlRXJyb3I6IE5vdCBlbm91Z2ggYXJndW1lbnRzJyk7CiB0ZXN0KCduZXcg d2Via2l0UGVlckNvbm5lY3Rpb24oLUluZmluaXR5KScsIHRydWUsICdUeXBlRXJyb3I6IE5vdCBl bm91Z2ggYXJndW1lbnRzJyk7CiB0ZXN0KCduZXcgd2Via2l0UGVlckNvbm5lY3Rpb24oZW1wdHlG dW5jdGlvbiknLCB0cnVlLCAnVHlwZUVycm9yOiBOb3QgZW5vdWdoIGFyZ3VtZW50cycpOwo=