<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>79094</bug_id>
          
          <creation_ts>2012-02-21 02:21:06 -0800</creation_ts>
          <short_desc>[BlackBerry] Upstream the BlackBerry change to platform/graphics/IntPoint.h</short_desc>
          <delta_ts>2012-02-23 19:05:45 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>73144</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Leo Yang">leo.yang</reporter>
          <assigned_to name="Leo Yang">leo.yang</assigned_to>
          <cc>charles.wei</cc>
    
    <cc>rwlbuis</cc>
    
    <cc>staikos</cc>
    
    <cc>tonikitoo</cc>
    
    <cc>webkit.review.bot</cc>
    
    <cc>zimmermann</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>560764</commentid>
    <comment_count>0</comment_count>
    <who name="Leo Yang">leo.yang</who>
    <bug_when>2012-02-21 02:21:06 -0800</bug_when>
    <thetext>This is to add the blackberry specific change to platform/graphics/IntPoint.h.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>560768</commentid>
    <comment_count>1</comment_count>
      <attachid>127948</attachid>
    <who name="Leo Yang">leo.yang</who>
    <bug_when>2012-02-21 02:29:29 -0800</bug_when>
    <thetext>Created attachment 127948
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>560775</commentid>
    <comment_count>2</comment_count>
      <attachid>127948</attachid>
    <who name="Nikolas Zimmermann">zimmermann</who>
    <bug_when>2012-02-21 03:15:30 -0800</bug_when>
    <thetext>Comment on attachment 127948
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127948&amp;action=review

Looks fine, I have a suggestion though:

&gt; Source/WebCore/ChangeLog:11
&gt; +        The porting can be built now, no new tests.

I think this sentence is obsolete, at least I don&apos;t understand it. Do you mean the port can now be build for the first time?

&gt; Source/WebCore/platform/graphics/IntPoint.h:127
&gt; +        return String::format(&quot;(%i,%i)&quot;, m_x, m_y);

String::format should absolutely be avoided in new code. It&apos;s deprecated.
You can either make use of Strings operator+ optimization, and juse use:
return String(&quot;(&quot;) + String::number(m_x) + ...
That will result in one malloc, for the final string size, and no intermediate &lt;any&gt;-&gt;String conversions, and thus should be at least as efficient as using String::format directly.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>560816</commentid>
    <comment_count>3</comment_count>
      <attachid>127948</attachid>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2012-02-21 05:05:27 -0800</bug_when>
    <thetext>Comment on attachment 127948
Patch

Can not this code go to IntPointBlackBerry?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>561435</commentid>
    <comment_count>4</comment_count>
      <attachid>128097</attachid>
    <who name="Leo Yang">leo.yang</who>
    <bug_when>2012-02-21 17:59:51 -0800</bug_when>
    <thetext>Created attachment 128097
Patch v2</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>561437</commentid>
    <comment_count>5</comment_count>
    <who name="Leo Yang">leo.yang</who>
    <bug_when>2012-02-21 18:01:20 -0800</bug_when>
    <thetext>(In reply to comment #2)
&gt; (From update of attachment 127948 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=127948&amp;action=review
&gt; 
&gt; Looks fine, I have a suggestion though:
&gt; 
&gt; &gt; Source/WebCore/ChangeLog:11
&gt; &gt; +        The porting can be built now, no new tests.
&gt; 
&gt; I think this sentence is obsolete, at least I don&apos;t understand it. Do you mean the port can now be build for the first time?
Oh, silly. The porting can&apos;t be built yet, now new tests.

&gt; 
&gt; &gt; Source/WebCore/platform/graphics/IntPoint.h:127
&gt; &gt; +        return String::format(&quot;(%i,%i)&quot;, m_x, m_y);
&gt; 
&gt; String::format should absolutely be avoided in new code. It&apos;s deprecated.
&gt; You can either make use of Strings operator+ optimization, and juse use:
&gt; return String(&quot;(&quot;) + String::number(m_x) + ...
&gt; That will result in one malloc, for the final string size, and no intermediate &lt;any&gt;-&gt;String conversions, and thus should be at least as efficient as using String::format directly.
OK.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>561438</commentid>
    <comment_count>6</comment_count>
    <who name="Leo Yang">leo.yang</who>
    <bug_when>2012-02-21 18:02:25 -0800</bug_when>
    <thetext>(In reply to comment #3)
&gt; (From update of attachment 127948 [details])
&gt; Can not this code go to IntPointBlackBerry?

I think it should go in the header because we need to alter the declaration.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>561444</commentid>
    <comment_count>7</comment_count>
      <attachid>128097</attachid>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2012-02-21 18:08:50 -0800</bug_when>
    <thetext>Comment on attachment 128097
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=128097&amp;action=review

&gt; Source/WebCore/platform/graphics/IntPoint.h:127
&gt; +#if PLATFORM(BLACKBERRY)
&gt; +    String toString() const
&gt; +    {
&gt; +        return String(&quot;(&quot;) + String::number(m_x) + String(&quot;,&quot;) + String::number(m_y) + String(&quot;)&quot;);

I would suggest making it non bb-specific</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>561446</commentid>
    <comment_count>8</comment_count>
    <who name="Leo Yang">leo.yang</who>
    <bug_when>2012-02-21 18:13:37 -0800</bug_when>
    <thetext>(In reply to comment #7)
&gt; (From update of attachment 128097 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=128097&amp;action=review
&gt; 
&gt; &gt; Source/WebCore/platform/graphics/IntPoint.h:127
&gt; &gt; +#if PLATFORM(BLACKBERRY)
&gt; &gt; +    String toString() const
&gt; &gt; +    {
&gt; &gt; +        return String(&quot;(&quot;) + String::number(m_x) + String(&quot;,&quot;) + String::number(m_y) + String(&quot;)&quot;);
&gt; 
&gt; I would suggest making it non bb-specific

good suggestion.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>562919</commentid>
    <comment_count>9</comment_count>
      <attachid>128421</attachid>
    <who name="Leo Yang">leo.yang</who>
    <bug_when>2012-02-23 00:32:42 -0800</bug_when>
    <thetext>Created attachment 128421
Patch v3</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>562921</commentid>
    <comment_count>10</comment_count>
    <who name="Leo Yang">leo.yang</who>
    <bug_when>2012-02-23 00:33:27 -0800</bug_when>
    <thetext>toString has been removed internally.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>563777</commentid>
    <comment_count>11</comment_count>
      <attachid>128421</attachid>
    <who name="Leo Yang">leo.yang</who>
    <bug_when>2012-02-23 18:04:13 -0800</bug_when>
    <thetext>Comment on attachment 128421
Patch v3

Sending it to cq...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>563827</commentid>
    <comment_count>12</comment_count>
      <attachid>128421</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-02-23 19:05:40 -0800</bug_when>
    <thetext>Comment on attachment 128421
Patch v3

Clearing flags on attachment: 128421

Committed r108715: &lt;http://trac.webkit.org/changeset/108715&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>563828</commentid>
    <comment_count>13</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-02-23 19:05:45 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>127948</attachid>
            <date>2012-02-21 02:29:29 -0800</date>
            <delta_ts>2012-02-21 17:59:51 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>0001-BlackBerry-Upstream-the-BlackBerry-change-to-platfor.patch</filename>
            <type>text/plain</type>
            <size>2881</size>
            <attacher name="Leo Yang">leo.yang</attacher>
            
              <data encoding="base64">RnJvbSA4OGJlNzcwOGEzZGVjNjMzNTU5NDNkZDFlZWQyNDU1OWQ3OGVkYTYzIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBMZW8gWWFuZyA8bGVvLnlhbmdAdG9yY2htb2JpbGUuY29tLmNu
PgpEYXRlOiBUdWUsIDIxIEZlYiAyMDEyIDE4OjI4OjE1ICswODAwClN1YmplY3Q6IFtQQVRDSF0g
W0JsYWNrQmVycnldIFVwc3RyZWFtIHRoZSBCbGFja0JlcnJ5IGNoYW5nZSB0bwogcGxhdGZvcm0v
Z3JhcGhpY3MvSW50UG9pbnQuaAogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTc5MDk0CgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCkFkZCBjb252ZXJzaW9uIGNv
bnZlbmllbmNlIGJldHdlZW4gV2ViQ29yZTo6SW50UG9pbnQgYW5kIEJsYWNrQmVycnk6OlBsYXRm
b3JtOjpJbnRQb2ludC4KQWxzbyBhZGQgYSBibGFja2JlcnJ5IHNwZWNpZmljIHRvU3RyaW5nIG1l
dGhvZC4KClRoZSBwb3J0aW5nIGNhbiBiZSBidWlsdCBub3csIG5vIG5ldyB0ZXN0cy4KCiogcGxh
dGZvcm0vZ3JhcGhpY3MvSW50UG9pbnQuaDoKKFBsYXRmb3JtKToKKEludFBvaW50KToKKFdlYkNv
cmU6OkludFBvaW50Ojp0b1N0cmluZyk6Ci0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAg
ICAgICAgICAgICAgICAgICB8ICAgMTcgKysrKysrKysrKysrKysrKysKIFNvdXJjZS9XZWJDb3Jl
L3BsYXRmb3JtL2dyYXBoaWNzL0ludFBvaW50LmggfCAgIDE2ICsrKysrKysrKysrKysrKysKIDIg
ZmlsZXMgY2hhbmdlZCwgMzMgaW5zZXJ0aW9ucygrKSwgMCBkZWxldGlvbnMoLSkKCmRpZmYgLS1n
aXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cK
aW5kZXggZjU1ZmZhOC4uZjYxMzlkNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdl
TG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEy
LTAyLTIxICBMZW8gWWFuZyAgPGxlby55YW5nQHRvcmNobW9iaWxlLmNvbS5jbj4KKworICAgICAg
ICBbQmxhY2tCZXJyeV0gVXBzdHJlYW0gdGhlIEJsYWNrQmVycnkgY2hhbmdlIHRvIHBsYXRmb3Jt
L2dyYXBoaWNzL0ludFBvaW50LmgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTc5MDk0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku
CisKKyAgICAgICAgQWRkIGNvbnZlcnNpb24gY29udmVuaWVuY2UgYmV0d2VlbiBXZWJDb3JlOjpJ
bnRQb2ludCBhbmQgQmxhY2tCZXJyeTo6UGxhdGZvcm06OkludFBvaW50LgorICAgICAgICBBbHNv
IGFkZCBhIGJsYWNrYmVycnkgc3BlY2lmaWMgdG9TdHJpbmcgbWV0aG9kLgorCisgICAgICAgIFRo
ZSBwb3J0aW5nIGNhbiBiZSBidWlsdCBub3csIG5vIG5ldyB0ZXN0cy4KKworICAgICAgICAqIHBs
YXRmb3JtL2dyYXBoaWNzL0ludFBvaW50Lmg6CisgICAgICAgIChQbGF0Zm9ybSk6CisgICAgICAg
IChJbnRQb2ludCk6CisgICAgICAgIChXZWJDb3JlOjpJbnRQb2ludDo6dG9TdHJpbmcpOgorCiAy
MDEyLTAyLTIwICBLZW50YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAogICAgICAg
ICBVbnJldmlld2VkLiBSZWJhc2VsaW5lZCBydW4tYmluZGluZ3MtdGVzdHMgcmVzdWx0cy4KZGlm
ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ludFBvaW50LmggYi9T
b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9JbnRQb2ludC5oCmluZGV4IDhkN2ZkN2Yu
LmNjMjliYjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0lu
dFBvaW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW50UG9pbnQu
aApAQCAtNTUsNiArNTUsMTIgQEAgY2xhc3MgUVBvaW50OwogUVRfRU5EX05BTUVTUEFDRQogI2Vs
aWYgUExBVEZPUk0oR1RLKQogdHlwZWRlZiBzdHJ1Y3QgX0dka1BvaW50IEdka1BvaW50OworI2Vs
aWYgUExBVEZPUk0oQkxBQ0tCRVJSWSkKK25hbWVzcGFjZSBCbGFja0JlcnJ5IHsKK25hbWVzcGFj
ZSBQbGF0Zm9ybSB7CitjbGFzcyBJbnRQb2ludDsKK30KK30KICNlbGlmIFBMQVRGT1JNKEVGTCkK
IHR5cGVkZWYgc3RydWN0IF9FdmFzX1BvaW50IEV2YXNfUG9pbnQ7CiAjZW5kaWYKQEAgLTExNSw2
ICsxMjEsMTMgQEAgcHVibGljOgogICAgICAgICByZXR1cm4gSW50UG9pbnQobV95LCBtX3gpOwog
ICAgIH0KIAorI2lmIFBMQVRGT1JNKEJMQUNLQkVSUlkpCisgICAgU3RyaW5nIHRvU3RyaW5nKCkg
Y29uc3QKKyAgICB7CisgICAgICAgIHJldHVybiBTdHJpbmc6OmZvcm1hdCgiKCVpLCVpKSIsIG1f
eCwgbV95KTsKKyAgICB9CisjZW5kaWYKKwogI2lmIFVTRShDRykgfHwgVVNFKFNLSUFfT05fTUFD
X0NIUk9NSVVNKQogICAgIGV4cGxpY2l0IEludFBvaW50KGNvbnN0IENHUG9pbnQmKTsgLy8gZG9u
J3QgZG8gdGhpcyBpbXBsaWNpdGx5IHNpbmNlIGl0J3MgbG9zc3kKICAgICBvcGVyYXRvciBDR1Bv
aW50KCkgY29uc3Q7CkBAIC0xMzYsNiArMTQ5LDkgQEAgcHVibGljOgogI2VsaWYgUExBVEZPUk0o
R1RLKQogICAgIEludFBvaW50KGNvbnN0IEdka1BvaW50Jik7CiAgICAgb3BlcmF0b3IgR2RrUG9p
bnQoKSBjb25zdDsKKyNlbGlmIFBMQVRGT1JNKEJMQUNLQkVSUlkpCisgICAgSW50UG9pbnQoY29u
c3QgQmxhY2tCZXJyeTo6UGxhdGZvcm06OkludFBvaW50Jik7CisgICAgb3BlcmF0b3IgQmxhY2tC
ZXJyeTo6UGxhdGZvcm06OkludFBvaW50KCkgY29uc3Q7CiAjZWxpZiBQTEFURk9STShFRkwpCiAg
ICAgZXhwbGljaXQgSW50UG9pbnQoY29uc3QgRXZhc19Qb2ludCYpOwogICAgIG9wZXJhdG9yIEV2
YXNfUG9pbnQoKSBjb25zdDsKLS0gCjEuNy41LjQKCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>128097</attachid>
            <date>2012-02-21 17:59:51 -0800</date>
            <delta_ts>2012-02-23 00:32:42 -0800</delta_ts>
            <desc>Patch v2</desc>
            <filename>0001-BlackBerry-Upstream-the-BlackBerry-change-to-platfor.patch</filename>
            <type>text/plain</type>
            <size>2933</size>
            <attacher name="Leo Yang">leo.yang</attacher>
            
              <data encoding="base64">RnJvbSAwMmQ5Nzg5YjA1Y2RiYzc4OTlmM2JiYTc2YjgwMTM4MzQyMzcxZTkwIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBMZW8gWWFuZyA8bGVvLnlhbmdAdG9yY2htb2JpbGUuY29tLmNu
PgpEYXRlOiBUdWUsIDIxIEZlYiAyMDEyIDE4OjI4OjE1ICswODAwClN1YmplY3Q6IFtQQVRDSF0g
W0JsYWNrQmVycnldIFVwc3RyZWFtIHRoZSBCbGFja0JlcnJ5IGNoYW5nZSB0bwogcGxhdGZvcm0v
Z3JhcGhpY3MvSW50UG9pbnQuaAogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTc5MDk0CgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCkFkZCBjb252ZXJzaW9uIGNv
bnZlbmllbmNlIGJldHdlZW4gV2ViQ29yZTo6SW50UG9pbnQgYW5kIEJsYWNrQmVycnk6OlBsYXRm
b3JtOjpJbnRQb2ludC4KQWxzbyBhZGQgYSBibGFja2JlcnJ5IHNwZWNpZmljIHRvU3RyaW5nIG1l
dGhvZC4KClRoZSBwb3J0aW5nIGNhbid0IGJlIGJ1aWx0IHlldCwgbm8gbmV3IHRlc3RzLgoKKiBw
bGF0Zm9ybS9ncmFwaGljcy9JbnRQb2ludC5oOgooUGxhdGZvcm0pOgooSW50UG9pbnQpOgooV2Vi
Q29yZTo6SW50UG9pbnQ6OnRvU3RyaW5nKToKLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cg
ICAgICAgICAgICAgICAgICAgIHwgICAxNyArKysrKysrKysrKysrKysrKwogU291cmNlL1dlYkNv
cmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW50UG9pbnQuaCB8ICAgMTYgKysrKysrKysrKysrKysrKwog
MiBmaWxlcyBjaGFuZ2VkLCAzMyBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlmZiAt
LWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv
ZwppbmRleCBmNTVmZmE4Li41ZGVkMzVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFu
Z2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIw
MTItMDItMjEgIExlbyBZYW5nICA8bGVvLnlhbmdAdG9yY2htb2JpbGUuY29tLmNuPgorCisgICAg
ICAgIFtCbGFja0JlcnJ5XSBVcHN0cmVhbSB0aGUgQmxhY2tCZXJyeSBjaGFuZ2UgdG8gcGxhdGZv
cm0vZ3JhcGhpY3MvSW50UG9pbnQuaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z
aG93X2J1Zy5jZ2k/aWQ9NzkwOTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh
KS4KKworICAgICAgICBBZGQgY29udmVyc2lvbiBjb252ZW5pZW5jZSBiZXR3ZWVuIFdlYkNvcmU6
OkludFBvaW50IGFuZCBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6SW50UG9pbnQuCisgICAgICAgIEFs
c28gYWRkIGEgYmxhY2tiZXJyeSBzcGVjaWZpYyB0b1N0cmluZyBtZXRob2QuCisKKyAgICAgICAg
VGhlIHBvcnRpbmcgY2FuJ3QgYmUgYnVpbHQgeWV0LCBubyBuZXcgdGVzdHMuCisKKyAgICAgICAg
KiBwbGF0Zm9ybS9ncmFwaGljcy9JbnRQb2ludC5oOgorICAgICAgICAoUGxhdGZvcm0pOgorICAg
ICAgICAoSW50UG9pbnQpOgorICAgICAgICAoV2ViQ29yZTo6SW50UG9pbnQ6OnRvU3RyaW5nKToK
KwogMjAxMi0wMi0yMCAgS2VudGFybyBIYXJhICA8aGFyYWtlbkBjaHJvbWl1bS5vcmc+CiAKICAg
ICAgICAgVW5yZXZpZXdlZC4gUmViYXNlbGluZWQgcnVuLWJpbmRpbmdzLXRlc3RzIHJlc3VsdHMu
CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9JbnRQb2ludC5o
IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW50UG9pbnQuaAppbmRleCA4ZDdm
ZDdmLi43ODI4MTJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj
cy9JbnRQb2ludC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ludFBv
aW50LmgKQEAgLTU1LDYgKzU1LDEyIEBAIGNsYXNzIFFQb2ludDsKIFFUX0VORF9OQU1FU1BBQ0UK
ICNlbGlmIFBMQVRGT1JNKEdUSykKIHR5cGVkZWYgc3RydWN0IF9HZGtQb2ludCBHZGtQb2ludDsK
KyNlbGlmIFBMQVRGT1JNKEJMQUNLQkVSUlkpCituYW1lc3BhY2UgQmxhY2tCZXJyeSB7CituYW1l
c3BhY2UgUGxhdGZvcm0geworY2xhc3MgSW50UG9pbnQ7Cit9Cit9CiAjZWxpZiBQTEFURk9STShF
RkwpCiB0eXBlZGVmIHN0cnVjdCBfRXZhc19Qb2ludCBFdmFzX1BvaW50OwogI2VuZGlmCkBAIC0x
MTUsNiArMTIxLDEzIEBAIHB1YmxpYzoKICAgICAgICAgcmV0dXJuIEludFBvaW50KG1feSwgbV94
KTsKICAgICB9CiAKKyNpZiBQTEFURk9STShCTEFDS0JFUlJZKQorICAgIFN0cmluZyB0b1N0cmlu
ZygpIGNvbnN0CisgICAgeworICAgICAgICByZXR1cm4gU3RyaW5nKCIoIikgKyBTdHJpbmc6Om51
bWJlcihtX3gpICsgU3RyaW5nKCIsIikgKyBTdHJpbmc6Om51bWJlcihtX3kpICsgU3RyaW5nKCIp
Iik7CisgICAgfQorI2VuZGlmCisKICNpZiBVU0UoQ0cpIHx8IFVTRShTS0lBX09OX01BQ19DSFJP
TUlVTSkKICAgICBleHBsaWNpdCBJbnRQb2ludChjb25zdCBDR1BvaW50Jik7IC8vIGRvbid0IGRv
IHRoaXMgaW1wbGljaXRseSBzaW5jZSBpdCdzIGxvc3N5CiAgICAgb3BlcmF0b3IgQ0dQb2ludCgp
IGNvbnN0OwpAQCAtMTM2LDYgKzE0OSw5IEBAIHB1YmxpYzoKICNlbGlmIFBMQVRGT1JNKEdUSykK
ICAgICBJbnRQb2ludChjb25zdCBHZGtQb2ludCYpOwogICAgIG9wZXJhdG9yIEdka1BvaW50KCkg
Y29uc3Q7CisjZWxpZiBQTEFURk9STShCTEFDS0JFUlJZKQorICAgIEludFBvaW50KGNvbnN0IEJs
YWNrQmVycnk6OlBsYXRmb3JtOjpJbnRQb2ludCYpOworICAgIG9wZXJhdG9yIEJsYWNrQmVycnk6
OlBsYXRmb3JtOjpJbnRQb2ludCgpIGNvbnN0OwogI2VsaWYgUExBVEZPUk0oRUZMKQogICAgIGV4
cGxpY2l0IEludFBvaW50KGNvbnN0IEV2YXNfUG9pbnQmKTsKICAgICBvcGVyYXRvciBFdmFzX1Bv
aW50KCkgY29uc3Q7Ci0tIAoxLjcuNS40Cgo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>128421</attachid>
            <date>2012-02-23 00:32:42 -0800</date>
            <delta_ts>2012-02-23 19:05:40 -0800</delta_ts>
            <desc>Patch v3</desc>
            <filename>0001-BlackBerry-Upstream-the-BlackBerry-change-to-platfor.patch</filename>
            <type>text/plain</type>
            <size>2338</size>
            <attacher name="Leo Yang">leo.yang</attacher>
            
              <data encoding="base64">RnJvbSBiOWNjZGMwNGVhNzY0N2YyY2Q1MzIwMDcyOGM1MzBkNzFlZTAxMDBkIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBMZW8gWWFuZyA8bGVvLnlhbmdAdG9yY2htb2JpbGUuY29tLmNu
PgpEYXRlOiBUaHUsIDIzIEZlYiAyMDEyIDE2OjMxOjIxICswODAwClN1YmplY3Q6IFtQQVRDSF0g
W0JsYWNrQmVycnldIFVwc3RyZWFtIHRoZSBCbGFja0JlcnJ5IGNoYW5nZSB0bwogcGxhdGZvcm0v
Z3JhcGhpY3MvSW50UG9pbnQuaAogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTc5MDk0CgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCkFkZCBjb252ZXJzaW9uIGNv
bnZlbmllbmNlIGJldHdlZW4gV2ViQ29yZTo6SW50UG9pbnQgYW5kIEJsYWNrQmVycnk6OlBsYXRm
b3JtOjpJbnRQb2ludC4KClRoZSBwb3J0aW5nIGNhbid0IGJlIGJ1aWx0IHlldCwgbm8gbmV3IHRl
c3RzLgoKKiBwbGF0Zm9ybS9ncmFwaGljcy9JbnRQb2ludC5oOgooUGxhdGZvcm0pOgooSW50UG9p
bnQpOgotLS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgfCAg
IDE1ICsrKysrKysrKysrKysrKwogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW50
UG9pbnQuaCB8ICAgIDkgKysrKysrKysrCiAyIGZpbGVzIGNoYW5nZWQsIDI0IGluc2VydGlvbnMo
KyksIDAgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n
IGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDEyMDIxM2QuLjljMmQ5YWYgMTAwNjQ0
Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFu
Z2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMi0wMi0yMyAgTGVvIFlhbmcgIDxsZW8ueWFuZ0B0
b3JjaG1vYmlsZS5jb20uY24+CisKKyAgICAgICAgW0JsYWNrQmVycnldIFVwc3RyZWFtIHRoZSBC
bGFja0JlcnJ5IGNoYW5nZSB0byBwbGF0Zm9ybS9ncmFwaGljcy9JbnRQb2ludC5oCisgICAgICAg
IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03OTA5NAorCisgICAgICAg
IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBjb252ZXJzaW9uIGNv
bnZlbmllbmNlIGJldHdlZW4gV2ViQ29yZTo6SW50UG9pbnQgYW5kIEJsYWNrQmVycnk6OlBsYXRm
b3JtOjpJbnRQb2ludC4KKworICAgICAgICBUaGUgcG9ydGluZyBjYW4ndCBiZSBidWlsdCB5ZXQs
IG5vIG5ldyB0ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0ludFBvaW50Lmg6
CisgICAgICAgIChQbGF0Zm9ybSk6CisgICAgICAgIChJbnRQb2ludCk6CisKIDIwMTItMDItMjEg
IE1PUklUQSBIYWppbWUgPG1vcnJpdGFAZ29vZ2xlLmNvbT4KIAogICAgICAgICBJTlBVVF9TUEVF
Q0ggc2hvdWxkIGJlIGltcGxlbWVudGVkIGFzIGEgUGFnZVN1cHBsZW1lbnQuCmRpZmYgLS1naXQg
YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9JbnRQb2ludC5oIGIvU291cmNlL1dl
YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW50UG9pbnQuaAppbmRleCA4ZDdmZDdmLi5kZGM0MWI0
IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9JbnRQb2ludC5o
CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ludFBvaW50LmgKQEAgLTU1
LDYgKzU1LDEyIEBAIGNsYXNzIFFQb2ludDsKIFFUX0VORF9OQU1FU1BBQ0UKICNlbGlmIFBMQVRG
T1JNKEdUSykKIHR5cGVkZWYgc3RydWN0IF9HZGtQb2ludCBHZGtQb2ludDsKKyNlbGlmIFBMQVRG
T1JNKEJMQUNLQkVSUlkpCituYW1lc3BhY2UgQmxhY2tCZXJyeSB7CituYW1lc3BhY2UgUGxhdGZv
cm0geworY2xhc3MgSW50UG9pbnQ7Cit9Cit9CiAjZWxpZiBQTEFURk9STShFRkwpCiB0eXBlZGVm
IHN0cnVjdCBfRXZhc19Qb2ludCBFdmFzX1BvaW50OwogI2VuZGlmCkBAIC0xMzYsNiArMTQyLDkg
QEAgcHVibGljOgogI2VsaWYgUExBVEZPUk0oR1RLKQogICAgIEludFBvaW50KGNvbnN0IEdka1Bv
aW50Jik7CiAgICAgb3BlcmF0b3IgR2RrUG9pbnQoKSBjb25zdDsKKyNlbGlmIFBMQVRGT1JNKEJM
QUNLQkVSUlkpCisgICAgSW50UG9pbnQoY29uc3QgQmxhY2tCZXJyeTo6UGxhdGZvcm06OkludFBv
aW50Jik7CisgICAgb3BlcmF0b3IgQmxhY2tCZXJyeTo6UGxhdGZvcm06OkludFBvaW50KCkgY29u
c3Q7CiAjZWxpZiBQTEFURk9STShFRkwpCiAgICAgZXhwbGljaXQgSW50UG9pbnQoY29uc3QgRXZh
c19Qb2ludCYpOwogICAgIG9wZXJhdG9yIEV2YXNfUG9pbnQoKSBjb25zdDsKLS0gCjEuNy41LjQK
Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>