79084 2012-02-21 00:04:54 -0800 [GTK] REGRESSION: r108278 broke some tests that expect focus 2012-03-05 09:50:31 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mrobinson mrobinson webkit.review.bot oldest_to_newest 560708 0 mrobinson 2012-02-21 00:04:54 -0800 http://trac.webkit.org/changeset/108278 removed an explicit gtk_widget_grab_focus from WebCore. This broke the following layout tests: fast/images/imagemap-focus-ring-zoom-style.html fast/forms/number/input-number-events.html fast/events/tabindex-focus-chain.html fast/events/tab-focus-hidden.html fast/events/tab-focus-anchor.html fast/events/media-element-focus-tab.html fast/events/keypress-insert-tab.html fast/images/imagemap-focus-ring-zoom-style.html editing/pasteboard/copy-element-with-conflicting-background-color-from-rule.html 570379 1 130047 mrobinson 2012-03-04 20:12:08 -0800 Created attachment 130047 Patch 570458 2 mrobinson 2012-03-05 00:29:07 -0800 Committed r109719: <http://trac.webkit.org/changeset/109719> 130047 2012-03-04 20:12:08 -0800 2012-03-05 09:50:31 -0800 Patch bug-79084-20120304201208.patch text/plain 5426 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5NjUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0 ay9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggNmZhOWE5YjQ2 YWMyYzZhNWFmNGI5MjhhOWQzNGYyM2YzMWRlYzFlMC4uZTVkNDlkMDExYzBmNzVhODgwMDlhMmRl MzE5YzQ2Njk3MTRmM2Y2YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEy LTAzLTA0ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KKworICAgICAg ICBbR1RLXSBSRUdSRVNTSU9OOiByMTA4Mjc4IGJyb2tlIHNvbWUgdGVzdHMgdGhhdCBleHBlY3Qg Zm9jdXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc5 MDg0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgR3Jh YiBmb2N1cyBiZWZvcmUgcnVubmluZyB0aGUgdGVzdC4gVGhpcyBlbnN1cmVzIHRoYXQgaWYgdGhl CisgICAgICAgIFdlYlZpZXcgbG9zdCBmb2N1cywgaXQgaGFzIGl0IGJlZm9yZSBzZW5kaW5nIGV2 ZW50cy4KKworICAgICAgICAqIHRlc3RzL3Rlc3Rjb3B5YW5kcGFzdGUuYzoKKyAgICAgICAgKHRl c3RfY29weV9hbmRfcGFzdGUpOiBHcmFiIGZvY3VzLgorCiAyMDEyLTAyLTE4ICBNYXJ0aW4gUm9i aW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBbQUNdIEdlbmVy YWxpemUgV2luZG93Q29udGV4dEdMCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0ay90ZXN0 cy90ZXN0Y29weWFuZHBhc3RlLmMgYi9Tb3VyY2UvV2ViS2l0L2d0ay90ZXN0cy90ZXN0Y29weWFu ZHBhc3RlLmMKaW5kZXggN2Q4ZGQ4ZjBkZWViYmIxMGM5MWYyZGNmMDM5ZTVkMmU3ZWE1ZWJkZi4u YzU1MmJlNjM2NzA5OWFiNWIwMmRmZDUxYTAzYWNmNDUwZjMzYzNkOCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9ndGsvdGVzdHMvdGVzdGNvcHlhbmRwYXN0ZS5jCisrKyBiL1NvdXJjZS9XZWJL aXQvZ3RrL3Rlc3RzL3Rlc3Rjb3B5YW5kcGFzdGUuYwpAQCAtMTI2LDYgKzEyNiw3IEBAIHN0YXRp YyB2b2lkIHRlc3RfY29weV9hbmRfcGFzdGUoQ29weUFuZFBhc3RlRml4dHVyZSogZml4dHVyZSwg Z2NvbnN0cG9pbnRlciBkYXRhCiAgICAgZ3RrX3dpZGdldF9zaG93KGZpeHR1cmUtPndpbmRvdyk7 CiAgICAgZ3RrX3dpZGdldF9zaG93KEdUS19XSURHRVQoZml4dHVyZS0+d2ViVmlldykpOwogICAg IGd0a193aW5kb3dfcHJlc2VudChHVEtfV0lORE9XKGZpeHR1cmUtPndpbmRvdykpOworICAgIGd0 a193aWRnZXRfZ3JhYl9mb2N1cyhmaXh0dXJlLT53ZWJWaWV3KTsKIAogICAgIGdfc2lnbmFsX2Nv bm5lY3QoZml4dHVyZS0+d2ViVmlldywgIm5vdGlmeTo6bG9hZC1zdGF0dXMiLAogICAgICAgICAg ICAgICAgICAgICAgR19DQUxMQkFDSyhsb2FkX3N0YXR1c19jYiksIGZpeHR1cmUpOwpkaWZmIC0t Z2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDY2NjNiOTQwYmMw MjZmNTYyYTFhYjRlMzFmNjNmMzU3YTFlNTAxMGEuLjg2MjllNmRkMzE0MzE3OTZkMDA1OTNmYTIx ZTM1YmQ3MjkyMGVkOGEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMi0wMy0wNCAgTWFydGluIFJvYmluc29uICA8 bXJvYmluc29uQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gUkVHUkVTU0lPTjogcjEwODI3 OCBicm9rZSBzb21lIHRlc3RzIHRoYXQgZXhwZWN0IGZvY3VzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03OTA4NAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEdyYWIgZm9jdXMgd2hlbiBkdW1waW5nIHRlc3Qg cmVzdWx0cyBhbmQgYWxzbyB3aGVuIHNlbmRpbmcKKyAgICAgICAgZXZlbnRzLiBEdXJpbmcgdGhl IGNvdXJzZSBvZiB0ZXN0aW5nLCB0aGUgV2ViVmlldyBtYXkgbG9zZQorICAgICAgICBmb2N1cyBh bmQgdGhpcyBzZWVtcyB0byBzbmFwIGl0IGJhY2sgd2hlbiB0ZXN0cyBkZW1hbmQgaXQuCisKKyAg ICAgICAgKiBEdW1wUmVuZGVyVHJlZS9ndGsvRHVtcFJlbmRlclRyZWUuY3BwOgorICAgICAgICAo ZHVtcCk6IEdyYWIgZm9jdXMuCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvZ3RrL0V2ZW50U2Vu ZGVyLmNwcDoKKyAgICAgICAgKGRpc3BhdGNoRXZlbnQpOiBEaXR0by4KKwogMjAxMi0wMy0wMiAg QWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggY29tbWl0 IHF1ZXVlLCByZW1vdmUgZHVwbGljYXRlIGVudHJ5LgpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJl bmRlclRyZWUvZ3RrL0R1bXBSZW5kZXJUcmVlLmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2d0 ay9EdW1wUmVuZGVyVHJlZS5jcHAKaW5kZXggOTc4Zjg2OWExMWIwODA0ZDE1MGI1MDRkNGZiODlj ZTY1OTdkN2NhOC4uMzhmZmY0NjhhMjMwMTQ4ZWNjYzBiNjViNGRkYzg5YzJmZjEzN2U3MiAxMDA2 NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0R1bXBSZW5kZXJUcmVlLmNwcAorKysg Yi9Ub29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRHVtcFJlbmRlclRyZWUuY3BwCkBAIC01MTgsNiAr NTE4LDEwIEBAIHZvaWQgZHVtcCgpCiB7CiAgICAgaW52YWxpZGF0ZUFueVByZXZpb3VzV2FpdFRv RHVtcFdhdGNoZG9nKCk7CiAKKyAgICAvLyBHcmFiIHdpZGdldCBmb2N1cyBiZWZvcmUgZHVtcGlu ZyB0aGUgY29udGVudHMgb2YgYSB3aWRnZXQsIGluCisgICAgLy8gY2FzZSBpdCB3YXMgbG9zdCBp biB0aGUgY291cnNlIG9mIHRoZSB0ZXN0LgorICAgIGd0a193aWRnZXRfZ3JhYl9mb2N1cyhHVEtf V0lER0VUKHdlYlZpZXcpKTsKKwogICAgIGlmIChkdW1wVHJlZSkgewogICAgICAgICBjaGFyKiBy ZXN1bHQgPSAwOwogICAgICAgICBnY2hhciogcmVzcG9uc2VNaW1lVHlwZSA9IHdlYmtpdF93ZWJf ZnJhbWVfZ2V0X3Jlc3BvbnNlX21pbWVfdHlwZShtYWluRnJhbWUpOwpkaWZmIC0tZ2l0IGEvVG9v bHMvRHVtcFJlbmRlclRyZWUvZ3RrL0V2ZW50U2VuZGVyLmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJU cmVlL2d0ay9FdmVudFNlbmRlci5jcHAKaW5kZXggMzk3YjZjNmRjNjYzODllMWE2M2MzZjM3MDFj M2RlNjBlYzBmMmI0Mi4uZDM5NmM1MmEzMTIwYjIyNzIwNmQ5YjAzMTQxMjgzODZmY2VjN2M1NiAx MDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0V2ZW50U2VuZGVyLmNwcAorKysg Yi9Ub29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRXZlbnRTZW5kZXIuY3BwCkBAIC01NjMsNiArNTYz LDkgQEAgc3RhdGljIHZvaWQgZGlzcGF0Y2hFdmVudChHZGtFdmVudCogZXZlbnQpCiAgICAgICAg IHJldHVybjsKICAgICB9CiAKKyAgICAvLyBUaGUgd2lkZ2V0IGZvY3VzIG1heSBoYXZlIGJlZW4g bG9zdCBpbiB0aGUgY291cnNlIG9mIHRoZSB0ZXN0LAorICAgIC8vIHNvIGZvcmNlIGFub3RoZXIg ZXhwbGljaXQgZm9jdXMgZ3JhYiBoZXJlLgorICAgIGd0a193aWRnZXRfZ3JhYl9mb2N1cyhHVEtf V0lER0VUKHZpZXcpKTsKICAgICBndGtfbWFpbl9kb19ldmVudChldmVudCk7CiAKICAgICBpZiAo IWN1cnJlbnREcmFnU291cmNlQ29udGV4dCkgewpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGViNjcyMmE3Nzg5NzQwMmI0NmNl YzFhMzJlNzVlODA5YWJlNWFlNjcuLmU1NGQwYzg1Yzk4ODdjMGZiNjE3MWMxMjRlMjNlMjc1ZTE1 OWMxOGQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMi0wMy0wNCAgTWFydGluIFJvYmluc29u ICA8bXJvYmluc29uQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gUkVHUkVTU0lPTjogcjEw ODI3OCBicm9rZSBzb21lIHRlc3RzIHRoYXQgZXhwZWN0IGZvY3VzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03OTA4NAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1NraXBwZWQ6IFVu c2tpcCBwYXNzaW5nIHRlc3RzLgorCiAyMDEyLTAzLTAyICBOb2VsIEdvcmRvbiAgPG5vZWwuZ29y ZG9uQGdtYWlsLmNvbT4KIAogICAgICAgICA6ZW1wdHkgc2hvdWxkIGFwcGx5IHRvIGVsZW1lbnRz IG1hZGUgZW1wdHkgdmlhIHBhZ2UgZHluYW1pY3MKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3Bs YXRmb3JtL2d0ay9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQKaW5k ZXggMzA0ZjQ4ZWU2NmNkMmIzMGJjZDg5MmIyYWRlZGFkMmM4NDc5ZTNmYi4uNmUxMGE4ZjYzNjg1 OTkyYWM1ZDI1OTcyNzA4YWNmZDY3YjM4ZDc2YyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxh dGZvcm0vZ3RrL1NraXBwZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQK QEAgLTE1ODEsMTggKzE1ODEsNiBAQCBmYXN0L3dvcmtlcnMvc2hhcmVkLXdvcmtlci1sb2FkLWVy cm9yLmh0bWwKIHRhYmxlcy9tb3ppbGxhL2J1Z3MvYnVnMjcwMzgtMS5odG1sCiB0YWJsZXMvbW96 aWxsYS9idWdzL2J1ZzI3MDM4LTIuaHRtbAogCi0jIFJlbW92aW5nIGFuIGV4cGxpY2l0IGdyYWIg Zm9jdXMgb24gV2ViQ29yZSBicm9rZSBzb21lIHRlc3RzCi0jIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD03OTA4NAotZmFzdC9pbWFnZXMvaW1hZ2VtYXAtZm9jdXMtcmlu Zy16b29tLXN0eWxlLmh0bWwKLWZhc3QvZm9ybXMvbnVtYmVyL2lucHV0LW51bWJlci1ldmVudHMu aHRtbAotZmFzdC9ldmVudHMvdGFiaW5kZXgtZm9jdXMtY2hhaW4uaHRtbAotZmFzdC9ldmVudHMv dGFiLWZvY3VzLWhpZGRlbi5odG1sCi1mYXN0L2V2ZW50cy90YWItZm9jdXMtYW5jaG9yLmh0bWwK LWZhc3QvZXZlbnRzL21lZGlhLWVsZW1lbnQtZm9jdXMtdGFiLmh0bWwKLWZhc3QvZXZlbnRzL2tl eXByZXNzLWluc2VydC10YWIuaHRtbAotZmFzdC9pbWFnZXMvaW1hZ2VtYXAtZm9jdXMtcmluZy16 b29tLXN0eWxlLmh0bWwKLWVkaXRpbmcvcGFzdGVib2FyZC9jb3B5LWVsZW1lbnQtd2l0aC1jb25m bGljdGluZy1iYWNrZ3JvdW5kLWNvbG9yLWZyb20tcnVsZS5odG1sCi0KICMgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc5MjAzCiBmYXN0L2RvbS9NZWRpYVN0cmVhbS9h cmd1bWVudC10eXBlcy5odG1sCiBmYXN0L21lZGlhc3RyZWFtL3BlZXJjb25uZWN0aW9uLUF0dHJp YnV0ZXMuaHRtbAo=