<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>79083</bug_id>
          
          <creation_ts>2012-02-21 00:04:36 -0800</creation_ts>
          <short_desc>Unnecessary preprocessor macro in MainThread.h/cpp</short_desc>
          <delta_ts>2012-02-21 10:28:09 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Roland Takacs">rtakacs</reporter>
          <assigned_to name="Roland Takacs">rtakacs</assigned_to>
          <cc>loki</cc>
    
    <cc>ossy</cc>
    
    <cc>paroga</cc>
    
    <cc>zherczeg</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>560707</commentid>
    <comment_count>0</comment_count>
    <who name="Roland Takacs">rtakacs</who>
    <bug_when>2012-02-21 00:04:36 -0800</bug_when>
    <thetext>Patrick R. Gansterer mentioned at https://bugs.webkit.org/show_bug.cgi?id=73309 that I wrote &quot;#if PLATFORM(WINDOWS)&quot; insted of &quot;#if PLATFORM(WIN)&quot;.

I fixed this bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>560709</commentid>
    <comment_count>1</comment_count>
      <attachid>127928</attachid>
    <who name="Roland Takacs">rtakacs</who>
    <bug_when>2012-02-21 00:08:33 -0800</bug_when>
    <thetext>Created attachment 127928
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>560717</commentid>
    <comment_count>2</comment_count>
      <attachid>127928</attachid>
    <who name="Patrick R. Gansterer">paroga</who>
    <bug_when>2012-02-21 00:28:17 -0800</bug_when>
    <thetext>Comment on attachment 127928
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127928&amp;action=review

&gt; Source/JavaScriptCore/wtf/MainThread.cpp:284
&gt; +#elif PLATFORM(MAC) || PLATFORM(WIN)

IMHO you need an additional line in the exports file too now, when you do not inline the code. But maybe you that, only let the EWS generate the mangeled name... :-)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>560757</commentid>
    <comment_count>3</comment_count>
      <attachid>127942</attachid>
    <who name="Roland Takacs">rtakacs</who>
    <bug_when>2012-02-21 01:54:18 -0800</bug_when>
    <thetext>Created attachment 127942
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>560762</commentid>
    <comment_count>4</comment_count>
    <who name="Roland Takacs">rtakacs</who>
    <bug_when>2012-02-21 02:19:01 -0800</bug_when>
    <thetext>Thanks to show me what cause the error ;)

(In reply to comment #2)
&gt; (From update of attachment 127928 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=127928&amp;action=review
&gt; 
&gt; &gt; Source/JavaScriptCore/wtf/MainThread.cpp:284
&gt; &gt; +#elif PLATFORM(MAC) || PLATFORM(WIN)
&gt; 
&gt; IMHO you need an additional line in the exports file too now, when you do not inline the code. But maybe you that, only let the EWS generate the mangeled name... :-)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>560797</commentid>
    <comment_count>5</comment_count>
      <attachid>127942</attachid>
    <who name="Patrick R. Gansterer">paroga</who>
    <bug_when>2012-02-21 03:50:54 -0800</bug_when>
    <thetext>Comment on attachment 127942
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127942&amp;action=review

&gt; Source/JavaScriptCore/ChangeLog:8
&gt; +        There is &quot;PLATFORM(WINDOWS)&quot; insted of &quot;PLATFORM(WIN)&quot;.

not the other direction?!?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>560826</commentid>
    <comment_count>6</comment_count>
      <attachid>127958</attachid>
    <who name="Roland Takacs">rtakacs</who>
    <bug_when>2012-02-21 05:47:25 -0800</bug_when>
    <thetext>Created attachment 127958
patch

Sorry, You are right, I meant the other direction.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>560849</commentid>
    <comment_count>7</comment_count>
      <attachid>127958</attachid>
    <who name="Patrick R. Gansterer">paroga</who>
    <bug_when>2012-02-21 07:01:58 -0800</bug_when>
    <thetext>Comment on attachment 127958
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127958&amp;action=review

sorry for not asking earlier, but why can&apos;t we simple remove the PLATFORM(WINDOWS)? IMHO nobody needs it.

&gt; Source/JavaScriptCore/ChangeLog:3
&gt; +        [Qt] Parallel GC bugfix

how is _this_ patch related to Qt? which bug does it fix?

&gt; Source/JavaScriptCore/ChangeLog:10
&gt; +        Futhermore the decoration name of isMainThreadOrGCThread
&gt; +        was inserted to the JavaScriptCore.def.

Please explain why.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>560986</commentid>
    <comment_count>8</comment_count>
    <who name="Roland Takacs">rtakacs</who>
    <bug_when>2012-02-21 10:11:05 -0800</bug_when>
    <thetext>(In reply to comment #7)
&gt; (From update of attachment 127958 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=127958&amp;action=review
&gt; 
&gt; sorry for not asking earlier, but why can&apos;t we simple remove the PLATFORM(WINDOWS)? IMHO nobody needs it.

You are right, it is really not necessary to check it.

&gt; 
&gt; &gt; Source/JavaScriptCore/ChangeLog:3
&gt; &gt; +        [Qt] Parallel GC bugfix
&gt; 
&gt; how is _this_ patch related to Qt? which bug does it fix?
&gt;

The name was really wrong. I renamed it.
 
&gt; &gt; Source/JavaScriptCore/ChangeLog:10
&gt; &gt; +        Futhermore the decoration name of isMainThreadOrGCThread
&gt; &gt; +        was inserted to the JavaScriptCore.def.
&gt; 
&gt; Please explain why.

When I changed &apos;WINDOWS&apos; to &apos;WIN&apos; and I uploaded the patch, it failed. Secondly, I added the isMainThreadOrGCThreads mangled name to the JavaScriptCore.def, and it works.

I will upload the patch soon without &quot;PLATFORM(WINDOWS)&quot; preprocessor macros.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>560988</commentid>
    <comment_count>9</comment_count>
      <attachid>127992</attachid>
    <who name="Roland Takacs">rtakacs</who>
    <bug_when>2012-02-21 10:14:42 -0800</bug_when>
    <thetext>Created attachment 127992
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>560997</commentid>
    <comment_count>10</comment_count>
    <who name="Patrick R. Gansterer">paroga</who>
    <bug_when>2012-02-21 10:24:20 -0800</bug_when>
    <thetext>Committed r108369: &lt;http://trac.webkit.org/changeset/108369&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>561000</commentid>
    <comment_count>11</comment_count>
      <attachid>127992</attachid>
    <who name="Patrick R. Gansterer">paroga</who>
    <bug_when>2012-02-21 10:28:09 -0800</bug_when>
    <thetext>Comment on attachment 127992
patch

THX for the patch.

(In reply to comment #8)
&gt; &gt; &gt; Source/JavaScriptCore/ChangeLog:10
&gt; &gt; &gt; +        Futhermore the decoration name of isMainThreadOrGCThread
&gt; &gt; &gt; +        was inserted to the JavaScriptCore.def.
&gt; &gt; 
&gt; &gt; Please explain why.
&gt; 
&gt; When I changed &apos;WINDOWS&apos; to &apos;WIN&apos; and I uploaded the patch, it failed. Secondly, I added the isMainThreadOrGCThreads mangled name to the JavaScriptCore.def, and it works.

The ChangeLog should usually explain the what and why. When browsing the history you usually don&apos;t look into the bug, so any relevant information should go into ChangeLog. :-)</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>127928</attachid>
            <date>2012-02-21 00:08:33 -0800</date>
            <delta_ts>2012-02-21 01:54:18 -0800</delta_ts>
            <desc>patch</desc>
            <filename>BUGFIX.diff</filename>
            <type>text/plain</type>
            <size>1748</size>
            <attacher name="Roland Takacs">rtakacs</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2
YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGI2NDBhODcuLmQ0MWMwZTYgMTAwNjQ0Ci0tLSBh
L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD
b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTAyLTIxICBSb2xhbmQgVGFrYWNz
ICA8dGFrYWNzLnJvbGFuZEBzdHVkLnUtc3plZ2VkLmh1PgorCisgICAgICAgIFtRdF0gUGFyYWxs
ZWwgR0MgYnVnZml4CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn
aT9pZD03OTA4MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg
ICAgIFRoZXJlIGlzICJQTEFURk9STShXSU5ET1dTKSIgaW5zdGVkIG9mICJQTEFURk9STShXSU4p
Ii4KKyAgICAgICAgVGhpcyBwYXRjaCBmaXggdGhpcyBwcm9ibGVtLgorCisgICAgICAgICogd3Rm
L01haW5UaHJlYWQuY3BwOgorICAgICAgICAoV1RGKToKKyAgICAgICAgKiB3dGYvTWFpblRocmVh
ZC5oOgorICAgICAgICAoV1RGKToKKwogMjAxMi0wMi0yMCAgRmlsaXAgUGl6bG8gIDxmcGl6bG9A
YXBwbGUuY29tPgogCiAgICAgICAgIEpTQyBzaG91bGQgYmUgYSB0cmlwbGUtdGllciBWTQpkaWZm
IC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9NYWluVGhyZWFkLmNwcCBiL1NvdXJj
ZS9KYXZhU2NyaXB0Q29yZS93dGYvTWFpblRocmVhZC5jcHAKaW5kZXggNGFjOWYxOC4uMGQ5YTM4
OSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9NYWluVGhyZWFkLmNwcAor
KysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL01haW5UaHJlYWQuY3BwCkBAIC0yODEsNyAr
MjgxLDcgQEAgYm9vbCBpc01haW5UaHJlYWRPckdDVGhyZWFkKCkKIAogICAgIHJldHVybiBpc01h
aW5UaHJlYWQoKTsKIH0KLSNlbGlmIFBMQVRGT1JNKE1BQykgfHwgUExBVEZPUk0oV0lORE9XUykK
KyNlbGlmIFBMQVRGT1JNKE1BQykgfHwgUExBVEZPUk0oV0lOKQogLy8gVGhpcyBpcyBuZWNlc3Nh
cnkgYmVjYXVzZSBKYXZhU2NyaXB0Q29yZS5leHAgZG9lc24ndCBzdXBwb3J0IHByZXByb2Nlc3Nv
ciBtYWNyb3MuCiBib29sIGlzTWFpblRocmVhZE9yR0NUaHJlYWQoKQogewpkaWZmIC0tZ2l0IGEv
U291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9NYWluVGhyZWFkLmggYi9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvd3RmL01haW5UaHJlYWQuaAppbmRleCAyYzZlOWJjLi4yYzljNmViIDEwMDY0NAotLS0g
YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL01haW5UaHJlYWQuaAorKysgYi9Tb3VyY2UvSmF2
YVNjcmlwdENvcmUvd3RmL01haW5UaHJlYWQuaApAQCAtNTgsNyArNTgsNyBAQCB2b2lkIGluaXRp
YWxpemVHQ1RocmVhZHMoKTsKICNpZiBFTkFCTEUoUEFSQUxMRUxfR0MpCiB2b2lkIHJlZ2lzdGVy
R0NUaHJlYWQoKTsKIFdURl9FWFBPUlRfUFJJVkFURSBib29sIGlzTWFpblRocmVhZE9yR0NUaHJl
YWQoKTsKLSNlbGlmIFBMQVRGT1JNKE1BQykgfHwgUExBVEZPUk0oV0lORE9XUykKKyNlbGlmIFBM
QVRGT1JNKE1BQykgfHwgUExBVEZPUk0oV0lOKQogV1RGX0VYUE9SVF9QUklWQVRFIGJvb2wgaXNN
YWluVGhyZWFkT3JHQ1RocmVhZCgpOwogI2Vsc2UKIGlubGluZSBib29sIGlzTWFpblRocmVhZE9y
R0NUaHJlYWQoKSB7IHJldHVybiBpc01haW5UaHJlYWQoKTsgfQo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>127942</attachid>
            <date>2012-02-21 01:54:18 -0800</date>
            <delta_ts>2012-02-21 05:47:25 -0800</delta_ts>
            <desc>patch</desc>
            <filename>BUGFIX_1.diff</filename>
            <type>text/plain</type>
            <size>2684</size>
            <attacher name="Roland Takacs">rtakacs</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2
YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGI2NDBhODcuLmQwZWU1Y2UgMTAwNjQ0Ci0tLSBh
L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD
b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTAyLTIxICBSb2xhbmQgVGFrYWNz
ICA8dGFrYWNzLnJvbGFuZEBzdHVkLnUtc3plZ2VkLmh1PgorCisgICAgICAgIFtRdF0gUGFyYWxs
ZWwgR0MgYnVnZml4CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn
aT9pZD03OTA4MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg
ICAgIFRoZXJlIGlzICJQTEFURk9STShXSU5ET1dTKSIgaW5zdGVkIG9mICJQTEFURk9STShXSU4p
Ii4KKyAgICAgICAgRnV0aGVybW9yZSB0aGUgZGVjb3JhdGlvbiBuYW1lIG9mIGlzTWFpblRocmVh
ZE9yR0NUaHJlYWQKKyAgICAgICAgd2FzIGluc2VydGVkIHRvIHRoZSBKYXZhU2NyaXB0Q29yZS5k
ZWYuCisKKyAgICAgICAgKiBKYXZhU2NyaXB0Q29yZS52Y3Byb2ovSmF2YVNjcmlwdENvcmUvSmF2
YVNjcmlwdENvcmUuZGVmOgorICAgICAgICAqIHd0Zi9NYWluVGhyZWFkLmNwcDoKKyAgICAgICAg
KFdURik6CisgICAgICAgICogd3RmL01haW5UaHJlYWQuaDoKKyAgICAgICAgKFdURik6CisKIDIw
MTItMDItMjAgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBKU0Mg
c2hvdWxkIGJlIGEgdHJpcGxlLXRpZXIgVk0KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0
Q29yZS9KYXZhU2NyaXB0Q29yZS52Y3Byb2ovSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUu
ZGVmIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnZjcHJvai9KYXZhU2Ny
aXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5kZWYKaW5kZXggYWNkZjQ3Yi4uMmM1ODE0YiAxMDA2NDQK
LS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnZjcHJvai9KYXZhU2Ny
aXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5kZWYKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0ph
dmFTY3JpcHRDb3JlLnZjcHJvai9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5kZWYKQEAg
LTIzNiw2ICsyMzYsNyBAQCBFWFBPUlRTCiAgICAgP2lzRGF0YURlc2NyaXB0b3JAUHJvcGVydHlE
ZXNjcmlwdG9yQEpTQ0BAUUJFX05YWgogICAgID9pc0hvc3RGdW5jdGlvbk5vbklubGluZUBKU0Z1
bmN0aW9uQEpTQ0BAQUJFX05YWgogICAgID9pc01haW5UaHJlYWRAV1RGQEBZQV9OWFoKKyAgICA/
aXNNYWluVGhyZWFkT3JHQ1RocmVhZEBXVEZAQFlBX05YWgogICAgID9pc1JlYWNoYWJsZUZyb21P
cGFxdWVSb290c0BXZWFrSGFuZGxlT3duZXJASlNDQEBVQUVfTlY/JEhhbmRsZUBXNFVua25vd25A
SlNDQEBAMkBQQVhBQVZTbG90VmlzaXRvckAyQEBaCiAgICAgP2lzVGVybWluYXRlZEV4ZWN1dGlv
bkV4Y2VwdGlvbkBKU0NAQFlBX05WSlNWYWx1ZUAxQEBaCiAgICAgP2lzVmFsaWRBbGxvY2F0aW9u
QEhlYXBASlNDQEBBQUVfTklAWgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0
Zi9NYWluVGhyZWFkLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvTWFpblRocmVhZC5j
cHAKaW5kZXggNGFjOWYxOC4uMGQ5YTM4OSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRD
b3JlL3d0Zi9NYWluVGhyZWFkLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL01h
aW5UaHJlYWQuY3BwCkBAIC0yODEsNyArMjgxLDcgQEAgYm9vbCBpc01haW5UaHJlYWRPckdDVGhy
ZWFkKCkKIAogICAgIHJldHVybiBpc01haW5UaHJlYWQoKTsKIH0KLSNlbGlmIFBMQVRGT1JNKE1B
QykgfHwgUExBVEZPUk0oV0lORE9XUykKKyNlbGlmIFBMQVRGT1JNKE1BQykgfHwgUExBVEZPUk0o
V0lOKQogLy8gVGhpcyBpcyBuZWNlc3NhcnkgYmVjYXVzZSBKYXZhU2NyaXB0Q29yZS5leHAgZG9l
c24ndCBzdXBwb3J0IHByZXByb2Nlc3NvciBtYWNyb3MuCiBib29sIGlzTWFpblRocmVhZE9yR0NU
aHJlYWQoKQogewpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9NYWluVGhy
ZWFkLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL01haW5UaHJlYWQuaAppbmRleCAyYzZl
OWJjLi4yYzljNmViIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL01haW5U
aHJlYWQuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL01haW5UaHJlYWQuaApAQCAt
NTgsNyArNTgsNyBAQCB2b2lkIGluaXRpYWxpemVHQ1RocmVhZHMoKTsKICNpZiBFTkFCTEUoUEFS
QUxMRUxfR0MpCiB2b2lkIHJlZ2lzdGVyR0NUaHJlYWQoKTsKIFdURl9FWFBPUlRfUFJJVkFURSBi
b29sIGlzTWFpblRocmVhZE9yR0NUaHJlYWQoKTsKLSNlbGlmIFBMQVRGT1JNKE1BQykgfHwgUExB
VEZPUk0oV0lORE9XUykKKyNlbGlmIFBMQVRGT1JNKE1BQykgfHwgUExBVEZPUk0oV0lOKQogV1RG
X0VYUE9SVF9QUklWQVRFIGJvb2wgaXNNYWluVGhyZWFkT3JHQ1RocmVhZCgpOwogI2Vsc2UKIGlu
bGluZSBib29sIGlzTWFpblRocmVhZE9yR0NUaHJlYWQoKSB7IHJldHVybiBpc01haW5UaHJlYWQo
KTsgfQo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>127958</attachid>
            <date>2012-02-21 05:47:25 -0800</date>
            <delta_ts>2012-02-21 10:14:42 -0800</delta_ts>
            <desc>patch</desc>
            <filename>BUGFIX_1.diff</filename>
            <type>text/plain</type>
            <size>2679</size>
            <attacher name="Roland Takacs">rtakacs</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2
YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGI2NDBhODcuLmQwZWU1Y2UgMTAwNjQ0Ci0tLSBh
L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD
b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTAyLTIxICBSb2xhbmQgVGFrYWNz
ICA8dGFrYWNzLnJvbGFuZEBzdHVkLnUtc3plZ2VkLmh1PgorCisgICAgICAgIFtRdF0gUGFyYWxs
ZWwgR0MgYnVnZml4CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn
aT9pZD03OTA4MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg
ICAgIEkgcmVwbGFjZWQgIlBMQVRGT1JNKFdJTkRPV1MpIiB0byAiUExBVEZPUk0oV0lOKSIuCisg
ICAgICAgIEZ1dGhlcm1vcmUgdGhlIGRlY29yYXRpb24gbmFtZSBvZiBpc01haW5UaHJlYWRPckdD
VGhyZWFkCisgICAgICAgIHdhcyBpbnNlcnRlZCB0byB0aGUgSmF2YVNjcmlwdENvcmUuZGVmLgor
CisgICAgICAgICogSmF2YVNjcmlwdENvcmUudmNwcm9qL0phdmFTY3JpcHRDb3JlL0phdmFTY3Jp
cHRDb3JlLmRlZjoKKyAgICAgICAgKiB3dGYvTWFpblRocmVhZC5jcHA6CisgICAgICAgIChXVEYp
OgorICAgICAgICAqIHd0Zi9NYWluVGhyZWFkLmg6CisgICAgICAgIChXVEYpOgorCiAyMDEyLTAy
LTIwICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgSlNDIHNob3Vs
ZCBiZSBhIHRyaXBsZS10aWVyIFZNCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv
SmF2YVNjcmlwdENvcmUudmNwcm9qL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLmRlZiBi
L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS52Y3Byb2ovSmF2YVNjcmlwdENv
cmUvSmF2YVNjcmlwdENvcmUuZGVmCmluZGV4IGFjZGY0N2IuLjJjNTgxNGIgMTAwNjQ0Ci0tLSBh
L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS52Y3Byb2ovSmF2YVNjcmlwdENv
cmUvSmF2YVNjcmlwdENvcmUuZGVmCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2Ny
aXB0Q29yZS52Y3Byb2ovSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUuZGVmCkBAIC0yMzYs
NiArMjM2LDcgQEAgRVhQT1JUUwogICAgID9pc0RhdGFEZXNjcmlwdG9yQFByb3BlcnR5RGVzY3Jp
cHRvckBKU0NAQFFCRV9OWFoKICAgICA/aXNIb3N0RnVuY3Rpb25Ob25JbmxpbmVASlNGdW5jdGlv
bkBKU0NAQEFCRV9OWFoKICAgICA/aXNNYWluVGhyZWFkQFdURkBAWUFfTlhaCisgICAgP2lzTWFp
blRocmVhZE9yR0NUaHJlYWRAV1RGQEBZQV9OWFoKICAgICA/aXNSZWFjaGFibGVGcm9tT3BhcXVl
Um9vdHNAV2Vha0hhbmRsZU93bmVyQEpTQ0BAVUFFX05WPyRIYW5kbGVAVzRVbmtub3duQEpTQ0BA
QDJAUEFYQUFWU2xvdFZpc2l0b3JAMkBAWgogICAgID9pc1Rlcm1pbmF0ZWRFeGVjdXRpb25FeGNl
cHRpb25ASlNDQEBZQV9OVkpTVmFsdWVAMUBAWgogICAgID9pc1ZhbGlkQWxsb2NhdGlvbkBIZWFw
QEpTQ0BAQUFFX05JQFoKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvTWFp
blRocmVhZC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL01haW5UaHJlYWQuY3BwCmlu
ZGV4IDRhYzlmMTguLjBkOWEzODkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93
dGYvTWFpblRocmVhZC5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9NYWluVGhy
ZWFkLmNwcApAQCAtMjgxLDcgKzI4MSw3IEBAIGJvb2wgaXNNYWluVGhyZWFkT3JHQ1RocmVhZCgp
CiAKICAgICByZXR1cm4gaXNNYWluVGhyZWFkKCk7CiB9Ci0jZWxpZiBQTEFURk9STShNQUMpIHx8
IFBMQVRGT1JNKFdJTkRPV1MpCisjZWxpZiBQTEFURk9STShNQUMpIHx8IFBMQVRGT1JNKFdJTikK
IC8vIFRoaXMgaXMgbmVjZXNzYXJ5IGJlY2F1c2UgSmF2YVNjcmlwdENvcmUuZXhwIGRvZXNuJ3Qg
c3VwcG9ydCBwcmVwcm9jZXNzb3IgbWFjcm9zLgogYm9vbCBpc01haW5UaHJlYWRPckdDVGhyZWFk
KCkKIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvTWFpblRocmVhZC5o
IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9NYWluVGhyZWFkLmgKaW5kZXggMmM2ZTliYy4u
MmM5YzZlYiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9NYWluVGhyZWFk
LmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9NYWluVGhyZWFkLmgKQEAgLTU4LDcg
KzU4LDcgQEAgdm9pZCBpbml0aWFsaXplR0NUaHJlYWRzKCk7CiAjaWYgRU5BQkxFKFBBUkFMTEVM
X0dDKQogdm9pZCByZWdpc3RlckdDVGhyZWFkKCk7CiBXVEZfRVhQT1JUX1BSSVZBVEUgYm9vbCBp
c01haW5UaHJlYWRPckdDVGhyZWFkKCk7Ci0jZWxpZiBQTEFURk9STShNQUMpIHx8IFBMQVRGT1JN
KFdJTkRPV1MpCisjZWxpZiBQTEFURk9STShNQUMpIHx8IFBMQVRGT1JNKFdJTikKIFdURl9FWFBP
UlRfUFJJVkFURSBib29sIGlzTWFpblRocmVhZE9yR0NUaHJlYWQoKTsKICNlbHNlCiBpbmxpbmUg
Ym9vbCBpc01haW5UaHJlYWRPckdDVGhyZWFkKCkgeyByZXR1cm4gaXNNYWluVGhyZWFkKCk7IH0K
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>127992</attachid>
            <date>2012-02-21 10:14:42 -0800</date>
            <delta_ts>2012-02-21 10:28:09 -0800</delta_ts>
            <desc>patch</desc>
            <filename>BUGFIX_1.1.diff.txt</filename>
            <type>text/plain</type>
            <size>1735</size>
            <attacher name="Roland Takacs">rtakacs</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2
YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGI2NDBhODcuLmQ1YzMwZTYgMTAwNjQ0Ci0tLSBh
L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD
b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTAyLTIxICBSb2xhbmQgVGFrYWNz
ICA8dGFrYWNzLnJvbGFuZEBzdHVkLnUtc3plZ2VkLmh1PgorCisgICAgICAgIFVubmVjZXNzYXJ5
IHByZXByb2Nlc3NvciBtYWNyb3MgaW4gTWFpblRocmVhZC5oL2NwcAorICAgICAgICBodHRwczov
L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzkwODMKKworICAgICAgICBSZXZpZXdl
ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAiUExBVEZPUk0oV0lORE9XUykiIHByZXBy
b2Nlc3NvciBtYWNyb3MgYXJlIHJlbW92ZWQKKyAgICAgICAgYmVjYXVzZSBub3RoaW5nIHVzZSB0
aGVtLgorCisgICAgICAgICogd3RmL01haW5UaHJlYWQuY3BwOgorICAgICAgICAoV1RGKToKKyAg
ICAgICAgKiB3dGYvTWFpblRocmVhZC5oOgorICAgICAgICAoV1RGKToKKwogMjAxMi0wMi0yMCAg
RmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIEpTQyBzaG91bGQgYmUg
YSB0cmlwbGUtdGllciBWTQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9N
YWluVGhyZWFkLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvTWFpblRocmVhZC5jcHAK
aW5kZXggNGFjOWYxOC4uZjg2ODZhYSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3Jl
L3d0Zi9NYWluVGhyZWFkLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL01haW5U
aHJlYWQuY3BwCkBAIC0yODEsNyArMjgxLDcgQEAgYm9vbCBpc01haW5UaHJlYWRPckdDVGhyZWFk
KCkKIAogICAgIHJldHVybiBpc01haW5UaHJlYWQoKTsKIH0KLSNlbGlmIFBMQVRGT1JNKE1BQykg
fHwgUExBVEZPUk0oV0lORE9XUykKKyNlbGlmIFBMQVRGT1JNKE1BQykKIC8vIFRoaXMgaXMgbmVj
ZXNzYXJ5IGJlY2F1c2UgSmF2YVNjcmlwdENvcmUuZXhwIGRvZXNuJ3Qgc3VwcG9ydCBwcmVwcm9j
ZXNzb3IgbWFjcm9zLgogYm9vbCBpc01haW5UaHJlYWRPckdDVGhyZWFkKCkKIHsKZGlmZiAtLWdp
dCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvTWFpblRocmVhZC5oIGIvU291cmNlL0phdmFT
Y3JpcHRDb3JlL3d0Zi9NYWluVGhyZWFkLmgKaW5kZXggMmM2ZTliYy4uNDgzOWM4MSAxMDA2NDQK
LS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9NYWluVGhyZWFkLmgKKysrIGIvU291cmNl
L0phdmFTY3JpcHRDb3JlL3d0Zi9NYWluVGhyZWFkLmgKQEAgLTU4LDcgKzU4LDcgQEAgdm9pZCBp
bml0aWFsaXplR0NUaHJlYWRzKCk7CiAjaWYgRU5BQkxFKFBBUkFMTEVMX0dDKQogdm9pZCByZWdp
c3RlckdDVGhyZWFkKCk7CiBXVEZfRVhQT1JUX1BSSVZBVEUgYm9vbCBpc01haW5UaHJlYWRPckdD
VGhyZWFkKCk7Ci0jZWxpZiBQTEFURk9STShNQUMpIHx8IFBMQVRGT1JNKFdJTkRPV1MpCisjZWxp
ZiBQTEFURk9STShNQUMpCiBXVEZfRVhQT1JUX1BSSVZBVEUgYm9vbCBpc01haW5UaHJlYWRPckdD
VGhyZWFkKCk7CiAjZWxzZQogaW5saW5lIGJvb2wgaXNNYWluVGhyZWFkT3JHQ1RocmVhZCgpIHsg
cmV0dXJuIGlzTWFpblRocmVhZCgpOyB9Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>