79064 2012-02-20 18:22:22 -0800 Remove [TreatReturnedNullStringAsNull] from HTMLMediaElement.mediaGroup 2012-02-21 13:58:00 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 77393 1 haraken haraken abarth darin ian morrita webkit.review.bot oldest_to_newest 560516 0 haraken 2012-02-20 18:22:22 -0800 [TreatReturnedNullStringAsNull] is a typo of [TreatReturnedNullStringAs=Null]. But as far as I read the spec (http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html#attr-media-mediagroup), there is no statement about what value should be returned when HTMLMediaElement.mediaGroup is not yet initialized. In particular, there is no statement that says "null should be returned when HTMLMediaElement.mediaGroup is not initialized". Thus, I think that instead of fixing the typo, just removing [TreatReturnedNullStringAsNull] would make sense. Removing [TreatReturnedNullStringAsNull] does not change the current behavior. 560520 1 127889 haraken 2012-02-20 18:25:36 -0800 Created attachment 127889 Patch 560580 2 127889 abarth 2012-02-20 20:08:17 -0800 Comment on attachment 127889 Patch Can we add a test that verifies this behavior? 560595 3 127905 haraken 2012-02-20 20:30:33 -0800 Created attachment 127905 Patch 560597 4 haraken 2012-02-20 20:31:56 -0800 (In reply to comment #2) > (From update of attachment 127889 [details]) > Can we add a test that verifies this behavior? media/media-controller.html already has the test: testExpected("video.mediaGroup", ""); I added "Test: media/media-controller.html (No change in the test result)" to ChangeLog. 560641 5 127905 morrita 2012-02-20 21:37:39 -0800 Comment on attachment 127905 Patch I'd like to see green cr-linux. 560642 6 morrita 2012-02-20 21:38:16 -0800 Also, please take care of ChangeLog diff crash. 560667 7 127905 webkit.review.bot 2012-02-20 22:23:42 -0800 Comment on attachment 127905 Patch Clearing flags on attachment: 127905 Committed r108305: <http://trac.webkit.org/changeset/108305> 560668 8 webkit.review.bot 2012-02-20 22:23:47 -0800 All reviewed patches have been landed. Closing bug. 561128 9 ian 2012-02-21 12:21:18 -0800 The mediaGroup IDL attribute on media elements must reflect the mediagroup content attribute. It's always initialised. There's no concept of it not being initialised. 561196 10 haraken 2012-02-21 13:58:00 -0800 (In reply to comment #9) > The mediaGroup IDL attribute on media elements must reflect the mediagroup content attribute. It's always initialised. There's no concept of it not being initialised. Hixie: Thanks for the clarification! 127889 2012-02-20 18:25:36 -0800 2012-02-20 20:30:29 -0800 Patch bug-79064-20120221112534.patch text/plain 2124 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4Mjc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjU1ZmZhODE4MTMwM2Nk NzQxMTFmMGIxN2Y3MDg1OThlYzg5ZjY5NC4uOGI1YjcxYzZhZmQwOTFhNWYyYWQ1NjE3YmRlM2Rh ODIyYzg0MmM4MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI1IEBACiAyMDEyLTAyLTIwICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBSZW1vdmUgW1RyZWF0 UmV0dXJuZWROdWxsU3RyaW5nQXNOdWxsXSBmcm9tIEhUTUxNZWRpYUVsZW1lbnQubWVkaWFHcm91 cAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzkwNjQK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbVHJlYXRS ZXR1cm5lZE51bGxTdHJpbmdBc051bGxdIGlzIGEgdHlwbyBvZiBbVHJlYXRSZXR1cm5lZE51bGxT dHJpbmdBcz1OdWxsXS4KKyAgICAgICAgQnV0IGFzIGZhciBhcyBJIHJlYWQgdGhlIHNwZWMKKyAg ICAgICAgKGh0dHA6Ly93d3cud2hhdHdnLm9yZy9zcGVjcy93ZWItYXBwcy9jdXJyZW50LXdvcmsv bXVsdGlwYWdlL3RoZS12aWRlby1lbGVtZW50Lmh0bWwjYXR0ci1tZWRpYS1tZWRpYWdyb3VwKSwK KyAgICAgICAgdGhlcmUgaXMgbm8gc3RhdGVtZW50IGFib3V0IHdoYXQgdmFsdWUgc2hvdWxkIGJl IHJldHVybmVkIHdoZW4gSFRNTE1lZGlhRWxlbWVudC5tZWRpYUdyb3VwCisgICAgICAgIGlzIG5v dCB5ZXQgaW5pdGlhbGl6ZWQuIEluIHBhcnRpY3VsYXIsIHRoZXJlIGlzIG5vIHN0YXRlbWVudCB0 aGF0IHNheXMgIm51bGwgc2hvdWxkCisgICAgICAgIGJlIHJldHVybmVkIHdoZW4gSFRNTE1lZGlh RWxlbWVudC5tZWRpYUdyb3VwIGlzIG5vdCBpbml0aWFsaXplZCIuIFRodXMsIGluc3RlYWQgb2YK KyAgICAgICAgZml4aW5nIHRoZSB0eXBvLCBqdXN0IHJlbW92aW5nIFtUcmVhdFJldHVybmVkTnVs bFN0cmluZ0FzTnVsbF0gd291bGQgbWFrZSBzZW5zZS4KKyAgICAgICAgUmVtb3ZpbmcgW1RyZWF0 UmV0dXJuZWROdWxsU3RyaW5nQXNOdWxsXSBkb2VzIG5vdCBjaGFuZ2UgdGhlIGN1cnJlbnQgYmVo YXZpb3IuCisKKyAgICAgICAgTm8gdGVzdHMuIE5vIGNoYW5nZSBpbiBiZWhhdmlvci4KKworICAg ICAgICAqIGh0bWwvSFRNTE1lZGlhRWxlbWVudC5pZGw6CisKKzIwMTItMDItMjAgIEtlbnRhcm8g SGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3JnPgorCiAgICAgICAgIFVucmV2aWV3ZWQuIFJlYmFz ZWxpbmVkIHJ1bi1iaW5kaW5ncy10ZXN0cyByZXN1bHRzLgogCiAgICAgICAgICogYmluZGluZ3Mv c2NyaXB0cy90ZXN0L0NQUC9XZWJET01UZXN0SW50ZXJmYWNlLmNwcDoKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9o dG1sL0hUTUxNZWRpYUVsZW1lbnQuaWRsCmluZGV4IGI1NzBkNmI5OTdjYzM1YzFmYmU5OGYzMzU4 YTEyNDI1ODlhYjQwYmUuLjU1ZDA2ZjNjYTczYjA2MThhOGRlMDRhNDRhOTg4Yjc5ZDRkZjg0Yjcg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5pZGwKKysr IGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmlkbApAQCAtMTE3LDcgKzEx Nyw3IEBAIG1vZHVsZSBodG1sIHsKICAgICByZWFkb25seSBhdHRyaWJ1dGUgW1Y4RW5hYmxlZEF0 UnVudGltZT13ZWJraXRWaWRlb1RyYWNrXSBUZXh0VHJhY2tMaXN0IHRleHRUcmFja3M7CiAjZW5k aWYKIAotICAgIGF0dHJpYnV0ZSBbUmVmbGVjdCwgVHJlYXROdWxsQXM9TnVsbFN0cmluZywgVHJl YXRSZXR1cm5lZE51bGxTdHJpbmdBc051bGxdIERPTVN0cmluZyBtZWRpYUdyb3VwOworICAgIGF0 dHJpYnV0ZSBbUmVmbGVjdCwgVHJlYXROdWxsQXM9TnVsbFN0cmluZ10gRE9NU3RyaW5nIG1lZGlh R3JvdXA7CiAgICAgYXR0cmlidXRlIFtDdXN0b21TZXR0ZXJdIE1lZGlhQ29udHJvbGxlciBjb250 cm9sbGVyOwogfTsKIH0K 127905 2012-02-20 20:30:33 -0800 2012-02-20 22:23:42 -0800 Patch bug-79064-20120221133032.patch text/plain 2158 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4Mjc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjU1ZmZhODE4MTMwM2Nk NzQxMTFmMGIxN2Y3MDg1OThlYzg5ZjY5NC4uYjdkZTZjMGJhODIzMmZlZWM0ZGNiOWY1MTUxNGM3 OWQ2ODc4NmY5NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI1IEBACiAyMDEyLTAyLTIwICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBSZW1vdmUgW1RyZWF0 UmV0dXJuZWROdWxsU3RyaW5nQXNOdWxsXSBmcm9tIEhUTUxNZWRpYUVsZW1lbnQubWVkaWFHcm91 cAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzkwNjQK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbVHJlYXRS ZXR1cm5lZE51bGxTdHJpbmdBc051bGxdIGlzIGEgdHlwbyBvZiBbVHJlYXRSZXR1cm5lZE51bGxT dHJpbmdBcz1OdWxsXS4KKyAgICAgICAgQnV0IGFzIGZhciBhcyBJIHJlYWQgdGhlIHNwZWMKKyAg ICAgICAgKGh0dHA6Ly93d3cud2hhdHdnLm9yZy9zcGVjcy93ZWItYXBwcy9jdXJyZW50LXdvcmsv bXVsdGlwYWdlL3RoZS12aWRlby1lbGVtZW50Lmh0bWwjYXR0ci1tZWRpYS1tZWRpYWdyb3VwKSwK KyAgICAgICAgdGhlcmUgaXMgbm8gc3RhdGVtZW50IGFib3V0IHdoYXQgdmFsdWUgc2hvdWxkIGJl IHJldHVybmVkIHdoZW4gSFRNTE1lZGlhRWxlbWVudC5tZWRpYUdyb3VwCisgICAgICAgIGlzIG5v dCB5ZXQgaW5pdGlhbGl6ZWQuIEluIHBhcnRpY3VsYXIsIHRoZXJlIGlzIG5vIHN0YXRlbWVudCB0 aGF0IHNheXMgIm51bGwgc2hvdWxkCisgICAgICAgIGJlIHJldHVybmVkIHdoZW4gSFRNTE1lZGlh RWxlbWVudC5tZWRpYUdyb3VwIGlzIG5vdCBpbml0aWFsaXplZCIuIFRodXMsIGluc3RlYWQgb2YK KyAgICAgICAgZml4aW5nIHRoZSB0eXBvLCBqdXN0IHJlbW92aW5nIFtUcmVhdFJldHVybmVkTnVs bFN0cmluZ0FzTnVsbF0gd291bGQgbWFrZSBzZW5zZS4KKyAgICAgICAgUmVtb3ZpbmcgW1RyZWF0 UmV0dXJuZWROdWxsU3RyaW5nQXNOdWxsXSBkb2VzIG5vdCBjaGFuZ2UgdGhlIGN1cnJlbnQgYmVo YXZpb3IuCisKKyAgICAgICAgVGVzdDogbWVkaWEvbWVkaWEtY29udHJvbGxlci5odG1sIChObyBj aGFuZ2UgaW4gdGhlIHRlc3QgcmVzdWx0cy4pCisKKyAgICAgICAgKiBodG1sL0hUTUxNZWRpYUVs ZW1lbnQuaWRsOgorCisyMDEyLTAyLTIwICBLZW50YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVt Lm9yZz4KKwogICAgICAgICBVbnJldmlld2VkLiBSZWJhc2VsaW5lZCBydW4tYmluZGluZ3MtdGVz dHMgcmVzdWx0cy4KIAogICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvdGVzdC9DUFAvV2ViRE9N VGVzdEludGVyZmFjZS5jcHA6CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxN ZWRpYUVsZW1lbnQuaWRsIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50Lmlk bAppbmRleCBiNTcwZDZiOTk3Y2MzNWMxZmJlOThmMzM1OGExMjQyNTg5YWI0MGJlLi41NWQwNmYz Y2E3M2IwNjE4YThkZTA0YTQ0YTk4OGI3OWQ0ZGY4NGI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwv SFRNTE1lZGlhRWxlbWVudC5pZGwKQEAgLTExNyw3ICsxMTcsNyBAQCBtb2R1bGUgaHRtbCB7CiAg ICAgcmVhZG9ubHkgYXR0cmlidXRlIFtWOEVuYWJsZWRBdFJ1bnRpbWU9d2Via2l0VmlkZW9UcmFj a10gVGV4dFRyYWNrTGlzdCB0ZXh0VHJhY2tzOwogI2VuZGlmCiAKLSAgICBhdHRyaWJ1dGUgW1Jl ZmxlY3QsIFRyZWF0TnVsbEFzPU51bGxTdHJpbmcsIFRyZWF0UmV0dXJuZWROdWxsU3RyaW5nQXNO dWxsXSBET01TdHJpbmcgbWVkaWFHcm91cDsKKyAgICBhdHRyaWJ1dGUgW1JlZmxlY3QsIFRyZWF0 TnVsbEFzPU51bGxTdHJpbmddIERPTVN0cmluZyBtZWRpYUdyb3VwOwogICAgIGF0dHJpYnV0ZSBb Q3VzdG9tU2V0dGVyXSBNZWRpYUNvbnRyb2xsZXIgY29udHJvbGxlcjsKIH07CiB9Cg==