79049 2012-02-20 15:19:17 -0800 Regression (108135) isOpaque() returns uninitialized variable. 2012-02-20 17:33:29 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yael webkit-unassigned noam webkit.review.bot oldest_to_newest 560406 0 yael 2012-02-20 15:19:17 -0800 r108135 replaced m_isOpaque with some new m_flags, but isOpaque is still used in some parts of the code. Patch is coming soon. 560426 1 127862 yael 2012-02-20 15:40:32 -0800 Created attachment 127862 Patch 560431 2 127862 noam 2012-02-20 15:48:42 -0800 Comment on attachment 127862 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127862&action=review > Source/WebCore/ChangeLog:9 > + No new tests. Tests are not enabled yet for texture mapper code. Just say "No new functionality". 560470 3 127872 yael 2012-02-20 17:10:18 -0800 Created attachment 127872 Patch for landing. 560478 4 127872 webkit.review.bot 2012-02-20 17:33:25 -0800 Comment on attachment 127872 Patch for landing. Clearing flags on attachment: 127872 Committed r108276: <http://trac.webkit.org/changeset/108276> 560479 5 webkit.review.bot 2012-02-20 17:33:29 -0800 All reviewed patches have been landed. Closing bug. 127862 2012-02-20 15:40:32 -0800 2012-02-20 17:10:18 -0800 Patch 79049.patch text/plain 1993 yael SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwODI2NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTAyLTIwICBZYWVsIEFo YXJvbiAgPHlhZWwuYWhhcm9uQG5va2lhLmNvbT4KKworICAgICAgICBSZWdyZXNzaW9uICgxMDgx MzUpIGlzT3BhcXVlKCkgcmV0dXJucyB1bmluaXRpYWxpemVkIHZhcmlhYmxlLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzkwNDkKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBpc09wYXF1ZSgpIHNob3VsZCB1 c2UgdGhlIG5ldyBtX2ZsYWdzIGluc3RlYWQgb2YgdGhlIG9sZCBtX2lzT3BhcXVlLgorICAgICAg ICBObyBuZXcgdGVzdHMuIFRlc3RzIGFyZSBub3QgZW5hYmxlZCB5ZXQgZm9yIHRleHR1cmUgbWFw cGVyIGNvZGUuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1h cHBlci5oOgorICAgICAgICAoV2ViQ29yZTo6Qml0bWFwVGV4dHVyZTo6cmVzZXQpOgorICAgICAg ICAoV2ViQ29yZTo6Qml0bWFwVGV4dHVyZTo6aXNPcGFxdWUpOgorICAgICAgICAoQml0bWFwVGV4 dHVyZSk6CisKIDIwMTItMDItMjAgIFJheW1vbmQgTGl1ICA8cmF5bW9uZC5saXVAaW50ZWwuY29t PgogCiAgICAgICAgIEhhdmUgdGhlIER5bmFtaWNzQ29tcHJlc3Nvck5vZGUgc3VwcG9ydCBtdWx0 aS1jaGFubmVsIGRhdGEKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3Rl eG1hcC9UZXh0dXJlTWFwcGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXIuaAkocmV2aXNpb24gMTA4MjYzKQorKysg U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXIuaAko d29ya2luZyBjb3B5KQpAQCAtNzAsNyArNzAsNyBAQCBwdWJsaWM6CiAKICAgICB2aXJ0dWFsIGlu dCBicHAoKSBjb25zdCB7IHJldHVybiAzMjsgfQogICAgIHZpcnR1YWwgdm9pZCBkaWRSZXNldCgp IHsgfQotICAgIHZvaWQgcmVzZXQoY29uc3QgSW50U2l6ZSYgc2l6ZSwgRmxhZ3MgZmxhZ3MgPSAw KQorICAgIHZvaWQgcmVzZXQoY29uc3QgSW50U2l6ZSYgc2l6ZSwgRmxhZ3MgZmxhZ3MpCiAgICAg ewogICAgICAgICBtX2ZsYWdzID0gZmxhZ3M7CiAgICAgICAgIG1fY29udGVudFNpemUgPSBzaXpl OwpAQCAtNzksNyArNzksNyBAQCBwdWJsaWM6CiAKICAgICBpbmxpbmUgSW50U2l6ZSBjb250ZW50 U2l6ZSgpIGNvbnN0IHsgcmV0dXJuIG1fY29udGVudFNpemU7IH0KICAgICBpbmxpbmUgaW50IG51 bWJlck9mQnl0ZXMoKSBjb25zdCB7IHJldHVybiBzaXplKCkud2lkdGgoKSAqIHNpemUoKS5oZWln aHQoKSAqIGJwcCgpID4+IDM7IH0KLSAgICBpbmxpbmUgYm9vbCBpc09wYXF1ZSgpIGNvbnN0IHsg cmV0dXJuIG1faXNPcGFxdWU7IH0KKyAgICBpbmxpbmUgYm9vbCBpc09wYXF1ZSgpIGNvbnN0IHsg cmV0dXJuICEobV9mbGFncyAmIFN1cHBvcnRzQWxwaGEpOyB9CiAKICNpZiBFTkFCTEUoQ1NTX0ZJ TFRFUlMpCiAgICAgdmlydHVhbCB2b2lkIGFwcGx5RmlsdGVycyhjb25zdCBCaXRtYXBUZXh0dXJl JiBjb250ZW50VGV4dHVyZSwgY29uc3QgRmlsdGVyT3BlcmF0aW9ucyYpIHsgfQpAQCAtODcsNyAr ODcsNiBAQCBwdWJsaWM6CiAKIHByb3RlY3RlZDoKICAgICBJbnRTaXplIG1fY29udGVudFNpemU7 Ci0gICAgYm9vbCBtX2lzT3BhcXVlOwogCiBwcml2YXRlOgogICAgIEZsYWdzIG1fZmxhZ3M7Cg== 127872 2012-02-20 17:10:18 -0800 2012-02-20 17:33:25 -0800 Patch for landing. 79049.patch text/plain 1964 yael SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwODI2NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTAyLTIwICBZYWVsIEFo YXJvbiAgPHlhZWwuYWhhcm9uQG5va2lhLmNvbT4KKworICAgICAgICBSZWdyZXNzaW9uICgxMDgx MzUpIGlzT3BhcXVlKCkgcmV0dXJucyB1bmluaXRpYWxpemVkIHZhcmlhYmxlLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzkwNDkKKworICAgICAgICBS ZXZpZXdlZCBieSBOb2FtIFJvc2VudGhhbC4KKworICAgICAgICBpc09wYXF1ZSgpIHNob3VsZCB1 c2UgdGhlIG5ldyBtX2ZsYWdzIGluc3RlYWQgb2YgdGhlIG9sZCBtX2lzT3BhcXVlLgorICAgICAg ICBObyBuZXcgdGVzdHMuIE5vIG5ldyBmdW5jdGlvbmFsaXR5LgorCisgICAgICAgICogcGxhdGZv cm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXIuaDoKKyAgICAgICAgKFdlYkNvcmU6OkJp dG1hcFRleHR1cmU6OnJlc2V0KToKKyAgICAgICAgKFdlYkNvcmU6OkJpdG1hcFRleHR1cmU6Omlz T3BhcXVlKToKKyAgICAgICAgKEJpdG1hcFRleHR1cmUpOgorCiAyMDEyLTAyLTIwICBSYXltb25k IExpdSAgPHJheW1vbmQubGl1QGludGVsLmNvbT4KIAogICAgICAgICBIYXZlIHRoZSBEeW5hbWlj c0NvbXByZXNzb3JOb2RlIHN1cHBvcnQgbXVsdGktY2hhbm5lbCBkYXRhCkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlci5oCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFw cGVyLmgJKHJldmlzaW9uIDEwODI2MykKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTcwLDcgKzcwLDcg QEAgcHVibGljOgogCiAgICAgdmlydHVhbCBpbnQgYnBwKCkgY29uc3QgeyByZXR1cm4gMzI7IH0K ICAgICB2aXJ0dWFsIHZvaWQgZGlkUmVzZXQoKSB7IH0KLSAgICB2b2lkIHJlc2V0KGNvbnN0IElu dFNpemUmIHNpemUsIEZsYWdzIGZsYWdzID0gMCkKKyAgICB2b2lkIHJlc2V0KGNvbnN0IEludFNp emUmIHNpemUsIEZsYWdzIGZsYWdzKQogICAgIHsKICAgICAgICAgbV9mbGFncyA9IGZsYWdzOwog ICAgICAgICBtX2NvbnRlbnRTaXplID0gc2l6ZTsKQEAgLTc5LDcgKzc5LDcgQEAgcHVibGljOgog CiAgICAgaW5saW5lIEludFNpemUgY29udGVudFNpemUoKSBjb25zdCB7IHJldHVybiBtX2NvbnRl bnRTaXplOyB9CiAgICAgaW5saW5lIGludCBudW1iZXJPZkJ5dGVzKCkgY29uc3QgeyByZXR1cm4g c2l6ZSgpLndpZHRoKCkgKiBzaXplKCkuaGVpZ2h0KCkgKiBicHAoKSA+PiAzOyB9Ci0gICAgaW5s aW5lIGJvb2wgaXNPcGFxdWUoKSBjb25zdCB7IHJldHVybiBtX2lzT3BhcXVlOyB9CisgICAgaW5s aW5lIGJvb2wgaXNPcGFxdWUoKSBjb25zdCB7IHJldHVybiAhKG1fZmxhZ3MgJiBTdXBwb3J0c0Fs cGhhKTsgfQogCiAjaWYgRU5BQkxFKENTU19GSUxURVJTKQogICAgIHZpcnR1YWwgdm9pZCBhcHBs eUZpbHRlcnMoY29uc3QgQml0bWFwVGV4dHVyZSYgY29udGVudFRleHR1cmUsIGNvbnN0IEZpbHRl ck9wZXJhdGlvbnMmKSB7IH0KQEAgLTg3LDcgKzg3LDYgQEAgcHVibGljOgogCiBwcm90ZWN0ZWQ6 CiAgICAgSW50U2l6ZSBtX2NvbnRlbnRTaXplOwotICAgIGJvb2wgbV9pc09wYXF1ZTsKIAogcHJp dmF0ZToKICAgICBGbGFncyBtX2ZsYWdzOwo=