79045 2012-02-20 14:36:51 -0800 Does not build on GNU Hurd 2012-02-20 18:12:15 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://bugs.debian.org/649192 P2 Normal --- 1 gustavo gustavo webkit.review.bot oldest_to_newest 560369 0 gustavo 2012-02-20 14:36:51 -0800 From the Debian bug: The problem is due to the missing PTHREAD_KEYS_MAX definition (which is optional in POSIX, though). The attached patch does two things: - Source/JavaScriptCore/wtf/Platform.h defines WTF_OS_HURD in hopefully a suitable way for upstream; it would be nice if you could send it upstream (so I don't need to patch also the various webkit copies for it). - Source/JavaScriptCore/wtf/ThreadIdentifierDataPthreads.cpp adds a band-aid fix fix for the lack of PTHREAD_KEYS_MAX definition, with a value which should not cause issues; this part should not go upstream but stay locally in Debian for now, as it will need either a better fix in webkit or a fix in glibc/libpthread for Hurd. 560375 1 127852 gustavo 2012-02-20 14:42:04 -0800 Created attachment 127852 Patch 560404 2 127852 webkit.review.bot 2012-02-20 15:16:55 -0800 Comment on attachment 127852 Patch Rejecting attachment 127852 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Gustavo Noronha found in /mnt/git/webkit-commit-queue/Source/JavaScriptCore/ChangeLog does not appear to be a valid reviewer according to committers.py. ERROR: /mnt/git/webkit-commit-queue/Source/JavaScriptCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/11552258 560429 3 127864 gustavo 2012-02-20 15:47:05 -0800 Created attachment 127864 Patch 560507 4 127864 webkit.review.bot 2012-02-20 18:12:09 -0800 Comment on attachment 127864 Patch Clearing flags on attachment: 127864 Committed r108279: <http://trac.webkit.org/changeset/108279> 560509 5 webkit.review.bot 2012-02-20 18:12:15 -0800 All reviewed patches have been landed. Closing bug. 127852 2012-02-20 14:42:04 -0800 2012-02-20 15:46:58 -0800 Patch bug-79045-20120220204028.patch text/plain 2181 gustavo U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4MjQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy MGY1OTg2YjQyNDNlZTA2YWQ5ZmMwYzZhZWJhZTZmMDljYmI1OWU4Li5iNGQwYzRhZWFmYjQ0M2Q5 M2ZjN2NhYWMxNmNkNjgyNDQyZTdjMTg5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxMi0wMi0yMCAgUGlubyBUb3NjYW5vICA8cGlub0BkZWJpYW4ub3JnPgor CisgICAgICAgIERvZXMgbm90IGJ1aWxkIG9uIEdOVSBIdXJkCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03OTA0NQorCisgICAgICAgIFJldmlld2VkIGJ5 IEd1c3Rhdm8gTm9yb25oYS4KKworICAgICAgICAqIHd0Zi9QbGF0Zm9ybS5oOiBkZWZpbmUgV1RG X09TX0hVUkQuCisgICAgICAgICogd3RmL1RocmVhZElkZW50aWZpZXJEYXRhUHRocmVhZHMuY3Bw OiBhZGRzIGEgYmFuZC1haWQgZml4CisgICAgICAgIGZvciB0aGUgbGFjayBvZiBQVEhSRUFEX0tF WVNfTUFYIGRlZmluaXRpb24sIHdpdGggYSB2YWx1ZSB3aGljaAorICAgICAgICBzaG91bGQgbm90 IGNhdXNlIGlzc3Vlcy4KKwogMjAxMi0wMi0yMCAgQW5keSBXaW5nbyAgPHdpbmdvQGlnYWxpYS5j b20+CiAKICAgICAgICAgUmVtb3ZlIHVudXNlZCBmZWF0dXJlcyBmcm9tIENvZGVGZWF0dXJlcwpk aWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCmluZGV4IDhkMDI0NDU4ZjAzMTI4MDIxMWQ3 NGU3MGU1YjRmYWVmOWI1ZWQyMzkuLmZhYTBjMDhlZjBkY2EzZWQ1ZTI2MDc1Y2FkNGZlODQ2MDg0 MDUxN2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAor KysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgKQEAgLTM1MSw2ICszNTEs MTEgQEAKICNkZWZpbmUgV1RGX09TX0ZSRUVCU0QgMQogI2VuZGlmCiAKKy8qIE9TKEhVUkQpIC0g R05VL0h1cmQgKi8KKyNpZmRlZiBfX0dOVV9fCisjZGVmaW5lIFdURl9PU19IVVJEIDEKKyNlbmRp ZgorCiAvKiBPUyhMSU5VWCkgLSBMaW51eCAqLwogI2lmZGVmIF9fbGludXhfXwogI2RlZmluZSBX VEZfT1NfTElOVVggMQpAQCAtMzk0LDYgKzM5OSw3IEBACiAgICAgfHwgT1MoQU5EUk9JRCkgICAg ICAgICAgXAogICAgIHx8IE9TKERBUldJTikgICAgICAgICAgIFwKICAgICB8fCBPUyhGUkVFQlNE KSAgICAgICAgICBcCisgICAgfHwgT1MoSFVSRCkgICAgICAgICAgICAgXAogICAgIHx8IE9TKExJ TlVYKSAgICAgICAgICAgIFwKICAgICB8fCBPUyhORVRCU0QpICAgICAgICAgICBcCiAgICAgfHwg T1MoT1BFTkJTRCkgICAgICAgICAgXApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L3d0Zi9UaHJlYWRJZGVudGlmaWVyRGF0YVB0aHJlYWRzLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS93dGYvVGhyZWFkSWRlbnRpZmllckRhdGFQdGhyZWFkcy5jcHAKaW5kZXggYjNiNjkwZjcw OTFlZTZlYWEyZTFmOTQ3OTQ0NzcyYzRlYTYwYjU3OC4uMGJhZGY5MzlhNmFiYjAyNDM0NzBmMzY1 ZTQyYmU2YmQ1NmUxNTdmYSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9U aHJlYWRJZGVudGlmaWVyRGF0YVB0aHJlYWRzLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvd3RmL1RocmVhZElkZW50aWZpZXJEYXRhUHRocmVhZHMuY3BwCkBAIC0zNiw4ICszNiw4IEBA CiAKICNpbmNsdWRlICJUaHJlYWRpbmcuaCIKIAotI2lmIE9TKEFORFJPSUQpCi0vLyBQVEhSRUFE X0tFWVNfTUFYIGlzIG5vdCBkZWZpbmVkIGluIGJpb25pYywgc28gZXhwbGljaXRseSBkZWZpbmUg aXQgaGVyZS4KKyNpZiBPUyhBTkRST0lEKSB8fCBPUyhIVVJEKQorLy8gUFRIUkVBRF9LRVlTX01B WCBpcyBub3QgZGVmaW5lZCBpbiBiaW9uaWMgbm9yIGluIEh1cmQsIHNvIGV4cGxpY2l0bHkgZGVm aW5lIGl0IGhlcmUuCiAjZGVmaW5lIFBUSFJFQURfS0VZU19NQVggMTAyNAogI2Vsc2UKICNpbmNs dWRlIDxsaW1pdHMuaD4K 127864 2012-02-20 15:47:05 -0800 2012-02-20 18:12:09 -0800 Patch bug-79045-20120220214530.patch text/plain 2221 gustavo U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4MjY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz OGU2ZGJmNDk4N2Q4YWQ5NmU5NmIyZmRiNDQ3M2I1YTU0MWE0OTY2Li5jNTE0ZDlkMjkzMzUwNWFj NGZiMDU4MjNkMWEyNGEzNTc5NGQ3ZDY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxMi0wMi0yMCAgUGlubyBUb3NjYW5vICA8cGlub0BkZWJpYW4ub3JnPgor CisgICAgICAgIERvZXMgbm90IGJ1aWxkIG9uIEdOVSBIdXJkCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03OTA0NQorCisgICAgICAgIFJldmlld2VkIGJ5 IEd1c3Rhdm8gTm9yb25oYSBTaWx2YS4KKworICAgICAgICAqIHd0Zi9QbGF0Zm9ybS5oOiBkZWZp bmUgV1RGX09TX0hVUkQuCisgICAgICAgICogd3RmL1RocmVhZElkZW50aWZpZXJEYXRhUHRocmVh ZHMuY3BwOiBhZGRzIGEgYmFuZC1haWQgZml4CisgICAgICAgIGZvciB0aGUgbGFjayBvZiBQVEhS RUFEX0tFWVNfTUFYIGRlZmluaXRpb24sIHdpdGggYSB2YWx1ZSB3aGljaAorICAgICAgICBzaG91 bGQgbm90IGNhdXNlIGlzc3Vlcy4KKwogMjAxMi0wMi0yMCAgTWFyayBIYWhuZW5iZXJnICA8bWhh aG5lbmJlcmdAYXBwbGUuY29tPgogCiAgICAgICAgIEZhY3RvciBvdXQgYWxsb2NhdGlvbiBpbiBD b3B5U3BhY2UgaW50byBhIHNlcGFyYXRlIENvcHlBbGxvY2F0b3IKZGlmZiAtLWdpdCBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93 dGYvUGxhdGZvcm0uaAppbmRleCA4ZDAyNDQ1OGYwMzEyODAyMTFkNzRlNzBlNWI0ZmFlZjliNWVk MjM5Li5mYWEwYzA4ZWYwZGNhM2VkNWUyNjA3NWNhZDRmZTg0NjA4NDA1MTdhIDEwMDY0NAotLS0g YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgKKysrIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCkBAIC0zNTEsNiArMzUxLDExIEBACiAjZGVmaW5lIFdU Rl9PU19GUkVFQlNEIDEKICNlbmRpZgogCisvKiBPUyhIVVJEKSAtIEdOVS9IdXJkICovCisjaWZk ZWYgX19HTlVfXworI2RlZmluZSBXVEZfT1NfSFVSRCAxCisjZW5kaWYKKwogLyogT1MoTElOVVgp IC0gTGludXggKi8KICNpZmRlZiBfX2xpbnV4X18KICNkZWZpbmUgV1RGX09TX0xJTlVYIDEKQEAg LTM5NCw2ICszOTksNyBAQAogICAgIHx8IE9TKEFORFJPSUQpICAgICAgICAgIFwKICAgICB8fCBP UyhEQVJXSU4pICAgICAgICAgICBcCiAgICAgfHwgT1MoRlJFRUJTRCkgICAgICAgICAgXAorICAg IHx8IE9TKEhVUkQpICAgICAgICAgICAgIFwKICAgICB8fCBPUyhMSU5VWCkgICAgICAgICAgICBc CiAgICAgfHwgT1MoTkVUQlNEKSAgICAgICAgICAgXAogICAgIHx8IE9TKE9QRU5CU0QpICAgICAg ICAgIFwKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvVGhyZWFkSWRlbnRp ZmllckRhdGFQdGhyZWFkcy5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1RocmVhZElk ZW50aWZpZXJEYXRhUHRocmVhZHMuY3BwCmluZGV4IGIzYjY5MGY3MDkxZWU2ZWFhMmUxZjk0Nzk0 NDc3MmM0ZWE2MGI1NzguLjBiYWRmOTM5YTZhYmIwMjQzNDcwZjM2NWU0MmJlNmJkNTZlMTU3ZmEg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvVGhyZWFkSWRlbnRpZmllckRh dGFQdGhyZWFkcy5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9UaHJlYWRJZGVu dGlmaWVyRGF0YVB0aHJlYWRzLmNwcApAQCAtMzYsOCArMzYsOCBAQAogCiAjaW5jbHVkZSAiVGhy ZWFkaW5nLmgiCiAKLSNpZiBPUyhBTkRST0lEKQotLy8gUFRIUkVBRF9LRVlTX01BWCBpcyBub3Qg ZGVmaW5lZCBpbiBiaW9uaWMsIHNvIGV4cGxpY2l0bHkgZGVmaW5lIGl0IGhlcmUuCisjaWYgT1Mo QU5EUk9JRCkgfHwgT1MoSFVSRCkKKy8vIFBUSFJFQURfS0VZU19NQVggaXMgbm90IGRlZmluZWQg aW4gYmlvbmljIG5vciBpbiBIdXJkLCBzbyBleHBsaWNpdGx5IGRlZmluZSBpdCBoZXJlLgogI2Rl ZmluZSBQVEhSRUFEX0tFWVNfTUFYIDEwMjQKICNlbHNlCiAjaW5jbHVkZSA8bGltaXRzLmg+Cg==