79042 2012-02-20 12:49:29 -0800 Little optimization for CSSParser::parseFillShorthand. 2012-02-21 09:35:08 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 menard menard darin kling macpherson tony webkit.review.bot oldest_to_newest 560321 0 menard 2012-02-20 12:49:29 -0800 Little optimization for CSSParser::parseFillShorthand. 560323 1 127843 menard 2012-02-20 12:53:28 -0800 Created attachment 127843 Patch 560581 2 127843 morrita 2012-02-20 20:09:59 -0800 Comment on attachment 127843 Patch R+ing for this small and looking sane change. I hope original comment to stay there. The code is cryptic enough to have comments. 560912 3 127843 menard 2012-02-21 08:43:53 -0800 Comment on attachment 127843 Patch All original comments are preserved. cq+ 560958 4 127843 webkit.review.bot 2012-02-21 09:35:03 -0800 Comment on attachment 127843 Patch Clearing flags on attachment: 127843 Committed r108365: <http://trac.webkit.org/changeset/108365> 560959 5 webkit.review.bot 2012-02-21 09:35:08 -0800 All reviewed patches have been landed. Closing bug. 127843 2012-02-20 12:53:28 -0800 2012-02-21 09:35:02 -0800 Patch bug-79042-20120220175313.patch text/plain 3079 menard U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4MjI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWI4NDM4NmNmYWQ4YmU2 ZDYwNTVlNmM2OGM0ODQzMGQzZTUwZTMxMS4uMDA0MmNjNzYyMzkxYmM3ZjE1M2IzMjNhMzY0OTFh Y2UwMmE1NWU1MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTAyLTIwICBBbGV4 aXMgTWVuYXJkICA8YWxleGlzLm1lbmFyZEBvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIExpdHRs ZSBvcHRpbWl6YXRpb24gZm9yIENTU1BhcnNlcjo6cGFyc2VGaWxsU2hvcnRoYW5kLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzkwNDIKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgb25lIGV4dHJh IGxvb3AgdGhhdCB3ZSBjYW4gY29tYmluZSB3aXRoIHRoZSBmb2xsb3dpbmcgb25lCisgICAgICAg IHdoaWNoIGFkZHMgdGhlIHByb3BlcnRpZXMgdG8gdGhlIHBhcnNlcidzIGxpc3Qgb2YgcHJvcGVy dGllcy4gSSBhbHNvCisgICAgICAgIHJlbW92ZWQgYSB1c2VsZXNzIGNoZWNrLgorICAgICAgICBJ bnN0cnVtZW50cyBzaG93cyBvbiB0aGUgY3NzLXBhcnNlci15dWkgYmVuY2htYXJrIGFuIGltcHJv dmVtZW50CisgICAgICAgIG9mIDEzbXMgKGZyb20gNzdtcyBzcGVudCBpbiB0aGUgZnVuY3Rpb24g dG8gNjRtcykuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIDogcmVmYWN0b3JpbmcsIGV4aXN0aW5n cyB0ZXN0cyBzaG91bGQgY292ZXIuCisKKyAgICAgICAgKiBjc3MvQ1NTUGFyc2VyLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkNTU1BhcnNlcjo6cGFyc2VGaWxsU2hvcnRoYW5kKToKKwogMjAxMi0w Mi0yMCAgU2hpbnlhIEthd2FuYWthICA8c2hpbnlha0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg QXR0YWNoZWQvRGV0YWNoZWQgc3RhdGUgbXVzdCBiZSB0ZXN0YWJsZQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFy c2VyLmNwcAppbmRleCBlMmQ0NjQ2OGM3YzE5MzUzMTg4ZWE1MDkyYmI3OGIwNThiNjQ0YmYxLi5l YTBhNDU4NjFjM2VkZDM1MTk2Yjk5MDI4ODhlZWU3ODI5OWViYjhhIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NT UGFyc2VyLmNwcApAQCAtMjQ4NCwyMyArMjQ4NCwyMCBAQCBib29sIENTU1BhcnNlcjo6cGFyc2VG aWxsU2hvcnRoYW5kKGludCBwcm9wSWQsIGNvbnN0IGludCogcHJvcGVydGllcywgaW50IG51bVBy bwogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIH0KIAotICAgIC8vIEZpbGwgaW4gYW55 IHJlbWFpbmluZyBwcm9wZXJ0aWVzIHdpdGggdGhlIGluaXRpYWwgdmFsdWUuCi0gICAgZm9yIChp ID0gMDsgaSA8IG51bVByb3BlcnRpZXM7ICsraSkgeworICAgIC8vIE5vdyBhZGQgYWxsIG9mIHRo ZSBwcm9wZXJ0aWVzIHdlIGZvdW5kLgorICAgIGZvciAoaSA9IDA7IGkgPCBudW1Qcm9wZXJ0aWVz OyBpKyspIHsKKyAgICAgICAgLy8gRmlsbCBpbiBhbnkgcmVtYWluaW5nIHByb3BlcnRpZXMgd2l0 aCB0aGUgaW5pdGlhbCB2YWx1ZS4KICAgICAgICAgaWYgKCFwYXJzZWRQcm9wZXJ0eVtpXSkgewog ICAgICAgICAgICAgYWRkRmlsbFZhbHVlKHZhbHVlc1tpXSwgY3NzVmFsdWVQb29sKCktPmNyZWF0 ZUltcGxpY2l0SW5pdGlhbFZhbHVlKCkpOwogICAgICAgICAgICAgaWYgKHByb3BlcnRpZXNbaV0g PT0gQ1NTUHJvcGVydHlCYWNrZ3JvdW5kUG9zaXRpb24gfHwgcHJvcGVydGllc1tpXSA9PSBDU1NQ cm9wZXJ0eVdlYmtpdE1hc2tQb3NpdGlvbikKICAgICAgICAgICAgICAgICBhZGRGaWxsVmFsdWUo cG9zaXRpb25ZVmFsdWUsIGNzc1ZhbHVlUG9vbCgpLT5jcmVhdGVJbXBsaWNpdEluaXRpYWxWYWx1 ZSgpKTsKICAgICAgICAgICAgIGlmIChwcm9wZXJ0aWVzW2ldID09IENTU1Byb3BlcnR5QmFja2dy b3VuZFJlcGVhdCB8fCBwcm9wZXJ0aWVzW2ldID09IENTU1Byb3BlcnR5V2Via2l0TWFza1JlcGVh dCkKICAgICAgICAgICAgICAgICBhZGRGaWxsVmFsdWUocmVwZWF0WVZhbHVlLCBjc3NWYWx1ZVBv b2woKS0+Y3JlYXRlSW1wbGljaXRJbml0aWFsVmFsdWUoKSk7Ci0gICAgICAgICAgICBpZiAoKHBy b3BlcnRpZXNbaV0gPT0gQ1NTUHJvcGVydHlCYWNrZ3JvdW5kT3JpZ2luIHx8IHByb3BlcnRpZXNb aV0gPT0gQ1NTUHJvcGVydHlXZWJraXRNYXNrT3JpZ2luKSAmJiAhcGFyc2VkUHJvcGVydHlbaV0p IHsKKyAgICAgICAgICAgIGlmICgocHJvcGVydGllc1tpXSA9PSBDU1NQcm9wZXJ0eUJhY2tncm91 bmRPcmlnaW4gfHwgcHJvcGVydGllc1tpXSA9PSBDU1NQcm9wZXJ0eVdlYmtpdE1hc2tPcmlnaW4p KSB7CiAgICAgICAgICAgICAgICAgLy8gSWYgYmFja2dyb3VuZC1vcmlnaW4gd2Fzbid0IHByZXNl bnQsIHRoZW4gcmVzZXQgYmFja2dyb3VuZC1jbGlwIGFsc28uCiAgICAgICAgICAgICAgICAgYWRk RmlsbFZhbHVlKGNsaXBWYWx1ZSwgY3NzVmFsdWVQb29sKCktPmNyZWF0ZUltcGxpY2l0SW5pdGlh bFZhbHVlKCkpOwogICAgICAgICAgICAgfQogICAgICAgICB9Ci0gICAgfQotCi0gICAgLy8gTm93 IGFkZCBhbGwgb2YgdGhlIHByb3BlcnRpZXMgd2UgZm91bmQuCi0gICAgZm9yIChpID0gMDsgaSA8 IG51bVByb3BlcnRpZXM7IGkrKykgewogICAgICAgICBpZiAocHJvcGVydGllc1tpXSA9PSBDU1NQ cm9wZXJ0eUJhY2tncm91bmRQb3NpdGlvbikgewogICAgICAgICAgICAgYWRkUHJvcGVydHkoQ1NT UHJvcGVydHlCYWNrZ3JvdW5kUG9zaXRpb25YLCB2YWx1ZXNbaV0ucmVsZWFzZSgpLCBpbXBvcnRh bnQpOwogICAgICAgICAgICAgLy8gaXQncyBPSyB0byBjYWxsIHBvc2l0aW9uWVZhbHVlLnJlbGVh c2UoKSBzaW5jZSB3ZSBvbmx5IHNlZSBDU1NQcm9wZXJ0eUJhY2tncm91bmRQb3NpdGlvbiBvbmNl Cg==