79040 2012-02-20 11:30:56 -0800 (function () { while(true) { } })() runs forever with DFG JIT 2012-11-21 06:33:36 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All NEW Qt, QtTriaged P1 Critical --- 96916 79668 1 ossy webkit-unassigned barraclough fpizlo gaborb gergely ggaren hausmann laszlo.gombos loki mark.lam ossy pvarga tonikitoo yong.li.webkit zherczeg oldest_to_newest 560307 0 ossy 2012-02-20 11:30:56 -0800 tst_QWebPage Qt API tests fails after enabling DFG JIT: QFATAL : tst_QWebPage::infiniteLoopJS() Received signal 15 FAIL! : tst_QWebPage::infiniteLoopJS() Received a fatal error. But unfortunately we didn't notice it before, because zillion API tests fail and nobody cares with them. And unfortunately timeouts were hidden before http://trac.webkit.org/changeset/108246 It might be a JSC bug, but we should check it on a small QWebPage independent example. 560680 1 127922 ossy 2012-02-20 22:51:47 -0800 Created attachment 127922 Patch 560681 2 ossy 2012-02-20 22:53:18 -0800 (In reply to comment #1) > Created an attachment (id=127922) [details] > Patch It is a workaround to make our bots happier. Without fixing this bug or without this workaround our bots can't be green anymore. (because of stricter rule in master.cfg - http://trac.webkit.org/changeset/108246) 560780 3 hausmann 2012-02-21 03:27:38 -0800 Filip, it seems that LLint doesn't do the timeout checks for loops, like it's done in op_loop in Interpreter.cpp. Is that a missing feature in llint? 560782 4 127922 hausmann 2012-02-21 03:29:02 -0800 Comment on attachment 127922 Patch rs=me. Let's get this workaround in until we figure out why the timeout don't seem to be getting called with llint. 560805 5 ossy 2012-02-21 04:24:58 -0800 I made a little digging, and checked if TimeoutChecker::didTimeOut(ExecState* exec) is called or not. It is called from tst_QWebPage::infiniteLoopJS()if DFG JIT is disabled. But it isn't called if DFG JIT is enabled. And it isn't called with same infinite loop from DRT and QtTestBrowser irrespectively of DFG JIT is enabled or not. 560806 6 127922 ossy 2012-02-21 04:34:02 -0800 Comment on attachment 127922 Patch Clearing flags on attachment: 127922 Committed r108341: <http://trac.webkit.org/changeset/108341> 684044 7 zherczeg 2012-08-01 03:14:11 -0700 Hey Filip, I think I tracked down this issue. It seems the DFG JIT does not call TimeoutChecker at all, so nothing checks the timeout in case of a simple (function () { while(true) { } })() Which essentially stops the browser forever. Any idea how to fix this? 725253 8 barraclough 2012-09-21 01:12:10 -0700 We don't currently support a mechanism to asynchronously interrupt JavaScript execution. To stop a runaway script in WebKit2, you can kill the web process - this ensures all resources are released. 725267 9 zherczeg 2012-09-21 01:34:32 -0700 We discussed this issue with Philip before, and we decided that we refactor the code. This work is currently in progress. 729622 10 166022 gaborb 2012-09-27 09:36:51 -0700 Created attachment 166022 Proposed patch Proposed patch without changelog. It depends on https://bugs.webkit.org/show_bug.cgi?id=96916 754796 11 ggaren 2012-10-30 16:51:19 -0700 Mark Lam is working on a more efficient fix for this. 754920 12 zherczeg 2012-10-30 20:49:10 -0700 Thanks for letting us know! 754981 13 ossy 2012-10-30 22:57:01 -0700 (In reply to comment #11) > Mark Lam is working on a more efficient fix for this. :(( I don't think if ignoring review at all for a month is the best / most friendlier way to let us know that you don't want Gábor's fix and you prefer fixing by yourself. 755352 14 ggaren 2012-10-31 08:52:34 -0700 > I don't think if ignoring review at all for a month is the best / > most friendlier way to let us know that you don't want Gábor's fix > and you prefer fixing by yourself. To clarify, Mark wasn't working on this a month ago. If you want this patch reviewed, the best thing to do is mark the review flag r? and post performance numbers for a reviewer to evaluate. 765572 15 gaborb 2012-11-13 07:20:38 -0800 Sunspider benchmark results on x86_64 Linux: sunspider: TEST COMPARISON r134387 Proposed patch DETAILS ============================================================================= ** TOTAL **: *1.014x as slow* 208.5ms +/- 0.1% 211.4ms +/- 0.2% significant ============================================================================= 3d: *1.019x as slow* 32.6ms +/- 0.4% 33.2ms +/- 0.4% significant cube: *1.050x as slow* 11.5ms +/- 1.1% 12.1ms +/- 0.5% significant morph: ?? 9.1ms +/- 0.9% 9.3ms +/- 1.1% not conclusive: might be *1.012x as slow* raytrace: - 11.9ms +/- 0.5% 11.9ms +/- 0.5% access: ?? 18.0ms +/- 0.0% 18.0ms +/- 0.2% not conclusive: might be *1.001x as slow* binary-trees: - 2.0ms +/- 0.0% 2.0ms +/- 0.0% fannkuch: ?? 8.0ms +/- 0.0% 8.0ms +/- 0.3% not conclusive: might be *1.002x as slow* nbody: - 4.0ms +/- 0.0% 4.0ms +/- 0.0% nsieve: - 4.0ms +/- 0.0% 4.0ms +/- 0.0% bitops: 1.025x as fast 12.5ms +/- 0.8% 12.2ms +/- 0.7% significant 3bit-bits-in-byte: - 1.0ms +/- 0.0% 1.0ms +/- 0.0% bits-in-byte: 1.057x as fast 5.5ms +/- 1.8% 5.2ms +/- 1.6% significant bitwise-and: - 2.0ms +/- 0.0% 2.0ms +/- 0.0% nsieve-bits: - 4.0ms +/- 0.0% 4.0ms +/- 0.0% controlflow: - 2.0ms +/- 0.0% 2.0ms +/- 0.0% recursive: - 2.0ms +/- 0.0% 2.0ms +/- 0.0% crypto: - 17.0ms +/- 0.0% 17.0ms +/- 0.1% aes: - 10.0ms +/- 0.0% 10.0ms +/- 0.0% md5: ?? 4.0ms +/- 0.0% 4.0ms +/- 0.5% not conclusive: might be *1.002x as slow* sha1: - 3.0ms +/- 0.0% 3.0ms +/- 0.0% date: ?? 31.0ms +/- 0.1% 31.1ms +/- 0.5% not conclusive: might be *1.002x as slow* format-tofte: ?? 16.0ms +/- 0.2% 16.1ms +/- 0.8% not conclusive: might be *1.006x as slow* format-xparb: - 15.0ms +/- 0.2% 15.0ms +/- 0.3% math: *1.073x as slow* 18.6ms +/- 0.5% 20.0ms +/- 0.0% significant cordic: *1.33x as slow* 3.0ms +/- 0.0% 4.0ms +/- 0.0% significant partial-sums: - 13.0ms +/- 0.2% 13.0ms +/- 0.0% spectral-norm: *1.141x as slow* 2.6ms +/- 3.7% 3.0ms +/- 0.0% significant regexp: - 11.0ms +/- 0.2% 11.0ms +/- 0.0% dna: - 11.0ms +/- 0.2% 11.0ms +/- 0.0% string: *1.017x as slow* 65.8ms +/- 0.2% 66.9ms +/- 0.4% significant base64: ?? 5.0ms +/- 0.0% 5.0ms +/- 0.4% not conclusive: might be *1.002x as slow* fasta: - 10.0ms +/- 0.0% 10.0ms +/- 0.0% tagcloud: *1.008x as slow* 16.2ms +/- 0.5% 16.4ms +/- 0.6% significant unpack-code: *1.025x as slow* 26.5ms +/- 0.4% 27.1ms +/- 0.6% significant validate-input: *1.042x as slow* 8.1ms +/- 0.6% 8.4ms +/- 1.5% significant V8: TEST COMPARISON r134387 Proposed patch DETAILS ============================================================================= ** TOTAL **: *1.016x as slow* 748.9ms +/- 0.0% 760.7ms +/- 0.1% significant ============================================================================= v8: *1.016x as slow* 748.9ms +/- 0.0% 760.7ms +/- 0.1% significant crypto: *1.107x as slow* 86.8ms +/- 0.1% 96.1ms +/- 0.1% significant deltablue: *1.009x as slow* 135.4ms +/- 0.1% 136.7ms +/- 0.1% significant earley-boyer: *1.006x as slow* 97.8ms +/- 0.1% 98.4ms +/- 0.2% significant raytrace: *1.002x as slow* 70.8ms +/- 0.1% 71.0ms +/- 0.1% significant regexp: 1.010x as fast 107.2ms +/- 0.1% 106.1ms +/- 0.1% significant richards: *1.014x as slow* 113.5ms +/- 0.2% 115.0ms +/- 0.2% significant splay: - 137.3ms +/- 0.2% 137.4ms +/- 0.3% 772884 16 ossy 2012-11-21 06:30:00 -0800 As far as I know, Gábor doesn't work on it anymore. Could you confirm it? 772889 17 gaborb 2012-11-21 06:33:36 -0800 (In reply to comment #16) > As far as I know, Gábor doesn't work on it anymore. Could you confirm it? Yes, that's true. As far as I know Mark Lam is working on it now. 127922 2012-02-20 22:51:47 -0800 2012-02-21 04:34:02 -0800 Patch bug-79040-20120220225145.patch text/plain 1982 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4MzA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0 L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IDQ2NzIxMzBkNmNj OTE0YWZhN2Q4ZjQxYzI1M2QyMTVjYTllNzlhYTYuLmFiMmJkNWI4MWM3NzZkMzNhZGZlY2JiNmRm NWEzOTBjNzJjNzBmZjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTItMDIt MjAgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KKworICAgICAgICBbUXRd IHRzdF9RV2ViUGFnZTo6aW5maW5pdGVMb29wSlMoKSB0aW1lb3V0cyB3aXRoIERGRyBKSVQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc5MDQwCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB0ZXN0cy9xd2Vi cGFnZS90c3RfcXdlYnBhZ2UuY3BwOgorICAgICAgICAodHN0X1FXZWJQYWdlKTogRGlzYWJsZSB0 c3RfUVdlYlBhZ2U6OmluZmluaXRlTG9vcEpTKCkgdW50aWwgcHJvcGVyIGZpeC4KKwogMjAxMi0w Mi0xNiAgU2ltb24gSGF1c21hbm4gIDxzaW1vbi5oYXVzbWFubkBub2tpYS5jb20+CiAKICAgICAg ICAgVW5yZXZpZXdlZCBicm93bi1wYXBlciBiYWcgYnVpbGQgZml4LgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9xdC90ZXN0cy9xd2VicGFnZS90c3RfcXdlYnBhZ2UuY3BwIGIvU291cmNlL1dl YktpdC9xdC90ZXN0cy9xd2VicGFnZS90c3RfcXdlYnBhZ2UuY3BwCmluZGV4IGIzZmYzYjljMTk3 ODc1M2JlNzA1NWQ2YjI2MTBhNzQ2OWMzYzhlOGYuLmMwZjdiYjkyMGNjYjBjNDA4YmQyNzdlZGE4 YzkwNDRmOTMyMWU5ZTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvdGVzdHMvcXdlYnBh Z2UvdHN0X3F3ZWJwYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJwYWdl L3RzdF9xd2VicGFnZS5jcHAKQEAgLTE2MCw3ICsxNjAsOSBAQCBwcml2YXRlIHNsb3RzOgogICAg IHZvaWQgdGVzdFN0b3BTY2hlZHVsZWRQYWdlUmVmcmVzaCgpOwogICAgIHZvaWQgZmluZFRleHQo KTsKICAgICB2b2lkIHN1cHBvcnRlZENvbnRlbnRUeXBlKCk7Ci0gICAgdm9pZCBpbmZpbml0ZUxv b3BKUygpOworICAgIC8vIFtRdF0gdHN0X1FXZWJQYWdlOjppbmZpbml0ZUxvb3BKUygpIHRpbWVv dXRzIHdpdGggREZHIEpJVAorICAgIC8vIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD03OTA0MAorICAgIC8vIHZvaWQgaW5maW5pdGVMb29wSlMoKTsKICAgICB2b2lkIG5h dmlnYXRvckNvb2tpZUVuYWJsZWQoKTsKICAgICB2b2lkIGRlbGV0ZVFXZWJWaWV3VHdpY2UoKTsK ICAgICB2b2lkIHJlbmRlck9uUmVwYWludFJlcXVlc3RlZFNob3VsZE5vdFJlY3Vyc2UoKTsKQEAg LTI4NCw2ICsyODYsOSBAQCBwcml2YXRlOgogICAgIGJvb2wgbV9hbGxvd0dlb2xvY2F0aW9uOwog fTsKIAorLy8gW1F0XSB0c3RfUVdlYlBhZ2U6OmluZmluaXRlTG9vcEpTKCkgdGltZW91dHMgd2l0 aCBERkcgSklUCisvLyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzkw NDAKKy8qCiB2b2lkIHRzdF9RV2ViUGFnZTo6aW5maW5pdGVMb29wSlMoKQogewogICAgIEpTVGVz dFBhZ2UqIG5ld1BhZ2UgPSBuZXcgSlNUZXN0UGFnZShtX3ZpZXcpOwpAQCAtMjkyLDYgKzI5Nyw3 IEBAIHZvaWQgdHN0X1FXZWJQYWdlOjppbmZpbml0ZUxvb3BKUygpCiAgICAgbV92aWV3LT5wYWdl KCktPm1haW5GcmFtZSgpLT5ldmFsdWF0ZUphdmFTY3JpcHQoInZhciBydW4gPSB0cnVlO3ZhciBh ID0gMTt3aGlsZShydW4pe2ErKzt9Iik7CiAgICAgZGVsZXRlIG5ld1BhZ2U7CiB9CisqLwogCiB2 b2lkIHRzdF9RV2ViUGFnZTo6Z2VvbG9jYXRpb25SZXF1ZXN0SlMoKQogewo= 166022 2012-09-27 09:36:51 -0700 2012-09-27 09:36:51 -0700 Proposed patch dfg-jit-no-changelog.patch text/plain 7376 gaborb ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQnl0ZUNvZGVQYXJzZXIu Y3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdCeXRlQ29kZVBhcnNlci5jcHAKaW5k ZXggMDg4ZTI4ZS4uZjkwYzhkYyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Rm Zy9ERkdCeXRlQ29kZVBhcnNlci5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9E RkdCeXRlQ29kZVBhcnNlci5jcHAKQEAgLTI4NTgsMTAgKzI4NTgsNyBAQCBib29sIEJ5dGVDb2Rl UGFyc2VyOjpwYXJzZUJsb2NrKHVuc2lnbmVkIGxpbWl0KQogICAgICAgICAgICAgaWYgKCFtX2lu bGluZVN0YWNrVG9wLT5tX2NhbGxlcikKICAgICAgICAgICAgICAgICBtX2N1cnJlbnRCbG9jay0+ aXNPU1JUYXJnZXQgPSB0cnVlOwogICAgICAgICAgICAgCi0gICAgICAgICAgICAvLyBFbWl0IGEg cGhhbnRvbSBub2RlIHRvIGVuc3VyZSB0aGF0IHRoZXJlIGlzIGEgcGxhY2Vob2xkZXIgbm9kZSBm b3IgdGhpcyBieXRlY29kZQotICAgICAgICAgICAgLy8gb3AuCi0gICAgICAgICAgICBhZGRUb0dy YXBoKFBoYW50b20pOwotICAgICAgICAgICAgCisgICAgICAgICAgICBhZGRUb0dyYXBoKExvb3BI aW50KTsKICAgICAgICAgICAgIE5FWFRfT1BDT0RFKG9wX2xvb3BfaGludCk7CiAgICAgICAgIH0K ICAgICAgICAgICAgIApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdO b2RlVHlwZS5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdOb2RlVHlwZS5oCmluZGV4 IDljOTNhOGIuLjM5OWRhYTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcv REZHTm9kZVR5cGUuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR05vZGVUeXBl LmgKQEAgLTIzMyw2ICsyMzMsNyBAQCBuYW1lc3BhY2UgSlNDIHsgbmFtZXNwYWNlIERGRyB7CiAg ICAgbWFjcm8oUmV0dXJuLCBOb2RlTXVzdEdlbmVyYXRlKSBcCiAgICAgbWFjcm8oVGhyb3csIE5v ZGVNdXN0R2VuZXJhdGUpIFwKICAgICBtYWNybyhUaHJvd1JlZmVyZW5jZUVycm9yLCBOb2RlTXVz dEdlbmVyYXRlKSBcCisgICAgbWFjcm8oTG9vcEhpbnQsIE5vZGVNdXN0R2VuZXJhdGUpIFwKICAg ICBcCiAgICAgLyogVGhpcyBpcyBhIHBzZXVkby10ZXJtaW5hbC4gSXQgbWVhbnMgdGhhdCBleGVj dXRpb24gc2hvdWxkIGZhbGwgb3V0IG9mIERGRyBhdCAqL1wKICAgICAvKiB0aGlzIHBvaW50LCBi dXQgZXhlY3V0aW9uIGRvZXMgY29udGludWUgaW4gdGhlIGJhc2ljIGJsb2NrIC0ganVzdCBpbiBh ICovXApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPcGVyYXRpb25z LmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT3BlcmF0aW9ucy5jcHAKaW5kZXgg ZWFhMGY0Ny4uNTgyYTg0YSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9E RkdPcGVyYXRpb25zLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09wZXJh dGlvbnMuY3BwCkBAIC0xMzc4LDYgKzEzNzgsMjAgQEAgc2l6ZV90IERGR19PUEVSQVRJT04gZGZn Q29udmVydEpTVmFsdWVUb0Jvb2xlYW4oRXhlY1N0YXRlKiBleGVjLCBFbmNvZGVkSlNWYWx1ZQog ICAgIHJldHVybiBKU1ZhbHVlOjpkZWNvZGUoZW5jb2RlZE9wKS50b0Jvb2xlYW4oZXhlYyk7CiB9 CiAKK3ZvaWQgREZHX09QRVJBVElPTiBvcGVyYXRpb25UaW1lb3V0KEV4ZWNTdGF0ZSogZXhlYykK K3sKKyAgICBKU0dsb2JhbERhdGEqIGdsb2JhbERhdGEgPSAmZXhlYy0+Z2xvYmFsRGF0YSgpOwor ICAgIFRpbWVvdXRDaGVja2VyJiB0aW1lb3V0Q2hlY2tlciA9IGdsb2JhbERhdGEtPnRpbWVvdXRD aGVja2VyOworCisgICAgaWYgKGdsb2JhbERhdGEtPnRlcm1pbmF0b3Iuc2hvdWxkVGVybWluYXRl KCkpIHsKKyAgICAgICAgZ2xvYmFsRGF0YS0+ZXhjZXB0aW9uID0gY3JlYXRlVGVybWluYXRlZEV4 ZWN1dGlvbkV4Y2VwdGlvbihnbG9iYWxEYXRhKTsKKyAgICB9IGVsc2UgaWYgKHRpbWVvdXRDaGVj a2VyLmRpZFRpbWVPdXQoZXhlYykpIHsKKyAgICAgICAgZ2xvYmFsRGF0YS0+ZXhjZXB0aW9uID0g Y3JlYXRlSW50ZXJydXB0ZWRFeGVjdXRpb25FeGNlcHRpb24oZ2xvYmFsRGF0YSk7CisgICAgfQor CisgICAgZ2xvYmFsRGF0YS0+bV90aW1lb3V0Q291bnQgPSB0aW1lb3V0Q2hlY2tlci50aWNrc1Vu dGlsTmV4dENoZWNrKCk7Cit9CisKICNpZiBERkdfRU5BQkxFKFZFUkJPU0VfU1BFQ1VMQVRJT05f RkFJTFVSRSkKIHZvaWQgREZHX09QRVJBVElPTiBkZWJ1Z09wZXJhdGlvblByaW50U3BlY3VsYXRp b25GYWlsdXJlKEV4ZWNTdGF0ZSogZXhlYywgdm9pZCogZGVidWdJbmZvUmF3KQogewpkaWZmIC0t Z2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPcGVyYXRpb25zLmggYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvZGZnL0RGR09wZXJhdGlvbnMuaAppbmRleCAzYjk0N2VjLi4yNzU3NzZh IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09wZXJhdGlvbnMuaAor KysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09wZXJhdGlvbnMuaApAQCAtOTYsNiAr OTYsNyBAQCB0eXBlZGVmIHNpemVfdCBERkdfT1BFUkFUSU9OICgqU19ERkdPcGVyYXRpb25fRUop KEV4ZWNTdGF0ZSosIEVuY29kZWRKU1ZhbHVlKTsKIHR5cGVkZWYgc2l6ZV90IERGR19PUEVSQVRJ T04gKCpTX0RGR09wZXJhdGlvbl9FSkopKEV4ZWNTdGF0ZSosIEVuY29kZWRKU1ZhbHVlLCBFbmNv ZGVkSlNWYWx1ZSk7CiB0eXBlZGVmIHNpemVfdCBERkdfT1BFUkFUSU9OICgqU19ERkdPcGVyYXRp b25fSikoRW5jb2RlZEpTVmFsdWUpOwogdHlwZWRlZiB2b2lkIERGR19PUEVSQVRJT04gKCpWX0RG R09wZXJhdGlvbl9FT1pKKShFeGVjU3RhdGUqLCBKU09iamVjdCosIGludDMyX3QsIEVuY29kZWRK U1ZhbHVlKTsKK3R5cGVkZWYgdm9pZCBERkdfT1BFUkFUSU9OICgqVl9ERkdPcGVyYXRpb25fRSko RXhlY1N0YXRlKik7CiB0eXBlZGVmIHZvaWQgREZHX09QRVJBVElPTiAoKlZfREZHT3BlcmF0aW9u X0VDKShFeGVjU3RhdGUqLCBKU0NlbGwqKTsKIHR5cGVkZWYgdm9pZCBERkdfT1BFUkFUSU9OICgq Vl9ERkdPcGVyYXRpb25fRUNJY2YpKEV4ZWNTdGF0ZSosIEpTQ2VsbCosIElubGluZUNhbGxGcmFt ZSopOwogdHlwZWRlZiB2b2lkIERGR19PUEVSQVRJT04gKCpWX0RGR09wZXJhdGlvbl9FQ0NJY2Yp KEV4ZWNTdGF0ZSosIEpTQ2VsbCosIEpTQ2VsbCosIElubGluZUNhbGxGcmFtZSopOwpAQCAtMTkz LDYgKzE5NCw3IEBAIGNoYXIqIERGR19PUEVSQVRJT04gb3BlcmF0aW9uQWxsb2NhdGVQcm9wZXJ0 eVN0b3JhZ2UoRXhlY1N0YXRlKiwgc2l6ZV90IG5ld1NpemUpCiBjaGFyKiBERkdfT1BFUkFUSU9O IG9wZXJhdGlvblJlYWxsb2NhdGVCdXR0ZXJmbHlUb0hhdmVQcm9wZXJ0eVN0b3JhZ2VXaXRoSW5p dGlhbENhcGFjaXR5KEV4ZWNTdGF0ZSosIEpTT2JqZWN0KikgV1RGX0lOVEVSTkFMOwogY2hhciog REZHX09QRVJBVElPTiBvcGVyYXRpb25SZWFsbG9jYXRlQnV0dGVyZmx5VG9Hcm93UHJvcGVydHlT dG9yYWdlKEV4ZWNTdGF0ZSosIEpTT2JqZWN0Kiwgc2l6ZV90IG5ld1NpemUpIFdURl9JTlRFUk5B TDsKIGNoYXIqIERGR19PUEVSQVRJT04gb3BlcmF0aW9uRW5zdXJlQXJyYXlTdG9yYWdlKEV4ZWNT dGF0ZSosIEpTT2JqZWN0Kik7Cit2b2lkIERGR19PUEVSQVRJT04gb3BlcmF0aW9uVGltZW91dChF eGVjU3RhdGUqKSBXVEZfSU5URVJOQUw7CiAKIC8vIFRoaXMgbWV0aG9kIGlzIHVzZWQgdG8gbG9v a3VwIGFuIGV4Y2VwdGlvbiBoYW5kZXIsIGtleWVkIGJ5IGZhdWx0TG9jYXRpb24sIHdoaWNoIGlz CiAvLyB0aGUgcmV0dXJuIGxvY2F0aW9uIGZyb20gb25lIG9mIHRoZSBjYWxscyBvdXQgdG8gb25l IG9mIHRoZSBoZWxwZXIgb3BlcmF0aW9ucyBhYm92ZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVC5jcHAKaW5kZXggMDViMWU3NC4uMmM1OGNlMyAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVC5jcHAK KysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVC5jcHAKQEAg LTI5NSw2ICsyOTUsMTggQEAgY29uc3QgVHlwZWRBcnJheURlc2NyaXB0b3IqIFNwZWN1bGF0aXZl SklUOjp0eXBlZEFycmF5RGVzY3JpcHRvcihBcnJheTo6TW9kZSBhcnIKICAgICB9CiB9CiAKK3Zv aWQgU3BlY3VsYXRpdmVKSVQ6OmNoZWNrTG9vcFRpbWVvdXQoKQoreworICAgIEdQUlRlbXBvcmFy eSByZXN1bHQodGhpcyk7CisgICAgR1BSUmVnIHJlc3VsdEdQUiA9IHJlc3VsdC5ncHIoKTsKKyAg ICBKSVRDb21waWxlcjo6SnVtcCBza2lwVGltZW91dCA9IG1faml0LmJyYW5jaFN1YjMyKE1hY3Jv QXNzZW1ibGVyOjpaZXJvLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgVHJ1c3RlZEltbTMyKDEpLAorICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgSklUQ29tcGlsZXI6OkFic29sdXRlQWRkcmVz cygmKG1faml0Lmdsb2JhbERhdGEoKS0+bV90aW1lb3V0Q291bnQpKSk7CisgICAgYWRkU2xvd1Bh dGhHZW5lcmF0b3IoCisgICAgICAgIHNsb3dQYXRoQ2FsbCgKKyAgICAgICAgICAgIHNraXBUaW1l b3V0LCB0aGlzLCBvcGVyYXRpb25UaW1lb3V0LCByZXN1bHRHUFIpKTsKK30KKwogdm9pZCBTcGVj dWxhdGl2ZUpJVDo6Y2hlY2tBcnJheShOb2RlJiBub2RlKQogewogICAgIEFTU0VSVChtb2RlSXNT cGVjaWZpYyhub2RlLmFycmF5TW9kZSgpKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZn L0RGR1NwZWN1bGF0aXZlSklULmgKaW5kZXggMTUzMTRiMi4uMGU5ZmU3NSAxMDA2NDQKLS0tIGEv U291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVC5oCisrKyBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuaApAQCAtMTE1MSw2ICsxMTUx LDEyIEBAIHB1YmxpYzoKICAgICAvLyBtYWNoaW5lIHJlZ2lzdGVycywgYW5kIGRlbGVnYXRlIHRo ZSBjYWxsaW5nIGNvbnZlbnRpb24gc3BlY2lmaWMKICAgICAvLyBkZWNpc2lvbiBhcyB0byBob3cg dG8gZmlsbCB0aGUgcmVnc2l0ZXJzIHRvIHNldHVwQXJndW1lbnRzKiBtZXRob2RzLgogI2lmIFVT RShKU1ZBTFVFNjQpCisKKyAgICBKSVRDb21waWxlcjo6Q2FsbCBjYWxsT3BlcmF0aW9uKFZfREZH T3BlcmF0aW9uX0Ugb3BlcmF0aW9uLCBHUFJSZWcgcmVzdWx0KQorICAgIHsKKyAgICAgICAgbV9q aXQuc2V0dXBBcmd1bWVudHNFeGVjU3RhdGUoKTsKKyAgICAgICAgcmV0dXJuIGFwcGVuZENhbGxX aXRoRXhjZXB0aW9uQ2hlY2tTZXRSZXN1bHQob3BlcmF0aW9uLCByZXN1bHQpOworICAgIH0KICAg ICBKSVRDb21waWxlcjo6Q2FsbCBjYWxsT3BlcmF0aW9uKFBfREZHT3BlcmF0aW9uX0Ugb3BlcmF0 aW9uLCBHUFJSZWcgcmVzdWx0KQogICAgIHsKICAgICAgICAgbV9qaXQuc2V0dXBBcmd1bWVudHNF eGVjU3RhdGUoKTsKQEAgLTE0NTMsNiArMTQ1OSwxMSBAQCBwdWJsaWM6CiAjZGVmaW5lIEVBQklf MzJCSVRfRFVNTVlfQVJHCiAjZW5kaWYKIAorICAgIEpJVENvbXBpbGVyOjpDYWxsIGNhbGxPcGVy YXRpb24oVl9ERkdPcGVyYXRpb25fRSBvcGVyYXRpb24sIEdQUlJlZyByZXN1bHQpCisgICAgewor ICAgICAgICBtX2ppdC5zZXR1cEFyZ3VtZW50c0V4ZWNTdGF0ZSgpOworICAgICAgICByZXR1cm4g YXBwZW5kQ2FsbFdpdGhFeGNlcHRpb25DaGVja1NldFJlc3VsdChvcGVyYXRpb24sIHJlc3VsdCk7 CisgICAgfQogICAgIEpJVENvbXBpbGVyOjpDYWxsIGNhbGxPcGVyYXRpb24oUF9ERkdPcGVyYXRp b25fRSBvcGVyYXRpb24sIEdQUlJlZyByZXN1bHQpCiAgICAgewogICAgICAgICBtX2ppdC5zZXR1 cEFyZ3VtZW50c0V4ZWNTdGF0ZSgpOwpAQCAtMjI2Nyw2ICsyMjc4LDggQEAgcHVibGljOgogICAg IHZvaWQgY2hlY2tBcnJheShOb2RlJik7CiAgICAgdm9pZCBhcnJheWlmeShOb2RlJik7CiAgICAg CisgICAgdm9pZCBjaGVja0xvb3BUaW1lb3V0KCk7CisKICAgICB0ZW1wbGF0ZTxib29sIHN0cmlj dD4KICAgICBHUFJSZWcgZmlsbFNwZWN1bGF0ZUludEludGVybmFsKE5vZGVJbmRleCwgRGF0YUZv cm1hdCYgcmV0dXJuRm9ybWF0KTsKICAgICAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQzMl82NC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvZGZnL0RGR1NwZWN1bGF0aXZlSklUMzJfNjQuY3BwCmluZGV4IDcwNzA5YjUuLjc4NjIyNGQg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQz Ml82NC5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJ VDMyXzY0LmNwcApAQCAtNDQxMiw2ICs0NDEyLDExIEBAIHZvaWQgU3BlY3VsYXRpdmVKSVQ6OmNv bXBpbGUoTm9kZSYgbm9kZSkKICAgICAgICAgYnJlYWs7CiAgICAgfQogCisgICAgY2FzZSBMb29w SGludDogeworICAgICAgICBjaGVja0xvb3BUaW1lb3V0KCk7CisgICAgICAgIGJyZWFrOworICAg IH0KKwogICAgIGNhc2UgUGhhbnRvbToKICAgICAgICAgLy8gVGhpcyBpcyBhIG5vLW9wLgogICAg ICAgICBub1Jlc3VsdChtX2NvbXBpbGVJbmRleCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklUNjQuY3BwIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVDY0LmNwcAppbmRleCBkN2NlYzI3Li43ZmRjNmI0IDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklUNjQu Y3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQ2NC5j cHAKQEAgLTQzNDUsNiArNDM0NSwxMSBAQCB2b2lkIFNwZWN1bGF0aXZlSklUOjpjb21waWxlKE5v ZGUmIG5vZGUpCiAgICAgICAgIGJyZWFrOwogICAgIH0KIAorICAgIGNhc2UgTG9vcEhpbnQ6IHsK KyAgICAgICAgY2hlY2tMb29wVGltZW91dCgpOworICAgICAgICBicmVhazsKKyAgICB9CisKICAg ICBjYXNlIFBoYW50b206CiAgICAgICAgIC8vIFRoaXMgaXMgYSBuby1vcC4KICAgICAgICAgbm9S ZXN1bHQobV9jb21waWxlSW5kZXgpOwo=