79005 2012-02-19 19:19:37 -0800 [CMAKE] Check gstreamer minimum required version 2012-02-19 23:42:20 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 79006 1 gyuyoung.kim gyuyoung.kim dbates paroga webkit.review.bot oldest_to_newest 559986 0 gyuyoung.kim 2012-02-19 19:19:37 -0800 To enable video requires over 0.10.30 version of GStreamer. This patch checks whether GStreamer version is over 0.10.30. 559994 1 127751 gyuyoung.kim 2012-02-19 20:26:38 -0800 Created attachment 127751 Patch 559999 2 gyuyoung.kim 2012-02-19 20:37:54 -0800 CC'ing Daniel and Patrick 560037 3 127751 dbates 2012-02-19 22:40:43 -0800 Comment on attachment 127751 Patch OK 560040 4 127751 dbates 2012-02-19 22:46:10 -0800 Comment on attachment 127751 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127751&action=review > Source/cmake/FindGStreamer-App.cmake:15 > +libfind_pkg_check_modules(GStreamer-App_PKGCONF gstreamer-app-0.10>=0.10.30) I'm assuming this syntax actually works. 560051 5 gyuyoung.kim 2012-02-19 23:07:50 -0800 (In reply to comment #4) > (From update of attachment 127751 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=127751&action=review > > > Source/cmake/FindGStreamer-App.cmake:15 > > +libfind_pkg_check_modules(GStreamer-App_PKGCONF gstreamer-app-0.10>=0.10.30) > > I'm assuming this syntax actually works. Yes, this work. I verified on my linux box. 560052 6 gyuyoung.kim 2012-02-19 23:09:02 -0800 Daniel, could you review Bug 79006 as well ? 560060 7 127751 webkit.review.bot 2012-02-19 23:42:14 -0800 Comment on attachment 127751 Patch Clearing flags on attachment: 127751 Committed r108211: <http://trac.webkit.org/changeset/108211> 560061 8 webkit.review.bot 2012-02-19 23:42:20 -0800 All reviewed patches have been landed. Closing bug. 127751 2012-02-19 20:26:38 -0800 2012-02-19 23:42:14 -0800 Patch bug-79005-20120220132640.patch text/plain 5435 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4MjAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvRmlu ZEdTdHJlYW1lci1BcHAuY21ha2UgYi9Tb3VyY2UvY21ha2UvRmluZEdTdHJlYW1lci1BcHAuY21h a2UKaW5kZXggMGI3Y2U5YmFkNGJhMDE0Yjc3NWM0NTU3YzVhNWY2Y2MyNzBhZmQzYS4uZjg2NWY0 NDNhYTNkYjExZDc5MjM5NDljODZhMTI5MjhjY2NkYTFkOSAxMDA2NDQKLS0tIGEvU291cmNlL2Nt YWtlL0ZpbmRHU3RyZWFtZXItQXBwLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9GaW5kR1N0cmVh bWVyLUFwcC5jbWFrZQpAQCAtMTIsNyArMTIsNyBAQCBsaWJmaW5kX3BhY2thZ2UoR1N0cmVhbWVy LUFwcCBHU3RyZWFtZXIpCiBsaWJmaW5kX3BhY2thZ2UoR1N0cmVhbWVyLUFwcCBHU3RyZWFtZXIt QmFzZSkKIAogIyBVc2UgcGtnLWNvbmZpZyB0byBnZXQgaGludHMgYWJvdXQgcGF0aHMKLWxpYmZp bmRfcGtnX2NoZWNrX21vZHVsZXMoR1N0cmVhbWVyLUFwcF9QS0dDT05GIGdzdHJlYW1lci1hcHAt MC4xMCkKK2xpYmZpbmRfcGtnX2NoZWNrX21vZHVsZXMoR1N0cmVhbWVyLUFwcF9QS0dDT05GIGdz dHJlYW1lci1hcHAtMC4xMD49MC4xMC4zMCkKIAogIyBJbmNsdWRlIGRpcgogZmluZF9wYXRoKEdT dHJlYW1lci1BcHBfSU5DTFVERV9ESVIKZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9GaW5kR1N0 cmVhbWVyLUJhc2UuY21ha2UgYi9Tb3VyY2UvY21ha2UvRmluZEdTdHJlYW1lci1CYXNlLmNtYWtl CmluZGV4IGQ0NjgxYTlhMTYwZDhkNDIwMTliYjg5MTVhYzVlODJiZjBjMGU5NGYuLjRlMDRiMGNh ZTM4NWViZWRkM2M1NzViNWMwZWIzMjIwNTEyYTMwOTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFr ZS9GaW5kR1N0cmVhbWVyLUJhc2UuY21ha2UKKysrIGIvU291cmNlL2NtYWtlL0ZpbmRHU3RyZWFt ZXItQmFzZS5jbWFrZQpAQCAtMTEsNyArMTEsNyBAQCBpbmNsdWRlKExpYkZpbmRNYWNyb3MpCiBs aWJmaW5kX3BhY2thZ2UoR1N0cmVhbWVyLUJhc2UgR1N0cmVhbWVyKQogCiAjIFVzZSBwa2ctY29u ZmlnIHRvIGdldCBoaW50cyBhYm91dCBwYXRocwotbGliZmluZF9wa2dfY2hlY2tfbW9kdWxlcyhH U3RyZWFtZXItQmFzZV9QS0dDT05GIGdzdHJlYW1lci1iYXNlLTAuMTApCitsaWJmaW5kX3BrZ19j aGVja19tb2R1bGVzKEdTdHJlYW1lci1CYXNlX1BLR0NPTkYgZ3N0cmVhbWVyLWJhc2UtMC4xMD49 MC4xMC4zMCkKIAogIyBJbmNsdWRlIGRpcgogZmluZF9wYXRoKEdTdHJlYW1lci1CYXNlX0lOQ0xV REVfRElSCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvRmluZEdTdHJlYW1lci1JbnRlcmZhY2Vz LmNtYWtlIGIvU291cmNlL2NtYWtlL0ZpbmRHU3RyZWFtZXItSW50ZXJmYWNlcy5jbWFrZQppbmRl eCAxYzdlM2U3M2Y3ODUwYjMwMjExNzRkMTFjNzU5YjkwMjQ5OWEzOTQ2Li43OTU5YzY2NzgxMmEz YWY4ZjZmM2I4YzRmMTRlNWRiYWMzYTg3NDY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvRmlu ZEdTdHJlYW1lci1JbnRlcmZhY2VzLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9GaW5kR1N0cmVh bWVyLUludGVyZmFjZXMuY21ha2UKQEAgLTExLDcgKzExLDcgQEAgaW5jbHVkZShMaWJGaW5kTWFj cm9zKQogbGliZmluZF9wYWNrYWdlKEdTdHJlYW1lci1JbnRlcmZhY2VzIEdTdHJlYW1lcikKIAog IyBVc2UgcGtnLWNvbmZpZyB0byBnZXQgaGludHMgYWJvdXQgcGF0aHMKLWxpYmZpbmRfcGtnX2No ZWNrX21vZHVsZXMoR1N0cmVhbWVyLUludGVyZmFjZXNfUEtHQ09ORiBnc3RyZWFtZXItaW50ZXJm YWNlcy0wLjEwKQorbGliZmluZF9wa2dfY2hlY2tfbW9kdWxlcyhHU3RyZWFtZXItSW50ZXJmYWNl c19QS0dDT05GIGdzdHJlYW1lci1pbnRlcmZhY2VzLTAuMTA+PTAuMTAuMzApCiAKICMgSW5jbHVk ZSBkaXIKIGZpbmRfcGF0aChHU3RyZWFtZXItSW50ZXJmYWNlc19JTkNMVURFX0RJUgpkaWZmIC0t Z2l0IGEvU291cmNlL2NtYWtlL0ZpbmRHU3RyZWFtZXItUGJ1dGlscy5jbWFrZSBiL1NvdXJjZS9j bWFrZS9GaW5kR1N0cmVhbWVyLVBidXRpbHMuY21ha2UKaW5kZXggMTIwODA3NzRkYmQwYWJlYmE3 YWQ5ODYxODAxM2E3MzAxZWJiN2Y1Yi4uYTEyNDZjOGQzOTVlZThlZTQyNDVmNjE2MzcxMGM5MGU0 MGYxMGRlZCAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL0ZpbmRHU3RyZWFtZXItUGJ1dGlscy5j bWFrZQorKysgYi9Tb3VyY2UvY21ha2UvRmluZEdTdHJlYW1lci1QYnV0aWxzLmNtYWtlCkBAIC0x MSw3ICsxMSw3IEBAIGluY2x1ZGUoTGliRmluZE1hY3JvcykKIGxpYmZpbmRfcGFja2FnZShHU3Ry ZWFtZXItUGJ1dGlscyBHU3RyZWFtZXIpCiAKICMgVXNlIHBrZy1jb25maWcgdG8gZ2V0IGhpbnRz IGFib3V0IHBhdGhzCi1saWJmaW5kX3BrZ19jaGVja19tb2R1bGVzKEdTdHJlYW1lci1QYnV0aWxz X1BLR0NPTkYgZ3N0cmVhbWVyLXBidXRpbHMtMC4xMCkKK2xpYmZpbmRfcGtnX2NoZWNrX21vZHVs ZXMoR1N0cmVhbWVyLVBidXRpbHNfUEtHQ09ORiBnc3RyZWFtZXItcGJ1dGlscy0wLjEwPj0wLjEw LjMwKQogCiAjIEluY2x1ZGUgZGlyCiBmaW5kX3BhdGgoR1N0cmVhbWVyLVBidXRpbHNfSU5DTFVE RV9ESVIKZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9GaW5kR1N0cmVhbWVyLVBsdWdpbnMtQmFz ZS5jbWFrZSBiL1NvdXJjZS9jbWFrZS9GaW5kR1N0cmVhbWVyLVBsdWdpbnMtQmFzZS5jbWFrZQpp bmRleCBlNGM3N2JlOTQ3ZTZmZWU1NzRiMDRiYzZlZTBhZWFkMWMzY2M3Mjc3Li5lZTQxYmI5MzVk MGU2ZjE1MzMxMjYyNmY1OWFkZWY4ODE1NzIxYmZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2Uv RmluZEdTdHJlYW1lci1QbHVnaW5zLUJhc2UuY21ha2UKKysrIGIvU291cmNlL2NtYWtlL0ZpbmRH U3RyZWFtZXItUGx1Z2lucy1CYXNlLmNtYWtlCkBAIC0xMSw3ICsxMSw3IEBAIGluY2x1ZGUoTGli RmluZE1hY3JvcykKIGxpYmZpbmRfcGFja2FnZShHU3RyZWFtZXItUGx1Z2lucy1CYXNlIEdTdHJl YW1lcikKIAogIyBVc2UgcGtnLWNvbmZpZyB0byBnZXQgaGludHMgYWJvdXQgcGF0aHMKLWxpYmZp bmRfcGtnX2NoZWNrX21vZHVsZXMoR1N0cmVhbWVyLVBsdWdpbnMtQmFzZV9QS0dDT05GIGdzdHJl YW1lci1wbHVnaW5zLWJhc2UtMC4xMCkKK2xpYmZpbmRfcGtnX2NoZWNrX21vZHVsZXMoR1N0cmVh bWVyLVBsdWdpbnMtQmFzZV9QS0dDT05GIGdzdHJlYW1lci1wbHVnaW5zLWJhc2UtMC4xMD49MC4x MC4zMCkKIAogIyBJbmNsdWRlIGRpcgogZmluZF9wYXRoKEdTdHJlYW1lci1QbHVnaW5zLUJhc2Vf SU5DTFVERV9ESVIKZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9GaW5kR1N0cmVhbWVyLVZpZGVv LmNtYWtlIGIvU291cmNlL2NtYWtlL0ZpbmRHU3RyZWFtZXItVmlkZW8uY21ha2UKaW5kZXggYjEy MjhmNjJkNWQ4ZmE0NjJhZWExMmUxYTUxNTI0NzI5NmMzMjUxOC4uNjQ3NDhkMjZlMDA0MTFmNWQx MWJjYzUzZGQ2MDliMzNkYTdhYmY3ZCAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL0ZpbmRHU3Ry ZWFtZXItVmlkZW8uY21ha2UKKysrIGIvU291cmNlL2NtYWtlL0ZpbmRHU3RyZWFtZXItVmlkZW8u Y21ha2UKQEAgLTEyLDcgKzEyLDcgQEAgbGliZmluZF9wYWNrYWdlKEdTdHJlYW1lci1WaWRlbyBH U3RyZWFtZXIpCiBsaWJmaW5kX3BhY2thZ2UoR1N0cmVhbWVyLVZpZGVvIEdTdHJlYW1lci1CYXNl KQogCiAjIFVzZSBwa2ctY29uZmlnIHRvIGdldCBoaW50cyBhYm91dCBwYXRocwotbGliZmluZF9w a2dfY2hlY2tfbW9kdWxlcyhHU3RyZWFtZXItVmlkZW9fUEtHQ09ORiBnc3RyZWFtZXItdmlkZW8t MC4xMCkKK2xpYmZpbmRfcGtnX2NoZWNrX21vZHVsZXMoR1N0cmVhbWVyLVZpZGVvX1BLR0NPTkYg Z3N0cmVhbWVyLXZpZGVvLTAuMTA+PTAuMTAuMzApCiAKICMgSW5jbHVkZSBkaXIKIGZpbmRfcGF0 aChHU3RyZWFtZXItVmlkZW9fSU5DTFVERV9ESVIKZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9G aW5kR1N0cmVhbWVyLmNtYWtlIGIvU291cmNlL2NtYWtlL0ZpbmRHU3RyZWFtZXIuY21ha2UKaW5k ZXggN2ZlODM2NDk3NDIyYWY4YTU2YTk4ZTQ2ZjBkZTBmMTY4NGNjMmZlMy4uZGJmZTQ1YjI3N2Vi ZjVkOWY5ZjlkZDA2ODRlZTNhNzNmOWI3ZGQzOSAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL0Zp bmRHU3RyZWFtZXIuY21ha2UKKysrIGIvU291cmNlL2NtYWtlL0ZpbmRHU3RyZWFtZXIuY21ha2UK QEAgLTgsNyArOCw3IEBACiBpbmNsdWRlKExpYkZpbmRNYWNyb3MpCiAKICMgVXNlIHBrZy1jb25m aWcgdG8gZ2V0IGhpbnRzIGFib3V0IHBhdGhzCi1saWJmaW5kX3BrZ19jaGVja19tb2R1bGVzKEdT dHJlYW1lcl9QS0dDT05GIGdzdHJlYW1lci0wLjEwKQorbGliZmluZF9wa2dfY2hlY2tfbW9kdWxl cyhHU3RyZWFtZXJfUEtHQ09ORiBnc3RyZWFtZXItMC4xMD49MC4xMC4zMCkKIAogIyBJbmNsdWRl IGRpcgogZmluZF9wYXRoKEdTdHJlYW1lcl9JTkNMVURFX0RJUgpkaWZmIC0tZ2l0IGEvQ2hhbmdl TG9nIGIvQ2hhbmdlTG9nCmluZGV4IDhiNjEyMmE3ZDBkN2VkMTQyOWZhMGY5ZDlhNjI2NzRlNGZh YzlhMWUuLmQ5MDk3YmY4OWE5NWMwMTgwNDNkZjExZWFjMTcxYzIzYTFkNjVhNTUgMTAwNjQ0Ci0t LSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMi0wMi0x OSAgR3l1eW91bmcgS2ltICA8Z3l1eW91bmcua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtD TUFLRV0gQ2hlY2sgZ3N0cmVhbWVyIG1pbmltdW0gcmVxdWlyZWQgdmVyc2lvbi4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc5MDA1CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVG8gZW5hYmxlIHZpZGVvLCBH c3RyZWFtZXIgdmVyc2lvbiByZXF1aXJlcyB0byBiZSBhYm92ZSAwLjEwLjMwLgorICAgICAgICBU aGlzIHBhdGNoIGNoZWNrcyB3aGV0aGVyIEdzdHJlYW1lciB2ZXJzaW9uIGlzIGdyZWF0ZXIgdGhh biAwLjEwLjMwLgorCisgICAgICAgICogU291cmNlL2NtYWtlL0ZpbmRHU3RyZWFtZXItQXBwLmNt YWtlOgorICAgICAgICAqIFNvdXJjZS9jbWFrZS9GaW5kR1N0cmVhbWVyLUJhc2UuY21ha2U6Cisg ICAgICAgICogU291cmNlL2NtYWtlL0ZpbmRHU3RyZWFtZXItSW50ZXJmYWNlcy5jbWFrZToKKyAg ICAgICAgKiBTb3VyY2UvY21ha2UvRmluZEdTdHJlYW1lci1QYnV0aWxzLmNtYWtlOgorICAgICAg ICAqIFNvdXJjZS9jbWFrZS9GaW5kR1N0cmVhbWVyLVBsdWdpbnMtQmFzZS5jbWFrZToKKyAgICAg ICAgKiBTb3VyY2UvY21ha2UvRmluZEdTdHJlYW1lci1WaWRlby5jbWFrZToKKyAgICAgICAgKiBT b3VyY2UvY21ha2UvRmluZEdTdHJlYW1lci5jbWFrZToKKwogMjAxMi0wMi0xOSAgR3VzdGF2byBO b3JvbmhhIFNpbHZhICA8Z25zQGdub21lLm9yZz4KIAogICAgICAgICBbR1RLXSBSZW1vdmUgdW51 c2VkIEdTZXR0aW5ncyBzdHVmZgo=