79000 2012-02-19 13:44:00 -0800 webkitpy: update names after deleting message_broker 2012-02-21 11:41:01 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 78997 78999 78187 1 dpranke dpranke abarth eric tony oldest_to_newest 559943 0 dpranke 2012-02-19 13:44:00 -0800 webkitpy: update names after deleting message_broker 559944 1 127741 dpranke 2012-02-19 13:45:43 -0800 Created attachment 127741 Patch 559970 2 127741 eric 2012-02-19 17:44:12 -0800 Comment on attachment 127741 Patch These classes are now private to the file? If so, r=me. 561087 3 dpranke 2012-02-21 11:35:21 -0800 (In reply to comment #2) > (From update of attachment 127741 [details]) > These classes are now private to the file? If so, r=me. Yes, exactly. 561091 4 dpranke 2012-02-21 11:41:01 -0800 Committed r108379: <http://trac.webkit.org/changeset/108379> 127741 2012-02-19 13:45:43 -0800 2012-02-19 17:44:12 -0800 Patch bug-79000-20120219134545.patch text/plain 6008 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4MTgyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOWI3MTc2MDE3YWIwM2QwNjFlNDNjNGY5YmExMmNkYzlh OTIyMGFhNS4uZWUyNTU5YWE4NzkzMTk4ZmMzZmY4YjMyZWViZGZjNDc4ZWE2MzFjZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI3 IEBACiAyMDEyLTAyLTE5ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCisg ICAgICAgIHdlYmtpdHB5OiB1cGRhdGUgbmFtZXMgYWZ0ZXIgZGVsZXRpbmcgbWVzc2FnZV9icm9r ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc5MDAw CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUGFydCAz IG9mIDMgaW4gZGVsZXRpbmcgbWVzc2FnZV9icm9rZXIucHk7IHRoaXMgY2hhbmdlIGp1c3QKKyAg ICAgICAgYWRqdXN0cyB0aGUgbmFtZXMgZm9yIHRoZSBuZXdseSBtZXJnZWQgc3ltYm9scyBzbyB0 aGF0IHRoZXkgYXJlCisgICAgICAgIHByaXZhdGUgYXMgYXBwcm9wcmlhdGUuCisKKyAgICAgICAg KiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVycy9tYW5hZ2VyX3dvcmtl cl9icm9rZXIucHk6CisgICAgICAgIChnZXQpOgorICAgICAgICAoX0Jyb2tlcik6CisgICAgICAg IChfQnJva2VyQ29ubmVjdGlvbik6CisgICAgICAgIChfQnJva2VyQ29ubmVjdGlvbi5fX2luaXRf Xyk6CisgICAgICAgIChBYnN0cmFjdFdvcmtlci5fX2luaXRfXyk6CisgICAgICAgIChfTWFuYWdl ckNvbm5lY3Rpb24pOgorICAgICAgICAoX01hbmFnZXJDb25uZWN0aW9uLl9faW5pdF9fKToKKyAg ICAgICAgKF9Xb3JrZXJDb25uZWN0aW9uKToKKyAgICAgICAgKF9Xb3JrZXJDb25uZWN0aW9uLl9f aW5pdF9fKToKKworMjAxMi0wMi0xOSAgRGlyayBQcmFua2UgIDxkcHJhbmtlQGNocm9taXVtLm9y Zz4KKwogICAgICAgICB3ZWJraXRweTogbWVyZ2UgbWVzc2FnZV9icm9rZXIucHkgaW50byBtYW5h Z2VyX3dvcmtlcl9icm9rZXIucHkKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTc4OTk5CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv bGF5b3V0X3Rlc3RzL2NvbnRyb2xsZXJzL21hbmFnZXJfd29ya2VyX2Jyb2tlci5weSBiL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2NvbnRyb2xsZXJzL21hbmFnZXJfd29ya2Vy X2Jyb2tlci5weQppbmRleCBkMWE4MmQ0Mjk1ZjI5YmUyZTJhMGI4NDI1MDdlN2JkOTg1ODllMjk3 Li43MGM0M2E2ZDQxNWQzNDA2NWIxNGE3M2UzZTFkZWY3ODFmZmEyM2ZmIDEwMDc1NQotLS0gYS9U b29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVycy9tYW5hZ2VyX3dv cmtlcl9icm9rZXIucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMv Y29udHJvbGxlcnMvbWFuYWdlcl93b3JrZXJfYnJva2VyLnB5CkBAIC01MCwxOCArNTAsMTggQEAg TWVzc2FnZXMgbXVzdCBiZSBwaWNrbGFibGUuCiAKIFRoZSBtb2R1bGUgZGVmaW5lcyBvbmUgaW50 ZXJmYWNlIGFuZCB0d28gY2xhc3Nlcy4gQ2FsbGVycyBvZiB0aGlzIHBhY2thZ2UKIG11c3QgaW1w bGVtZW50IHRoZSBCcm9rZXJDbGllbnQgaW50ZXJmYWNlLCBhbmQgbW9zdCBjYWxsZXJzIHdpbGwg Y3JlYXRlCi1Ccm9rZXJDb25uZWN0aW9ucyBhcyB3ZWxsIGFzIEJyb2tlcnMuCitfQnJva2VyQ29u bmVjdGlvbnMgYXMgd2VsbCBhcyBCcm9rZXJzLgogCiBUaGUgY2xhc3NlcyByZWxhdGUgdG8gZWFj aCBvdGhlciBhczoKIAotICAgIEJyb2tlckNsaWVudCAgIC0tLS0tLT4gICAgQnJva2VyQ29ubmVj dGlvbgorICAgIEJyb2tlckNsaWVudCAgIC0tLS0tLT4gICAgX0Jyb2tlckNvbm5lY3Rpb24KICAg ICAgICAgIF4gICAgICAgICAgICAgICAgICAgICAgICAgfAogICAgICAgICAgfCAgICAgICAgICAg ICAgICAgICAgICAgICB2Ci0gICAgICAgICBcLS0tLS0tLS0tLS0tLS0tLSAgICAgIEJyb2tlcgor ICAgICAgICAgXC0tLS0tLS0tLS0tLS0tLS0gICAgICBfQnJva2VyCiAKIChUaGUgQnJva2VyQ2xp ZW50IG5ldmVyIGNhbGxzIGJyb2tlciBkaXJlY3RseSBhZnRlciBpdCBpcyBjcmVhdGVkLCBvbmx5 Ci1Ccm9rZXJDb25uZWN0aW9uLiAgQnJva2VyQ29ubmVjdGlvbiBwYXNzZXMgYSByZWZlcmVuY2Ug dG8gQnJva2VyQ2xpZW50IHRvCi1Ccm9rZXIsIGFuZCBCcm9rZXIgb25seSBpbnZva2VzIHRoYXQg cmVmZXJlbmNlLCBuZXZlciB0YWxraW5nIGRpcmVjdGx5IHRvCitfQnJva2VyQ29ubmVjdGlvbi4g IF9Ccm9rZXJDb25uZWN0aW9uIHBhc3NlcyBhIHJlZmVyZW5jZSB0byBCcm9rZXJDbGllbnQgdG8K K19Ccm9rZXIsIGFuZCBfQnJva2VyIG9ubHkgaW52b2tlcyB0aGF0IHJlZmVyZW5jZSwgbmV2ZXIg dGFsa2luZyBkaXJlY3RseSB0bwogQnJva2VyQ29ubmVjdGlvbikuCiAiIiIKIApAQCAtMTA4LDcg KzEwOCw3IEBAIGRlZiBnZXQod29ya2VyX21vZGVsLCBjbGllbnQsIHdvcmtlcl9jbGFzcyk6CiAg ICAgZWxzZToKICAgICAgICAgcmFpc2UgVmFsdWVFcnJvcigidW5zdXBwb3J0ZWQgdmFsdWUgZm9y IC0td29ya2VyLW1vZGVsOiAlcyIgJSB3b3JrZXJfbW9kZWwpCiAKLSAgICBicm9rZXIgPSBCcm9r ZXIocXVldWVfY2xhc3MpCisgICAgYnJva2VyID0gX0Jyb2tlcihxdWV1ZV9jbGFzcykKICAgICBy ZXR1cm4gbWFuYWdlcl9jbGFzcyhicm9rZXIsIGNsaWVudCwgd29ya2VyX2NsYXNzKQogCiAKQEAg LTEzMiw3ICsxMzIsNyBAQCBjbGFzcyBCcm9rZXJDbGllbnQob2JqZWN0KToKICAgICAgICAgcmFp c2UgTm90SW1wbGVtZW50ZWRFcnJvcgogCiAKLWNsYXNzIEJyb2tlcihvYmplY3QpOgorY2xhc3Mg X0Jyb2tlcihvYmplY3QpOgogICAgICIiIkJyb2tlcnMgcHJvdmlkZSB0aGUgYmFzaWMgbW9kZWwg b2YgYSBzZXQgb2YgdG9waWNzLiBDbGllbnRzIGNhbiBwb3N0IGEKICAgICBtZXNzYWdlIHRvIGFu eSB0b3BpYyB1c2luZyBwb3N0X21lc3NhZ2UoKSwgYW5kIGNhbiBwcm9jZXNzIG1lc3NhZ2VzIG9u IG9uZQogICAgIHRvcGljIGF0IGEgdGltZSB1c2luZyBydW5fbWVzc2FnZV9sb29wKCkuIiIiCkBA IC0yMTIsMTUgKzIxMiwxNSBAQCBjbGFzcyBfTWVzc2FnZShvYmplY3QpOgogICAgICAgICAgICAg ICAgIChzZWxmLnNyYywgc2VsZi50b3BpY19uYW1lLCBzZWxmLm5hbWUpKQogCiAKLWNsYXNzIEJy b2tlckNvbm5lY3Rpb24ob2JqZWN0KToKLSAgICAiIiJCcm9rZXJDb25uZWN0aW9uIHByb3ZpZGVz IGEgY29ubmVjdGlvbi1vcmllbnRlZCBmYWNhZGUgb24gdG9wIG9mIGEKK2NsYXNzIF9Ccm9rZXJD b25uZWN0aW9uKG9iamVjdCk6CisgICAgIiIiX0Jyb2tlckNvbm5lY3Rpb24gcHJvdmlkZXMgYSBj b25uZWN0aW9uLW9yaWVudGVkIGZhY2FkZSBvbiB0b3Agb2YgYQogICAgIEJyb2tlciwgc28gdGhh dCBjYWxsZXJzIGRvbid0IGhhdmUgdG8gcmVwZWF0ZWRseSBwYXNzIHRoZSBzYW1lIHRvcGljCiAg ICAgbmFtZXMgb3ZlciBhbmQgb3Zlci4iIiIKIAogICAgIGRlZiBfX2luaXRfXyhzZWxmLCBicm9r ZXIsIGNsaWVudCwgcnVuX3RvcGljLCBwb3N0X3RvcGljKToKLSAgICAgICAgIiIiQ3JlYXRlIGEg QnJva2VyQ29ubmVjdGlvbiBvbiB0b3Agb2YgYSBCcm9rZXIuIE5vdGUgdGhhdCB0aGUgQnJva2Vy Ci0gICAgICAgIGlzIHBhc3NlZCBpbiByYXRoZXIgdGhhbiBjcmVhdGVkIHNvIHRoYXQgYSBzaW5n bGUgQnJva2VyIGNhbiBiZSB1c2VkCi0gICAgICAgIGJ5IG11bHRpcGxlIEJyb2tlckNvbm5lY3Rp b25zLiIiIgorICAgICAgICAiIiJDcmVhdGUgYSBfQnJva2VyQ29ubmVjdGlvbiBvbiB0b3Agb2Yg YSBfQnJva2VyLiBOb3RlIHRoYXQgdGhlIF9Ccm9rZXIKKyAgICAgICAgaXMgcGFzc2VkIGluIHJh dGhlciB0aGFuIGNyZWF0ZWQgc28gdGhhdCBhIHNpbmdsZSBfQnJva2VyIGNhbiBiZSB1c2VkCisg ICAgICAgIGJ5IG11bHRpcGxlIF9Ccm9rZXJDb25uZWN0aW9ucy4iIiIKICAgICAgICAgc2VsZi5f YnJva2VyID0gYnJva2VyCiAgICAgICAgIHNlbGYuX2NsaWVudCA9IGNsaWVudAogICAgICAgICBz ZWxmLl9wb3N0X3RvcGljID0gcG9zdF90b3BpYwpAQCAtMjUyLDcgKzI1Miw3IEBAIGNsYXNzIEFi c3RyYWN0V29ya2VyKEJyb2tlckNsaWVudCk6CiAgICAgICAgIHN0YXJ0IG9mIHRoZSBydW4oKSBj YWxsLgogCiAgICAgICAgIEFyZ3M6Ci0gICAgICAgICAgICB3b3JrZXJfY29ubmVjdGlvbiAtIGhh bmRsZSB0byB0aGUgQnJva2VyQ29ubmVjdGlvbiBvYmplY3QgY3JlYXRpbmcKKyAgICAgICAgICAg IHdvcmtlcl9jb25uZWN0aW9uIC0gaGFuZGxlIHRvIHRoZSBfQnJva2VyQ29ubmVjdGlvbiBvYmpl Y3QgY3JlYXRpbmcKICAgICAgICAgICAgICAgICB0aGUgd29ya2VyIGFuZCB0aGF0IGNhbiBiZSB1 c2VkIGZvciBtZXNzYWdpbmcuCiAgICAgICAgICAgICB3b3JrZXJfYXJndW1lbnRzIC0gKG9wdGlv bmFsLCBQaWNrbGFibGUpIG9iamVjdCBwYXNzZWQgdG8gdGhlIHdvcmtlciBmcm9tIHRoZSBtYW5h Z2VyIiIiCiAgICAgICAgIEJyb2tlckNsaWVudC5fX2luaXRfXyhzZWxmKQpAQCAtMjk3LDcgKzI5 Nyw3IEBAIGNsYXNzIEFic3RyYWN0V29ya2VyKEJyb2tlckNsaWVudCk6CiAgICAgICAgIHNlbGYu X2NhbmNlbGVkID0gVHJ1ZQogCiAKLWNsYXNzIF9NYW5hZ2VyQ29ubmVjdGlvbihCcm9rZXJDb25u ZWN0aW9uKToKK2NsYXNzIF9NYW5hZ2VyQ29ubmVjdGlvbihfQnJva2VyQ29ubmVjdGlvbik6CiAg ICAgZGVmIF9faW5pdF9fKHNlbGYsIGJyb2tlciwgY2xpZW50LCB3b3JrZXJfY2xhc3MpOgogICAg ICAgICAiIiJCYXNlIGluaXRpYWxpemF0aW9uIGZvciBhbGwgTWFuYWdlciBvYmplY3RzLgogCkBA IC0zMDYsNyArMzA2LDcgQEAgY2xhc3MgX01hbmFnZXJDb25uZWN0aW9uKEJyb2tlckNvbm5lY3Rp b24pOgogICAgICAgICAgICAgY2xpZW50OiBjYWxsYmFjayBvYmplY3QgKHRoZSBjYWxsZXIpCiAg ICAgICAgICAgICB3b3JrZXJfY2xhc3M6IGNsYXNzIG9iamVjdCB0byB1c2UgdG8gY3JlYXRlIHdv cmtlcnMuCiAgICAgICAgICIiIgotICAgICAgICBCcm9rZXJDb25uZWN0aW9uLl9faW5pdF9fKHNl bGYsIGJyb2tlciwgY2xpZW50LCBNQU5BR0VSX1RPUElDLCBBTllfV09SS0VSX1RPUElDKQorICAg ICAgICBfQnJva2VyQ29ubmVjdGlvbi5fX2luaXRfXyhzZWxmLCBicm9rZXIsIGNsaWVudCwgTUFO QUdFUl9UT1BJQywgQU5ZX1dPUktFUl9UT1BJQykKICAgICAgICAgc2VsZi5fd29ya2VyX2NsYXNz ID0gd29ya2VyX2NsYXNzCiAKICAgICBkZWYgc3RhcnRfd29ya2VyKHNlbGYsIHdvcmtlcl9hcmd1 bWVudHM9Tm9uZSk6CkBAIC0zNDksMTAgKzM0OSwxMCBAQCBjbGFzcyBfTXVsdGlQcm9jZXNzTWFu YWdlcihfTWFuYWdlckNvbm5lY3Rpb24pOgogICAgICAgICByZXR1cm4gd29ya2VyX2Nvbm5lY3Rp b24KIAogCi1jbGFzcyBfV29ya2VyQ29ubmVjdGlvbihCcm9rZXJDb25uZWN0aW9uKToKK2NsYXNz IF9Xb3JrZXJDb25uZWN0aW9uKF9Ccm9rZXJDb25uZWN0aW9uKToKICAgICBkZWYgX19pbml0X18o c2VsZiwgYnJva2VyLCB3b3JrZXJfY2xhc3MsIHdvcmtlcl9hcmd1bWVudHM9Tm9uZSk6CiAgICAg ICAgIHNlbGYuX2NsaWVudCA9IHdvcmtlcl9jbGFzcyhzZWxmLCB3b3JrZXJfYXJndW1lbnRzKQot ICAgICAgICBCcm9rZXJDb25uZWN0aW9uLl9faW5pdF9fKHNlbGYsIGJyb2tlciwgc2VsZi5fY2xp ZW50LCBBTllfV09SS0VSX1RPUElDLCBNQU5BR0VSX1RPUElDKQorICAgICAgICBfQnJva2VyQ29u bmVjdGlvbi5fX2luaXRfXyhzZWxmLCBicm9rZXIsIHNlbGYuX2NsaWVudCwgQU5ZX1dPUktFUl9U T1BJQywgTUFOQUdFUl9UT1BJQykKIAogICAgIGRlZiBuYW1lKHNlbGYpOgogICAgICAgICByZXR1 cm4gc2VsZi5fY2xpZW50Lm5hbWUoKQo=