78996 2012-02-19 09:54:22 -0800 Fails to build on platforms where UChar is wchar_t 2012-02-19 11:16:54 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 kalevlember webkit-unassigned webkit.review.bot oldest_to_newest 559906 0 kalevlember 2012-02-19 09:54:22 -0800 The ICU backend defines UChar as wchar_t on win32. Source/WebCore/platform/gtk/GtkPopupMenu.cpp: In member function 'bool WebCore::GtkPopupMenu::typeAheadFind(GdkEventKey*)': Source/WebCore/platform/gtk/GtkPopupMenu.cpp:181:77: error: invalid static_cast from type 'short unsigned int*' to type 'UChar* {aka wchar_t*}' Source/WebCore/platform/gtk/GtkPopupMenu.cpp:183:82: error: invalid static_cast from type 'short unsigned int*' to type 'UChar* {aka wchar_t*}' make[1]: *** [Source/WebCore/platform/gtk/libWebCoreGtk_la-GtkPopupMenu.lo] Error 1 559907 1 127734 kalevlember 2012-02-19 09:56:45 -0800 Created attachment 127734 Patch 559920 2 127734 webkit.review.bot 2012-02-19 11:16:46 -0800 Comment on attachment 127734 Patch Clearing flags on attachment: 127734 Committed r108191: <http://trac.webkit.org/changeset/108191> 559921 3 webkit.review.bot 2012-02-19 11:16:54 -0800 All reviewed patches have been landed. Closing bug. 127734 2012-02-19 09:56:45 -0800 2012-02-19 11:16:46 -0800 Patch webkitgtk-icu-cast.patch text/plain 2558 kalevlember ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmMTc0YTE3Li4yYmViOTYzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTItMDItMTkgIEthbGV2IExlbWJlciAgPGthbGV2bGVtYmVyQGdtYWlsLmNvbT4KKwor ICAgICAgICBbR1RLXSBGaXggYnVpbGQgb24gcGxhdGZvcm1zIHdoZXJlIFVDaGFyIGlzIHdjaGFy X3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc4OTk2 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIElD VSBiYWNrZW5kIGRlZmluZXMgVUNoYXIgYXMgd2NoYXJfdCBmb3IgcGxhdGZvcm1zIHdoZXJlIHdj aGFyX3QgaXMKKyAgICAgICAgMTYgYml0cyB3aWRlLCBlLmcuIHdpbjMyLgorCisgICAgICAgICog cGxhdGZvcm0vZ3JhcGhpY3MvcGFuZ28vRm9udFBhbmdvLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OnV0ZjE2VG9VdGY4KTogVXNlIHJlaW50ZXJwcmV0X2Nhc3QgaW5zdGVhZCBvZiBzdGF0aWNfY2Fz dC4KKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvR3RrUG9wdXBNZW51LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6Okd0a1BvcHVwTWVudTo6dHlwZUFoZWFkRmluZCk6IERpdHRvLgorCiAyMDEyLTAyLTE3 ICBEYXZpZCBSZXZlbWFuICA8cmV2ZW1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW0Nocm9t aXVtXSBUZXh0dXJlIGV2aWN0aW9uIGRvZXNuJ3Qgc2hvdyB1cCBpbiB0cmFjZXMuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9wYW5nby9Gb250UGFuZ28uY3Bw IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcGFuZ28vRm9udFBhbmdvLmNwcApp bmRleCAyNjg0ZjUzLi4wYzYwYzc2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvcGFuZ28vRm9udFBhbmdvLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9wYW5nby9Gb250UGFuZ28uY3BwCkBAIC0xMzYsNyArMTM2LDcgQEAgc3Rh dGljIGdjaGFyKiB1dGYxNlRvVXRmOChjb25zdCBVQ2hhciogYVRleHQsIGdpbnQgYUxlbmd0aCwg Z2ludCAmbGVuZ3RoKQogCiAgICAgZ2NoYXIqIHV0ZjhUZXh0OwogICAgIGdsb25nIGl0ZW1zV3Jp dHRlbjsKLSAgICB1dGY4VGV4dCA9IGdfdXRmMTZfdG9fdXRmOChzdGF0aWNfY2FzdDxjb25zdCBn dW5pY2hhcjIqPihhVGV4dCksIGFMZW5ndGgsIDAsICZpdGVtc1dyaXR0ZW4sIDApOworICAgIHV0 ZjhUZXh0ID0gZ191dGYxNl90b191dGY4KHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgZ3VuaWNoYXIy Kj4oYVRleHQpLCBhTGVuZ3RoLCAwLCAmaXRlbXNXcml0dGVuLCAwKTsKICAgICBsZW5ndGggPSBp dGVtc1dyaXR0ZW47CiAKICAgICByZXR1cm4gdXRmOFRleHQ7CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ndGsvR3RrUG9wdXBNZW51LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2d0ay9HdGtQb3B1cE1lbnUuY3BwCmluZGV4IGI5MTEyZTkuLmZkN2M4NGMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9HdGtQb3B1cE1lbnUuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9HdGtQb3B1cE1lbnUuY3BwCkBAIC0xNzgsOSAr MTc4LDkgQEAgYm9vbCBHdGtQb3B1cE1lbnU6OnR5cGVBaGVhZEZpbmQoR2RrRXZlbnRLZXkqIGV2 ZW50KQogICAgIC8vIG1lbnVsaXN0cy4KICAgICBib29sIHJlcGVhdGluZ0NoYXJhY3RlciA9IHVu aWNvZGVDaGFyYWN0ZXIgIT0gbV9wcmV2aW91c0tleUV2ZW50Q2hhcmFjdGVyOwogICAgIGlmIChl dmVudC0+dGltZSAtIG1fcHJldmlvdXNLZXlFdmVudFRpbWVzdGFtcCA+IGdTZWFyY2hUaW1lb3V0 TXMpCi0gICAgICAgIG1fY3VycmVudFNlYXJjaFN0cmluZyA9IFN0cmluZyhzdGF0aWNfY2FzdDxV Q2hhcio+KHV0ZjE2U3RyaW5nLmdldCgpKSwgY2hhcmFjdGVyc1dyaXR0ZW4pOworICAgICAgICBt X2N1cnJlbnRTZWFyY2hTdHJpbmcgPSBTdHJpbmcocmVpbnRlcnByZXRfY2FzdDxVQ2hhcio+KHV0 ZjE2U3RyaW5nLmdldCgpKSwgY2hhcmFjdGVyc1dyaXR0ZW4pOwogICAgIGVsc2UgaWYgKHJlcGVh dGluZ0NoYXJhY3RlcikKLSAgICAgICAgbV9jdXJyZW50U2VhcmNoU3RyaW5nLmFwcGVuZChTdHJp bmcoc3RhdGljX2Nhc3Q8VUNoYXIqPih1dGYxNlN0cmluZy5nZXQoKSksIGNoYXJhY3RlcnNXcml0 dGVuKSk7CisgICAgICAgIG1fY3VycmVudFNlYXJjaFN0cmluZy5hcHBlbmQoU3RyaW5nKHJlaW50 ZXJwcmV0X2Nhc3Q8VUNoYXIqPih1dGYxNlN0cmluZy5nZXQoKSksIGNoYXJhY3RlcnNXcml0dGVu KSk7CiAKICAgICBtX3ByZXZpb3VzS2V5RXZlbnRUaW1lc3RhbXAgPSBldmVudC0+dGltZTsKICAg ICBtX3ByZXZpb3VzS2V5RXZlbnRDaGFyYWN0ZXIgPSB1bmljb2RlQ2hhcmFjdGVyOwo=