<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>78974</bug_id>
          
          <creation_ts>2012-02-18 13:38:55 -0800</creation_ts>
          <short_desc>Make WebCore compile with libc++</short_desc>
          <delta_ts>2012-02-18 17:09:06 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Sam Weinig">sam</reporter>
          <assigned_to name="Sam Weinig">sam</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>559820</commentid>
    <comment_count>0</comment_count>
    <who name="Sam Weinig">sam</who>
    <bug_when>2012-02-18 13:38:55 -0800</bug_when>
    <thetext>Make WebCore compile with libc++</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>559821</commentid>
    <comment_count>1</comment_count>
      <attachid>127714</attachid>
    <who name="Sam Weinig">sam</who>
    <bug_when>2012-02-18 13:41:03 -0800</bug_when>
    <thetext>Created attachment 127714
Part 1</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>559822</commentid>
    <comment_count>2</comment_count>
    <who name="Sam Weinig">sam</who>
    <bug_when>2012-02-18 13:42:14 -0800</bug_when>
    <thetext>When libc++ is updated to have we will have to predicate this fix on the libc++ version number.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>559824</commentid>
    <comment_count>3</comment_count>
    <who name="Sam Weinig">sam</who>
    <bug_when>2012-02-18 13:51:20 -0800</bug_when>
    <thetext>Part 2 will be to disable DisallowCType.h if using libc++, at least until we can figure out how to make that work.  We could be more conservative, since files affected are ones that include wtf/Complex.h.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>559833</commentid>
    <comment_count>4</comment_count>
    <who name="Sam Weinig">sam</who>
    <bug_when>2012-02-18 15:44:57 -0800</bug_when>
    <thetext>Committed r108174: &lt;http://trac.webkit.org/changeset/108174&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>559838</commentid>
    <comment_count>5</comment_count>
    <who name="Sam Weinig">sam</who>
    <bug_when>2012-02-18 16:50:15 -0800</bug_when>
    <thetext>(In reply to comment #3)
&gt; Part 2 will be to disable DisallowCType.h if using libc++, at least until we can figure out how to make that work.  We could be more conservative, since files affected are ones that include wtf/Complex.h.

One way we could be more conservative about this is to include &lt;wtf/Complex.h&gt; in the prefix header or config.h before we include DisallowCType.h.  This has the down side of including wtf/Complex.h everywhere, which transitively includes quite a bit.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>559841</commentid>
    <comment_count>6</comment_count>
      <attachid>127722</attachid>
    <who name="Sam Weinig">sam</who>
    <bug_when>2012-02-18 17:03:56 -0800</bug_when>
    <thetext>Created attachment 127722
Part 2</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>559842</commentid>
    <comment_count>7</comment_count>
    <who name="Sam Weinig">sam</who>
    <bug_when>2012-02-18 17:08:49 -0800</bug_when>
    <thetext>Committed r108179: &lt;http://trac.webkit.org/changeset/108179&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>127714</attachid>
            <date>2012-02-18 13:41:03 -0800</date>
            <delta_ts>2012-02-18 17:03:53 -0800</delta_ts>
            <desc>Part 1</desc>
            <filename>bug-78974-20120218134110.patch</filename>
            <type>text/plain</type>
            <size>1725</size>
            <attacher name="Sam Weinig">sam</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4MTY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjVlNjFmOGQwYmIzZGQ4
MDcwOWY1YjNhOTBjNWYwZmUxZGFkY2E2Ny4uNjg0OTVmOGQ1ZmFlOWFiNzI4MjcyNGJkNzhkY2Y1
N2Y2YmVhMDVlYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAyLTE0ICBTYW0g
V2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CisKKyAgICAgICAgTWFrZSBXZWJDb3JlIGNvbXBpbGUg
d2l0aCBsaWJjKysgKFBhcnQgMSkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTc4OTc0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku
CisKKyAgICAgICAgQWRkIGEgd29ya2Fyb3VuZCBmb3IgPHJkYXI6Ly9wcm9ibGVtLzEwODU4MTEy
Piwgd2hpY2ggY2F1c2UgdGhlIHN0YW5kYXJkIGhlYXAgZnVuY3Rpb25zCisgICAgICAgIG5vdCB0
byB3b3JrIHdoZW4gdXNpbmcgYW4gaXRlcmF0b3Igd2l0aCBwcm94eSBvYmplY3RzIGZvciByZWZl
cmVuY2UgYW5kIHBvaW50ZXIgdHlwZXMuCisKKyAgICAgICAgKiBXZWJDb3JlUHJlZml4Lmg6Cisg
ICAgICAgIChtb3ZlKToKKyAgICAgICAgQWRkIGFuIG92ZXJsb2FkIG9mIHN0ZDo6bW92ZSB0aGF0
IHRoZSBoZWFwIGZ1bmN0aW9ucyBjYW4gY2FsbCBzdWNjZXNzZnVsbHkuCisKIDIwMTItMDItMTgg
IFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBGaXggdGhlIEVOQUJMRShU
SFJFQURFRF9TQ1JPTExJTkcpIGJ1aWxkLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvV2Vi
Q29yZVByZWZpeC5oIGIvU291cmNlL1dlYkNvcmUvV2ViQ29yZVByZWZpeC5oCmluZGV4IDUxOGI3
YjkxMDgzNTAwMGQ4MzI3ZDFkMTk5OTViMGI4NjM2YTQ2MzkuLjE0MmM2YWJmYzExZGNmNGZmZDlj
MmI1NTk3MDI4Y2E2ZTMzNzAxODMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmVQ
cmVmaXguaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlUHJlZml4LmgKQEAgLTg5LDYgKzg5
LDM0IEBACiAKICNpZmRlZiBfX2NwbHVzcGx1cwogCisKKyNpbmNsdWRlIDxjaXNvNjQ2PgorCisj
aWYgZGVmaW5lZChfTElCQ1BQX1ZFUlNJT04pCisKKy8vIEFkZCB3b3JrIGFyb3VuZCBmb3IgYSBi
dWcgaW4gbGliYysrIHRoYXQgY2F1c2VkIHN0YW5kYXJkIGhlYXAKKy8vIEFQSXMgdG8gbm90IGNv
bXBpbGUgPHJkYXI6Ly9wcm9ibGVtLzEwODU4MTEyPi4KKworI2luY2x1ZGUgPHR5cGVfdHJhaXRz
PgorCitfTElCQ1BQX0JFR0lOX05BTUVTUEFDRV9TVEQKKwordGVtcGxhdGUgPGNsYXNzIF9UcD4K
K2lubGluZSBfTElCQ1BQX0lOTElORV9WSVNJQklMSVRZCit0eXBlbmFtZSBlbmFibGVfaWYKKzwK
KyAgICAhaXNfY29udmVydGlibGU8X1RwLCBfX3J2PF9UcD4gPjo6dmFsdWUsCisgICAgY29uc3Qg
X1RwJgorPjo6dHlwZQorbW92ZShjb25zdCBfVHAmIF9fdCkKK3sKKyAgICByZXR1cm4gX190Owor
fQorCitfTElCQ1BQX0VORF9OQU1FU1BBQ0VfU1RECisKKyNlbmRpZiAvLyBkZWZpbmVkKF9MSUJD
UFBfVkVSU0lPTikKKwogI2luY2x1ZGUgPGFsZ29yaXRobT4KICNpbmNsdWRlIDxjc3RkZGVmPgog
I2luY2x1ZGUgPG5ldz4K
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>127722</attachid>
            <date>2012-02-18 17:03:56 -0800</date>
            <delta_ts>2012-02-18 17:05:46 -0800</delta_ts>
            <desc>Part 2</desc>
            <filename>bug-78974-20120218170354.patch</filename>
            <type>text/plain</type>
            <size>1349</size>
            <attacher name="Sam Weinig">sam</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwODE3OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAyLTE4ICBTYW0gV2Vp
bmlnICA8c2FtQHdlYmtpdC5vcmc+CisKKyAgICAgICAgTWFrZSBXZWJDb3JlIGNvbXBpbGUgd2l0
aCBsaWJjKysgKFBhcnQgMikKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i
dWcuY2dpP2lkPTc4OTc0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK
KyAgICAgICAgKiBjb25maWcuaDoKKyAgICAgICAgRGlzYWJsZSB0aGUgRGlzYWxsb3dDVHlwZSBj
aGVjayB3aGVuIHVzaW5nIGxpYmMrKy4KKwogMjAxMi0wMi0xOCAgU2FtIFdlaW5pZyAgPHNhbUB3
ZWJraXQub3JnPgogCiAgICAgICAgIEZpeCB0aGUgYnVpbGQuCkluZGV4OiBTb3VyY2UvV2ViQ29y
ZS9jb25maWcuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9jb25maWcuaAkocmV2aXNp
b24gMTA4MTc3KQorKysgU291cmNlL1dlYkNvcmUvY29uZmlnLmgJKHdvcmtpbmcgY29weSkKQEAg
LTc3LDYgKzc3LDggQEAKICN1bmRlZiBkZWxldGUKICNpbmNsdWRlIDx3dGYvRmFzdE1hbGxvYy5o
PgogCisjaW5jbHVkZSA8Y2lzbzY0Nj4KKwogI2VuZGlmCiAKIC8vIE9uIE1TVywgd3ggaGVhZGVy
cyBuZWVkIHRvIGJlIGluY2x1ZGVkIGJlZm9yZSB3aW5kb3dzLmggaXMuCkBAIC05MCw3ICs5Miw3
IEBACiAvLyBhcmUgdXNlZCBmcm9tIHd4IGhlYWRlcnMuIE9uIEdUSysgZm9yIE1hYyBtYW55IEdU
SysgZmlsZXMgaW5jbHVkZSA8bGliaW50bC5oPgogLy8gb3IgPGdsaWIvZ2kxOG4tbGliLmg+LCB3
aGljaCBpbiB0dXJuIGluY2x1ZGUgPHhsb2NhbGUvX2N0eXBlLmg+IHdoaWNoIHVzZXMKIC8vIGlz
YWNpaSgpLiAKLSNpZiAhUExBVEZPUk0oUVQpICYmICFQTEFURk9STShXWCkgJiYgIVBMQVRGT1JN
KENIUk9NSVVNKSAmJiAhKE9TKERBUldJTikgJiYgUExBVEZPUk0oR1RLKSkKKyNpZiAhUExBVEZP
Uk0oUVQpICYmICFQTEFURk9STShXWCkgJiYgIVBMQVRGT1JNKENIUk9NSVVNKSAmJiAhKE9TKERB
UldJTikgJiYgUExBVEZPUk0oR1RLKSkgJiYgIWRlZmluZWQoX0xJQkNQUF9WRVJTSU9OKQogI2lu
Y2x1ZGUgPHd0Zi9EaXNhbGxvd0NUeXBlLmg+CiAjZW5kaWYKIAo=
</data>
<flag name="review"
          id="129924"
          type_id="1"
          status="+"
          setter="andersca"
    />
          </attachment>
      

    </bug>

</bugzilla>