<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>78971</bug_id>
          
          <creation_ts>2012-02-18 12:52:08 -0800</creation_ts>
          <short_desc>Default canvas backing store to be 1:1 with specified dimensions.</short_desc>
          <delta_ts>2012-02-22 09:36:07 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>66687</blocked>
    
    <blocked>78973</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="John Knottenbelt">jknotten</reporter>
          <assigned_to name="John Knottenbelt">jknotten</assigned_to>
          <cc>abarth</cc>
    
    <cc>ap</cc>
    
    <cc>efidler</cc>
    
    <cc>eoconnor</cc>
    
    <cc>eric</cc>
    
    <cc>mdelaney7</cc>
    
    <cc>sam</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>559812</commentid>
    <comment_count>0</comment_count>
    <who name="John Knottenbelt">jknotten</who>
    <bug_when>2012-02-18 12:52:08 -0800</bug_when>
    <thetext>Introduce WebCore Setting for Canvas Backing Store</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>559815</commentid>
    <comment_count>1</comment_count>
      <attachid>127711</attachid>
    <who name="John Knottenbelt">jknotten</who>
    <bug_when>2012-02-18 13:00:56 -0800</bug_when>
    <thetext>Created attachment 127711
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>559846</commentid>
    <comment_count>2</comment_count>
    <who name="Sam Weinig">sam</who>
    <bug_when>2012-02-18 17:30:51 -0800</bug_when>
    <thetext>I am not clear on how an embedder would make this decision or why they would want anything but the default.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>559903</commentid>
    <comment_count>3</comment_count>
    <who name="John Knottenbelt">jknotten</who>
    <bug_when>2012-02-19 08:40:52 -0800</bug_when>
    <thetext>Right now, using a backing store larger than 1:1 has issues, at least on the Chromium port, which are captured at https://bugs.webkit.org/show_bug.cgi?id=73645 . On the desktop, the deviceScaleFactor is 1 anyway, so we don&apos;t see these issues. However, on a high-dpi mobile system the deviceScaleFactor can be 2, which is where these issues would be seen. 

iOS 5.0 WebKit hard codes the backing store to be 1:1, perhaps for the same reasons. See the initialisation of m_pageScaleFactor to 1 in the constructor of HTMLCanvasElement.cpp http://opensource.apple.com/source/WebCore/WebCore-1298/html/HTMLCanvasElement.cpp

Fixing the issues relating to high-dpi is a longer term project, so in the mean time it is desirable to be able to have a correctly functioning canvas (according to the spec and tests). 

Another aspect of this is that many web developers typically do not expect a difference between backing store and specified canvas dimensions, despite the spec allowing this. When converting the canvas to a data url, for example, many developers expect that the size of the image will be according to the canvas dimensions, rather than the backing store dimensions (See https://www.w3.org/Bugs/Public/show_bug.cgi?id=15041 )</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>559933</commentid>
    <comment_count>4</comment_count>
    <who name="Sam Weinig">sam</who>
    <bug_when>2012-02-19 12:57:08 -0800</bug_when>
    <thetext>(In reply to comment #3)
&gt; Right now, using a backing store larger than 1:1 has issues, at least on the Chromium port, which are captured at https://bugs.webkit.org/show_bug.cgi?id=73645 . On the desktop, the deviceScaleFactor is 1 anyway, so we don&apos;t see these issues. However, on a high-dpi mobile system the deviceScaleFactor can be 2, which is where these issues would be seen. 
&gt; 
&gt; iOS 5.0 WebKit hard codes the backing store to be 1:1, perhaps for the same reasons. See the initialisation of m_pageScaleFactor to 1 in the constructor of HTMLCanvasElement.cpp http://opensource.apple.com/source/WebCore/WebCore-1298/html/HTMLCanvasElement.cpp
&gt; 
&gt; Fixing the issues relating to high-dpi is a longer term project, so in the mean time it is desirable to be able to have a correctly functioning canvas (according to the spec and tests). 
&gt; 
&gt; Another aspect of this is that many web developers typically do not expect a difference between backing store and specified canvas dimensions, despite the spec allowing this. When converting the canvas to a data url, for example, many developers expect that the size of the image will be according to the canvas dimensions, rather than the backing store dimensions (See https://www.w3.org/Bugs/Public/show_bug.cgi?id=15041 )

Ok, so on what port would you want non 1:1?  This change seems to only create the possibility for more incompatibilities between different ports of WebKit which should be avoided.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>559934</commentid>
    <comment_count>5</comment_count>
    <who name="John Knottenbelt">jknotten</who>
    <bug_when>2012-02-19 12:59:52 -0800</bug_when>
    <thetext>I think that for now, probably all ports should use 1:1, however, it would be helpful for the fixing of 73645 if there was an easy way to switch back to the &apos;high-dpi&apos; backing canvas. 

It sounds like a WebCore setting may not be the best way to do this. Would a ENABLE(HIGH_DPI_CANVAS) option be better here, do you think?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>559936</commentid>
    <comment_count>6</comment_count>
    <who name="Sam Weinig">sam</who>
    <bug_when>2012-02-19 13:20:23 -0800</bug_when>
    <thetext>(In reply to comment #5)
&gt; I think that for now, probably all ports should use 1:1, however, it would be helpful for the fixing of 73645 if there was an easy way to switch back to the &apos;high-dpi&apos; backing canvas. 
&gt; 
&gt; It sounds like a WebCore setting may not be the best way to do this. Would a ENABLE(HIGH_DPI_CANVAS) option be better here, do you think?

Yes.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>559950</commentid>
    <comment_count>7</comment_count>
      <attachid>127742</attachid>
    <who name="John Knottenbelt">jknotten</who>
    <bug_when>2012-02-19 14:25:08 -0800</bug_when>
    <thetext>Created attachment 127742
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>560565</commentid>
    <comment_count>8</comment_count>
      <attachid>127742</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-02-20 19:48:46 -0800</bug_when>
    <thetext>Comment on attachment 127742
Patch

Clearing flags on attachment: 127742

Committed r108293: &lt;http://trac.webkit.org/changeset/108293&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>560566</commentid>
    <comment_count>9</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-02-20 19:48:51 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>127711</attachid>
            <date>2012-02-18 13:00:56 -0800</date>
            <delta_ts>2012-02-19 14:25:05 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-78971-20120218130055.patch</filename>
            <type>text/plain</type>
            <size>5307</size>
            <attacher name="John Knottenbelt">jknotten</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4MTY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWJkYzA1ODc3MDlhMjU2
OTcxMTAxOGU5Yzg3ZmEyZjdkN2MwMWIxMS4uODAwMjJkNDkyNTUzODhhNjU0OWE5NDQ3MTQyZjll
MGNlMzIzZjM0YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM5IEBACisyMDEyLTAyLTE4ICBKb2hu
IEtub3R0ZW5iZWx0ICA8amtub3R0ZW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIEludHJvZHVj
ZSBXZWJDb3JlIFNldHRpbmcgZm9yIENhbnZhcyBCYWNraW5nIFN0b3JlCisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03ODk3MQorCisgICAgICAgIFJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENhbnZhcywgYnkgZGVmYXVsdCwgdXNl
cyB0aGUgZGV2aWNlU2NhbGVGYWN0b3IgdG8gc2NhbGUgdGhlIHNpemUKKyAgICAgICAgb2YgdGhl
IGJhY2tpbmcgaW1hZ2UuIFRvIGRhdGUsIHRoaXMgZGV2aWNlU2NhbGVGYWN0b3IgaGFzIGJlZW4g
MS4wCisgICAgICAgIGluIFdlYktpdCwgYnV0IHJlY2VudGx5LCB3aXRoIHRoZSBhZGRpdGlvbiBv
ZiBWSUVXUE9SVCBzdXBwb3J0LCBpdAorICAgICAgICBpcyBwb3NzaWJsZSBmb3IgdGhlIHNjYWxl
IGZhY3RvciB0byBiZSBhIHZhbHVlIG90aGVyIHRoYW4gMS4wLgorCisgICAgICAgIEFsdGhvdWdo
IHRoZSBjYW52YXMgc3BlY2lmaWNhdGlvbiBzdGF0ZXMgdGhhdCB0aGUgYmFja2luZyBpbWFnZQor
ICAgICAgICBtYXkgYmUgbGFyZ2VyLCB0aGVyZSBhcmUgYSBudW1iZXIgb2YgcGhpbGlwIGNhbnZh
cyB0ZXN0cyB0aGF0IGZhaWwKKyAgICAgICAgd2hlbiB0aGUgYmFja2luZyBpbWFnZSBkYXRhIGlz
IG5vdCAxOjEgd2l0aCB0aGUgc3BlY2lmaWVkIGNhbnZhcworICAgICAgICBkaW1lbnNpb25zLiBU
aGVzZSBmYWlsdXJlcyBhcmUgdHJhY2tlZCBpbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0
Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzM2NDUKKworICAgICAgICBUaGlzIGNoYW5nZSBpbnRyb2R1
Y2VzIGEgV2ViQ29yZSBzZXR0aW5nIHRvIGFsbG93IHRoZSBlbWJlZGRlciB0bworICAgICAgICBj
b250cm9sIHdoZXRoZXIgQ2FudmFzIHNob3VsZCB1c2UgYSBiYWNraW5nIGltYWdlIGRlcGVuZGVu
dCBvbiB0aGUKKyAgICAgICAgZGV2aWNlU2NhbGVGYWN0b3IuCisKKyAgICAgICAgVGVzdHM6IEV4
aXN0aW5nIGNhbnZhcy9waGlsaXAvdGVzdHMuCisKKyAgICAgICAgKiBodG1sL0hUTUxDYW52YXNF
bGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmRldmljZVNjYWxlRmFjdG9yKToKKyAgICAg
ICAgKFdlYkNvcmUpOgorICAgICAgICAoV2ViQ29yZTo6SFRNTENhbnZhc0VsZW1lbnQ6OkhUTUxD
YW52YXNFbGVtZW50KToKKyAgICAgICAgKiBwYWdlL1NldHRpbmdzLmNwcDoKKyAgICAgICAgKFdl
YkNvcmU6OlNldHRpbmdzOjpTZXR0aW5ncyk6CisgICAgICAgIChXZWJDb3JlOjpTZXR0aW5nczo6
c2V0Q2FudmFzVXNlc0RldmljZVNjYWxlRmFjdG9yKToKKyAgICAgICAgKFdlYkNvcmUpOgorICAg
ICAgICAqIHBhZ2UvU2V0dGluZ3MuaDoKKyAgICAgICAgKFNldHRpbmdzKToKKyAgICAgICAgKFdl
YkNvcmU6OlNldHRpbmdzOjpjYW52YXNVc2VzRGV2aWNlU2NhbGVGYWN0b3IpOgorCiAyMDEyLTAy
LTE4ICBBbmRyZWFzIEtsaW5nICA8YXdlc29tZWtsaW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBI
VE1MOiBSZW1vdmUgdW5uZWNlc3NhcnkgYXR0cmlidXRlQ2hhbmdlKCkgb3ZlcnJpZGVzLgpkaWZm
IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5jcHAgYi9Tb3Vy
Y2UvV2ViQ29yZS9odG1sL0hUTUxDYW52YXNFbGVtZW50LmNwcAppbmRleCA1ZmFmMjk1NjU3OWY5
NDBiYzRlMTFmNDVjNDhhOWM5M2Y3NTA0NzI5Li4yNGYwOWRlMTdjNTk1MTg3ZjE2ZDBiMGY2Mjgx
ZTEyZjllN2JkMzE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxDYW52YXNF
bGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxDYW52YXNFbGVtZW50LmNw
cApAQCAtNzQsMTIgKzc0LDI1IEBAIHN0YXRpYyBjb25zdCBmbG9hdCBNYXhDYW52YXNBcmVhID0g
MzI3NjggKiA4MTkyOyAvLyBNYXhpbXVtIGNhbnZhcyBhcmVhIGluIENTUyBwCiAvL0luIFNraWEs
IHdlIHdpbGwgYWxzbyBsaW1pdCB3aWR0aC9oZWlnaHQgdG8gMzI3NjcuCiBzdGF0aWMgY29uc3Qg
ZmxvYXQgTWF4U2tpYURpbSA9IDMyNzY3LjBGOyAvLyBNYXhpbXVtIHdpZHRoL2hlaWdodCBpbiBD
U1MgcGl4ZWxzLgogCitzdGF0aWMgZmxvYXQgZGV2aWNlU2NhbGVGYWN0b3IoRG9jdW1lbnQqIGRv
Y3VtZW50KQoreworICAgIEZyYW1lKiBmcmFtZSA9IGRvY3VtZW50LT5mcmFtZSgpOworICAgIGlm
ICghZnJhbWUpCisgICAgICAgIHJldHVybiAxOworCisgICAgU2V0dGluZ3MqIHNldHRpbmdzID0g
ZnJhbWUtPnNldHRpbmdzKCk7CisgICAgaWYgKCFzZXR0aW5ncyB8fCBzZXR0aW5ncy0+Y2FudmFz
VXNlc0RldmljZVNjYWxlRmFjdG9yKCkpCisgICAgICAgIHJldHVybiBmcmFtZS0+cGFnZSgpLT5k
ZXZpY2VTY2FsZUZhY3RvcigpOworCisgICAgcmV0dXJuIDE7Cit9CisKIEhUTUxDYW52YXNFbGVt
ZW50OjpIVE1MQ2FudmFzRWxlbWVudChjb25zdCBRdWFsaWZpZWROYW1lJiB0YWdOYW1lLCBEb2N1
bWVudCogZG9jdW1lbnQpCiAgICAgOiBIVE1MRWxlbWVudCh0YWdOYW1lLCBkb2N1bWVudCkKICAg
ICAsIG1fc2l6ZShEZWZhdWx0V2lkdGgsIERlZmF1bHRIZWlnaHQpCiAgICAgLCBtX3JlbmRlcmVy
SXNDYW52YXMoZmFsc2UpCiAgICAgLCBtX2lnbm9yZVJlc2V0KGZhbHNlKQotICAgICwgbV9kZXZp
Y2VTY2FsZUZhY3Rvcihkb2N1bWVudC0+ZnJhbWUoKSA/IGRvY3VtZW50LT5mcmFtZSgpLT5wYWdl
KCktPmRldmljZVNjYWxlRmFjdG9yKCkgOiAxKQorICAgICwgbV9kZXZpY2VTY2FsZUZhY3Rvcihk
ZXZpY2VTY2FsZUZhY3Rvcihkb2N1bWVudCkpCiAgICAgLCBtX29yaWdpbkNsZWFuKHRydWUpCiAg
ICAgLCBtX2hhc0NyZWF0ZWRJbWFnZUJ1ZmZlcihmYWxzZSkKIHsKZGlmZiAtLWdpdCBhL1NvdXJj
ZS9XZWJDb3JlL3BhZ2UvU2V0dGluZ3MuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9TZXR0aW5n
cy5jcHAKaW5kZXggNjRmOGUwNTg1NDRmODM2MDhlMWEyNjYyMzkxMTUwNWYwZGQzNjk0Yi4uMzY1
N2E4ODczNWE3ZjFhZmFmOWJmZjI4YjUwZWI3ZDI4YTRjNzQyMyAxMDA2NDQKLS0tIGEvU291cmNl
L1dlYkNvcmUvcGFnZS9TZXR0aW5ncy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9TZXR0
aW5ncy5jcHAKQEAgLTE3MCw2ICsxNzAsNyBAQCBTZXR0aW5nczo6U2V0dGluZ3MoUGFnZSogcGFn
ZSkKICAgICAsIG1fdXNlc0VuY29kaW5nRGV0ZWN0b3IoZmFsc2UpCiAgICAgLCBtX2FsbG93U2Ny
aXB0c1RvQ2xvc2VXaW5kb3dzKGZhbHNlKQogICAgICwgbV9jYW52YXNVc2VzQWNjZWxlcmF0ZWRE
cmF3aW5nKGZhbHNlKQorICAgICwgbV9jYW52YXNVc2VzRGV2aWNlU2NhbGVGYWN0b3IodHJ1ZSkK
ICAgICAsIG1fYWNjZWxlcmF0ZWREcmF3aW5nRW5hYmxlZChmYWxzZSkKICAgICAsIG1fYWNjZWxl
cmF0ZWRGaWx0ZXJzRW5hYmxlZChmYWxzZSkKICAgICAsIG1faXNDU1NDdXN0b21GaWx0ZXJFbmFi
bGVkKGZhbHNlKQpAQCAtNzQyLDYgKzc0MywxMSBAQCB2b2lkIFNldHRpbmdzOjpzZXRDYW52YXNV
c2VzQWNjZWxlcmF0ZWREcmF3aW5nKGJvb2wgZW5hYmxlZCkKICAgICBtX2NhbnZhc1VzZXNBY2Nl
bGVyYXRlZERyYXdpbmcgPSBlbmFibGVkOwogfQogCit2b2lkIFNldHRpbmdzOjpzZXRDYW52YXNV
c2VzRGV2aWNlU2NhbGVGYWN0b3IoYm9vbCBlbmFibGVkKQoreworICAgIG1fY2FudmFzVXNlc0Rl
dmljZVNjYWxlRmFjdG9yID0gZW5hYmxlZDsKK30KKwogdm9pZCBTZXR0aW5nczo6c2V0QWNjZWxl
cmF0ZWRDb21wb3NpdGluZ0ZvcjNEVHJhbnNmb3Jtc0VuYWJsZWQoYm9vbCBlbmFibGVkKQogewog
ICAgIG1fYWNjZWxlcmF0ZWRDb21wb3NpdGluZ0ZvcjNEVHJhbnNmb3Jtc0VuYWJsZWQgPSBlbmFi
bGVkOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9TZXR0aW5ncy5oIGIvU291cmNl
L1dlYkNvcmUvcGFnZS9TZXR0aW5ncy5oCmluZGV4IGYxOWI0YzExZmYxNWQ2Y2NlNzI2ODJmZDU3
ZDljOGY1YmM5ODM1ZDkuLjhiNDk4MDU3MThiODRlNDQxZmU2NTdjMjRjZmM5NTdmZjg5ZTc1OTMg
MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvU2V0dGluZ3MuaAorKysgYi9Tb3VyY2Uv
V2ViQ29yZS9wYWdlL1NldHRpbmdzLmgKQEAgLTMwNCw2ICszMDQsOSBAQCBuYW1lc3BhY2UgV2Vi
Q29yZSB7CiAgICAgICAgIHZvaWQgc2V0Q2FudmFzVXNlc0FjY2VsZXJhdGVkRHJhd2luZyhib29s
KTsKICAgICAgICAgYm9vbCBjYW52YXNVc2VzQWNjZWxlcmF0ZWREcmF3aW5nKCkgY29uc3QgeyBy
ZXR1cm4gbV9jYW52YXNVc2VzQWNjZWxlcmF0ZWREcmF3aW5nOyB9CiAKKyAgICAgICAgdm9pZCBz
ZXRDYW52YXNVc2VzRGV2aWNlU2NhbGVGYWN0b3IoYm9vbCk7CisgICAgICAgIGJvb2wgY2FudmFz
VXNlc0RldmljZVNjYWxlRmFjdG9yKCkgY29uc3QgeyByZXR1cm4gbV9jYW52YXNVc2VzRGV2aWNl
U2NhbGVGYWN0b3I7IH0KKwogICAgICAgICB2b2lkIHNldEFjY2VsZXJhdGVkRHJhd2luZ0VuYWJs
ZWQoYm9vbCBlbmFibGVkKSB7IG1fYWNjZWxlcmF0ZWREcmF3aW5nRW5hYmxlZCA9IGVuYWJsZWQ7
IH0KICAgICAgICAgYm9vbCBhY2NlbGVyYXRlZERyYXdpbmdFbmFibGVkKCkgY29uc3QgeyByZXR1
cm4gbV9hY2NlbGVyYXRlZERyYXdpbmdFbmFibGVkOyB9CiAKQEAgLTYxNCw2ICs2MTcsNyBAQCBu
YW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIGJvb2wgbV91c2VzRW5jb2RpbmdEZXRlY3RvciA6
IDE7CiAgICAgICAgIGJvb2wgbV9hbGxvd1NjcmlwdHNUb0Nsb3NlV2luZG93cyA6IDE7CiAgICAg
ICAgIGJvb2wgbV9jYW52YXNVc2VzQWNjZWxlcmF0ZWREcmF3aW5nIDogMTsKKyAgICAgICAgYm9v
bCBtX2NhbnZhc1VzZXNEZXZpY2VTY2FsZUZhY3RvciA6IDE7CiAgICAgICAgIGJvb2wgbV9hY2Nl
bGVyYXRlZERyYXdpbmdFbmFibGVkIDogMTsKICAgICAgICAgYm9vbCBtX2FjY2VsZXJhdGVkRmls
dGVyc0VuYWJsZWQgOiAxOwogICAgICAgICBib29sIG1faXNDU1NDdXN0b21GaWx0ZXJFbmFibGVk
IDogMTsK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>127742</attachid>
            <date>2012-02-19 14:25:08 -0800</date>
            <delta_ts>2012-02-20 19:48:45 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-78971-20120219142507.patch</filename>
            <type>text/plain</type>
            <size>2207</size>
            <attacher name="John Knottenbelt">jknotten</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4MTk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGQ5OGEwYWRlYTVkMDA1
N2YzNGU1OGIyYWRmNDUyNDQ4ZmIyZTFkNi4uNWQ2ZDkyNzE1NDBhOWRmMmRkZGU2YzEwNGUwZDFh
NWNhOWU0ZWY5NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTAyLTE5ICBKb2hu
IEtub3R0ZW5iZWx0ICA8amtub3R0ZW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIERlZmF1bHQg
Y2FudmFzIGJhY2tpbmcgc3RvcmUgdG8gYmUgMToxIHdpdGggc3BlY2lmaWVkIGRpbWVuc2lvbnMu
CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03ODk3MQor
CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFsdGhvdWdo
IHRoZSBjYW52YXMgc3BlY2lmaWNhdGlvbiBzdGF0ZXMgdGhhdCB0aGUgYmFja2luZyBpbWFnZSBt
YXkKKyAgICAgICAgYmUgbGFyZ2VyIHRoYW4gdGhlIHVzZXItc3BlY2lmaWVkIGRpbWVuc2lvbnMs
IHRoZXJlIGFyZSBhIG51bWJlciBvZgorICAgICAgICBwaGlsaXAgY2FudmFzIHRlc3RzIHRoYXQg
ZmFpbCB3aGVuIHRoZSBiYWNraW5nIGltYWdlIGRhdGEgaXMgbm90CisgICAgICAgIDE6MSB3aXRo
IHRoZSBzcGVjaWZpZWQgY2FudmFzIGRpbWVuc2lvbnMuIFRoZXNlIGZhaWx1cmVzIGFyZQorICAg
ICAgICB0cmFja2VkIGluIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03
MzY0NQorCisgICAgICAgIFRoaXMgY2hhbmdlIGRlZmF1bHRzIHRoZSBjYW52YXMgYmFja2luZyBz
dG9yZSB0byBiZSAxOjEgd2l0aCB0aGUKKyAgICAgICAgdXNlci1zcGVjaWZpZWQgZGltZW5zaW9u
cywgd2hpbGUgYWxzbyBwcm92aWRpbmcgYW4KKyAgICAgICAgRU5BQkxFKEhJR0hfRFBJX0NBTlZB
UykgYnVpbGQgb3B0aW9uIHRvIHJlaW5zdGF0ZSB0aGUgb3JpZ2luYWwKKyAgICAgICAgYmVoYXZp
b3VyLCBzbyB0aGF0IHRoZSBhYm92ZSBidWcgbWF5IGJlIG1vcmUgZWFzaWx5IGZpeGVkLgorCisg
ICAgICAgICogaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpI
VE1MQ2FudmFzRWxlbWVudDo6SFRNTENhbnZhc0VsZW1lbnQpOgorCiAyMDEyLTAyLTE5ICBBbmRy
ZWFzIEtsaW5nICA8YXdlc29tZWtsaW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBNYWtlIENTU1Zh
bHVlIHdyYXBwZXIgZ2V0dGVycyByZXR1cm4gdW5pcXVlIG9iamVjdHMgZXZlcnkgdGltZS4KZGlm
ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTENhbnZhc0VsZW1lbnQuY3BwIGIvU291
cmNlL1dlYkNvcmUvaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5jcHAKaW5kZXggNWZhZjI5NTY1Nzlm
OTQwYmM0ZTExZjQ1YzQ4YTljOTNmNzUwNDcyOS4uYmVjY2I2MGVjY2VlM2NjOGQwYWExOWQ3Y2U3
ZTQ2MTg2MjU3YmM3NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQ2FudmFz
RWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5j
cHAKQEAgLTc5LDcgKzc5LDEyIEBAIEhUTUxDYW52YXNFbGVtZW50OjpIVE1MQ2FudmFzRWxlbWVu
dChjb25zdCBRdWFsaWZpZWROYW1lJiB0YWdOYW1lLCBEb2N1bWVudCogZG9jCiAgICAgLCBtX3Np
emUoRGVmYXVsdFdpZHRoLCBEZWZhdWx0SGVpZ2h0KQogICAgICwgbV9yZW5kZXJlcklzQ2FudmFz
KGZhbHNlKQogICAgICwgbV9pZ25vcmVSZXNldChmYWxzZSkKKyNpZiBFTkFCTEUoSElHSF9EUElf
Q0FOVkFTKQorICAgICAgLy8gRklYTUU6IE1ha2UgdGhpcyB0aGUgZGVmYXVsdCBvbmNlIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MzY0NSBoYXMgYmVlbiBmaXhlZC4K
ICAgICAsIG1fZGV2aWNlU2NhbGVGYWN0b3IoZG9jdW1lbnQtPmZyYW1lKCkgPyBkb2N1bWVudC0+
ZnJhbWUoKS0+cGFnZSgpLT5kZXZpY2VTY2FsZUZhY3RvcigpIDogMSkKKyNlbHNlCisgICAgLCBt
X2RldmljZVNjYWxlRmFjdG9yKDEpCisjZW5kaWYKICAgICAsIG1fb3JpZ2luQ2xlYW4odHJ1ZSkK
ICAgICAsIG1faGFzQ3JlYXRlZEltYWdlQnVmZmVyKGZhbHNlKQogewo=
</data>

          </attachment>
      

    </bug>

</bugzilla>