78963 2012-02-18 05:17:03 -0800 [Qt][WK2] Accelerated animations don't work on Mac 2012-02-21 14:57:48 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 noam noam kenneth webkit.review.bot oldest_to_newest 559771 0 noam 2012-02-18 05:17:03 -0800 [Qt][WK2] Accelerated animations don't work on Mac 560322 1 127842 noam 2012-02-20 12:51:11 -0800 Created attachment 127842 Patch 561155 2 127842 kenneth 2012-02-21 12:51:54 -0800 Comment on attachment 127842 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127842&action=review > Source/WebKit2/UIProcess/qt/LayerTreeHostProxyQt.cpp:205 > + TextureMapperLayer* layer = toTextureMapperLayer(rootLayer()); > + ASSERT(layer); Shouldn't that assert not be in toTextureMapperLayer ? 561181 3 noam 2012-02-21 13:32:43 -0800 (In reply to comment #2) > (From update of attachment 127842 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=127842&action=review > > > Source/WebKit2/UIProcess/qt/LayerTreeHostProxyQt.cpp:205 > > + TextureMapperLayer* layer = toTextureMapperLayer(rootLayer()); > > + ASSERT(layer); > > Shouldn't that assert not be in toTextureMapperLayer ? No, sometimes it's ok to have NULL. 561247 4 127842 webkit.review.bot 2012-02-21 14:57:42 -0800 Comment on attachment 127842 Patch Clearing flags on attachment: 127842 Committed r108405: <http://trac.webkit.org/changeset/108405> 561248 5 webkit.review.bot 2012-02-21 14:57:48 -0800 All reviewed patches have been landed. Closing bug. 127842 2012-02-20 12:51:11 -0800 2012-02-21 14:57:41 -0800 Patch bug-78963-20120220125109.patch text/plain 4542 noam U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4MjA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMWVhOGM3ZjYwZWYwYTg4 YWVlNmMwZjBiYzQ5NzkyOTQxNmNjYWY5NC4uZTkyNWM3N2M3MzVhYWU3NmRhNjg3NWU1MjQ5MDI1 N2ZmZGM0NGU1ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDEyLTAyLTIwICBObydh bSBSb3NlbnRoYWwgIDxub2FtLnJvc2VudGhhbEBub2tpYS5jb20+CiAKKyAgICAgICAgW1F0XVtX SzJdIEFjY2VsZXJhdGVkIGFuaW1hdGlvbnMgZG9uJ3Qgd29yayBvbiBNYWMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc4OTYzCisKKyAgICAgICAgUHJv YmxlbSBjYW1lIGZyb20gdXNpbmcgYSBub24tUnVuTG9vcCB0aW1lci4KKyAgICAgICAgUmVtb3Zl IHRoZSB1bnVzZWQgdmlld3BvcnRVcGRhdGVUaW1lciwgYW5kIHVzZSB0aGUgZXhpc3RpbmcgYW5p bWF0aW9uVGltZXIgaW5zdGVhZC4KKyAgICAgICAgVXNlIGEgY29udGludW91cyB0aW1lciB0aGF0 IHdlIG9ubHkgc3RvcCB3aGVuIGFuaW1hdGlvbnMgc3RvcC4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9MYXllclRyZWVIb3N0UHJv eHkuaDoKKyAgICAgICAgKExheWVyVHJlZUhvc3RQcm94eSk6CisgICAgICAgICogVUlQcm9jZXNz L3F0L0xheWVyVHJlZUhvc3RQcm94eVF0LmNwcDoKKyAgICAgICAgKFdlYktpdDo6TGF5ZXJUcmVl SG9zdFByb3h5OjpMYXllclRyZWVIb3N0UHJveHkpOgorICAgICAgICAoV2ViS2l0OjpMYXllclRy ZWVIb3N0UHJveHk6OnBhaW50VG9DdXJyZW50R0xDb250ZXh0KToKKyAgICAgICAgKFdlYktpdCk6 CisgICAgICAgIChXZWJLaXQ6OkxheWVyVHJlZUhvc3RQcm94eTo6c3luY0FuaW1hdGlvbnMpOgor CisyMDEyLTAyLTIwICBObydhbSBSb3NlbnRoYWwgIDxub2FtLnJvc2VudGhhbEBub2tpYS5jb20+ CisKICAgICAgICAgW1F0XVtXSzJdIERyYXcgdGlsZXMgb2YgcHJldmlvdXMgY29udGVudHMtc2Nh bGUgZm9yIG9wYXF1ZSBsYXllcnMgaWYgdGhleSBkb24ndCBpbnRlcnNlY3Qgd2l0aCBwcmV2aW91 cyB0aWxlcwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 Nzg5NjIKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0xheWVyVHJlZUhv c3RQcm94eS5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0xheWVyVHJlZUhvc3RQcm94eS5o CmluZGV4IDNkYjBjZDM3MTBiNzQxMGY0ZDkyM2JhN2FkOGZkNTNkZTFjMzkwZGYuLjgwOGY4MGY3 MmJhYmRlNWFjODQyOTI5ZWUxMGEyNGRjYzBiYTY1MzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9MYXllclRyZWVIb3N0UHJveHkuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvTGF5ZXJUcmVlSG9zdFByb3h5LmgKQEAgLTg1LDcgKzg1LDYgQEAgcHJvdGVjdGVk OgogICAgIHZpcnR1YWwgYm9vbCBzaG93UmVwYWludENvdW50ZXIoY29uc3QgV2ViQ29yZTo6R3Jh cGhpY3NMYXllciopIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9CiAgICAgdm9pZCBwYWludENvbnRl bnRzKGNvbnN0IFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXIqLCBXZWJDb3JlOjpHcmFwaGljc0NvbnRl eHQmLCBXZWJDb3JlOjpHcmFwaGljc0xheWVyUGFpbnRpbmdQaGFzZSwgY29uc3QgV2ViQ29yZTo6 SW50UmVjdCYpIHsgfQogCi0gICAgV2ViQ29yZTo6UnVuTG9vcDo6VGltZXI8TGF5ZXJUcmVlSG9z dFByb3h5PiBtX2FuaW1hdGlvblRpbWVyOwogICAgIERyYXdpbmdBcmVhUHJveHkqIG1fZHJhd2lu Z0FyZWFQcm94eTsKIAogICAgIHR5cGVkZWYgSGFzaE1hcDxXZWJMYXllcklELCBXZWJDb3JlOjpH cmFwaGljc0xheWVyKj4gTGF5ZXJNYXA7CkBAIC0xMTYsNiArMTE1LDcgQEAgcHJvdGVjdGVkOgog ICAgIHZvaWQgZW5zdXJlTGF5ZXIoV2ViTGF5ZXJJRCk7CiAgICAgUGFzc1JlZlB0cjxMYXllckJh Y2tpbmdTdG9yZT4gZ2V0QmFja2luZ1N0b3JlKFdlYkxheWVySUQpOwogICAgIHZvaWQgc3dhcEJ1 ZmZlcnMoKTsKKyAgICB2b2lkIHN5bmNBbmltYXRpb25zKCk7CiAjZW5kaWYKIAogICAgIE93blB0 cjxXZWJDb3JlOjpHcmFwaGljc0xheWVyPiBtX3Jvb3RMYXllcjsKQEAgLTEyMywxMSArMTIzLDYg QEAgcHJvdGVjdGVkOgogICAgIEhhc2hNYXA8aW50NjRfdCwgUmVmUHRyPFdlYkNvcmU6OlRleHR1 cmVNYXBwZXJCYWNraW5nU3RvcmU+ID4gbV9kaXJlY3RseUNvbXBvc2l0ZWRJbWFnZXM7CiAgICAg SGFzaFNldDxSZWZQdHI8TGF5ZXJCYWNraW5nU3RvcmU+ID4gbV9iYWNraW5nU3RvcmVzV2l0aFBl bmRpbmdCdWZmZXJzOwogCi0jaWYgUExBVEZPUk0oUVQpCi0gICAgdm9pZCBkaWRGaXJlVmlld3Bv cnRVcGRhdGVUaW1lcihXZWJDb3JlOjpUaW1lcjxMYXllclRyZWVIb3N0UHJveHk+Kik7Ci0gICAg V2ViQ29yZTo6VGltZXI8TGF5ZXJUcmVlSG9zdFByb3h5PiBtX3ZpZXdwb3J0VXBkYXRlVGltZXI7 Ci0jZW5kaWYKLQogICAgIExheWVyTWFwIG1fbGF5ZXJzOwogICAgIFdlYkxheWVySUQgbV9yb290 TGF5ZXJJRDsKICAgICBpbnQgbV9pZDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9xdC9MYXllclRyZWVIb3N0UHJveHlRdC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvcXQvTGF5ZXJUcmVlSG9zdFByb3h5UXQuY3BwCmluZGV4IDRmYzEyMmU2YWVhOWUzOWJhOGI3 ZTU3MjIwZDZmZTU4MDRhMTM5MmUuLjVmZDYyYTQ3M2QwNmU4MjIzMTA1N2Q4ZjRmYjY2ZWQ5NDdj MDE5ZTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9MYXllclRyZWVI b3N0UHJveHlRdC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L0xheWVyVHJl ZUhvc3RQcm94eVF0LmNwcApAQCAtMTU1LDkgKzE1NSw3IEBAIFBhc3NPd25QdHI8R3JhcGhpY3NM YXllcj4gTGF5ZXJUcmVlSG9zdFByb3h5OjpjcmVhdGVMYXllcihXZWJMYXllcklEIGxheWVySUQp CiB9CiAKIExheWVyVHJlZUhvc3RQcm94eTo6TGF5ZXJUcmVlSG9zdFByb3h5KERyYXdpbmdBcmVh UHJveHkqIGRyYXdpbmdBcmVhUHJveHkpCi0gICAgOiBtX2FuaW1hdGlvblRpbWVyKFJ1bkxvb3A6 Om1haW4oKSwgdGhpcywgJkxheWVyVHJlZUhvc3RQcm94eTo6dXBkYXRlVmlld3BvcnQpCi0gICAg LCBtX2RyYXdpbmdBcmVhUHJveHkoZHJhd2luZ0FyZWFQcm94eSkKLSAgICAsIG1fdmlld3BvcnRV cGRhdGVUaW1lcih0aGlzLCAmTGF5ZXJUcmVlSG9zdFByb3h5OjpkaWRGaXJlVmlld3BvcnRVcGRh dGVUaW1lcikKKyAgICA6IG1fZHJhd2luZ0FyZWFQcm94eShkcmF3aW5nQXJlYVByb3h5KQogICAg ICwgbV9yb290TGF5ZXJJRCgwKQogewogfQpAQCAtMTk4LDEwICsxOTYsMTcgQEAgdm9pZCBMYXll clRyZWVIb3N0UHJveHk6OnBhaW50VG9DdXJyZW50R0xDb250ZXh0KGNvbnN0IFRyYW5zZm9ybWF0 aW9uTWF0cml4JiBtYXQKICAgICBtX3RleHR1cmVNYXBwZXItPmVuZENsaXAoKTsKICAgICBtX3Rl eHR1cmVNYXBwZXItPmVuZFBhaW50aW5nKCk7CiAKLSAgICBpZiAobGF5ZXItPmRlc2NlbmRhbnRz T3JTZWxmSGF2ZVJ1bm5pbmdBbmltYXRpb25zKCkpIHsKLSAgICAgICAgbGF5ZXItPnN5bmNBbmlt YXRpb25zUmVjdXJzaXZlbHkoKTsKLSAgICAgICAgbV92aWV3cG9ydFVwZGF0ZVRpbWVyLnN0YXJ0 T25lU2hvdCgwKTsKLSAgICB9CisgICAgc3luY0FuaW1hdGlvbnMoKTsKK30KKwordm9pZCBMYXll clRyZWVIb3N0UHJveHk6OnN5bmNBbmltYXRpb25zKCkKK3sKKyAgICBUZXh0dXJlTWFwcGVyTGF5 ZXIqIGxheWVyID0gdG9UZXh0dXJlTWFwcGVyTGF5ZXIocm9vdExheWVyKCkpOworICAgIEFTU0VS VChsYXllcik7CisKKyAgICBsYXllci0+c3luY0FuaW1hdGlvbnNSZWN1cnNpdmVseSgpOworICAg IGlmIChsYXllci0+ZGVzY2VuZGFudHNPclNlbGZIYXZlUnVubmluZ0FuaW1hdGlvbnMoKSkKKyAg ICAgICAgdXBkYXRlVmlld3BvcnQoKTsKIH0KIAogdm9pZCBMYXllclRyZWVIb3N0UHJveHk6OnBh aW50VG9HcmFwaGljc0NvbnRleHQoUVBhaW50ZXIqIHBhaW50ZXIpCkBAIC0yMjQsMTIgKzIyOSw2 IEBAIHZvaWQgTGF5ZXJUcmVlSG9zdFByb3h5OjpwYWludFRvR3JhcGhpY3NDb250ZXh0KFFQYWlu dGVyKiBwYWludGVyKQogICAgIG1fdGV4dHVyZU1hcHBlci0+c2V0R3JhcGhpY3NDb250ZXh0KDAp OwogfQogCi0KLXZvaWQgTGF5ZXJUcmVlSG9zdFByb3h5OjpkaWRGaXJlVmlld3BvcnRVcGRhdGVU aW1lcihUaW1lcjxMYXllclRyZWVIb3N0UHJveHk+KikKLXsKLSAgICB1cGRhdGVWaWV3cG9ydCgp OwotfQotCiB2b2lkIExheWVyVHJlZUhvc3RQcm94eTo6dXBkYXRlVmlld3BvcnQoKQogewogICAg IG1fZHJhd2luZ0FyZWFQcm94eS0+dXBkYXRlVmlld3BvcnQoKTsK