78911 2012-02-17 10:24:23 -0800 Fix some warnings encountered during the GTK+ build 2012-02-17 10:52:09 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mrobinson mrobinson gustavo noam oldest_to_newest 559289 0 mrobinson 2012-02-17 10:24:23 -0800 This bug tracks fixing a few warnings encountered during the GTK+ build. 559294 1 127607 mrobinson 2012-02-17 10:28:00 -0800 Created attachment 127607 Patch 559309 2 127607 xan.lopez 2012-02-17 10:37:03 -0800 Comment on attachment 127607 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127607&action=review > Source/WebCore/page/GestureTapHighlighter.cpp:182 > + LayoutRect next = i != (drawableRects.size() - 1) ? drawableRects.at(i + 1) : LayoutRect(); I think < fits better the spirit of this code, tbh. So, i < (drawableRects.size - 1). 559333 3 mrobinson 2012-02-17 10:52:09 -0800 Committed r108095: <http://trac.webkit.org/changeset/108095> 127607 2012-02-17 10:28:00 -0800 2012-02-17 10:37:03 -0800 Patch bug-78911-20120217102757.patch text/plain 6634 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4MDQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzI4MzBiNzY3M2YxZDZj M2Q0YTI1ZTJhODhlNGQ1N2VjYjQ5NGJmMS4uYWIyYjQwMTZkYjE0ZWUyYmQzOTE1Y2U5ZDIxOGI4 Y2RmYTI3NzI3NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTAyLTE3ICBNYXJ0 aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KKworICAgICAgICBGaXggc29tZSB3 YXJuaW5ncyBlbmNvdW50ZXJlZCBkdXJpbmcgdGhlIEdUSysgYnVpbGQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc4OTExCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBUaGVzZSBhcmUg anVzdCBmaXhlcyBmb3Igd2FybmluZ3MuCisKKyAgICAgICAgKiBwYWdlL0dlc3R1cmVUYXBIaWdo bGlnaHRlci5jcHA6IEF2b2lkIHVzaW5nIHBvdGVudGlhbGx5IHNpZ25lZCBvcGVyYXRpb25zIG9u CisgICAgICAgIGEgc2l6ZV90IHR5cGUuIFVzZSBzaXplX3QgZm9yIGl0ZXJhdGluZyBvdmVyIG1l bWJlcnMgb2YgYSB2ZWN0b3IuCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1Rl eHR1cmVNYXBwZXJCYWNraW5nU3RvcmUuY3BwOiBVc2Ugc2l6ZV90IHdoZXJlIG5lY2Vzc2FyeS4K KyAgICAgICAgKFdlYkNvcmU6OlRleHR1cmVNYXBwZXJUaWxlZEJhY2tpbmdTdG9yZTo6Y3JlYXRl T3JEZXN0cm95VGlsZXNJZk5lZWRlZCk6IERpdHRvLgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyTGF5ZXIuY3BwOiBEaXR0by4KKyAgICAgICAgKFdlYkNv cmU6OlRleHR1cmVNYXBwZXJMYXllcjo6Y29tcHV0ZVRyYW5zZm9ybXNSZWN1cnNpdmUpOiBEaXR0 by4KKyAgICAgICAgKFdlYkNvcmU6OlRleHR1cmVNYXBwZXJMYXllcjo6cGFpbnRTZWxmQW5kQ2hp bGRyZW4pOiBEaXR0by4KKyAgICAgICAgKFdlYkNvcmU6OlRleHR1cmVNYXBwZXJMYXllcjo6aW50 ZXJtZWRpYXRlU3VyZmFjZVJlY3QpOiBEaXR0by4KKwogMjAxMi0wMi0xNiAgTWFydGluIFJvYmlu c29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CiAKICAgICAgICAgRml4IHRoZSBUZXh0dXJlTWFw cGVyIGJ1aWxkIGZvciBHVEsrLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9n IGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IDBhMmZlNjRhYmJhMTMxMDY0MzBjY2Nl Zjg3YTQwOTU4ODhkOTdkY2YuLmIwOWEwNzFjNGZhNDBjOTY2YTBiNGUyZjg0YTAwNWY4YTVlOTEw MjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMi0wMi0xNyAgTWFydGluIFJvYmlu c29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CisKKyAgICAgICAgRml4IHNvbWUgd2FybmluZ3Mg ZW5jb3VudGVyZWQgZHVyaW5nIHRoZSBHVEsrIGJ1aWxkCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03ODkxMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0TG9hZGVy Q2xpZW50LmNwcDoKKyAgICAgICAgKGF0dGFjaExvYWRlckNsaWVudFRvVmlldyk6IEluaXRpYWxp emUgYSBuZXcgbWVtYmVyIG9mIHRoZSBsb2FkZXIgY2xpZW50IHN0cnVjdC4KKwogMjAxMi0wMi0x NiAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAg W0dUS10gTWFrZSBzdXJlIHByaW50IG9wZXJhdGlvbiBvYmplY3QgaXMgYWxpdmUgdW50aWwgcHJp bnRpbmcgZmluaXNoZXMgaW4gV2ViS2l0MgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFn ZS9HZXN0dXJlVGFwSGlnaGxpZ2h0ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9HZXN0dXJl VGFwSGlnaGxpZ2h0ZXIuY3BwCmluZGV4IGMzZjcyMzliNWIzMDA2NjA4ZWVhNzJiMzY4ZDFjMzUw NDMyOGRkNzUuLmI0YjViYTBmZTMxZjhlNTQ5ZDI3NjI5ZWQ5YmJiNDQ0MzYzZjllZjYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvR2VzdHVyZVRhcEhpZ2hsaWdodGVyLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0dlc3R1cmVUYXBIaWdobGlnaHRlci5jcHAKQEAgLTE0Niw3 ICsxNDYsNyBAQCBQYXRoIHBhdGhGb3JSZW5kZXJlcihSZW5kZXJPYmplY3QqIG8pCiAKICAgICAv LyBNZXJnZSBhbGwgY2VudGVyIGJveGVzIChhbGwgYnV0IHRoZSBmaXJzdCBhbmQgdGhlIGxhc3Qp LgogICAgIExheW91dFJlY3QgbWlkOwotICAgIGZvciAoaW50IGkgPSAxOyBpIDwgcmVjdHMuc2l6 ZSgpIC0gMTsgKytpKQorICAgIGZvciAoc2l6ZV90IGkgPSAxOyBpIDwgcmVjdHMuc2l6ZSgpIC0g MTsgKytpKQogICAgICAgICBtaWQudW5pdGVJZk5vblplcm8ocmVjdHMuYXQoaSkpOwogCiAgICAg VmVjdG9yPExheW91dFJlY3Q+IGRyYXdhYmxlUmVjdHM7CkBAIC0xNzcsOSArMTc3LDkgQEAgUGF0 aCBwYXRoRm9yUmVuZGVyZXIoUmVuZGVyT2JqZWN0KiBvKQogICAgICAgICBzaGlmdFhFZGdlc1Rv Q29udGFpbklmU3RyaWtlcyhtaWRkbGUsIGRyYXdhYmxlUmVjdHMuYXQoMikpOwogICAgIH0KIAot ICAgIGZvciAoaW50IGkgPSAwOyBpIDwgZHJhd2FibGVSZWN0cy5zaXplKCk7ICsraSkgewotICAg ICAgICBMYXlvdXRSZWN0IHByZXYgPSAoaSAtIDEpID49IDAgPyBkcmF3YWJsZVJlY3RzLmF0KGkg LSAxKSA6IExheW91dFJlY3QoKTsKLSAgICAgICAgTGF5b3V0UmVjdCBuZXh0ID0gKGkgKyAxKSA8 IGRyYXdhYmxlUmVjdHMuc2l6ZSgpID8gZHJhd2FibGVSZWN0cy5hdChpICsgMSkgOiBMYXlvdXRS ZWN0KCk7CisgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBkcmF3YWJsZVJlY3RzLnNpemUoKTsg KytpKSB7CisgICAgICAgIExheW91dFJlY3QgcHJldiA9IGkgPyBkcmF3YWJsZVJlY3RzLmF0KGkg LSAxKSA6IExheW91dFJlY3QoKTsKKyAgICAgICAgTGF5b3V0UmVjdCBuZXh0ID0gaSAhPSAoZHJh d2FibGVSZWN0cy5zaXplKCkgLSAxKSA/IGRyYXdhYmxlUmVjdHMuYXQoaSArIDEpIDogTGF5b3V0 UmVjdCgpOwogICAgICAgICBhZGRIaWdobGlnaHRSZWN0KHBhdGgsIGRyYXdhYmxlUmVjdHMuYXQo aSksIHByZXYsIG5leHQpOwogICAgIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJCYWNraW5nU3RvcmUuY3BwIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJCYWNraW5n U3RvcmUuY3BwCmluZGV4IGZjYjlmNTMwZDQwOTZkNWI0NzVlNWExMDIyMjU0NzRjMGZmMzU3ZDUu LjU5ZDk2ZGZiYWE1ZWMwODQxNDgwZDlkZTcxMDAxZmZhNWYzZGJkZGEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyQmFja2lu Z1N0b3JlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAv VGV4dHVyZU1hcHBlckJhY2tpbmdTdG9yZS5jcHAKQEAgLTc5LDcgKzc5LDcgQEAgdm9pZCBUZXh0 dXJlTWFwcGVyVGlsZWRCYWNraW5nU3RvcmU6OmNyZWF0ZU9yRGVzdHJveVRpbGVzSWZOZWVkZWQo Y29uc3QgRmxvYXRTaXoKIAogICAgIFZlY3RvcjxGbG9hdFJlY3Q+IHRpbGVSZWN0c1RvQWRkOwog ICAgIFZlY3RvcjxpbnQ+IHRpbGVJbmRpY2VzVG9SZW1vdmU7Ci0gICAgc3RhdGljIGNvbnN0IGlu dCBUaWxlRXJhc2VUaHJlc2hvbGQgPSA2OworICAgIHN0YXRpYyBjb25zdCBzaXplX3QgVGlsZUVy YXNlVGhyZXNob2xkID0gNjsKIAogICAgIC8vIFRoaXMgbWV0aG9kIHJlY3ljbGVzIHRpbGVzLiBX ZSBjaGVjayB3aGljaCB0aWxlcyB3ZSBuZWVkIHRvIGFkZCwgd2hpY2ggdG8gcmVtb3ZlLCBhbmQg dXNlIGFzIG1hbnkKICAgICAvLyByZW1vdmFibGUgdGlsZXMgYXMgcmVwbGFjZW1lbnQgZm9yIG5l dyB0aWxlcyB3aGVuIHBvc3NpYmxlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJMYXllci5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckxheWVyLmNwcAppbmRleCBj YmVmZjcwMjU1ZWMxN2Q2YzVhMmYzYTY5N2QyMjQ0YTIzNDkwYmFjLi5iMjFjYmMxZTRkN2ZkZDEz NzExMWFmZDUyMjY1YjBiYzE5ZWU3ZjA2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckxheWVyLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckxheWVyLmNwcApA QCAtODEsNyArODEsNyBAQCB2b2lkIFRleHR1cmVNYXBwZXJMYXllcjo6Y29tcHV0ZVRyYW5zZm9y bXNSZWN1cnNpdmUoKQogICAgICAgICBtX3N0YXRlLm1hc2tMYXllci0+Y29tcHV0ZVRyYW5zZm9y bXNSZWN1cnNpdmUoKTsKICAgICBpZiAobV9zdGF0ZS5yZXBsaWNhTGF5ZXIpCiAgICAgICAgIG1f c3RhdGUucmVwbGljYUxheWVyLT5jb21wdXRlVHJhbnNmb3Jtc1JlY3Vyc2l2ZSgpOwotICAgIGZv ciAoaW50IGkgPSAwOyBpIDwgbV9jaGlsZHJlbi5zaXplKCk7ICsraSkKKyAgICBmb3IgKHNpemVf dCBpID0gMDsgaSA8IG1fY2hpbGRyZW4uc2l6ZSgpOyArK2kpCiAgICAgICAgIG1fY2hpbGRyZW5b aV0tPmNvbXB1dGVUcmFuc2Zvcm1zUmVjdXJzaXZlKCk7CiAKICAgICAvLyBSZW9yZGVyIGNoaWxk cmVuIGlmIG5lZWRlZCBvbiB0aGUgd2F5IGJhY2sgdXAuCkBAIC0xNzksNyArMTc5LDcgQEAgdm9p ZCBUZXh0dXJlTWFwcGVyTGF5ZXI6OnBhaW50U2VsZkFuZENoaWxkcmVuKGNvbnN0IFRleHR1cmVN YXBwZXJQYWludE9wdGlvbnMmIG8KIAogICAgIHBhaW50U2VsZihvcHRpb25zKTsKIAotICAgIGZv ciAoaW50IGkgPSAwOyBpIDwgbV9jaGlsZHJlbi5zaXplKCk7ICsraSkKKyAgICBmb3IgKHNpemVf dCBpID0gMDsgaSA8IG1fY2hpbGRyZW4uc2l6ZSgpOyArK2kpCiAgICAgICAgIG1fY2hpbGRyZW5b aV0tPnBhaW50UmVjdXJzaXZlKG9wdGlvbnMpOwogCiAgICAgaWYgKGhhc0NsaXApCkBAIC0xOTgs NyArMTk4LDcgQEAgSW50UmVjdCBUZXh0dXJlTWFwcGVyTGF5ZXI6OmludGVybWVkaWF0ZVN1cmZh Y2VSZWN0KGNvbnN0IFRyYW5zZm9ybWF0aW9uTWF0cml4JgogICAgIFRyYW5zZm9ybWF0aW9uTWF0 cml4IGxvY2FsVHJhbnNmb3JtID0gVHJhbnNmb3JtYXRpb25NYXRyaXgobWF0cml4KS5tdWx0aXBs eShtX3RyYW5zZm9ybS5jb21iaW5lZCgpKTsKICAgICByZWN0ID0gZW5jbG9zaW5nSW50UmVjdChs b2NhbFRyYW5zZm9ybS5tYXBSZWN0KGxheWVyUmVjdCgpKSk7CiAgICAgaWYgKCFtX3N0YXRlLm1h c2tzVG9Cb3VuZHMgJiYgIW1fc3RhdGUubWFza0xheWVyKSB7Ci0gICAgICAgIGZvciAoaW50IGkg PSAwOyBpIDwgbV9jaGlsZHJlbi5zaXplKCk7ICsraSkKKyAgICAgICAgZm9yIChzaXplX3QgaSA9 IDA7IGkgPCBtX2NoaWxkcmVuLnNpemUoKTsgKytpKQogICAgICAgICAgICAgcmVjdC51bml0ZSht X2NoaWxkcmVuW2ldLT5pbnRlcm1lZGlhdGVTdXJmYWNlUmVjdChtYXRyaXgpKTsKICAgICB9CiAK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdExvYWRl ckNsaWVudC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRMb2Fk ZXJDbGllbnQuY3BwCmluZGV4IDZkMTEzMzk0MTRiOWU3ODQwMDljYjhjNTA1YmM2NjYwNzA5YmM0 ZDUuLmMyNmQ4ZWJlOTdmYWU2OGExYTE2YzhlOTRiMmNiMGQxZDg4ZDMwMDMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdExvYWRlckNsaWVudC5jcHAK KysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0TG9hZGVyQ2xpZW50 LmNwcApAQCAtMTQ0LDcgKzE0NCw4IEBAIHZvaWQgYXR0YWNoTG9hZGVyQ2xpZW50VG9WaWV3KFdl YktpdFdlYlZpZXcqIHdlYlZpZXcpCiAgICAgICAgIGRpZENoYW5nZUJhY2tGb3J3YXJkTGlzdCwK ICAgICAgICAgMCwgLy8gc2hvdWxkR29Ub0JhY2tGb3J3YXJkTGlzdEl0ZW0KICAgICAgICAgMCwg Ly8gZGlkRmFpbFRvSW5pdGlhbGl6ZVBsdWdpbgotICAgICAgICAwIC8vIGRpZERldGVjdFhTU0Zv ckZyYW1lCisgICAgICAgIDAsIC8vIGRpZERldGVjdFhTU0ZvckZyYW1lCisgICAgICAgIDAgLy8g ZGlkRmlyc3RWaXN1YWxseU5vbkVtcHR5TGF5b3V0Rm9yRnJhbWUgCiAgICAgfTsKICAgICBXS1Bh Z2VSZWYgd2tQYWdlID0gdG9BUEkod2Via2l0V2ViVmlld0Jhc2VHZXRQYWdlKFdFQktJVF9XRUJf VklFV19CQVNFKHdlYlZpZXcpKSk7CiAgICAgV0tQYWdlU2V0UGFnZUxvYWRlckNsaWVudCh3a1Bh Z2UsICZ3a0xvYWRlckNsaWVudCk7Cg==