78894 2012-02-17 05:48:41 -0800 Replace [V8OnInstance] with [V8Unforgeable] 2012-02-17 18:21:07 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 77393 1 haraken haraken abarth darin webkit.review.bot oldest_to_newest 559141 0 haraken 2012-02-17 05:48:41 -0800 [V8OnInstance] means that the method should be defined (not on a prototype chain but) on a DOM object. It is the same meaning as [V8Unforgeable]. We can replace [V8OnInstance] with [V8Unforgeable]. 559143 1 127576 haraken 2012-02-17 05:50:45 -0800 Created attachment 127576 Patch 559683 2 127576 webkit.review.bot 2012-02-17 18:21:02 -0800 Comment on attachment 127576 Patch Clearing flags on attachment: 127576 Committed r108149: <http://trac.webkit.org/changeset/108149> 559684 3 webkit.review.bot 2012-02-17 18:21:07 -0800 All reviewed patches have been landed. Closing bug. 127576 2012-02-17 05:50:45 -0800 2012-02-17 18:21:02 -0800 Patch bug-78894-20120217225044.patch text/plain 3535 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4MDUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2IyOWRjMWQ5NDlmYjgz Mjc4M2M1ZTBmYWJjOTUwNzVkMzA5NDc1YS4uZDE3OGNkOWYwNjM4Y2Q5OTMxNmJiZWU0MTNjN2Nm YWM2NjZmYWU0OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTAyLTE3ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXBsYWNlIFtWOE9u SW5zdGFuY2VdIHdpdGggW1Y4VW5mb3JnZWFibGVdCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD03ODg5NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtWOE9uSW5zdGFuY2VdIG1lYW5zIHRoYXQgdGhlIG1ldGhv ZCBzaG91bGQgYmUgZGVmaW5lZAorICAgICAgICAobm90IG9uIGEgcHJvdG90eXBlIGNoYWluIGJ1 dCkgb24gYSBET00gb2JqZWN0LiBJdCBpcyB0aGUKKyAgICAgICAgc2FtZSBtZWFuaW5nIGFzIFtW OFVuZm9yZ2VhYmxlXS4gVGhpcyBwYXRjaCByZXBsYWNlcyBbVjhPbkluc3RhbmNlXQorICAgICAg ICB3aXRoIFtWOFVuZm9yZ2VhYmxlXS4KKworICAgICAgICBObyB0ZXN0cy4gTm8gY2hhbmdlIGlu IGJlaGF2aW9yLgorCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgu cG06CisgICAgICAgIChHZW5lcmF0ZUltcGxlbWVudGF0aW9uKToKKyAgICAgICAgKiBwYWdlL0xv Y2F0aW9uLmlkbDoKKwogMjAxMi0wMi0xNyAgWW9zaWZ1bWkgSW5vdWUgIDx5b3NpbkBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgW0Zvcm1zXSBJbnRlZ3JhdGUgSW5wdXRUeXBlOjpkaXNwYXRjaENo YW5nZUV2ZW50SW5SZXNwb25zZVRvU2V0VmFsdWUgaW50byBJbnB1dFR5cGU6OnNldFZhbHVlCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JW OC5wbSBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBt CmluZGV4IGY4MzM4NzA3NzM0YjA3Y2U4ZGVmZDMwZDhmY2JhZWY4Mzc2OWE2NTIuLmYwNDQ2M2Y0 MDYyNDZiODc4ZTg1M2UwODhjNWY3M2Q5Njk0MzAxMjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCisrKyBiL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCkBAIC0yMzg0LDcgKzIzODQs NyBAQCBzdWIgR2VuZXJhdGVJbXBsZW1lbnRhdGlvbgogCiAgICAgICAgIG15ICRhdHRyRXh0ID0g JGZ1bmN0aW9uLT5zaWduYXR1cmUtPmV4dGVuZGVkQXR0cmlidXRlczsKICAgICAgICAgIyBEb24n dCBwdXQgYW55IG5vbnN0YW5kYXJkIGZ1bmN0aW9ucyBpbnRvIHRoaXMgdGFibGU6Ci0gICAgICAg IGlmICgkYXR0ckV4dC0+eyJWOE9uSW5zdGFuY2UifSkgeworICAgICAgICBpZiAoJGF0dHJFeHQt PnsiVjhVbmZvcmdlYWJsZSJ9KSB7CiAgICAgICAgICAgICBuZXh0OwogICAgICAgICB9CiAgICAg ICAgIGlmICgkZnVuY3Rpb24tPmlzU3RhdGljKSB7CkBAIC0yNjAzLDcgKzI2MDMsNyBAQCBFTkQK ICAgICAgICAgbXkgJGNvbW1lbnRJbmZvID0gIkZ1bmN0aW9uICckbmFtZScgKEV4dEF0dHI6ICci IC4gam9pbignICcsIGtleXMoJXskYXR0ckV4dH0pKSAuICInKSI7CiAKICAgICAgICAgbXkgJHRl bXBsYXRlID0gInByb3RvIjsKLSAgICAgICAgaWYgKCRhdHRyRXh0LT57IlY4T25JbnN0YW5jZSJ9 KSB7CisgICAgICAgIGlmICgkYXR0ckV4dC0+eyJWOFVuZm9yZ2VhYmxlIn0pIHsKICAgICAgICAg ICAgICR0ZW1wbGF0ZSA9ICJpbnN0YW5jZSI7CiAgICAgICAgIH0KICAgICAgICAgaWYgKCRmdW5j dGlvbi0+aXNTdGF0aWMpIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvTG9jYXRp b24uaWRsIGIvU291cmNlL1dlYkNvcmUvcGFnZS9Mb2NhdGlvbi5pZGwKaW5kZXggYTU0M2YyMWFm MWMzYjM0ZTEyY2FiMTY1YmYyMjBlNzkwMjMwNWYyYS4uMWFjMTM3MDk5MGIxNmZmY2MwODVkNGQ5 OWRlYmJhZDI3M2I0OGMwNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9Mb2NhdGlv bi5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9Mb2NhdGlvbi5pZGwKQEAgLTQ3LDkgKzQ3 LDkgQEAgbW9kdWxlIHdpbmRvdyB7CiAgICAgICAgICAgICAgICAgIGF0dHJpYnV0ZSBbRG9Ob3RD aGVja0RvbWFpblNlY3VyaXR5T25TZXR0ZXIsIEN1c3RvbVNldHRlciwgVjhVbmZvcmdlYWJsZV0g RE9NU3RyaW5nIGhyZWY7CiAjZW5kaWYKIAotICAgICAgICBbQ3VzdG9tLCBWOE9uSW5zdGFuY2Vd IHZvaWQgYXNzaWduKGluIFtPcHRpb25hbD1EZWZhdWx0SXNVbmRlZmluZWRdIERPTVN0cmluZyB1 cmwpOwotICAgICAgICBbQ3VzdG9tLCBWOE9uSW5zdGFuY2VdIHZvaWQgcmVwbGFjZShpbiBbT3B0 aW9uYWw9RGVmYXVsdElzVW5kZWZpbmVkXSBET01TdHJpbmcgdXJsKTsKLSAgICAgICAgW0N1c3Rv bSwgVjhPbkluc3RhbmNlXSB2b2lkIHJlbG9hZCgpOworICAgICAgICBbQ3VzdG9tLCBWOFVuZm9y Z2VhYmxlXSB2b2lkIGFzc2lnbihpbiBbT3B0aW9uYWw9RGVmYXVsdElzVW5kZWZpbmVkXSBET01T dHJpbmcgdXJsKTsKKyAgICAgICAgW0N1c3RvbSwgVjhVbmZvcmdlYWJsZV0gdm9pZCByZXBsYWNl KGluIFtPcHRpb25hbD1EZWZhdWx0SXNVbmRlZmluZWRdIERPTVN0cmluZyB1cmwpOworICAgICAg ICBbQ3VzdG9tLCBWOFVuZm9yZ2VhYmxlXSB2b2lkIHJlbG9hZCgpOwogCiAgICAgICAgIC8vIFVS SSBkZWNvbXBvc2l0aW9uIGF0dHJpYnV0ZXMKICNpZiAhZGVmaW5lZChMQU5HVUFHRV9DUFApIHx8 ICFMQU5HVUFHRV9DUFAKQEAgLTY1LDEwICs2NSwxMCBAQCBtb2R1bGUgd2luZG93IHsKICNlbmRp ZgogCiAjaWYgZGVmaW5lZChMQU5HVUFHRV9KQVZBU0NSSVBUKSAmJiBMQU5HVUFHRV9KQVZBU0NS SVBUCi0gICAgICAgIFtOb3RFbnVtZXJhYmxlLCBDdXN0b20sIFY4T25JbnN0YW5jZSwgVjhSZWFk T25seSwgSW1wbGVtZW50ZWRBcz10b1N0cmluZ0Z1bmN0aW9uXSBET01TdHJpbmcgdG9TdHJpbmco KTsKKyAgICAgICAgW05vdEVudW1lcmFibGUsIEN1c3RvbSwgVjhVbmZvcmdlYWJsZSwgVjhSZWFk T25seSwgSW1wbGVtZW50ZWRBcz10b1N0cmluZ0Z1bmN0aW9uXSBET01TdHJpbmcgdG9TdHJpbmco KTsKICNlbmRpZgogI2lmIGRlZmluZWQoVjhfQklORElORykgJiYgVjhfQklORElORwotICAgICAg ICBbTm90RW51bWVyYWJsZSwgQ3VzdG9tLCBWOE9uSW5zdGFuY2UsIFY4UmVhZE9ubHldIERPTU9i amVjdCB2YWx1ZU9mKCk7CisgICAgICAgIFtOb3RFbnVtZXJhYmxlLCBDdXN0b20sIFY4VW5mb3Jn ZWFibGUsIFY4UmVhZE9ubHldIERPTU9iamVjdCB2YWx1ZU9mKCk7CiAjZW5kaWYKICAgICB9Owog Cg==