78887 2012-02-17 02:29:27 -0800 Node.cloneNode's deep parameter should default to true 2013-10-21 07:10:08 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#dom-node-clonenode P2 Normal --- 1 code.vineet webkit-unassigned abarth annevk ap ayg bzbarsky darin eoconnor mjs Ms2ger rniwa oldest_to_newest 559068 0 code.vineet 2012-02-17 02:29:27 -0800 Spec url : http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#dom-node-clonenode 559072 1 127561 code.vineet 2012-02-17 02:34:54 -0800 Created attachment 127561 proposed patch Proposed patch. 559073 2 code.vineet 2012-02-17 02:35:18 -0800 See also : https://bugzilla.mozilla.org/show_bug.cgi?id=698381 559255 3 ap 2012-02-17 09:28:55 -0800 In WebKit, the argument is already optional, so the bug title is confusing. Is the part in parentheses what you are actually changing here? Unlike for Mozilla, defaulting to true changes behavior to exact opposite of what we had. Can the spec be fixed to match long-standing WebKit behavior instead? 559328 4 127561 abarth 2012-02-17 10:49:13 -0800 Comment on attachment 127561 proposed patch We should ask for the spec to change to our existing behavior. 560252 5 ayg 2012-02-20 09:07:13 -0800 Testing: IE10 Developer Preview and Chrome 18 dev default to false. Firefox 13.0a1 and Opera Next 12.00 alpha throw exceptions due to too few arguments. So false is correct. I've updated the spec: http://dvcs.w3.org/hg/domcore/rev/f2d97e6f5cf1 Thanks for the feedback. 560256 6 ap 2012-02-20 09:12:15 -0800 Thank you. This renders the bug invalid. 560265 7 ayg 2012-02-20 09:40:43 -0800 Anne and Ms2ger objected to my spec change, so I reverted it. I started a thread on www-dom. Implementer feedback would be highly appreciated: http://lists.w3.org/Archives/Public/www-dom/2012JanMar/0084.html 560272 8 ap 2012-02-20 10:15:01 -0800 Feedback sent. We should consider diverging from DOM 4 even if it ends up specifying different behavior. 623286 9 ap 2012-05-14 13:49:16 -0700 *** Bug 86377 has been marked as a duplicate of this bug. *** 909992 10 rniwa 2013-07-18 21:03:56 -0700 Blink changed its behavior in https://chromium.googlesource.com/chromium/blink/+/76c4cbdf9823988c787f3625365e2f25a325a172. 910172 11 ap 2013-07-19 09:36:34 -0700 Crazy. What is the value of specs if they can be changed to no longer match implementations, all for purely aesthetic reasons? 910217 12 rniwa 2013-07-19 10:30:20 -0700 (In reply to comment #11) > Crazy. What is the value of specs if they can be changed to no longer match implementations, all for purely aesthetic reasons? Matches Firefox behavior now. 910220 13 ap 2013-07-19 10:33:50 -0700 It does now after a Firefox change. But WebKit was 100% compliant before, and Firefox wasn't compliant with either spec version. 910311 14 annevk 2013-07-19 13:49:59 -0700 100% compliant seems dubious given that the argument was only recently made optional in the specification. That WebKit would simply use undefined as an implicit default everywhere was unfortunate, but given that nobody else did that I don't think we should have automatically accepted that as precedent as it's pretty bad API-wise. 910312 15 ap 2013-07-19 13:58:56 -0700 Anne, I think that you are talking about implementation details here. Observable behavior is that behavior of cloneNode() in WebKit was and remains compliant to DOM3, and DOM4 was written to specify something that did not match any browser. 910314 16 annevk 2013-07-19 14:11:08 -0700 Whether your throw or not for omitted non-optional arguments is not an implementation detail. Before Web IDL bindings were badly defined, but that does not mean that how WebKit decided to the bindings needs to be the standard. If you think it should be, I hope you understand this is the wrong forum. 941833 17 annevk 2013-10-21 07:10:08 -0700 See https://github.com/whatwg/dom/commit/70fdc5f9030c22c5ceca9e875e06f8b305529ef8 Sadness. 127561 2012-02-17 02:34:54 -0800 2012-02-17 10:49:12 -0800 proposed patch node.patch text/plain 4545 code.vineet SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwODA1MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEyLTAyLTE3ICBWaW5lZXQg Q2hhdWRoYXJ5ICA8dmluZWV0LmNoYXVkaGFyeUBtb3Rvcm9sYS5jb20+CisKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc4ODg3CisgICAgICAgIE5vZGUu Y2xvbmVOb2RlJ3MgZGVlcCBwYXJhbWV0ZXIgc2hvdWxkIGJlIG9wdGlvbmFsIChkZWZhdWx0IHRv IHRydWUpCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QXMgbmV3IHNwZWNpZmljYXRpb24gc2F5cyBkZWVwIGFyZ3VtZW50IG9mIGNsb25lTm9kZSBzaG91 bGQgYmUgZGVmYXVsdCB0byB0cnVlLgorICAgICAgICBTcGVjIHVybCA6IGh0dHA6Ly9kdmNzLncz Lm9yZy9oZy9kb21jb3JlL3Jhdy1maWxlL3RpcC9PdmVydmlldy5odG1sI2RvbS1ub2RlLWNsb25l bm9kZQorCisgICAgICAgIFRlc3Q6IGZhc3QvZG9tL2Nsb25lLW5vZGUtYXJndW1lbnRzLmh0bWwK KworICAgICAgICAqIGRvbS9Ob2RlLmg6IEFkZGVkIHN1cHBvcnRpdmUgbWV0aG9kLgorICAgICAg ICAoV2ViQ29yZTo6Tm9kZTo6Y2xvbmVOb2RlKToKKyAgICAgICAgKiBkb20vTm9kZS5pZGw6IE1v ZGlmaWVkIGRlZXAgYXJndW1lbnQgYXMgb3B0aW9uYWwuCisKIDIwMTItMDItMTcgIFlvc2lmdW1p IElub3VlICA8eW9zaW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtGb3Jtc10gSW50ZWdyYXRl IElucHV0VHlwZTo6ZGlzcGF0Y2hDaGFuZ2VFdmVudEluUmVzcG9uc2VUb1NldFZhbHVlIGludG8g SW5wdXRUeXBlOjpzZXRWYWx1ZQpJbmRleDogU291cmNlL1dlYkNvcmUvZG9tL05vZGUuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9kb20vTm9kZS5oCShyZXZpc2lvbiAxMDgwMzQpCisr KyBTb3VyY2UvV2ViQ29yZS9kb20vTm9kZS5oCSh3b3JraW5nIGNvcHkpCkBAIC0xNzcsNiArMTc3 LDcgQEAgcHVibGljOgogCiAgICAgdm9pZCByZW1vdmUoRXhjZXB0aW9uQ29kZSYpOwogICAgIGJv b2wgaGFzQ2hpbGROb2RlcygpIGNvbnN0IHsgcmV0dXJuIGZpcnN0Q2hpbGQoKTsgfQorICAgIFBh c3NSZWZQdHI8Tm9kZT4gY2xvbmVOb2RlKCkgeyByZXR1cm4gY2xvbmVOb2RlKHRydWUpOyB9CiAg ICAgdmlydHVhbCBQYXNzUmVmUHRyPE5vZGU+IGNsb25lTm9kZShib29sIGRlZXApID0gMDsKICAg ICBjb25zdCBBdG9taWNTdHJpbmcmIGxvY2FsTmFtZSgpIGNvbnN0IHsgcmV0dXJuIHZpcnR1YWxM b2NhbE5hbWUoKTsgfQogICAgIGNvbnN0IEF0b21pY1N0cmluZyYgbmFtZXNwYWNlVVJJKCkgY29u c3QgeyByZXR1cm4gdmlydHVhbE5hbWVzcGFjZVVSSSgpOyB9CkluZGV4OiBTb3VyY2UvV2ViQ29y ZS9kb20vTm9kZS5pZGwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZG9tL05vZGUuaWRs CShyZXZpc2lvbiAxMDgwMzQpCisrKyBTb3VyY2UvV2ViQ29yZS9kb20vTm9kZS5pZGwJKHdvcmtp bmcgY29weSkKQEAgLTc5LDcgKzc5LDcgQEAgbW9kdWxlIGNvcmUgewogICAgICAgICAgICAgcmFp c2VzKERPTUV4Y2VwdGlvbik7CiAKICAgICAgICAgYm9vbGVhbiAgICAgICAgICAgIGhhc0NoaWxk Tm9kZXMoKTsKLSAgICAgICAgTm9kZSAgICAgICAgICAgICAgIGNsb25lTm9kZShpbiBbT3B0aW9u YWw9RGVmYXVsdElzVW5kZWZpbmVkXSBib29sZWFuIGRlZXApOworICAgICAgICBOb2RlICAgICAg ICAgICAgICAgY2xvbmVOb2RlKGluIFtPcHRpb25hbF0gYm9vbGVhbiBkZWVwKTsKICAgICAgICAg dm9pZCAgICAgICAgICAgICAgIG5vcm1hbGl6ZSgpOwogCiAgICAgICAgIC8vIEludHJvZHVjZWQg aW4gRE9NIExldmVsIDI6CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxMDgwNTIpCisrKyBMYXlvdXRUZXN0 cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNiBAQAorMjAxMi0wMi0xNyAg VmluZWV0IENoYXVkaGFyeSAgPHZpbmVldC5jaGF1ZGhhcnlAbW90b3JvbGEuY29tPgorCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03ODg4NworICAgICAg ICBOb2RlLmNsb25lTm9kZSdzIGRlZXAgcGFyYW1ldGVyIHNob3VsZCBiZSBvcHRpb25hbCAoZGVm YXVsdCB0byB0cnVlKQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEFkZGVkIHRlc3QgdG8gY2hlY2sgbm9kZS5jbG9uZU5vZGUgd2l0aCBObyBkZWVwIGFy Z3VtZW50LAorICAgICAgICBkZWVwIGFyZ3VtZW50IHRydWUgYW5kIGZhbHNlLgorCisgICAgICAg ICogZmFzdC9kb20vY2xvbmUtbm9kZS1hcmd1bWVudHMtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAg ICAgICAgKiBmYXN0L2RvbS9jbG9uZS1ub2RlLWFyZ3VtZW50cy5odG1sOiBBZGRlZC4KKwogMjAx Mi0wMi0xNyAgTm9lbCBHb3Jkb24gIDxub2VsLmdvcmRvbkBnbWFpbC5jb20+CiAKICAgICAgICAg W2Nocm9taXVtXSBSZWJhc2VsaW5lIEpQRUcgaW1hZ2UgcmVzdWx0cyBhZnRlciByMTA3Mzg5Cklu ZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9jbG9uZS1ub2RlLWFyZ3VtZW50cy1leHBlY3RlZC50 eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9kb20vY2xvbmUtbm9kZS1hcmd1bWVu dHMtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20vY2xv bmUtbm9kZS1hcmd1bWVudHMtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDkg QEAKK1RoaXMgcGFnZSB0ZXN0cyBjYWxsaW5nIG5vZGUuY2xvbmVOb2RlIHdpdGggYXJndW1lbnRz LgorCitQQVNTIGNsb25lZC5jaGlsZE5vZGVzLmxlbmd0aCBpcyAyCitQQVNTIGNsb25lZC50ZXh0 Q29udGVudCA9PSAnaGVsbG8gd29ybGQnIGlzIHRydWUKK1BBU1MgY2xvbmVkLmNoaWxkTm9kZXMu bGVuZ3RoIGlzIDIKK1BBU1MgY2xvbmVkLnRleHRDb250ZW50ID09ICdoZWxsbyB3b3JsZCcgaXMg dHJ1ZQorUEFTUyBjbG9uZWQuY2hpbGROb2Rlcy5sZW5ndGggaXMgMAorUEFTUyBjbG9uZWQudGV4 dENvbnRlbnQgPT0gJycgaXMgdHJ1ZQorCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9jbG9u ZS1ub2RlLWFyZ3VtZW50cy5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9t L2Nsb25lLW5vZGUtYXJndW1lbnRzLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9m YXN0L2RvbS9jbG9uZS1ub2RlLWFyZ3VtZW50cy5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsx LDMxIEBACis8aHRtbD4KKzxoZWFkPgorPHNjcmlwdCBzcmM9Ii4uL2pzL3Jlc291cmNlcy9qcy10 ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxwPlRoaXMgcGFnZSB0ZXN0 cyBjYWxsaW5nIG5vZGUuY2xvbmVOb2RlIHdpdGggYXJndW1lbnRzLjwvcD4KKzxkaXYgaWQ9J2Nv bnNvbGUnPjwvZGl2PgorPHNjcmlwdD4KK3ZhciBjbG9uZWQ7CisKK2lmICh3aW5kb3cubGF5b3V0 VGVzdENvbnRyb2xsZXIpCisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOwor Cit2YXIgZCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIpOworZC5pbm5lckhUTUwgPSAi PHNwYW4+aGVsbG8gPC9zcGFuPjxzcGFuPndvcmxkPC9zcGFuPiI7CisKK2Nsb25lZCA9IGQuY2xv bmVOb2RlKCk7CitzaG91bGRCZSgnY2xvbmVkLmNoaWxkTm9kZXMubGVuZ3RoJywnMicpOworc2hv dWxkQmVUcnVlKCJjbG9uZWQudGV4dENvbnRlbnQgPT0gJ2hlbGxvIHdvcmxkJyIpOworCitjbG9u ZWQgPSBkLmNsb25lTm9kZSh0cnVlKTsKK3Nob3VsZEJlKCdjbG9uZWQuY2hpbGROb2Rlcy5sZW5n dGgnLCcyJyk7CitzaG91bGRCZVRydWUoImNsb25lZC50ZXh0Q29udGVudCA9PSAnaGVsbG8gd29y bGQnIik7CisKK2Nsb25lZCA9IGQuY2xvbmVOb2RlKGZhbHNlKTsKK3Nob3VsZEJlKCdjbG9uZWQu Y2hpbGROb2Rlcy5sZW5ndGgnLCcwJyk7CitzaG91bGRCZVRydWUoImNsb25lZC50ZXh0Q29udGVu dCA9PSAnJyIpOworCis8L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K