78877 2012-02-16 21:55:38 -0800 [GObject IDL Parser] STRING argument should be HASHREF 2012-03-12 16:46:36 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 anthony webkit-unassigned abarth haraken japhet webkit.review.bot oldest_to_newest 558905 0 anthony 2012-02-16 21:55:38 -0800 i am admittedly not adept with perl, but i believe a mistake was made at one point to "correct" some warnings emitted during `generate-bindings.pl`, specifically `CodeGeneratorGObject.pm`. emitted error: Unquoted string "attributes" may clash with future reserved word at ../Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm line 1065. ------- previous (eg, WebKitGTK+ 1.6.3): [...] 1059 $function->signature->extendedAttributes($attribute->signature->extendedAttributes); 1060 1061 my $param = new domSignature(); 1062 $param->name("value"); 1063 $param->type($attribute->signature->type); 1064 my %attributes = (); 1065 $param->extendedAttributes(attributes); [...] ------- trunk: [...] 1090 $function->signature->extendedAttributes($attribute->signature->extendedAttributes); 1091 1092 my $param = new domSignature(); 1093 $param->name("value"); 1094 $param->type($attribute->signature->type); 1095 my %attributes = (); 1096 $param->extendedAttributes("attributes"); [...] ------- notice how quotes were added to "attributes"? IIUC this is now passing `attributes` as a simple string instead of a HASHREF. i included the first line (1059 and 1060, resp.) to show how it's used elsewhere ... if i add a simple: print "ATTR: ", $attribute->signature->extendedAttributes; ------- i get: [...] ATTR: HASH(0xf74f78) ATTR: HASH(0xf814e8) ATTR: HASH(0xf81a88) [...] ------- ... suggesting the unused my `%attributes = ();` is the intended type. seems to still build/etc just fine -- no idea what it's affecting, if anything. RESOLUTION: pass "attributes" as \%attributes 575797 1 131248 anthony 2012-03-11 11:00:50 -0700 Created attachment 131248 Change `attributes` to a hashref extended attributes (eg, CallWith=XX) are otherwise dropped. this is a dynamic set_* function anyway, so it's not "really" affecting anything, but is incorrect nonetheless. 576295 2 131356 anthony 2012-03-12 11:15:41 -0700 Created attachment 131356 Patch 576301 3 webkit.review.bot 2012-03-12 11:19:35 -0700 Attachment 131356 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 576321 4 131363 anthony 2012-03-12 11:33:40 -0700 Created attachment 131363 Patch 576720 5 131363 webkit.review.bot 2012-03-12 16:46:30 -0700 Comment on attachment 131363 Patch Clearing flags on attachment: 131363 Committed r110504: <http://trac.webkit.org/changeset/110504> 576721 6 webkit.review.bot 2012-03-12 16:46:36 -0700 All reviewed patches have been landed. Closing bug. 131248 2012-03-11 11:00:50 -0700 2012-03-12 11:15:37 -0700 Change `attributes` to a hashref attr-codegen.patch text/plain 526 anthony LS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yR09iamVj dC5wbQkyMDEyLTAyLTIzIDE3OjAwOjA4LjAwMDAwMDAwMCAtMDYwMAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JHT2JqZWN0LnBtCTIwMTItMDMtMTEg MTI6NTI6MDAuMjE3NDQyNTE4IC0wNTAwCkBAIC0xMDkzLDcgKzEwOTMsNyBAQAogICAgICAgICAk cGFyYW0tPm5hbWUoInZhbHVlIik7CiAgICAgICAgICRwYXJhbS0+dHlwZSgkYXR0cmlidXRlLT5z aWduYXR1cmUtPnR5cGUpOwogICAgICAgICBteSAlYXR0cmlidXRlcyA9ICgpOwotICAgICAgICAk cGFyYW0tPmV4dGVuZGVkQXR0cmlidXRlcygiYXR0cmlidXRlcyIpOworICAgICAgICAkcGFyYW0t PmV4dGVuZGVkQXR0cmlidXRlcyhcJWF0dHJpYnV0ZXMpOwogICAgICAgICBteSAkYXJyYXlSZWYg PSAkZnVuY3Rpb24tPnBhcmFtZXRlcnM7CiAgICAgICAgIHB1c2goQCRhcnJheVJlZiwgJHBhcmFt KTsKICAgICAgICAgCg== 131356 2012-03-12 11:15:41 -0700 2012-03-12 11:33:33 -0700 Patch bug-78877-20120312131539.patch text/plain 1478 anthony U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwNDQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjViMjBiZTJlYzI0YjI3 ZTk5OTNiOTJkNzIwM2ViN2ExYWFmY2IyNy4uZWJjZTc3NjFhN2JjZTBmMmIwMDYxMzQ2ZGQ2ZmI0 ZWM4MmM1OWM0YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAzLTEyICBDIEFu dGhvbnkgUmlzaW5nZXIgIDxhbnRob255QHh0ZngubWU+CisKKyAgICAgICAgW0dPYmplY3QgSURM IFBhcnNlcl0gU1RSSU5HIGFyZ3VtZW50IHNob3VsZCBiZSBIQVNIUkVGCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03ODg3NworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gKE9PUFMhKQor CisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yR09iamVjdC5wbToKKyAg ICAgICAgKEdlbmVyYXRlRnVuY3Rpb25zKTogZXh0ZW5kZWRBdHRyaWJ1dGVzIGFyZSBoYXNoZXMs IG5vdCBzdHJpbmdzCisKIDIwMTItMDMtMTIgIFBhdmVsIFBvZGl2aWxvdiAgPHBvZGl2aWxvdkBj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogZXh0cmFjdCBSZXNvdXJjZVNj cmlwdE1hcHBpbmcgZnJvbSBNYWluU2NyaXB0TWFwcGluZy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckdPYmplY3QucG0gYi9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JHT2JqZWN0LnBtCmluZGV4IDQ3 Njc3YThjMzE1NDg3MmYzYjVjNmQ3MGRmMGJjZWYyMTY4OGMyMTAuLmUxMGQwMTFjM2Q0ZmQ5ZGFh YjI3OWNjMjJkMDg3ZDMwNmQzNjQ2NGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckdPYmplY3QucG0KKysrIGIvU291cmNlL1dlYkNvcmUv YmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yR09iamVjdC5wbQpAQCAtMTA5Myw3ICsxMDkz LDcgQEAgc3ViIEdlbmVyYXRlRnVuY3Rpb25zIHsKICAgICAgICAgJHBhcmFtLT5uYW1lKCJ2YWx1 ZSIpOwogICAgICAgICAkcGFyYW0tPnR5cGUoJGF0dHJpYnV0ZS0+c2lnbmF0dXJlLT50eXBlKTsK ICAgICAgICAgbXkgJWF0dHJpYnV0ZXMgPSAoKTsKLSAgICAgICAgJHBhcmFtLT5leHRlbmRlZEF0 dHJpYnV0ZXMoImF0dHJpYnV0ZXMiKTsKKyAgICAgICAgJHBhcmFtLT5leHRlbmRlZEF0dHJpYnV0 ZXMoXCVhdHRyaWJ1dGVzKTsKICAgICAgICAgbXkgJGFycmF5UmVmID0gJGZ1bmN0aW9uLT5wYXJh bWV0ZXJzOwogICAgICAgICBwdXNoKEAkYXJyYXlSZWYsICRwYXJhbSk7CiAgICAgICAgIAo= 131363 2012-03-12 11:33:40 -0700 2012-03-12 16:46:30 -0700 Patch bug-78877-20120312133339.patch text/plain 1445 anthony U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwNDQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjViMjBiZTJlYzI0YjI3 ZTk5OTNiOTJkNzIwM2ViN2ExYWFmY2IyNy4uZTVkZjY2MzYyMDQ4N2NlNTIzMGFkYmZiMzM1MjQ0 MTExOTExMTg4ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAzLTEyICBDIEFu dGhvbnkgUmlzaW5nZXIgIDxhbnRob255QHh0ZngubWU+CisKKyAgICAgICAgW0dPYmplY3QgSURM IFBhcnNlcl0gU1RSSU5HIGFyZ3VtZW50IHNob3VsZCBiZSBIQVNIUkVGCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03ODg3NworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2Rl R2VuZXJhdG9yR09iamVjdC5wbToKKyAgICAgICAgKEdlbmVyYXRlRnVuY3Rpb25zKTogZXh0ZW5k ZWRBdHRyaWJ1dGVzIGFyZSBoYXNoZXMsIG5vdCBzdHJpbmdzCisKIDIwMTItMDMtMTIgIFBhdmVs IFBvZGl2aWxvdiAgPHBvZGl2aWxvdkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3Bl Y3RvcjogZXh0cmFjdCBSZXNvdXJjZVNjcmlwdE1hcHBpbmcgZnJvbSBNYWluU2NyaXB0TWFwcGlu Zy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVy YXRvckdPYmplY3QucG0gYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5l cmF0b3JHT2JqZWN0LnBtCmluZGV4IDQ3Njc3YThjMzE1NDg3MmYzYjVjNmQ3MGRmMGJjZWYyMTY4 OGMyMTAuLmUxMGQwMTFjM2Q0ZmQ5ZGFhYjI3OWNjMjJkMDg3ZDMwNmQzNjQ2NGUgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckdPYmplY3Qu cG0KKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yR09i amVjdC5wbQpAQCAtMTA5Myw3ICsxMDkzLDcgQEAgc3ViIEdlbmVyYXRlRnVuY3Rpb25zIHsKICAg ICAgICAgJHBhcmFtLT5uYW1lKCJ2YWx1ZSIpOwogICAgICAgICAkcGFyYW0tPnR5cGUoJGF0dHJp YnV0ZS0+c2lnbmF0dXJlLT50eXBlKTsKICAgICAgICAgbXkgJWF0dHJpYnV0ZXMgPSAoKTsKLSAg ICAgICAgJHBhcmFtLT5leHRlbmRlZEF0dHJpYnV0ZXMoImF0dHJpYnV0ZXMiKTsKKyAgICAgICAg JHBhcmFtLT5leHRlbmRlZEF0dHJpYnV0ZXMoXCVhdHRyaWJ1dGVzKTsKICAgICAgICAgbXkgJGFy cmF5UmVmID0gJGZ1bmN0aW9uLT5wYXJhbWV0ZXJzOwogICAgICAgICBwdXNoKEAkYXJyYXlSZWYs ICRwYXJhbSk7CiAgICAgICAgIAo=