<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>78865</bug_id>
          
          <creation_ts>2012-02-16 17:49:45 -0800</creation_ts>
          <short_desc>[Chromium] Include TestShellLinux.cpp in the build for Android</short_desc>
          <delta_ts>2012-02-17 10:10:10 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Peter Beverloo">peter</reporter>
          <assigned_to name="Peter Beverloo">peter</assigned_to>
          <cc>eric</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>558762</commentid>
    <comment_count>0</comment_count>
    <who name="Peter Beverloo">peter</who>
    <bug_when>2012-02-16 17:49:45 -0800</bug_when>
    <thetext>[Chromium] Include TestShellLinux.cpp in the build for Android</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>558764</commentid>
    <comment_count>1</comment_count>
      <attachid>127486</attachid>
    <who name="Peter Beverloo">peter</who>
    <bug_when>2012-02-16 17:52:14 -0800</bug_when>
    <thetext>Created attachment 127486
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>558786</commentid>
    <comment_count>2</comment_count>
      <attachid>127486</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2012-02-16 18:29:10 -0800</bug_when>
    <thetext>Comment on attachment 127486
Patch

Wow, it&apos;s still called TestShell... amazing. :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>558875</commentid>
    <comment_count>3</comment_count>
      <attachid>127486</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-02-16 21:00:06 -0800</bug_when>
    <thetext>Comment on attachment 127486
Patch

Rejecting attachment 127486 from commit-queue.

Failed to run &quot;[&apos;/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch&apos;, &apos;--status-host=queues.webkit.org&apos;, &apos;-...&quot; exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Tools/ChangeLog neither lists a valid reviewer nor contains the string &quot;Unreviewed&quot; or &quot;Rubber stamp&quot; (case insensitive).

Full output: http://queues.webkit.org/results/11535428</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>558913</commentid>
    <comment_count>4</comment_count>
    <who name="Peter Beverloo">peter</who>
    <bug_when>2012-02-16 22:10:59 -0800</bug_when>
    <thetext>Oh wow, how did I manage to rip that out. Sorry, I&apos;ll fix and land in the morning.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>559253</commentid>
    <comment_count>5</comment_count>
      <attachid>127605</attachid>
    <who name="Peter Beverloo">peter</who>
    <bug_when>2012-02-17 09:26:47 -0800</bug_when>
    <thetext>Created attachment 127605
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>559254</commentid>
    <comment_count>6</comment_count>
      <attachid>127605</attachid>
    <who name="Peter Beverloo">peter</who>
    <bug_when>2012-02-17 09:27:38 -0800</bug_when>
    <thetext>Comment on attachment 127605
Patch

Pushing this on the CQ.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>559281</commentid>
    <comment_count>7</comment_count>
      <attachid>127605</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-02-17 10:10:06 -0800</bug_when>
    <thetext>Comment on attachment 127605
Patch

Clearing flags on attachment: 127605

Committed r108090: &lt;http://trac.webkit.org/changeset/108090&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>559282</commentid>
    <comment_count>8</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-02-17 10:10:10 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>127486</attachid>
            <date>2012-02-16 17:52:14 -0800</date>
            <delta_ts>2012-02-17 09:26:41 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-78865-20120217015212.patch</filename>
            <type>text/plain</type>
            <size>1491</size>
            <attacher name="Peter Beverloo">peter</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4MDA3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTYzNzM5MDk2NjU0NGNhMzIxYjJiOGZiZjE0NGMyNTk2
YmM5MzVjYS4uYzBjODVlMzMzODk3ODQzMWEzMThjNDAwYjUxOGNiZDViOGFjOWYyMiAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0
IEBACisyMDEyLTAyLTE2ICBQZXRlciBCZXZlcmxvbyAgPHBldGVyQGNocm9taXVtLm9yZz4KKwor
ICAgICAgICBbQ2hyb21pdW1dIEluY2x1ZGUgVGVzdFNoZWxsTGludXguY3BwIGluIHRoZSBidWls
ZCBmb3IgQW5kcm9pZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9Nzg4NjUKKworICAgICAgICBBbmRyb2lkIHdpbGwgYmUgcmUtdXNpbmcgdGhlIFRlc3RT
aGVsbExpbnV4LmNwcCBmaWxlLiBJIGFscmVhZHkKKyAgICAgICAgYWRkZWQgdGhpcyByMTA0MDMz
LCBidXQgaXQgc2VlbXMgdG8gaGF2ZSBnb3R0ZW4gbG9zdCBpbiB0aGUKKyAgICAgICAgcmVjZW50
IHJlZmFjdG9yaW5ncy4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL0R1bXBSZW5kZXJUcmVl
Lmd5cC9EdW1wUmVuZGVyVHJlZS5neXA6CisKIDIwMTItMDItMTYgIERpcmsgUHJhbmtlICA8ZHBy
YW5rZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgbnJ3dDogc2ltcGxpZnkgd29ya2VyIGludGVy
ZmFjZQpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvRHVtcFJlbmRlclRyZWUuZ3lw
L0R1bXBSZW5kZXJUcmVlLmd5cCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL0R1bXBSZW5kZXJUcmVl
Lmd5cC9EdW1wUmVuZGVyVHJlZS5neXAKaW5kZXggMDIzNzhjYjZjZmM0ZmI1ZGZlOTZkZTJhNTVh
OGY3MmM5MTVhM2ZjNS4uNzc0Y2E5MDA4MGNmM2NlYTY3OWYwOTA1ODZhZDdkMjc4ZWZkODI3OSAx
MDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvRHVtcFJlbmRlclRyZWUuZ3lwL0R1bXBS
ZW5kZXJUcmVlLmd5cAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9EdW1wUmVuZGVyVHJlZS5n
eXAvRHVtcFJlbmRlclRyZWUuZ3lwCkBAIC0yMzEsNiArMjMxLDkgQEAKICAgICAgICAgICAgICAg
ICAgICAgJ2RlcGVuZGVuY2llcyc6IFsKICAgICAgICAgICAgICAgICAgICAgICAgICdJbWFnZURp
ZmYjaG9zdCcsCiAgICAgICAgICAgICAgICAgICAgIF0sCisgICAgICAgICAgICAgICAgICAgICdz
b3VyY2VzLyc6IFsKKyAgICAgICAgICAgICAgICAgICAgICAgIFsnaW5jbHVkZScsICdjaHJvbWl1
bS9UZXN0U2hlbGxMaW51eFxcLmNwcCQnXSwKKyAgICAgICAgICAgICAgICAgICAgXSwKICAgICAg
ICAgICAgICAgICB9LHsgIyBPUyE9ImFuZHJvaWQiCiAgICAgICAgICAgICAgICAgICAgICdzb3Vy
Y2VzLyc6IFsKICAgICAgICAgICAgICAgICAgICAgICAgIFsnZXhjbHVkZScsICcoQW5kcm9pZClc
XC5jcHAkJ10K
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>127605</attachid>
            <date>2012-02-17 09:26:47 -0800</date>
            <delta_ts>2012-02-17 10:10:06 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-78865-20120217172645.patch</filename>
            <type>text/plain</type>
            <size>1527</size>
            <attacher name="Peter Beverloo">peter</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4MDA3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTYzNzM5MDk2NjU0NGNhMzIxYjJiOGZiZjE0NGMyNTk2
YmM5MzVjYS4uNjNmNTExMGU1NDg1Y2IzZTQ5ZDdlMmQxNWUxZDllMGJkYzVjMGVhMyAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2
IEBACisyMDEyLTAyLTE2ICBQZXRlciBCZXZlcmxvbyAgPHBldGVyQGNocm9taXVtLm9yZz4KKwor
ICAgICAgICBbQ2hyb21pdW1dIEluY2x1ZGUgVGVzdFNoZWxsTGludXguY3BwIGluIHRoZSBidWls
ZCBmb3IgQW5kcm9pZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9Nzg4NjUKKworICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KKworICAgICAg
ICBBbmRyb2lkIHdpbGwgYmUgcmUtdXNpbmcgdGhlIFRlc3RTaGVsbExpbnV4LmNwcCBmaWxlLiBJ
IGFscmVhZHkKKyAgICAgICAgYWRkZWQgdGhpcyByMTA0MDMzLCBidXQgaXQgc2VlbXMgdG8gaGF2
ZSBnb3R0ZW4gbG9zdCBpbiB0aGUKKyAgICAgICAgcmVjZW50IHJlZmFjdG9yaW5ncy4KKworICAg
ICAgICAqIER1bXBSZW5kZXJUcmVlL0R1bXBSZW5kZXJUcmVlLmd5cC9EdW1wUmVuZGVyVHJlZS5n
eXA6CisKIDIwMTItMDItMTYgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CiAK
ICAgICAgICAgbnJ3dDogc2ltcGxpZnkgd29ya2VyIGludGVyZmFjZQpkaWZmIC0tZ2l0IGEvVG9v
bHMvRHVtcFJlbmRlclRyZWUvRHVtcFJlbmRlclRyZWUuZ3lwL0R1bXBSZW5kZXJUcmVlLmd5cCBi
L1Rvb2xzL0R1bXBSZW5kZXJUcmVlL0R1bXBSZW5kZXJUcmVlLmd5cC9EdW1wUmVuZGVyVHJlZS5n
eXAKaW5kZXggMDIzNzhjYjZjZmM0ZmI1ZGZlOTZkZTJhNTVhOGY3MmM5MTVhM2ZjNS4uNzc0Y2E5
MDA4MGNmM2NlYTY3OWYwOTA1ODZhZDdkMjc4ZWZkODI3OSAxMDA2NDQKLS0tIGEvVG9vbHMvRHVt
cFJlbmRlclRyZWUvRHVtcFJlbmRlclRyZWUuZ3lwL0R1bXBSZW5kZXJUcmVlLmd5cAorKysgYi9U
b29scy9EdW1wUmVuZGVyVHJlZS9EdW1wUmVuZGVyVHJlZS5neXAvRHVtcFJlbmRlclRyZWUuZ3lw
CkBAIC0yMzEsNiArMjMxLDkgQEAKICAgICAgICAgICAgICAgICAgICAgJ2RlcGVuZGVuY2llcyc6
IFsKICAgICAgICAgICAgICAgICAgICAgICAgICdJbWFnZURpZmYjaG9zdCcsCiAgICAgICAgICAg
ICAgICAgICAgIF0sCisgICAgICAgICAgICAgICAgICAgICdzb3VyY2VzLyc6IFsKKyAgICAgICAg
ICAgICAgICAgICAgICAgIFsnaW5jbHVkZScsICdjaHJvbWl1bS9UZXN0U2hlbGxMaW51eFxcLmNw
cCQnXSwKKyAgICAgICAgICAgICAgICAgICAgXSwKICAgICAgICAgICAgICAgICB9LHsgIyBPUyE9
ImFuZHJvaWQiCiAgICAgICAgICAgICAgICAgICAgICdzb3VyY2VzLyc6IFsKICAgICAgICAgICAg
ICAgICAgICAgICAgIFsnZXhjbHVkZScsICcoQW5kcm9pZClcXC5jcHAkJ10K
</data>

          </attachment>
      

    </bug>

</bugzilla>