78861 2012-02-16 17:09:43 -0800 [WK2] Clearing notifications does not clean up internal state 2012-02-22 15:44:55 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Mac OS X 10.7 RESOLVED FIXED InRadar P2 Normal --- 1 jonlee jonlee webkit-bug-importer oldest_to_newest 558715 0 jonlee 2012-02-16 17:09:43 -0800 When the page clears notifications (URL changed, window closed, etc), the WebNotificationManager forwards that request to the client, but doesn't clean up its internal state. This could lead to notifications not being released when they should since the manager is still holding onto them. 558717 1 webkit-bug-importer 2012-02-16 17:12:02 -0800 <rdar://problem/10881167> 558728 2 127478 jonlee 2012-02-16 17:17:20 -0800 Created attachment 127478 Patch 562473 3 jonlee 2012-02-22 15:44:55 -0800 Committed r108566: <http://trac.webkit.org/changeset/108566> 127478 2012-02-16 17:17:20 -0800 2012-02-22 15:37:48 -0800 Patch bug-78861-20120216171758.patch text/plain 5985 jonlee U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3ODUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNzgzYjEzZTE2ODBmOWFj YjAzN2UwMjgyMTU2MzdmNzY3NjA3ZjM3MC4uZjVjMGRjZDM3YjU0ZWIxM2VlOTEwNGUxNzVjNDEy NTA0ODdkYWM0MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTAyLTE2ICBKb24g TGVlICA8am9ubGVlQGFwcGxlLmNvbT4KKworICAgICAgICBbV0syXSBDbGVhcmluZyBub3RpZmlj YXRpb25zIGRvZXMgbm90IGNsZWFuIHVwIGludGVybmFsIHN0YXRlCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03ODg2MQorICAgICAgICA8cmRhcjovL3By b2JsZW0vMTA4ODExNjc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBXZWJQcm9jZXNzL05vdGlmaWNhdGlvbnMvV2ViTm90aWZpY2F0aW9uTWFuYWdl ci5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYk5vdGlmaWNhdGlvbk1hbmFnZXI6OmNsZWFyTm90 aWZpY2F0aW9ucyk6IFRoaXMgZnVuY3Rpb24gd2FzIG1pc3NpbmcgcmVtb3ZpbmcgdGhlIG5vdGlm aWNhdGlvbgorICAgICAgICBlbnRyaWVzIGZyb20gdGhlIG90aGVyIG1hcHMuCisgICAgICAgIChX ZWJLaXQ6OldlYk5vdGlmaWNhdGlvbk1hbmFnZXI6OmRpZERlc3Ryb3lOb3RpZmljYXRpb24pOiBX aGVuIHRoZSBub3RpZmljYXRpb24gaXMgZGVzdHJveWVkLCBpdCBzaG91bGQKKyAgICAgICAgYWxz byBiZSByZW1vdmVkIGZyb20gdGhlIGNvbnRleHQgbWFwLgorICAgICAgICAoV2ViS2l0OjpXZWJO b3RpZmljYXRpb25NYW5hZ2VyOjpkaWRDbG9zZU5vdGlmaWNhdGlvbnMpOiBSZWZhY3RvciB0byBw dWxsIG91dCB0aGUgY29kZSB0aGF0IHJlbW92ZXMKKyAgICAgICAgYSBwcm92aWRlZCBub3RpZmlj YXRpb24gZnJvbSB0aGUgY29udGV4dCBtYXAuCisgICAgICAgIChXZWJLaXQ6OldlYk5vdGlmaWNh dGlvbk1hbmFnZXI6OnJlbW92ZU5vdGlmaWNhdGlvbkZyb21Db250ZXh0TWFwKTogRmluZCB0aGUg bm90aWZpY2F0aW9uIGluIHRoZSBtYXAsIGFuZAorICAgICAgICByZW1vdmUgaXQuIElmIHRoZSBt YXAgaXMgZW1wdHksIGdldCByaWQgb2YgdGhlIGVudHJ5LgorICAgICAgICAqIFdlYlByb2Nlc3Mv Tm90aWZpY2F0aW9ucy9XZWJOb3RpZmljYXRpb25NYW5hZ2VyLmg6CisgICAgICAgIChXZWJOb3Rp ZmljYXRpb25NYW5hZ2VyKToKKwogMjAxMi0wMi0xNSAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJz Y2FAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBUaWxlZENvcmVBbmltYXRpb25EcmF3aW5nQXJl YTo6Zm9yY2VSZXBhaW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL05v dGlmaWNhdGlvbnMvV2ViTm90aWZpY2F0aW9uTWFuYWdlci5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL05vdGlmaWNhdGlvbnMvV2ViTm90aWZpY2F0aW9uTWFuYWdlci5jcHAKaW5kZXgg ODRiNTJjMmFjMDNmYjYyMzEyZDNkZmQ3YjJlNjU1NTZjZGJkZTZhNC4uNmI4Yjc0ZDcxNGYzY2Jh ZGM0YWFiZDI0ODlhMzM3YzUwZDdiMGFkYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9Ob3RpZmljYXRpb25zL1dlYk5vdGlmaWNhdGlvbk1hbmFnZXIuY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvTm90aWZpY2F0aW9ucy9XZWJOb3RpZmljYXRpb25NYW5h Z2VyLmNwcApAQCAtMSw1ICsxLDUgQEAKIC8qCi0gKiBDb3B5cmlnaHQgKEMpIDIwMTEgQXBwbGUg SW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSAyMDExLCAyMDEyIEFw cGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBhbmQg dXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICAqIG1vZGlm aWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0 aW9ucwpAQCAtMTQ5LDcgKzE0OSwxNiBAQCB2b2lkIFdlYk5vdGlmaWNhdGlvbk1hbmFnZXI6OmNs ZWFyTm90aWZpY2F0aW9ucyhXZWJDb3JlOjpTY3JpcHRFeGVjdXRpb25Db250ZXh0KgogICAgIGlm IChpdCA9PSBtX25vdGlmaWNhdGlvbkNvbnRleHRNYXAuZW5kKCkpCiAgICAgICAgIHJldHVybjsK ICAgICAKLSAgICBtX3Byb2Nlc3MtPmNvbm5lY3Rpb24oKS0+c2VuZChNZXNzYWdlczo6V2ViTm90 aWZpY2F0aW9uTWFuYWdlclByb3h5OjpDbGVhck5vdGlmaWNhdGlvbnMoaXQtPnNlY29uZCksIHBh Z2UtPnBhZ2VJRCgpKTsKKyAgICBWZWN0b3I8dWludDY0X3Q+JiBub3RpZmljYXRpb25JRHMgPSBp dC0+c2Vjb25kOworICAgIG1fcHJvY2Vzcy0+Y29ubmVjdGlvbigpLT5zZW5kKE1lc3NhZ2VzOjpX ZWJOb3RpZmljYXRpb25NYW5hZ2VyUHJveHk6OkNsZWFyTm90aWZpY2F0aW9ucyhub3RpZmljYXRp b25JRHMpLCBwYWdlLT5wYWdlSUQoKSk7CisgICAgc2l6ZV90IGNvdW50ID0gbm90aWZpY2F0aW9u SURzLnNpemUoKTsKKyAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IGNvdW50OyArK2kpIHsKKyAg ICAgICAgUmVmUHRyPE5vdGlmaWNhdGlvbj4gbm90aWZpY2F0aW9uID0gbV9ub3RpZmljYXRpb25J RE1hcC50YWtlKG5vdGlmaWNhdGlvbklEc1tpXSk7CisgICAgICAgIGlmICghbm90aWZpY2F0aW9u KQorICAgICAgICAgICAgY29udGludWU7CisgICAgICAgIG1fbm90aWZpY2F0aW9uTWFwLnJlbW92 ZShub3RpZmljYXRpb24pOworICAgIH0KKyAgICAKICAgICBtX25vdGlmaWNhdGlvbkNvbnRleHRN YXAucmVtb3ZlKGl0KTsKICNlbmRpZgogfQpAQCAtMTYxLDcgKzE3MCw4IEBAIHZvaWQgV2ViTm90 aWZpY2F0aW9uTWFuYWdlcjo6ZGlkRGVzdHJveU5vdGlmaWNhdGlvbihOb3RpZmljYXRpb24qIG5v dGlmaWNhdGlvbiwKICAgICBpZiAoIW5vdGlmaWNhdGlvbklEKQogICAgICAgICByZXR1cm47CiAK LSAgICBtX25vdGlmaWNhdGlvbklETWFwLnRha2Uobm90aWZpY2F0aW9uSUQpOworICAgIG1fbm90 aWZpY2F0aW9uSURNYXAucmVtb3ZlKG5vdGlmaWNhdGlvbklEKTsKKyAgICByZW1vdmVOb3RpZmlj YXRpb25Gcm9tQ29udGV4dE1hcChub3RpZmljYXRpb25JRCwgbm90aWZpY2F0aW9uKTsKICAgICBt X3Byb2Nlc3MtPmNvbm5lY3Rpb24oKS0+c2VuZChNZXNzYWdlczo6V2ViTm90aWZpY2F0aW9uTWFu YWdlclByb3h5OjpEaWREZXN0cm95Tm90aWZpY2F0aW9uKG5vdGlmaWNhdGlvbklEKSwgcGFnZS0+ cGFnZUlEKCkpOwogI2VuZGlmCiB9CkBAIC0yMDMsMTkgKzIxMywzMCBAQCB2b2lkIFdlYk5vdGlm aWNhdGlvbk1hbmFnZXI6OmRpZENsb3NlTm90aWZpY2F0aW9ucyhjb25zdCBWZWN0b3I8dWludDY0 X3Q+JiBub3RpZgogICAgICAgICBpZiAoIWlzTm90aWZpY2F0aW9uSURWYWxpZChub3RpZmljYXRp b25JRCkpCiAgICAgICAgICAgICBjb250aW51ZTsKIAotICAgICAgICBSZWZQdHI8Tm90aWZpY2F0 aW9uPiBub3RpZmljYXRpb24gPSBtX25vdGlmaWNhdGlvbklETWFwLmdldChub3RpZmljYXRpb25J RCk7CisgICAgICAgIFJlZlB0cjxOb3RpZmljYXRpb24+IG5vdGlmaWNhdGlvbiA9IG1fbm90aWZp Y2F0aW9uSURNYXAudGFrZShub3RpZmljYXRpb25JRCk7CiAgICAgICAgIGlmICghbm90aWZpY2F0 aW9uKQogICAgICAgICAgICAgY29udGludWU7CiAKLSAgICAgICAgTm90aWZpY2F0aW9uQ29udGV4 dE1hcDo6aXRlcmF0b3IgaXQgPSBtX25vdGlmaWNhdGlvbkNvbnRleHRNYXAuZmluZChub3RpZmlj YXRpb24tPnNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKSk7Ci0gICAgICAgIEFTU0VSVChpdCAhPSBt X25vdGlmaWNhdGlvbkNvbnRleHRNYXAuZW5kKCkpOwotICAgICAgICBzaXplX3QgaW5kZXggPSBp dC0+c2Vjb25kLmZpbmQobm90aWZpY2F0aW9uSUQpOwotICAgICAgICBBU1NFUlQoaW5kZXggIT0g bm90Rm91bmQpOwotICAgICAgICBpdC0+c2Vjb25kLnJlbW92ZShpbmRleCk7CisgICAgICAgIG1f bm90aWZpY2F0aW9uTWFwLnJlbW92ZShub3RpZmljYXRpb24pOworICAgICAgICByZW1vdmVOb3Rp ZmljYXRpb25Gcm9tQ29udGV4dE1hcChub3RpZmljYXRpb25JRCwgbm90aWZpY2F0aW9uLmdldCgp KTsKIAogICAgICAgICBub3RpZmljYXRpb24tPmRpc3BhdGNoQ2xvc2VFdmVudCgpOwogICAgIH0K ICNlbmRpZgogfQogCisjaWYgRU5BQkxFKE5PVElGSUNBVElPTlMpCit2b2lkIFdlYk5vdGlmaWNh dGlvbk1hbmFnZXI6OnJlbW92ZU5vdGlmaWNhdGlvbkZyb21Db250ZXh0TWFwKHVpbnQ2NF90IG5v dGlmaWNhdGlvbklELCBOb3RpZmljYXRpb24qIG5vdGlmaWNhdGlvbikKK3sKKyAgICAvLyBUaGlz IGlzIGEgaGVscGVyIGZ1bmN0aW9uIGZvciBtYW5hZ2luZyB0aGUgaGFzaCBtYXBzLgorICAgIE5v dGlmaWNhdGlvbkNvbnRleHRNYXA6Oml0ZXJhdG9yIGl0ID0gbV9ub3RpZmljYXRpb25Db250ZXh0 TWFwLmZpbmQobm90aWZpY2F0aW9uLT5zY3JpcHRFeGVjdXRpb25Db250ZXh0KCkpOworICAgIEFT U0VSVChpdCAhPSBtX25vdGlmaWNhdGlvbkNvbnRleHRNYXAuZW5kKCkpOworICAgIHNpemVfdCBp bmRleCA9IGl0LT5zZWNvbmQuZmluZChub3RpZmljYXRpb25JRCk7CisgICAgQVNTRVJUKGluZGV4 ICE9IG5vdEZvdW5kKTsKKyAgICBpdC0+c2Vjb25kLnJlbW92ZShpbmRleCk7CisgICAgaWYgKGl0 LT5zZWNvbmQuaXNFbXB0eSgpKQorICAgICAgICBtX25vdGlmaWNhdGlvbkNvbnRleHRNYXAucmVt b3ZlKGl0KTsKK30KKyNlbmRpZgorCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvTm90aWZpY2F0aW9ucy9XZWJOb3RpZmljYXRpb25N YW5hZ2VyLmggYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL05vdGlmaWNhdGlvbnMvV2ViTm90 aWZpY2F0aW9uTWFuYWdlci5oCmluZGV4IGRjNTUwZTIzMWE0Y2ZlODQ0ZmIxNjBiNTg2YmMxZDYz ZjkzYzkwODAuLjNiNzg4YmUyMDlhOTBlZGUyZTIyODNkZWMzOTk1NGFlN2UyNzE1OTYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvTm90aWZpY2F0aW9ucy9XZWJOb3RpZmlj YXRpb25NYW5hZ2VyLmgKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9Ob3RpZmljYXRp b25zL1dlYk5vdGlmaWNhdGlvbk1hbmFnZXIuaApAQCAtMSw1ICsxLDUgQEAKIC8qCi0gKiBDb3B5 cmlnaHQgKEMpIDIwMTEgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJp Z2h0IChDKSAyMDExLCAyMDEyIEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqCiAg KiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRo IG9yIHdpdGhvdXQKICAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0 IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucwpAQCAtNzcsNiArNzcsMTAgQEAgcHJpdmF0ZToKICAg ICB2b2lkIGRpZENsb3NlTm90aWZpY2F0aW9ucyhjb25zdCBWZWN0b3I8dWludDY0X3Q+JiBub3Rp ZmljYXRpb25JRHMpOwogICAgIHZvaWQgZGlkVXBkYXRlTm90aWZpY2F0aW9uRGVjaXNpb24oY29u c3QgU3RyaW5nJiBvcmlnaW5TdHJpbmcsIGJvb2wgYWxsb3dlZCk7CiAgICAgdm9pZCBkaWRSZW1v dmVOb3RpZmljYXRpb25EZWNpc2lvbnMoY29uc3QgVmVjdG9yPFN0cmluZz4mIG9yaWdpblN0cmlu Z3MpOworICAgIAorI2lmIEVOQUJMRShOT1RJRklDQVRJT05TKQorICAgIHZvaWQgcmVtb3ZlTm90 aWZpY2F0aW9uRnJvbUNvbnRleHRNYXAodWludDY0X3Qgbm90aWZpY2F0aW9uSUQsIFdlYkNvcmU6 Ok5vdGlmaWNhdGlvbiopOworI2VuZGlmCiAKICAgICBXZWJQcm9jZXNzKiBtX3Byb2Nlc3M7CiAK