78851 2012-02-16 15:27:43 -0800 [Chromium] Texture eviction doesn't show up in traces. 2012-02-17 14:31:33 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 reveman reveman jamesr nduca webkit.review.bot oldest_to_newest 558586 0 reveman 2012-02-16 15:27:43 -0800 Add TextureManager::evictTexture() function with TRACE statement so that texture eviction shows up in traces. 558590 1 127455 reveman 2012-02-16 15:30:23 -0800 Created attachment 127455 Patch 558863 2 127455 nduca 2012-02-16 20:36:50 -0800 Comment on attachment 127455 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127455&action=review LGTM with nit > Source/WebCore/platform/graphics/chromium/TextureManager.cpp:194 > + TRACE_EVENT("TextureManager::evictTexture", this, 0); Might be better to put the trace in "removeTexture" to avoid confusion over TextureManager::evictTexture being a function call that itself only conditionally traces. 559386 3 127624 reveman 2012-02-17 11:44:51 -0800 Created attachment 127624 Patch 559397 4 reveman 2012-02-17 11:50:24 -0800 (In reply to comment #2) > (From update of attachment 127455 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=127455&action=review > > LGTM with nit > > > Source/WebCore/platform/graphics/chromium/TextureManager.cpp:194 > > + TRACE_EVENT("TextureManager::evictTexture", this, 0); > > Might be better to put the trace in "removeTexture" to avoid confusion over TextureManager::evictTexture being a function call that itself only conditionally traces. Yes, the conditional trace in evictTexture() is less than ideal. I kept the evictTexture() function as I'd like to distinguish between a texture being removed normally and from eviction but I instead made the function a simple wrapper around removeTexture(). 559548 5 127624 webkit.review.bot 2012-02-17 14:31:29 -0800 Comment on attachment 127624 Patch Clearing flags on attachment: 127624 Committed r108124: <http://trac.webkit.org/changeset/108124> 559549 6 webkit.review.bot 2012-02-17 14:31:33 -0800 All reviewed patches have been landed. Closing bug. 127455 2012-02-16 15:30:23 -0800 2012-02-17 11:44:48 -0800 Patch bug-78851-20120216183022.patch text/plain 3225 reveman U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3OTc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2E0ZTliMTgwOGU2MWJl ODY0Y2UyZGRkMDU0ZTZjOWFiYWRmODkwMS4uNjJhYjg4MmM4ZDhmYzE3ZjUyN2M2OWI4ZTQ5Y2I5 NWExOGZmNGU2YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTAyLTE2ICBEYXZp ZCBSZXZlbWFuICA8cmV2ZW1hbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Nocm9taXVtXSBU ZXh0dXJlIGV2aWN0aW9uIGRvZXNuJ3Qgc2hvdyB1cCBpbiB0cmFjZXMuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03ODg1MQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBUZXh0dXJlTWFuYWdlcjo6ZXZp Y3RUZXh0dXJlKCkgZnVuY3Rpb24gd2l0aCBUUkFDRSBzdGF0ZW1lbnQgc28KKyAgICAgICAgdGhh dCB0ZXh0dXJlIGV2aWN0aW9uIHNob3dzIHVwIGluIHRyYWNlcy4KKworICAgICAgICBObyBuZXcg dGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9UZXh0dXJlTWFu YWdlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpUZXh0dXJlTWFuYWdlcjo6ZXZpY3RUZXh0dXJl KToKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAoV2ViQ29yZTo6VGV4dHVyZU1hbmFnZXI6 OnJlZHVjZU1lbW9yeVRvTGltaXQpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9t aXVtL1RleHR1cmVNYW5hZ2VyLmg6CisgICAgICAgIChUZXh0dXJlTWFuYWdlcik6CisKIDIwMTIt MDItMTYgIFNlcmdpbyBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+CiAKICAgICAg ICAgW3NvdXBdIE1vdmUgaW1wb3J0YW50IFNvdXBTZXNzaW9uIGZlYXR1cmUgaW5pdGlhbGl6YXRp b24gdG8gV2ViQ29yZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvY2hyb21pdW0vVGV4dHVyZU1hbmFnZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvY2hyb21pdW0vVGV4dHVyZU1hbmFnZXIuY3BwCmluZGV4IDEzMWE5YzcwZTdlMTcz NzM5NzNkNzQ5MzBlZGVkMTBkZWRhNWQ1ZDguLmY4NTliMDZjYzNhMjVlMTg5MDhmNTc5ZjI4ZjMz YWVmMDBhMTBmMWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2Nocm9taXVtL1RleHR1cmVNYW5hZ2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9jaHJvbWl1bS9UZXh0dXJlTWFuYWdlci5jcHAKQEAgLTE4NCw2ICsxODQsMTgg QEAgdm9pZCBUZXh0dXJlTWFuYWdlcjo6dW5wcm90ZWN0QWxsVGV4dHVyZXMoKQogICAgICAgICBp dC0+c2Vjb25kLmlzUHJvdGVjdGVkID0gZmFsc2U7CiB9CiAKK2Jvb2wgVGV4dHVyZU1hbmFnZXI6 OmV2aWN0VGV4dHVyZShUZXh0dXJlVG9rZW4gdG9rZW4pCit7CisgICAgQVNTRVJUKGhhc1RleHR1 cmUodG9rZW4pKTsKKyAgICBUZXh0dXJlSW5mbyBpbmZvID0gbV90ZXh0dXJlcy5nZXQodG9rZW4p OworICAgIGlmIChpbmZvLmlzUHJvdGVjdGVkKQorICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAg ICBUUkFDRV9FVkVOVCgiVGV4dHVyZU1hbmFnZXI6OmV2aWN0VGV4dHVyZSIsIHRoaXMsIDApOwor ICAgIHJlbW92ZVRleHR1cmUodG9rZW4sIGluZm8pOworICAgIHJldHVybiB0cnVlOworfQorCiB2 b2lkIFRleHR1cmVNYW5hZ2VyOjpyZWR1Y2VNZW1vcnlUb0xpbWl0KHNpemVfdCBsaW1pdCkKIHsK ICAgICB3aGlsZSAobV9tZW1vcnlVc2VCeXRlcyA+IGxpbWl0KSB7CkBAIC0xOTEsMTIgKzIwMyw5 IEBAIHZvaWQgVGV4dHVyZU1hbmFnZXI6OnJlZHVjZU1lbW9yeVRvTGltaXQoc2l6ZV90IGxpbWl0 KQogICAgICAgICBib29sIGZvdW5kQ2FuZGlkYXRlID0gZmFsc2U7CiAgICAgICAgIGZvciAoTGlz dEhhc2hTZXQ8VGV4dHVyZVRva2VuPjo6aXRlcmF0b3IgbHJ1SXQgPSBtX3RleHR1cmVMUlVTZXQu YmVnaW4oKTsgbHJ1SXQgIT0gbV90ZXh0dXJlTFJVU2V0LmVuZCgpOyArK2xydUl0KSB7CiAgICAg ICAgICAgICBUZXh0dXJlVG9rZW4gdG9rZW4gPSAqbHJ1SXQ7Ci0gICAgICAgICAgICBUZXh0dXJl SW5mbyBpbmZvID0gbV90ZXh0dXJlcy5nZXQodG9rZW4pOwotICAgICAgICAgICAgaWYgKGluZm8u aXNQcm90ZWN0ZWQpCi0gICAgICAgICAgICAgICAgY29udGludWU7Ci0gICAgICAgICAgICByZW1v dmVUZXh0dXJlKHRva2VuLCBpbmZvKTsKLSAgICAgICAgICAgIGZvdW5kQ2FuZGlkYXRlID0gdHJ1 ZTsKLSAgICAgICAgICAgIGJyZWFrOworICAgICAgICAgICAgZm91bmRDYW5kaWRhdGUgPSBldmlj dFRleHR1cmUodG9rZW4pOworICAgICAgICAgICAgaWYgKGZvdW5kQ2FuZGlkYXRlKQorICAgICAg ICAgICAgICAgIGJyZWFrOwogICAgICAgICB9CiAgICAgICAgIGlmICghZm91bmRDYW5kaWRhdGUp CiAgICAgICAgICAgICByZXR1cm47CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9jaHJvbWl1bS9UZXh0dXJlTWFuYWdlci5oIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vVGV4dHVyZU1hbmFnZXIuaAppbmRleCA4MjU5YWRiMTA0 OGQxNTIwZTM2ZTBhNTVlNDA5ZjQwNTcyYTNhZGE0Li4wYWFjODUxMGIzOGNjOTQwZDVhMzQzMTQ5 N2Q0NmQ5NmY3YTgwY2M1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9jaHJvbWl1bS9UZXh0dXJlTWFuYWdlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2Nocm9taXVtL1RleHR1cmVNYW5hZ2VyLmgKQEAgLTg5LDYgKzg5LDcgQEAg cHVibGljOgogICAgIHVuc2lnbmVkIGFsbG9jYXRlVGV4dHVyZShUZXh0dXJlQWxsb2NhdG9yKiwg VGV4dHVyZVRva2VuKTsKICAgICB2b2lkIGRlbGV0ZUV2aWN0ZWRUZXh0dXJlcyhUZXh0dXJlQWxs b2NhdG9yKik7CiAKKyAgICBib29sIGV2aWN0VGV4dHVyZShUZXh0dXJlVG9rZW4pOwogICAgIHZv aWQgZXZpY3RBbmREZWxldGVBbGxUZXh0dXJlcyhUZXh0dXJlQWxsb2NhdG9yKik7CiAKICAgICB2 b2lkIHJlZHVjZU1lbW9yeVRvTGltaXQoc2l6ZV90KTsK 127624 2012-02-17 11:44:51 -0800 2012-02-17 14:31:28 -0800 Patch bug-78851-20120217144450.patch text/plain 2735 reveman U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4MDk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGZjMjliN2I1ZjRkMGJl NjNjZTA2NjI3MjNiYTBiMzg4NmQ2ODM3MC4uOWI2ZDA4NmZhYTQ1NzJjZDkwZmMxMGY2NGEzYzQy NzA1Zjg1N2MxYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTAyLTE3ICBEYXZp ZCBSZXZlbWFuICA8cmV2ZW1hbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Nocm9taXVtXSBU ZXh0dXJlIGV2aWN0aW9uIGRvZXNuJ3Qgc2hvdyB1cCBpbiB0cmFjZXMuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03ODg1MQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBUZXh0dXJlTWFuYWdlcjo6ZXZp Y3RUZXh0dXJlKCkgZnVuY3Rpb24gd2l0aCBUUkFDRSBzdGF0ZW1lbnQgc28KKyAgICAgICAgdGhh dCB0ZXh0dXJlIGV2aWN0aW9uIHNob3dzIHVwIGluIHRyYWNlcy4KKworICAgICAgICBObyBuZXcg dGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9UZXh0dXJlTWFu YWdlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpUZXh0dXJlTWFuYWdlcjo6ZXZpY3RUZXh0dXJl KToKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAoV2ViQ29yZTo6VGV4dHVyZU1hbmFnZXI6 OnJlZHVjZU1lbW9yeVRvTGltaXQpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9t aXVtL1RleHR1cmVNYW5hZ2VyLmg6CisgICAgICAgIChUZXh0dXJlTWFuYWdlcik6CisKIDIwMTIt MDItMTcgIEp1bGllbiBDaGFmZnJhaXggIDxqY2hhZmZyYWl4QHdlYmtpdC5vcmc+CiAKICAgICAg ICAgVGFibGUgY2VsbCdzIGFub255bW91cyB3cmFwcGVycyBhcmUgbGVmdCBpbiB0aGUgdHJlZSwg aW1wYWN0aW5nIG91ciBsYXlvdXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2Nocm9taXVtL1RleHR1cmVNYW5hZ2VyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL1RleHR1cmVNYW5hZ2VyLmNwcAppbmRleCAxMzFhOWM3 MGU3ZTE3MzczOTczZDc0OTMwZWRlZDEwZGVkYTVkNWQ4Li4wYzZmZTE0ZjlhZDY1ZmMwMmYyZDVl NDllZjUyNTQ1MzI0MmZhNmZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9jaHJvbWl1bS9UZXh0dXJlTWFuYWdlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vVGV4dHVyZU1hbmFnZXIuY3BwCkBAIC0xODQsNiAr MTg0LDEyIEBAIHZvaWQgVGV4dHVyZU1hbmFnZXI6OnVucHJvdGVjdEFsbFRleHR1cmVzKCkKICAg ICAgICAgaXQtPnNlY29uZC5pc1Byb3RlY3RlZCA9IGZhbHNlOwogfQogCit2b2lkIFRleHR1cmVN YW5hZ2VyOjpldmljdFRleHR1cmUoVGV4dHVyZVRva2VuIHRva2VuLCBUZXh0dXJlSW5mbyBpbmZv KQoreworICAgIFRSQUNFX0VWRU5UKCJUZXh0dXJlTWFuYWdlcjo6ZXZpY3RUZXh0dXJlIiwgdGhp cywgMCk7CisgICAgcmVtb3ZlVGV4dHVyZSh0b2tlbiwgaW5mbyk7Cit9CisKIHZvaWQgVGV4dHVy ZU1hbmFnZXI6OnJlZHVjZU1lbW9yeVRvTGltaXQoc2l6ZV90IGxpbWl0KQogewogICAgIHdoaWxl IChtX21lbW9yeVVzZUJ5dGVzID4gbGltaXQpIHsKQEAgLTE5NCw3ICsyMDAsNyBAQCB2b2lkIFRl eHR1cmVNYW5hZ2VyOjpyZWR1Y2VNZW1vcnlUb0xpbWl0KHNpemVfdCBsaW1pdCkKICAgICAgICAg ICAgIFRleHR1cmVJbmZvIGluZm8gPSBtX3RleHR1cmVzLmdldCh0b2tlbik7CiAgICAgICAgICAg ICBpZiAoaW5mby5pc1Byb3RlY3RlZCkKICAgICAgICAgICAgICAgICBjb250aW51ZTsKLSAgICAg ICAgICAgIHJlbW92ZVRleHR1cmUodG9rZW4sIGluZm8pOworICAgICAgICAgICAgZXZpY3RUZXh0 dXJlKHRva2VuLCBpbmZvKTsKICAgICAgICAgICAgIGZvdW5kQ2FuZGlkYXRlID0gdHJ1ZTsKICAg ICAgICAgICAgIGJyZWFrOwogICAgICAgICB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9UZXh0dXJlTWFuYWdlci5oIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vVGV4dHVyZU1hbmFnZXIuaAppbmRleCA4MjU5 YWRiMTA0OGQxNTIwZTM2ZTBhNTVlNDA5ZjQwNTcyYTNhZGE0Li5lNGQ2ZDM4YjhjYjk4ZjViNzQ0 YWVhYjkyZTJkYjFhMGZlNmRhZmFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9jaHJvbWl1bS9UZXh0dXJlTWFuYWdlci5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL1RleHR1cmVNYW5hZ2VyLmgKQEAgLTEwOSw2ICsx MDksNyBAQCBwcml2YXRlOgogCiAgICAgdm9pZCBhZGRUZXh0dXJlKFRleHR1cmVUb2tlbiwgVGV4 dHVyZUluZm8pOwogICAgIHZvaWQgcmVtb3ZlVGV4dHVyZShUZXh0dXJlVG9rZW4sIFRleHR1cmVJ bmZvKTsKKyAgICB2b2lkIGV2aWN0VGV4dHVyZShUZXh0dXJlVG9rZW4sIFRleHR1cmVJbmZvKTsK IAogICAgIEhhc2hTZXQ8TWFuYWdlZFRleHR1cmUqPiBtX3JlZ2lzdGVyZWRUZXh0dXJlczsKIAo=