78844 2012-02-16 14:43:13 -0800 Chrome::*Geolocation* are just useless pass-throughs to ChromeClient and should be removed 2012-02-16 14:50:17 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth eric oldest_to_newest 558543 0 abarth 2012-02-16 14:43:13 -0800 Chrome::*Geolocation* are just useless pass-throughs to ChromeClient and should be removed 558544 1 127445 abarth 2012-02-16 14:44:16 -0800 Created attachment 127445 Patch 558547 2 127445 eric 2012-02-16 14:45:50 -0800 Comment on attachment 127445 Patch Don't you have a header import to remove in Chrome.cpp? 558552 3 abarth 2012-02-16 14:49:10 -0800 > Don't you have a header import to remove in Chrome.cpp? There's still some code in Chrome.cpp that uses ChromeClient.h 558554 4 abarth 2012-02-16 14:50:17 -0800 Committed r107982: <http://trac.webkit.org/changeset/107982> 127445 2012-02-16 14:44:16 -0800 2012-02-16 14:45:50 -0800 Patch bug-78844-20120216144415.patch text/plain 3482 abarth SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNzk4MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEyLTAyLTE2ICBBZGFtIEJh cnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgQ2hyb21lOjoqR2VvbG9jYXRpb24q IGFyZSBqdXN0IHVzZWxlc3MgcGFzcy10aHJvdWdocyB0byBDaHJvbWVDbGllbnQgYW5kIHNob3Vs ZCBiZSByZW1vdmVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD03ODg0NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFRoZXNlIGZ1bmN0aW9uIHNlcnZlIG5vIHVzZWZ1bCBwdXJwb3NlIGFuZCBzaG91bGQgYmUg cmVtb3ZlZC4KKworICAgICAgICAqIHBhZ2UvQ2hyb21lLmNwcDoKKyAgICAgICAgKFdlYkNvcmUp OgorICAgICAgICAqIHBhZ2UvQ2hyb21lLmg6CisgICAgICAgIChDaHJvbWUpOgorICAgICAgICAq IHBhZ2UvR2VvbG9jYXRpb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6R2VvbG9jYXRpb246OnJl c2V0KToKKyAgICAgICAgKFdlYkNvcmU6Okdlb2xvY2F0aW9uOjpyZXF1ZXN0UGVybWlzc2lvbik6 CisKIDIwMTItMDItMTYgIFNlcmdpbyBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+ CiAKICAgICAgICAgW3NvdXBdIE1vdmUgaW1wb3J0YW50IFNvdXBTZXNzaW9uIGZlYXR1cmUgaW5p dGlhbGl6YXRpb24gdG8gV2ViQ29yZQpJbmRleDogU291cmNlL1dlYkNvcmUvcGFnZS9DaHJvbWUu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BhZ2UvQ2hyb21lLmNwcAkocmV2aXNp b24gMTA3OTc3KQorKysgU291cmNlL1dlYkNvcmUvcGFnZS9DaHJvbWUuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC00NDUsMTYgKzQ0NSw2IEBAIHZvaWQgQ2hyb21lOjpwcmludChGcmFtZSogZnJhbWUp CiAgICAgbV9jbGllbnQtPnByaW50KGZyYW1lKTsKIH0KIAotdm9pZCBDaHJvbWU6OnJlcXVlc3RH ZW9sb2NhdGlvblBlcm1pc3Npb25Gb3JGcmFtZShGcmFtZSogZnJhbWUsIEdlb2xvY2F0aW9uKiBn ZW9sb2NhdGlvbikKLXsKLSAgICBtX2NsaWVudC0+cmVxdWVzdEdlb2xvY2F0aW9uUGVybWlzc2lv bkZvckZyYW1lKGZyYW1lLCBnZW9sb2NhdGlvbik7Ci19Ci0KLXZvaWQgQ2hyb21lOjpjYW5jZWxH ZW9sb2NhdGlvblBlcm1pc3Npb25SZXF1ZXN0Rm9yRnJhbWUoRnJhbWUqIGZyYW1lLCBHZW9sb2Nh dGlvbiogZ2VvbG9jYXRpb24pCi17Ci0gICAgbV9jbGllbnQtPmNhbmNlbEdlb2xvY2F0aW9uUGVy bWlzc2lvblJlcXVlc3RGb3JGcmFtZShmcmFtZSwgZ2VvbG9jYXRpb24pOwotfQotCiAjaWYgRU5B QkxFKERJUkVDVE9SWV9VUExPQUQpCiB2b2lkIENocm9tZTo6ZW51bWVyYXRlQ2hvc2VuRGlyZWN0 b3J5KEZpbGVDaG9vc2VyKiBmaWxlQ2hvb3NlcikKIHsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3Bh Z2UvQ2hyb21lLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGFnZS9DaHJvbWUuaAko cmV2aXNpb24gMTA3OTc3KQorKysgU291cmNlL1dlYkNvcmUvcGFnZS9DaHJvbWUuaAkod29ya2lu ZyBjb3B5KQpAQCAtMTQ5LDExICsxNDksNiBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKICAgICAg ICAgdm9pZCBwcmludChGcmFtZSopOwogCi0gICAgICAgIC8vIEZJWE1FOiBSZW1vdmUgb25jZSBh bGwgcG9ydHMgYXJlIHVzaW5nIGNsaWVudC1iYXNlZCBnZW9sb2NhdGlvbi4gaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQwMzczCi0gICAgICAgIC8vIEZvciBjbGllbnQt YmFzZWQgZ2VvbG9jYXRpb24sIHRoZXNlIHR3byBtZXRob2RzIGhhdmUgbW92ZWQgdG8gR2VvbG9j YXRpb25DbGllbnQuIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MDA2 MQotICAgICAgICB2b2lkIHJlcXVlc3RHZW9sb2NhdGlvblBlcm1pc3Npb25Gb3JGcmFtZShGcmFt ZSosIEdlb2xvY2F0aW9uKik7Ci0gICAgICAgIHZvaWQgY2FuY2VsR2VvbG9jYXRpb25QZXJtaXNz aW9uUmVxdWVzdEZvckZyYW1lKEZyYW1lKiwgR2VvbG9jYXRpb24qKTsKLQogI2lmIEVOQUJMRShJ TlBVVF9DT0xPUikKICAgICAgICAgUGFzc093blB0cjxDb2xvckNob29zZXI+IGNyZWF0ZUNvbG9y Q2hvb3NlcihDb2xvckNob29zZXJDbGllbnQqLCBjb25zdCBDb2xvciYgaW5pdGlhbENvbG9yKTsK ICNlbmRpZgpJbmRleDogU291cmNlL1dlYkNvcmUvcGFnZS9HZW9sb2NhdGlvbi5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGFnZS9HZW9sb2NhdGlvbi5jcHAJKHJldmlzaW9uIDEw Nzk3NykKKysrIFNvdXJjZS9XZWJDb3JlL3BhZ2UvR2VvbG9jYXRpb24uY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0yNTUsNyArMjU1LDcgQEAgdm9pZCBHZW9sb2NhdGlvbjo6cmVzZXQoKQogI2lmIEVO QUJMRShDTElFTlRfQkFTRURfR0VPTE9DQVRJT04pCiAgICAgICAgIHBhZ2UtPmdlb2xvY2F0aW9u Q29udHJvbGxlcigpLT5jYW5jZWxQZXJtaXNzaW9uUmVxdWVzdCh0aGlzKTsKICNlbHNlCi0gICAg ICAgIHBhZ2UtPmNocm9tZSgpLT5jYW5jZWxHZW9sb2NhdGlvblBlcm1pc3Npb25SZXF1ZXN0Rm9y RnJhbWUobV9mcmFtZSwgdGhpcyk7CisgICAgICAgIHBhZ2UtPmNocm9tZSgpLT5jbGllbnQoKS0+ Y2FuY2VsR2VvbG9jYXRpb25QZXJtaXNzaW9uUmVxdWVzdEZvckZyYW1lKG1fZnJhbWUsIHRoaXMp OwogI2VuZGlmCiAgICAgfQogICAgIC8vIFRoZSBmcmFtZSBtYXkgYmUgbW92aW5nIHRvIGEgbmV3 IHBhZ2UgYW5kIHdlIHdhbnQgdG8gZ2V0IHRoZSBwZXJtaXNzaW9ucyBmcm9tIHRoZSBuZXcgcGFn ZSdzIGNsaWVudC4KQEAgLTYxOSw3ICs2MTksNyBAQCB2b2lkIEdlb2xvY2F0aW9uOjpyZXF1ZXN0 UGVybWlzc2lvbigpCiAjaWYgRU5BQkxFKENMSUVOVF9CQVNFRF9HRU9MT0NBVElPTikKICAgICBw YWdlLT5nZW9sb2NhdGlvbkNvbnRyb2xsZXIoKS0+cmVxdWVzdFBlcm1pc3Npb24odGhpcyk7CiAj ZWxzZQotICAgIHBhZ2UtPmNocm9tZSgpLT5yZXF1ZXN0R2VvbG9jYXRpb25QZXJtaXNzaW9uRm9y RnJhbWUobV9mcmFtZSwgdGhpcyk7CisgICAgcGFnZS0+Y2hyb21lKCktPmNsaWVudCgpLT5yZXF1 ZXN0R2VvbG9jYXRpb25QZXJtaXNzaW9uRm9yRnJhbWUobV9mcmFtZSwgdGhpcyk7CiAjZW5kaWYK IH0KIAo=