7884 2006-03-20 21:42:54 -0800 REGRESSION: Selecting a custom style sheet crashes 20/3 nightly 2006-03-22 01:13:47 -0800 1 1 1 Unclassified WebKit Layout and Rendering 420+ Mac OS X 10.4 RESOLVED FIXED InRadar, Regression P1 Blocker --- 1 mustiman webkit-unassigned alice.barraclough bdakin c.petersen87 ggaren oldest_to_newest 37099 0 mustiman 2006-03-20 21:42:54 -0800 Steps to reproduce when WebKit nightly is open and NO custom style sheet is selected via Safari beforehand: 1. Select a custom style sheet in Preferences --> Advanced --> Style Sheet 2. reload the current page Steps to reproduce when a custom style sheet is selected via Safari before launching WebKit nightly 1. Launch WebKit nightly. 2. Crashes upon launch, even when trying to load the WebKit start page. Part of crash log Exception: EXC_BAD_ACCESS (0x0001) Codes: KERN_INVALID_ADDRESS (0x0001) at 0xbf7fffdc Thread 0 Crashed: 0 com.apple.JavaScriptCore 0x001763a8 KXMLCore::fastMalloc(unsigned long) + 8 1 com.apple.WebCore 0x01367b50 KXMLCore::Vector<char, (unsigned long)4096>::reserveCapacity(unsigned long) + 64 2 com.apple.WebCore 0x01367c04 KXMLCore::Vector<char, (unsigned long)4096>::expandCapacity(unsigned long) + 84 3 com.apple.WebCore 0x01367c54 KXMLCore::Vector<char, (unsigned long)4096>::resize(unsigned long) + 52 4 com.apple.WebCore 0x012be808 KURL::parse(char const*, DeprecatedString const*) + 1176 5 com.apple.WebCore 0x012c0584 KURL::KURL[in-charge](KURL const&, DeprecatedString const&, WebCore::TextEncoding const&) + 1860 6 com.apple.WebCore 0x011608fc WebCore::Document::completeURL(DeprecatedString const&) + 428 7 com.apple.WebCore 0x011807c0 WebCore::Cache::requestStyleSheet(WebCore::DocLoader*, WebCore::String const&, bool, long, DeprecatedString const&) + 112 8 com.apple.WebCore 0x0113b7d4 WebCore::Frame::setUserStyleSheet(KURL const&) + 260 9 com.apple.WebCore 0x01348814 WebCore::UserStyleSheetLoader::setStyleSheet(WebCore::String const&, WebCore::String const&) + 52 10 com.apple.WebCore 0x0113b7fc WebCore::Frame::setUserStyleSheet(KURL const&) + 300 11 com.apple.WebCore 0x01348814 WebCore::UserStyleSheetLoader::setStyleSheet(WebCore::String const&, WebCore::String const&) + 52 12 com.apple.WebCore 0x0113b7fc WebCore::Frame::setUserStyleSheet(KURL const&) + 300 13 com.apple.WebCore 0x01348814 WebCore::UserStyleSheetLoader::setStyleSheet(WebCore::String const&, WebCore::String const&) + 52 14 com.apple.WebCore 0x0113b7fc WebCore::Frame::setUserStyleSheet(KURL const&) + 300 15 com.apple.WebCore 0x01348814 WebCore::UserStyleSheetLoader::setStyleSheet(WebCore::String const&, WebCore::String const&) + 52 16 com.apple.WebCore 0x0113b7fc WebCore::Frame::setUserStyleSheet(KURL const&) + 300 17 com.apple.WebCore 0x01348814 WebCore::UserStyleSheetLoader::setStyleSheet snip snip snip 507 com.apple.WebCore 0x01348814 WebCore::UserStyleSheetLoader::setStyleSheet(WebCore::String const&, WebCore::String const&) + 52 508 com.apple.WebCore 0x0113b7fc WebCore::Frame::setUserStyleSheet(KURL const&) + 300 37125 1 c.petersen87 2006-03-20 23:24:57 -0800 I ran into this issue starting with the March 21 build (WebKit-SVN-r13404). You can reproduce by simply applying any external stylesheet to Safari (even a empty stylesheet file) when running Webkit WebKit-SVN-r13404. 37185 2 alice.barraclough 2006-03-21 09:21:45 -0800 <rdar://problem/4485448> 37195 3 mitz 2006-03-21 12:12:10 -0800 When I have this page open and I change the user style sheet, Safari tries to load the URL http://bugzilla.opendarwin.org/<contents of the style sheet I selected>. When that fails, it starts loading http://bugzilla.opendarwin.org/<contents of the error page from the previous attempt> and when that fails, it repeats. 37196 4 7220 mitz 2006-03-21 12:41:52 -0800 Created attachment 7220 Patch 37198 5 7220 mitz 2006-03-21 13:19:59 -0800 Comment on attachment 7220 Patch Better just rename one of the functions. 37200 6 7220 darin 2006-03-21 13:41:36 -0800 Comment on attachment 7220 Patch It would be even better to rename the one that takes a URL to setStyleSheetLocation, but this is good. 37201 7 7221 mitz 2006-03-21 13:54:14 -0800 Created attachment 7221 Rename the function that sets the location 37204 8 7221 darin 2006-03-21 14:47:53 -0800 Comment on attachment 7221 Rename the function that sets the location Great, lets do this. 37317 9 eric 2006-03-22 01:13:47 -0800 Sorry about this. I noticed it last night, but didn't get a fix ready in time. :( I actually had made the exact same fix locally. 7220 2006-03-21 12:41:52 -0800 2006-03-21 13:41:36 -0800 Patch 7884_r1.patch text/plain 1228 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAxMzQyMikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDYtIyMtIyMgIE1pdHogUGV0dGVsICA8b3BlbmRhcndpbi5vcmdA bWl0enBldHRlbC5jb20+CisKKyAgICAgICAgLSBmaXggaHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3 aW4ub3JnL3Nob3dfYnVnLmNnaT9pZD03ODg0CisgICAgICAgICAgUkVHUkVTU0lPTjogU2VsZWN0 aW5nIGEgY3VzdG9tIHN0eWxlIHNoZWV0IGNyYXNoZXMgMjAvMyBuaWdodGx5CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwYWdlL0ZyYW1lLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlVzZXJTdHlsZVNoZWV0TG9hZGVyOjpzZXRTdHlsZVNoZWV0KTog VGhpcyB3YXMgY2FsbGluZyB0aGUgZnVuY3Rpb24KKyAgICAgICAgdGhhdCBzZXRzIHRoZSBzaGVl dCBVUkwgaW5zdGVhZCBvZiB0aGUgb25lIHRoYXQgc2V0cyB0aGUgc2hlZXQncyBjb250ZW50cy4K KyAgICAgICAgVGhlIGxhdHRlciBzdGlsbCB0YWtlcyBhIERlcHJlY2F0ZWRTdHJpbmcuCisKIDIw MDYtMDMtMjEgIEJldGggRGFraW4gIDxiZGFraW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IE1hY2llagpJbmRleDogV2ViQ29yZS9wYWdlL0ZyYW1lLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJDb3JlL3BhZ2UvRnJhbWUuY3BwCShyZXZpc2lvbiAxMzQyMikKKysrIFdlYkNvcmUvcGFn ZS9GcmFtZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEyMiw3ICsxMjIsNyBAQCBwdWJsaWM6CiBw cml2YXRlOgogICAgIHZpcnR1YWwgdm9pZCBzZXRTdHlsZVNoZWV0KGNvbnN0IFN0cmluZyYsIGNv bnN0IFN0cmluZyYgc2hlZXQpCiAgICAgewotICAgICAgICBtX2ZyYW1lLT5zZXRVc2VyU3R5bGVT aGVldChzaGVldCk7CisgICAgICAgIG1fZnJhbWUtPnNldFVzZXJTdHlsZVNoZWV0KHNoZWV0LmRl cHJlY2F0ZWRTdHJpbmcoKSk7CiAgICAgfQogICAgIEZyYW1lKiBtX2ZyYW1lOwogICAgIENhY2hl ZENTU1N0eWxlU2hlZXQqIG1fY2FjaGVkU2hlZXQ7Cg== 7221 2006-03-21 13:54:14 -0800 2006-03-21 14:47:53 -0800 Rename the function that sets the location 7884_r2.patch text/plain 2765 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAxMzQyMikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMDYtMDMtIyMgIE1pdHogUGV0dGVsICA8b3BlbmRhcndpbi5vcmdA bWl0enBldHRlbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgLSBmaXggaHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNn aT9pZD03ODg0CisgICAgICAgICAgUkVHUkVTU0lPTjogU2VsZWN0aW5nIGEgY3VzdG9tIHN0eWxl IHNoZWV0IGNyYXNoZXMgMjAvMyBuaWdodGx5CisKKyAgICAgICAgKiBwYWdlL0ZyYW1lLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlVzZXJTdHlsZVNoZWV0TG9hZGVyOjpzZXRTdHlsZVNoZWV0KTog VGhpcyB3YXMgY2FsbGluZyB0aGUgZnVuY3Rpb24KKyAgICAgICAgdGhhdCBzZXRzIHRoZSBzdHls ZXNoZWV0IFVSTCwgcGFzc2luZyBpdCB0aGUgYWN0dWFsIHN0eWxlc2hlZXQuCisgICAgICAgIChX ZWJDb3JlOjpGcmFtZTo6YmVnaW4pOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWU6OnNldFVzZXJT dHlsZVNoZWV0TG9jYXRpb24pOiBSZW5hbWVkIHRoZSB2ZXJzaW9uIG9mCisgICAgICAgIHNldFVz ZXJTdHlsZVNoZWV0KCkgdGhhdCB0YWtlcyBhIFVSTCB0byB0aGlzLgorICAgICAgICAoV2ViQ29y ZTo6RnJhbWU6OnJlcGFyc2VDb25maWd1cmF0aW9uKToKKyAgICAgICAgKiBwYWdlL0ZyYW1lLmg6 CisKIDIwMDYtMDMtMjEgIEJldGggRGFraW4gIDxiZGFraW5AYXBwbGUuY29tPgogCiAgICAgICAg IFJldmlld2VkIGJ5IE1hY2llagpJbmRleDogV2ViQ29yZS9wYWdlL0ZyYW1lLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJDb3JlL3BhZ2UvRnJhbWUuY3BwCShyZXZpc2lvbiAxMzQyMikKKysrIFdlYkNv cmUvcGFnZS9GcmFtZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEyMiw3ICsxMjIsNyBAQCBwdWJs aWM6CiBwcml2YXRlOgogICAgIHZpcnR1YWwgdm9pZCBzZXRTdHlsZVNoZWV0KGNvbnN0IFN0cmlu ZyYsIGNvbnN0IFN0cmluZyYgc2hlZXQpCiAgICAgewotICAgICAgICBtX2ZyYW1lLT5zZXRVc2Vy U3R5bGVTaGVldChzaGVldCk7CisgICAgICAgIG1fZnJhbWUtPnNldFVzZXJTdHlsZVNoZWV0KHNo ZWV0LmRlcHJlY2F0ZWRTdHJpbmcoKSk7CiAgICAgfQogICAgIEZyYW1lKiBtX2ZyYW1lOwogICAg IENhY2hlZENTU1N0eWxlU2hlZXQqIG1fY2FjaGVkU2hlZXQ7CkBAIC02MzUsNyArNjM1LDcgQEAg dm9pZCBGcmFtZTo6YmVnaW4oY29uc3QgS1VSTCYgdXJsKQogICBTdHJpbmcgdXNlclN0eWxlU2hl ZXQgPSBkLT5tX3NldHRpbmdzLT51c2VyU3R5bGVTaGVldCgpOwogCiAgIGlmICghdXNlclN0eWxl U2hlZXQuaXNFbXB0eSgpKQotICAgIHNldFVzZXJTdHlsZVNoZWV0KEtVUkwodXNlclN0eWxlU2hl ZXQpKTsKKyAgICBzZXRVc2VyU3R5bGVTaGVldExvY2F0aW9uKEtVUkwodXNlclN0eWxlU2hlZXQp KTsKIAogICByZXN0b3JlRG9jdW1lbnRTdGF0ZSgpOwogCkBAIC0xMDI5LDcgKzEwMjksNyBAQCBE ZXByZWNhdGVkU3RyaW5nIEZyYW1lOjplbmNvZGluZygpIGNvbnN0CiAgICAgcmV0dXJuIHNldHRp bmdzKCktPmVuY29kaW5nKCk7CiB9CiAKLXZvaWQgRnJhbWU6OnNldFVzZXJTdHlsZVNoZWV0KGNv bnN0IEtVUkwmIHVybCkKK3ZvaWQgRnJhbWU6OnNldFVzZXJTdHlsZVNoZWV0TG9jYXRpb24oY29u c3QgS1VSTCYgdXJsKQogewogICAgIGRlbGV0ZSBkLT5tX3VzZXJTdHlsZVNoZWV0TG9hZGVyOwog ICAgIGQtPm1fdXNlclN0eWxlU2hlZXRMb2FkZXIgPSAwOwpAQCAtMTY1Myw3ICsxNjUzLDcgQEAg dm9pZCBGcmFtZTo6cmVwYXJzZUNvbmZpZ3VyYXRpb24oKQogCiAgIERlcHJlY2F0ZWRTdHJpbmcg dXNlclN0eWxlU2hlZXQgPSBkLT5tX3NldHRpbmdzLT51c2VyU3R5bGVTaGVldCgpOwogICBpZiAo IXVzZXJTdHlsZVNoZWV0LmlzRW1wdHkoKSkKLSAgICBzZXRVc2VyU3R5bGVTaGVldChLVVJMKHVz ZXJTdHlsZVNoZWV0KSk7CisgICAgc2V0VXNlclN0eWxlU2hlZXRMb2NhdGlvbihLVVJMKHVzZXJT dHlsZVNoZWV0KSk7CiAgIGVsc2UKICAgICBzZXRVc2VyU3R5bGVTaGVldChEZXByZWNhdGVkU3Ry aW5nKCkpOwogCkluZGV4OiBXZWJDb3JlL3BhZ2UvRnJhbWUuaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJD b3JlL3BhZ2UvRnJhbWUuaAkocmV2aXNpb24gMTM0MjIpCisrKyBXZWJDb3JlL3BhZ2UvRnJhbWUu aAkod29ya2luZyBjb3B5KQpAQCAtMjc1LDcgKzI3NSw3IEBAIHB1YmxpYzoKICAgICogVGhpcyBn aXZlcyBhIHdpZGUgcmFuZ2Ugb2YgcG9zc2liaWxpdGllcyB0bwogICAgKiBjaGFuZ2UgdGhlIGxh eW91dCBvZiB0aGUgcGFnZS4KICAgICovCi0gIHZvaWQgc2V0VXNlclN0eWxlU2hlZXQoY29uc3Qg S1VSTCYgdXJsKTsKKyAgdm9pZCBzZXRVc2VyU3R5bGVTaGVldExvY2F0aW9uKGNvbnN0IEtVUkwm IHVybCk7CiAKICAgLyoqCiAgICAqIFNldHMgYSB1c2VyIGRlZmluZWQgc3R5bGUgc2hlZXQgdG8g YmUgdXNlZCBvbiB0b3Agb2YgdGhlIEhUTUwgNAo=