78829 2012-02-16 10:36:03 -0800 [GTK] Make sure print operation object is alive until printing finishes in WebKit2 2012-02-16 23:26:33 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned oldest_to_newest 558313 0 cgarcia 2012-02-16 10:36:03 -0800 I should take a reference when the print operation starts and release with the print callback is emitted. This fixes a crash if the user unrefs the print operation right after calling run_dialog(). 558316 1 127406 cgarcia 2012-02-16 10:40:41 -0800 Created attachment 127406 Patch 558956 2 cgarcia 2012-02-16 23:26:33 -0800 Committed r108040: <http://trac.webkit.org/changeset/108040> 127406 2012-02-16 10:40:41 -0800 2012-02-16 11:10:01 -0800 Patch wk2-printing-crash.diff text/plain 2487 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAyNWQ2OWQyLi5hOTE5N2IxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTgg QEAKIDIwMTItMDItMTYgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgogCisgICAgICAgIFtHVEtdIE1ha2Ugc3VyZSBwcmludCBvcGVyYXRpb24gb2JqZWN0IGlzIGFs aXZlIHVudGlsIHByaW50aW5nIGZpbmlzaGVzIGluIFdlYktpdDIKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc4ODI5CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRQ cmludE9wZXJhdGlvbi5jcHA6CisgICAgICAgIChkcmF3UGFnZXNGb3JQcmludGluZ0NvbXBsZXRl ZCk6IEFkb3B0IHRoZSBXZWJLaXRQcmludE9wZXJhdGlvbgorICAgICAgICByZWZlcmVuY2Ugc28g dGhhdCBpdCdzIHJlbGVhc2VkIHdoZW4gdGhlIGNhbGxiYWNrIGZpbmlzaGVzLgorICAgICAgICAo d2Via2l0UHJpbnRPcGVyYXRpb25SdW5EaWFsb2dGb3JGcmFtZSk6IFBhc3MgYSByZWZlcmVuY2Ug b2YKKyAgICAgICAgV2ViS2l0UHJpbnRPcGVyYXRpb24gdG8gdGhlIHByaW50aW5nIGNhbGxiYWNr LgorCisyMDEyLTAyLTE2ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNv bT4KKwogICAgICAgICBVbnJldmlld2VkLiBGaXggV2ViS2l0MiBHVEsrIGJ1aWxkIGFmdGVyIHIx MDc5NDcuCiAKICAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRQcmludE9wZXJhdGlv bi5jcHA6CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJL aXRQcmludE9wZXJhdGlvbi5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9X ZWJLaXRQcmludE9wZXJhdGlvbi5jcHAKaW5kZXggYjQzYzk1MC4uNmU0YmIzMiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0UHJpbnRPcGVyYXRpb24u Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFByaW50T3Bl cmF0aW9uLmNwcApAQCAtMjM0LDEwICsyMzQsMTAgQEAgc3RhdGljIGJvb2wgd2Via2l0UHJpbnRP cGVyYXRpb25SdW5EaWFsb2dXaW4zMihXZWJLaXRQcmludE9wZXJhdGlvbiosIEd0a1dpbmRvdyoK IAogc3RhdGljIHZvaWQgZHJhd1BhZ2VzRm9yUHJpbnRpbmdDb21wbGV0ZWQoV0tFcnJvclJlZiwg dm9pZCogY29udGV4dCkKIHsKLSAgICBXZWJLaXRQcmludE9wZXJhdGlvbiogcHJpbnRPcGVyYXRp b24gPSBXRUJLSVRfUFJJTlRfT1BFUkFUSU9OKGNvbnRleHQpOworICAgIEdSZWZQdHI8V2ViS2l0 UHJpbnRPcGVyYXRpb24+IHByaW50T3BlcmF0aW9uID0gYWRvcHRHUmVmKFdFQktJVF9QUklOVF9P UEVSQVRJT04oY29udGV4dCkpOwogICAgIFdlYlBhZ2VQcm94eSogcGFnZSA9IHdlYmtpdFdlYlZp ZXdCYXNlR2V0UGFnZShXRUJLSVRfV0VCX1ZJRVdfQkFTRShwcmludE9wZXJhdGlvbi0+cHJpdi0+ d2ViVmlldykpOwogICAgIHBhZ2UtPmVuZFByaW50aW5nKCk7Ci0gICAgZ19zaWduYWxfZW1pdChw cmludE9wZXJhdGlvbiwgc2lnbmFsc1tET05FXSwgMCwgTlVMTCk7CisgICAgZ19zaWduYWxfZW1p dChwcmludE9wZXJhdGlvbi5nZXQoKSwgc2lnbmFsc1tET05FXSwgMCwgTlVMTCk7CiB9CiAKIHZv aWQgd2Via2l0UHJpbnRPcGVyYXRpb25SdW5EaWFsb2dGb3JGcmFtZShXZWJLaXRQcmludE9wZXJh dGlvbiogcHJpbnRPcGVyYXRpb24sIEd0a1dpbmRvdyogcGFyZW50LCBXZWJGcmFtZVByb3h5KiB3 ZWJGcmFtZSkKQEAgLTI2Miw3ICsyNjIsNyBAQCB2b2lkIHdlYmtpdFByaW50T3BlcmF0aW9uUnVu RGlhbG9nRm9yRnJhbWUoV2ViS2l0UHJpbnRPcGVyYXRpb24qIHByaW50T3BlcmF0aW9uLAogCiAg ICAgUHJpbnRJbmZvIHByaW50SW5mbyhwcml2LT5wcmludFNldHRpbmdzLmdldCgpLCBwcml2LT5w YWdlU2V0dXAuZ2V0KCkpOwogICAgIFdlYlBhZ2VQcm94eSogcGFnZSA9IHdlYmtpdFdlYlZpZXdC YXNlR2V0UGFnZShXRUJLSVRfV0VCX1ZJRVdfQkFTRShwcml2LT53ZWJWaWV3KSk7Ci0gICAgcGFn ZS0+ZHJhd1BhZ2VzRm9yUHJpbnRpbmcod2ViRnJhbWUsIHByaW50SW5mbywgVm9pZENhbGxiYWNr OjpjcmVhdGUocHJpbnRPcGVyYXRpb24sICZkcmF3UGFnZXNGb3JQcmludGluZ0NvbXBsZXRlZCkp OworICAgIHBhZ2UtPmRyYXdQYWdlc0ZvclByaW50aW5nKHdlYkZyYW1lLCBwcmludEluZm8sIFZv aWRDYWxsYmFjazo6Y3JlYXRlKGdfb2JqZWN0X3JlZihwcmludE9wZXJhdGlvbiksICZkcmF3UGFn ZXNGb3JQcmludGluZ0NvbXBsZXRlZCkpOwogfQogCiAvKioK