78817 2012-02-16 08:04:33 -0800 [Qt] Print warning when importing experimental WK2 APIs in QML 2012-02-21 03:34:13 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 74403 1 hausmann abecsi hausmann webkit.review.bot oldest_to_newest 558195 0 hausmann 2012-02-16 08:04:33 -0800 Similar to qmake printing a warning when using private Qt C++ APIs, we should print a warning (using qWarning?) when an application imports the experimental QML WebKit2 APIs. 560306 1 127838 abecsi 2012-02-20 11:30:32 -0800 Created attachment 127838 proposed patch 560312 2 127838 kenneth 2012-02-20 12:08:25 -0800 Comment on attachment 127838 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=127838&action=review > Source/WebKit/qt/declarative/experimental/plugin.cpp:49 > + qWarning("\nWARNING: This project is using the experimental QML WebKit2 API and is therefore tied to a specific QtWebKit version.\n" it sounds as the whole API is experimental! This project is using the experimental QML API extensions for QtWebKit and it therefore tied to a specific QtWebKit release. 560761 3 127946 abecsi 2012-02-21 02:14:55 -0800 Created attachment 127946 proposed patch 560788 4 127946 webkit.review.bot 2012-02-21 03:34:07 -0800 Comment on attachment 127946 proposed patch Clearing flags on attachment: 127946 Committed r108333: <http://trac.webkit.org/changeset/108333> 560789 5 webkit.review.bot 2012-02-21 03:34:13 -0800 All reviewed patches have been landed. Closing bug. 127838 2012-02-20 11:30:32 -0800 2012-02-21 02:14:55 -0800 proposed patch experimental_qml_api_warn.patch text/plain 1498 abecsi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9x dC9DaGFuZ2VMb2cKaW5kZXggNDY3MjEzMC4uMTAyOWNlNSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9xdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAxMi0wMi0yMCAgQW5kcmFzIEJlY3NpICA8YW5kcmFzLmJlY3NpQG5va2lh LmNvbT4KKworICAgICAgICBbUXRdIFByaW50IHdhcm5pbmcgd2hlbiBpbXBvcnRpbmcgZXhwZXJp bWVudGFsIFdLMiBBUElzIGluIFFNTAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9Nzg4MTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIGRlY2xhcmF0aXZlL2V4cGVyaW1lbnRhbC9wbHVnaW4uY3BwOgorCiAy MDEyLTAyLTE2ICBTaW1vbiBIYXVzbWFubiAgPHNpbW9uLmhhdXNtYW5uQG5va2lhLmNvbT4KIAog ICAgICAgICBVbnJldmlld2VkIGJyb3duLXBhcGVyIGJhZyBidWlsZCBmaXguCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L3F0L2RlY2xhcmF0aXZlL2V4cGVyaW1lbnRhbC9wbHVnaW4uY3BwIGIv U291cmNlL1dlYktpdC9xdC9kZWNsYXJhdGl2ZS9leHBlcmltZW50YWwvcGx1Z2luLmNwcAppbmRl eCA3YTQxNjU3Li43YzdjMzExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L3F0L2RlY2xhcmF0 aXZlL2V4cGVyaW1lbnRhbC9wbHVnaW4uY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvcXQvZGVjbGFy YXRpdmUvZXhwZXJpbWVudGFsL3BsdWdpbi5jcHAKQEAgLTQ2LDYgKzQ2LDkgQEAgY2xhc3MgV2Vi S2l0UW1sRXhwZXJpbWVudGFsRXh0ZW5zaW9uUGx1Z2luOiBwdWJsaWMgUURlY2xhcmF0aXZlRXh0 ZW5zaW9uUGx1Z2luIHsKIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgcmVnaXN0ZXJUeXBlcyhj b25zdCBjaGFyKiB1cmkpCiAgICAgeworICAgICAgICBxV2FybmluZygiXG5XQVJOSU5HOiBUaGlz IHByb2plY3QgaXMgdXNpbmcgdGhlIGV4cGVyaW1lbnRhbCBRTUwgV2ViS2l0MiBBUEkgYW5kIGlz IHRoZXJlZm9yZSB0aWVkIHRvIGEgc3BlY2lmaWMgUXRXZWJLaXQgdmVyc2lvbi5cbiIKKyAgICAg ICAgICAgICAgICAgIldBUk5JTkc6IFRoZSBleHBlcmltZW50YWwgQVBJIHdpbGwgY2hhbmdlIGZy b20gdmVyc2lvbiB0byB2ZXJzaW9uLCBvciBldmVuIGJlIHJlbW92ZWQuIFlvdSBoYXZlIGJlZW4g d2FybmVkIVxuIik7CisKICAgICAgICAgUV9BU1NFUlQoUUxhdGluMVN0cmluZyh1cmkpID09IFFM YXRpbjFTdHJpbmcoIlF0V2ViS2l0LmV4cGVyaW1lbnRhbCIpKTsKIAogICAgICAgICBxbWxSZWdp c3RlclVuY3JlYXRhYmxlVHlwZTxRV2ViRG93bmxvYWRJdGVtPih1cmksIDEsIDAsICJEb3dubG9h ZEl0ZW0iLCBRT2JqZWN0Ojp0cigiQ2Fubm90IGNyZWF0ZSBzZXBhcmF0ZSBpbnN0YW5jZSBvZiBE b3dubG9hZEl0ZW0iKSk7Cg== 127946 2012-02-21 02:14:55 -0800 2012-02-21 03:34:07 -0800 proposed patch experimental_qml_api_warn.patch text/plain 1514 abecsi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9x dC9DaGFuZ2VMb2cKaW5kZXggNDY3MjEzMC4uMTAyOWNlNSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9xdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAxMi0wMi0yMCAgQW5kcmFzIEJlY3NpICA8YW5kcmFzLmJlY3NpQG5va2lh LmNvbT4KKworICAgICAgICBbUXRdIFByaW50IHdhcm5pbmcgd2hlbiBpbXBvcnRpbmcgZXhwZXJp bWVudGFsIFdLMiBBUElzIGluIFFNTAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9Nzg4MTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIGRlY2xhcmF0aXZlL2V4cGVyaW1lbnRhbC9wbHVnaW4uY3BwOgorCiAy MDEyLTAyLTE2ICBTaW1vbiBIYXVzbWFubiAgPHNpbW9uLmhhdXNtYW5uQG5va2lhLmNvbT4KIAog ICAgICAgICBVbnJldmlld2VkIGJyb3duLXBhcGVyIGJhZyBidWlsZCBmaXguCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L3F0L2RlY2xhcmF0aXZlL2V4cGVyaW1lbnRhbC9wbHVnaW4uY3BwIGIv U291cmNlL1dlYktpdC9xdC9kZWNsYXJhdGl2ZS9leHBlcmltZW50YWwvcGx1Z2luLmNwcAppbmRl eCA3YTQxNjU3Li43YzdjMzExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L3F0L2RlY2xhcmF0 aXZlL2V4cGVyaW1lbnRhbC9wbHVnaW4uY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvcXQvZGVjbGFy YXRpdmUvZXhwZXJpbWVudGFsL3BsdWdpbi5jcHAKQEAgLTQ2LDYgKzQ2LDkgQEAgY2xhc3MgV2Vi S2l0UW1sRXhwZXJpbWVudGFsRXh0ZW5zaW9uUGx1Z2luOiBwdWJsaWMgUURlY2xhcmF0aXZlRXh0 ZW5zaW9uUGx1Z2luIHsKIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgcmVnaXN0ZXJUeXBlcyhj b25zdCBjaGFyKiB1cmkpCiAgICAgeworICAgICAgICBxV2FybmluZygiXG5XQVJOSU5HOiBUaGlz IHByb2plY3QgaXMgdXNpbmcgdGhlIGV4cGVyaW1lbnRhbCBRTUwgQVBJIGV4dGVuc2lvbnMgZm9y IFF0V2ViS2l0IGFuZCBpcyB0aGVyZWZvcmUgdGllZCB0byBhIHNwZWNpZmljIFF0V2ViS2l0IHJl bGVhc2UuXG4iCisgICAgICAgICAgICAgICAgICJXQVJOSU5HOiBUaGUgZXhwZXJpbWVudGFsIEFQ SSB3aWxsIGNoYW5nZSBmcm9tIHZlcnNpb24gdG8gdmVyc2lvbiwgb3IgZXZlbiBiZSByZW1vdmVk LiBZb3UgaGF2ZSBiZWVuIHdhcm5lZCFcbiIpOworCiAgICAgICAgIFFfQVNTRVJUKFFMYXRpbjFT dHJpbmcodXJpKSA9PSBRTGF0aW4xU3RyaW5nKCJRdFdlYktpdC5leHBlcmltZW50YWwiKSk7CiAK ICAgICAgICAgcW1sUmVnaXN0ZXJVbmNyZWF0YWJsZVR5cGU8UVdlYkRvd25sb2FkSXRlbT4odXJp LCAxLCAwLCAiRG93bmxvYWRJdGVtIiwgUU9iamVjdDo6dHIoIkNhbm5vdCBjcmVhdGUgc2VwYXJh dGUgaW5zdGFuY2Ugb2YgRG93bmxvYWRJdGVtIikpOwo=