78815 2012-02-16 07:55:17 -0800 Web Inspector: cache settings values 2012-02-16 10:08:41 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 pfeldman pfeldman apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 558190 0 pfeldman 2012-02-16 07:55:17 -0800 I saw fetching values from local storage fairly high in the CPU profiler. 558191 1 127380 pfeldman 2012-02-16 07:59:29 -0800 Created attachment 127380 Patch 558289 2 127380 webkit.review.bot 2012-02-16 10:01:21 -0800 Comment on attachment 127380 Patch Rejecting attachment 127380 from commit-queue. New failing tests: inspector/storage-panel-dom-storage.html inspector/debugger/scripts-panel.html Full output: http://queues.webkit.org/results/11541098 558292 3 pfeldman 2012-02-16 10:08:41 -0800 Committed r107953: <http://trac.webkit.org/changeset/107953> 127380 2012-02-16 07:59:29 -0800 2012-02-16 10:01:21 -0800 Patch bug-78815-20120216195927.patch text/plain 2552 pfeldman U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3OTM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDMwNmNiY2Y3ODJjMzdi ZWI4MDY1Yjg0ZDc1ZWUwZThkYzQ5NjlhNi4uNTRmYTUwZjY3YmU3NGVmMzRjNTNhOWM1M2FlMmVl MGRmOWNlMGZjZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAyLTE2ICBQYXZl bCBGZWxkbWFuICA8cGZlbGRtYW5AZ29vZ2xlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBjYWNoZSBzZXR0aW5ncyB2YWx1ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTc4ODE1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL1NldHRpbmdzLmpzOgorICAgICAg ICAoV2ViSW5zcGVjdG9yLlNldHRpbmcucHJvdG90eXBlLmdldCBpZik6CisgICAgICAgIChXZWJJ bnNwZWN0b3IuU2V0dGluZy5wcm90b3R5cGUpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlNldHRp bmcucHJvdG90eXBlLik6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU2V0dGluZy5wcm90b3R5cGUu c2V0IHRoaXMpOgorCiAyMDEyLTAyLTE1ICBQYXZlbCBGZWxkbWFuICA8cGZlbGRtYW5AZ29vZ2xl LmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBleHBsaWNpdGx5IG1hcmsgdW5kb2FibGUg c3RhdGUgZnJvbSB0aGUgZnJvbnQtZW5kLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9TZXR0aW5ncy5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvU2V0dGluZ3MuanMKaW5kZXggN2I2NjRlOGE3NTljMzBlMjIwMzhjY2MwNzAxM2Rj NzgxNmViNmYyMS4uYmJkNzBmNWVhYWI1ODYxODFmNWNmZTg3OGI2NjljMjM2MWQ4ZjA4MCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TZXR0aW5ncy5qcwor KysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NldHRpbmdzLmpzCkBAIC0x MzUsMjUgKzEzNSwzMyBAQCBXZWJJbnNwZWN0b3IuU2V0dGluZy5wcm90b3R5cGUgPSB7CiAKICAg ICBnZXQ6IGZ1bmN0aW9uKCkKICAgICB7Ci0gICAgICAgIHZhciB2YWx1ZSA9IHRoaXMuX2RlZmF1 bHRWYWx1ZTsKKyAgICAgICAgaWYgKHR5cGVvZiB0aGlzLl92YWx1ZSAhPT0gInVuZGVmaW5lZCIp CisgICAgICAgICAgICByZXR1cm4gdGhpcy5fdmFsdWU7CisKKyAgICAgICAgdGhpcy5fdmFsdWUg PSB0aGlzLl9kZWZhdWx0VmFsdWU7CiAgICAgICAgIGlmICh3aW5kb3cubG9jYWxTdG9yYWdlICE9 IG51bGwgJiYgdGhpcy5fbmFtZSBpbiB3aW5kb3cubG9jYWxTdG9yYWdlKSB7CiAgICAgICAgICAg ICB0cnkgewotICAgICAgICAgICAgICAgIHZhbHVlID0gSlNPTi5wYXJzZSh3aW5kb3cubG9jYWxT dG9yYWdlW3RoaXMuX25hbWVdKTsKKyAgICAgICAgICAgICAgICB0aGlzLl92YWx1ZSA9IEpTT04u cGFyc2Uod2luZG93LmxvY2FsU3RvcmFnZVt0aGlzLl9uYW1lXSk7CiAgICAgICAgICAgICB9IGNh dGNoKGUpIHsKICAgICAgICAgICAgICAgICB3aW5kb3cubG9jYWxTdG9yYWdlLnJlbW92ZUl0ZW0o dGhpcy5fbmFtZSk7CiAgICAgICAgICAgICB9CiAgICAgICAgIH0KLSAgICAgICAgcmV0dXJuIHZh bHVlOworICAgICAgICByZXR1cm4gdGhpcy5fdmFsdWU7CiAgICAgfSwKIAogICAgIHNldDogZnVu Y3Rpb24odmFsdWUpCiAgICAgeworICAgICAgICB0aGlzLl92YWx1ZSA9IHZhbHVlOwogICAgICAg ICBpZiAod2luZG93LmxvY2FsU3RvcmFnZSAhPSBudWxsKSB7Ci0gICAgICAgICAgICB0cnkgewot ICAgICAgICAgICAgICAgIHdpbmRvdy5sb2NhbFN0b3JhZ2VbdGhpcy5fbmFtZV0gPSBKU09OLnN0 cmluZ2lmeSh2YWx1ZSk7Ci0gICAgICAgICAgICB9IGNhdGNoKGUpIHsKLSAgICAgICAgICAgICAg ICBjb25zb2xlLmVycm9yKCJFcnJvciBzYXZpbmcgc2V0dGluZyB3aXRoIG5hbWU6IiArIHRoaXMu X25hbWUpOworICAgICAgICAgICAgZnVuY3Rpb24gcGVyc2lzdCgpCisgICAgICAgICAgICB7Cisg ICAgICAgICAgICAgICAgdHJ5IHsKKyAgICAgICAgICAgICAgICAgICAgd2luZG93LmxvY2FsU3Rv cmFnZVt0aGlzLl9uYW1lXSA9IEpTT04uc3RyaW5naWZ5KHZhbHVlKTsKKyAgICAgICAgICAgICAg ICB9IGNhdGNoKGUpIHsKKyAgICAgICAgICAgICAgICAgICAgY29uc29sZS5lcnJvcigiRXJyb3Ig c2F2aW5nIHNldHRpbmcgd2l0aCBuYW1lOiIgKyB0aGlzLl9uYW1lKTsKKyAgICAgICAgICAgICAg ICB9CiAgICAgICAgICAgICB9CisgICAgICAgICAgICBzZXRUaW1lb3V0KHBlcnNpc3QuYmluZCh0 aGlzKSwgMCk7CiAgICAgICAgIH0KICAgICAgICAgdGhpcy5fZXZlbnRTdXBwb3J0LmRpc3BhdGNo RXZlbnRUb0xpc3RlbmVycyh0aGlzLl9uYW1lLCB2YWx1ZSk7CiAgICAgfQo=