78813 2012-02-16 07:42:38 -0800 Web Inspector: remove free flow DOM editing experiment. 2012-02-17 00:43:30 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 pfeldman pfeldman apavlov bweinstein dglazkov joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 558183 0 pfeldman 2012-02-16 07:42:38 -0800 Patch to follow. 558184 1 127376 pfeldman 2012-02-16 07:44:58 -0800 Created attachment 127376 Patch 558216 2 127376 webkit.review.bot 2012-02-16 08:31:33 -0800 Comment on attachment 127376 Patch Attachment 127376 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11538148 New failing tests: inspector/elements/set-html-via-resource.html 558228 3 pfeldman 2012-02-16 08:38:14 -0800 Committed r107940: <http://trac.webkit.org/changeset/107940> 558431 4 127376 timothy 2012-02-16 12:20:10 -0800 Comment on attachment 127376 Patch Why? 559005 5 pfeldman 2012-02-17 00:43:30 -0800 (In reply to comment #4) > (From update of attachment 127376 [details]) > Why? Experiment was allowing free flow HTML editing from resources panel and was patching the DOM. It was also creating revisions of HTML document upon edits in the Elements panel. While it was working intuitively and well for static pages, I was struggling to make it work for highly dynamic pages (like inspector.html). Since it was editing DOM, not HTML, it was mixing the concepts and was suggesting that serialized DOM was a revision of the resource. The diff for such a revision was huge and non-helpful. I was also trying to toggle between ElementsTreeOutline and TextEditor in the ElementsPanel, so that free flow DOM editign took place where expected, but it needed tabbed interface (due to multiple iframes) and switching between the DOM and editors was non-intuitive (keeping them in sync was challenging). 127376 2012-02-16 07:44:58 -0800 2012-02-16 12:20:09 -0800 Patch bug-78813-20120216194456.patch text/plain 5037 pfeldman U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3OTM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDMwNmNiY2Y3ODJjMzdi ZWI4MDY1Yjg0ZDc1ZWUwZThkYzQ5NjlhNi4uZTRhZjRlZTQ4M2RkYjMyNDBjNmI1NWI3NGRjOWVl NWUxYTJhNzY1YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAyLTE2ICBQYXZl bCBGZWxkbWFuICA8cGZlbGRtYW5AZ29vZ2xlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiByZW1vdmUgZnJlZSBmbG93IERPTSBlZGl0aW5nIGV4cGVyaW1lbnQuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03ODgxMworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9E T01BZ2VudC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5ET01BZ2VudC5wcm90b3R5cGUuX21h cmtSZXZpc2lvbik6CisKIDIwMTItMDItMTUgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBnb29n bGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IGV4cGxpY2l0bHkgbWFyayB1bmRvYWJs ZSBzdGF0ZSBmcm9tIHRoZSBmcm9udC1lbmQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL0RPTUFnZW50LmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L2Zyb250LWVuZC9ET01BZ2VudC5qcwppbmRleCBkNjg2ZmE3MmZhNTIzMWM5Y2FiMzFjNDljNmQ4 NjBlMjBjY2I2NzZjLi4yZWYwMTY5NDMzMzAyNWQ2YzBkYWU5NDM4YzY2MDIxYTJjN2JiN2VmIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0RPTUFnZW50Lmpz CisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRE9NQWdlbnQuanMKQEAg LTY2MCw5ICs2NjAsNiBAQCBXZWJJbnNwZWN0b3IuRE9NQWdlbnQgPSBmdW5jdGlvbigpIHsKICAg ICB0aGlzLl9kb2N1bWVudCA9IG51bGw7CiAgICAgdGhpcy5fYXR0cmlidXRlTG9hZE5vZGVJZHMg PSB7fTsKICAgICBJbnNwZWN0b3JCYWNrZW5kLnJlZ2lzdGVyRE9NRGlzcGF0Y2hlcihuZXcgV2Vi SW5zcGVjdG9yLkRPTURpc3BhdGNoZXIodGhpcykpOwotICAgIGlmIChXZWJJbnNwZWN0b3IuZXhw ZXJpbWVudHNTZXR0aW5ncy5mcmVlRmxvd0RPTUVkaXRpbmcuaXNFbmFibGVkKCkpCi0gICAgICAg IG5ldyBXZWJJbnNwZWN0b3IuRE9NTW9kZWxSZXNvdXJjZUJpbmRpbmcodGhpcyk7Ci0KICAgICBp ZiAoV2ViSW5zcGVjdG9yLnNldHRpbmdzLmVtdWxhdGVUb3VjaEV2ZW50cy5nZXQoKSkKICAgICAg ICAgdGhpcy5fZW11bGF0ZVRvdWNoRXZlbnRzQ2hhbmdlZCgpOwogICAgIFdlYkluc3BlY3Rvci5z ZXR0aW5ncy5lbXVsYXRlVG91Y2hFdmVudHMuYWRkQ2hhbmdlTGlzdGVuZXIodGhpcy5fZW11bGF0 ZVRvdWNoRXZlbnRzQ2hhbmdlZCwgdGhpcyk7CkBAIC0xMTIyLDQ1ICsxMTE5LDEwIEBAIFdlYklu c3BlY3Rvci5ET01BZ2VudC5wcm90b3R5cGUgPSB7CiAKICAgICAgICAgICAgIGlmIChjYWxsYmFj aykKICAgICAgICAgICAgICAgICBjYWxsYmFjay5hcHBseSh0aGlzLCBhcmd1bWVudHMpOwotICAg ICAgICAgICAgaWYgKGVycm9yIHx8ICFXZWJJbnNwZWN0b3IuZXhwZXJpbWVudHNTZXR0aW5ncy5m cmVlRmxvd0RPTUVkaXRpbmcuaXNFbmFibGVkKCkpCi0gICAgICAgICAgICAgICAgcmV0dXJuOwot ICAgICAgICAgICAgaWYgKHRoaXMuX2NhcHR1cmVET01UaW1lcikKLSAgICAgICAgICAgICAgIGNs ZWFyVGltZW91dCh0aGlzLl9jYXB0dXJlRE9NVGltZXIpOwotICAgICAgICAgICAgdGhpcy5fY2Fw dHVyZURPTVRpbWVyID0gc2V0VGltZW91dCh0aGlzLl9jYXB0dXJlRE9NLmJpbmQodGhpcywgbm9k ZSksIDUwMCk7CiAgICAgICAgIH0KICAgICAgICAgcmV0dXJuIHdyYXBwZXJGdW5jdGlvbi5iaW5k KHRoaXMpOwogICAgIH0sCiAKLSAgICAvKioKLSAgICAgKiBAcGFyYW0ge1dlYkluc3BlY3Rvci5E T01Ob2RlfSBub2RlCi0gICAgICovCi0gICAgX2NhcHR1cmVET006IGZ1bmN0aW9uKG5vZGUpCi0g ICAgewotICAgICAgICBkZWxldGUgdGhpcy5fY2FwdHVyZURPTVRpbWVyOwotICAgICAgICBpZiAo IW5vZGUub3duZXJEb2N1bWVudCkKLSAgICAgICAgICAgIHJldHVybjsKLQotICAgICAgICBmdW5j dGlvbiBjYWxsYmFjayhlcnJvciwgdGV4dCkKLSAgICAgICAgewotICAgICAgICAgICAgaWYgKGVy cm9yKSB7Ci0gICAgICAgICAgICAgICAgY29uc29sZS5lcnJvcihlcnJvcik7Ci0gICAgICAgICAg ICAgICAgcmV0dXJuOwotICAgICAgICAgICAgfQotCi0gICAgICAgICAgICB2YXIgdXJsID0gbm9k ZS5vd25lckRvY3VtZW50LmRvY3VtZW50VVJMOwotICAgICAgICAgICAgaWYgKCF1cmwpCi0gICAg ICAgICAgICAgICAgcmV0dXJuOwotCi0gICAgICAgICAgICB2YXIgcmVzb3VyY2UgPSBXZWJJbnNw ZWN0b3IucmVzb3VyY2VGb3JVUkwodXJsKTsKLSAgICAgICAgICAgIGlmICghcmVzb3VyY2UpCi0g ICAgICAgICAgICAgICAgcmV0dXJuOwotCi0gICAgICAgICAgICByZXNvdXJjZS5hZGRSZXZpc2lv bih0ZXh0KTsKLSAgICAgICAgfQotICAgICAgICBET01BZ2VudC5nZXRPdXRlckhUTUwobm9kZS5v d25lckRvY3VtZW50LmlkLCBjYWxsYmFjayk7Ci0gICAgICAgIAotICAgIH0sCi0KICAgICBfZW11 bGF0ZVRvdWNoRXZlbnRzQ2hhbmdlZDogZnVuY3Rpb24oKQogICAgIHsKICAgICAgICAgRE9NQWdl bnQuc2V0VG91Y2hFbXVsYXRpb25FbmFibGVkKFdlYkluc3BlY3Rvci5zZXR0aW5ncy5lbXVsYXRl VG91Y2hFdmVudHMuZ2V0KCkpOwpAQCAtMTI5OCwzOSArMTI2MCwzIEBAIFdlYkluc3BlY3Rvci5E T01EaXNwYXRjaGVyLnByb3RvdHlwZSA9IHsKICAqIEB0eXBlIHs/V2ViSW5zcGVjdG9yLkRPTUFn ZW50fQogICovCiBXZWJJbnNwZWN0b3IuZG9tQWdlbnQgPSBudWxsOwotCi0vKioKLSAqIEBjb25z dHJ1Y3RvcgotICogQGltcGxlbWVudHMge1dlYkluc3BlY3Rvci5SZXNvdXJjZURvbWFpbk1vZGVs QmluZGluZ30KLSAqLwotV2ViSW5zcGVjdG9yLkRPTU1vZGVsUmVzb3VyY2VCaW5kaW5nID0gZnVu Y3Rpb24oZG9tQWdlbnQpCi17Ci0gICAgdGhpcy5fZG9tQWdlbnQgPSBkb21BZ2VudDsKLSAgICBX ZWJJbnNwZWN0b3IuUmVzb3VyY2UucmVnaXN0ZXJEb21haW5Nb2RlbEJpbmRpbmcoV2ViSW5zcGVj dG9yLlJlc291cmNlLlR5cGUuRG9jdW1lbnQsIHRoaXMpOwotfQotCi1XZWJJbnNwZWN0b3IuRE9N TW9kZWxSZXNvdXJjZUJpbmRpbmcucHJvdG90eXBlID0gewotICAgIHNldENvbnRlbnQ6IGZ1bmN0 aW9uKHJlc291cmNlLCBjb250ZW50LCBtYWpvckNoYW5nZSwgdXNlckNhbGxiYWNrKQotICAgIHsK LSAgICAgICAgdmFyIGZyYW1lSWQgPSByZXNvdXJjZS5mcmFtZUlkOwotICAgICAgICBpZiAoIWZy YW1lSWQpCi0gICAgICAgICAgICByZXR1cm47Ci0KLSAgICAgICAgUGFnZUFnZW50LnNldERvY3Vt ZW50Q29udGVudChmcmFtZUlkLCBjb250ZW50LCBjYWxsYmFja1dyYXBwZXIpOwotCi0gICAgICAg IGZ1bmN0aW9uIGNhbGxiYWNrV3JhcHBlcihlcnJvcikKLSAgICAgICAgewotICAgICAgICAgICAg aWYgKG1ham9yQ2hhbmdlKQotICAgICAgICAgICAgICAgIHJlc291cmNlLmFkZFJldmlzaW9uKGNv bnRlbnQpOwotICAgICAgICAgICAgaWYgKHVzZXJDYWxsYmFjaykKLSAgICAgICAgICAgICAgICB1 c2VyQ2FsbGJhY2soZXJyb3IpOwotICAgICAgICB9Ci0gICAgfSwKLQotICAgIGNhblNldENvbnRl bnQ6IGZ1bmN0aW9uKCkKLSAgICB7Ci0gICAgICAgIHJldHVybiB0cnVlOwotICAgIH0KLX0KLQot V2ViSW5zcGVjdG9yLkRPTU1vZGVsUmVzb3VyY2VCaW5kaW5nLnByb3RvdHlwZS5fX3Byb3RvX18g PSBXZWJJbnNwZWN0b3IuUmVzb3VyY2VEb21haW5Nb2RlbEJpbmRpbmcucHJvdG90eXBlOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TZXR0aW5ncy5qcyBi L1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2V0dGluZ3MuanMKaW5kZXggN2I2 NjRlOGE3NTljMzBlMjIwMzhjY2MwNzAxM2RjNzgxNmViNmYyMS4uNTM0NjgwYjdlOGQ2MmQxYzRk NzY5MGViZGJiZWQ1MmQ1NmNlZDM4ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9TZXR0aW5ncy5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL1NldHRpbmdzLmpzCkBAIC0xNzAsNyArMTcwLDYgQEAgV2ViSW5zcGVjdG9yLkV4 cGVyaW1lbnRzU2V0dGluZ3MgPSBmdW5jdGlvbigpCiAgICAgCiAgICAgLy8gQWRkIGN1cnJlbnRs eSBydW5uaW5nIGV4cGVyaW1lbnRzIGhlcmUuCiAgICAgdGhpcy5zb3VyY2VGcmFtZUFsd2F5c0Vk aXRhYmxlID0gdGhpcy5fY3JlYXRlRXhwZXJpbWVudCgic291cmNlRnJhbWVBbHdheXNFZGl0YWJs ZSIsICJNYWtlIHJlc291cmNlcyBhbHdheXMgZWRpdGFibGUiKTsKLSAgICB0aGlzLmZyZWVGbG93 RE9NRWRpdGluZyA9IHRoaXMuX2NyZWF0ZUV4cGVyaW1lbnQoImZyZWVGbG93RE9NRWRpdGluZyIs ICJFbmFibGUgZnJlZSBmbG93IERPTSBlZGl0aW5nIik7CiAgICAgdGhpcy5zaG93TWVtb3J5Q291 bnRlcnMgPSB0aGlzLl9jcmVhdGVFeHBlcmltZW50KCJzaG93TWVtb3J5Q291bnRlcnMiLCAiU2hv dyBtZW1vcnkgY291bnRlcnMgaW4gVGltZWxpbmUgcGFuZWwiKTsKICAgICB0aGlzLnNpbmdsZUNs aWNrRWRpdGluZyA9IHRoaXMuX2NyZWF0ZUV4cGVyaW1lbnQoInNpbmdsZUNsaWNrRWRpdGluZyIs ICJTaW5nbGUgY2xpY2sgQ1NTIGVkaXRpbmciKTsKICAgICAvLyBGSVhNRTogRW5hYmxlIGh0dHAv dGVzdHMvaW5zcGVjdG9yL2luZGV4ZWRkYi9yZXNvdXJjZXMtcGFuZWwuaHRtbCB3aGVuIHJlbW92 ZWQgZnJvbSBleHBlcmltZW50cy4K