78804 2012-02-16 05:54:59 -0800 Remove unused features from CodeFeatures 2012-02-20 04:50:19 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 wingo wingo barraclough ggaren oliver webkit.review.bot oldest_to_newest 558123 0 wingo 2012-02-16 05:54:59 -0800 A cleanup I saw while doing other things: removing some flags from CodeFeatures that are not used. Patch to be attached. 558127 1 127365 wingo 2012-02-16 05:56:02 -0800 Created attachment 127365 Patch 560177 2 127365 webkit.review.bot 2012-02-20 04:36:50 -0800 Comment on attachment 127365 Patch Rejecting attachment 127365 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/JavaScriptCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/11551149 560185 3 wingo 2012-02-20 04:50:19 -0800 Committed r108233: <http://trac.webkit.org/changeset/108233> 127365 2012-02-16 05:56:02 -0800 2012-02-20 04:36:50 -0800 Patch bug-78804-20120216145600.patch text/plain 4922 wingo U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3Mzc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 MDBhZTk1NDE4MWYyNjRjZTA5ZTdlZTFmNzNmNzliY2QzOTk1YzlkLi4zNGZmNjZlNzgwODQzZWYw N2M2ZWU4YTIwZGQxMzQwZmY2ZjA0NmI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMyBAQAorMjAxMi0wMi0xNiAgQW5keSBXaW5nbyAgPHdpbmdvQHBvYm94LmNvbT4KKwor ICAgICAgICBSZW1vdmUgdW51c2VkIGZlYXR1cmVzIGZyb20gQ29kZUZlYXR1cmVzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03ODgwNAorCisgICAgICAg ICogcGFyc2VyL05vZGVzLmg6CisgICAgICAgICogcGFyc2VyL0FTVEJ1aWxkZXIuaDoKKyAgICAg ICAgKEpTQzo6Q2xvc3VyZUZlYXR1cmUpOgorICAgICAgICAoSlNDOjpBU1RCdWlsZGVyOjpjcmVh dGVGdW5jdGlvbkJvZHkpOgorICAgICAgICAoSlNDOjpBU1RCdWlsZGVyOjp1c2VzQ2xvc3VyZXMp OgorICAgICAgICBSZW1vdmUgIkNsb3N1cmVGZWF0dXJlIi4gIFNpbmNlIHdlIHRyYWNrIGNhcHR1 cmVkIHZhcmlhYmxlcyBtb3JlCisgICAgICAgIHByZWNpc2VseSwgdGhpcyBiaXQgZG9lc24ndCBk byB1cyBhbnkgZ29vZC4KKworICAgICAgICAoSlNDOjpBc3NpZ25GZWF0dXJlKToKKyAgICAgICAg KEpTQzo6QVNUQnVpbGRlcjo6bWFrZUFzc2lnbk5vZGUpOgorICAgICAgICAoSlNDOjpBU1RCdWls ZGVyOjptYWtlUHJlZml4Tm9kZSk6CisgICAgICAgIChKU0M6OkFTVEJ1aWxkZXI6Om1ha2VQb3N0 Zml4Tm9kZSk6CisgICAgICAgIChKU0M6OkFTVEJ1aWxkZXI6OnVzZXNBc3NpZ25tZW50KToKKyAg ICAgICAgU2ltaWxhcmx5LCByZW1vdmUgQXNzaWduRmVhdHVyZS4gIEl0IGlzIHVudXNlZC4KKwog MjAxMi0wMi0wOSAgQW5keSBXaW5nbyAgPHdpbmdvQGlnYWxpYS5jb20+CiAKICAgICAgICAgRWxp bWluYXRlIGRlYWQgY29kZSBpbiBCeXRlY29kZUdlbmVyYXRvcjo6cmVzb2x2ZSgpCmRpZmYgLS1n aXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL0FTVEJ1aWxkZXIuaCBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9wYXJzZXIvQVNUQnVpbGRlci5oCmluZGV4IGI2ZWEwMDRiNTg5OGQ5MTgy MTIyMjM1YjE4ZWMxYmQ2ZjNlNzJjMWMuLmI4NzE4NzA5YjBkMzc2YjI0MmFmNTM5ZjAyOTU0NmYw MTQzYzU1YjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvQVNUQnVp bGRlci5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvQVNUQnVpbGRlci5oCkBA IC0yNjUsNyArMjY1LDYgQEAgcHVibGljOgogCiAgICAgRnVuY3Rpb25Cb2R5Tm9kZSogY3JlYXRl RnVuY3Rpb25Cb2R5KGludCBsaW5lTnVtYmVyLCBib29sIGluU3RyaWN0Q29udGV4dCkKICAgICB7 Ci0gICAgICAgIHVzZXNDbG9zdXJlcygpOwogICAgICAgICByZXR1cm4gRnVuY3Rpb25Cb2R5Tm9k ZTo6Y3JlYXRlKG1fZ2xvYmFsRGF0YSwgbGluZU51bWJlciwgaW5TdHJpY3RDb250ZXh0KTsKICAg ICB9CiAgICAgCkBAIC02MjQsOSArNjIzLDcgQEAgcHJpdmF0ZToKICAgICB2b2lkIGluY0NvbnN0 YW50cygpIHsgbV9zY29wZS5tX251bUNvbnN0YW50cysrOyB9CiAgICAgdm9pZCB1c2VzVGhpcygp IHsgbV9zY29wZS5tX2ZlYXR1cmVzIHw9IFRoaXNGZWF0dXJlOyB9CiAgICAgdm9pZCB1c2VzQ2F0 Y2goKSB7IG1fc2NvcGUubV9mZWF0dXJlcyB8PSBDYXRjaEZlYXR1cmU7IH0KLSAgICB2b2lkIHVz ZXNDbG9zdXJlcygpIHsgbV9zY29wZS5tX2ZlYXR1cmVzIHw9IENsb3N1cmVGZWF0dXJlOyB9CiAg ICAgdm9pZCB1c2VzQXJndW1lbnRzKCkgeyBtX3Njb3BlLm1fZmVhdHVyZXMgfD0gQXJndW1lbnRz RmVhdHVyZTsgfQotICAgIHZvaWQgdXNlc0Fzc2lnbm1lbnQoKSB7IG1fc2NvcGUubV9mZWF0dXJl cyB8PSBBc3NpZ25GZWF0dXJlOyB9CiAgICAgdm9pZCB1c2VzV2l0aCgpIHsgbV9zY29wZS5tX2Zl YXR1cmVzIHw9IFdpdGhGZWF0dXJlOyB9CiAgICAgdm9pZCB1c2VzRXZhbCgpIAogICAgIHsKQEAg LTkwNCw3ICs5MDEsNiBAQCBFeHByZXNzaW9uTm9kZSogQVNUQnVpbGRlcjo6bWFrZUJpbmFyeU5v ZGUoaW50IGxpbmVOdW1iZXIsIGludCB0b2tlbiwgcGFpcjxFeHByZQogCiBFeHByZXNzaW9uTm9k ZSogQVNUQnVpbGRlcjo6bWFrZUFzc2lnbk5vZGUoaW50IGxpbmVOdW1iZXIsIEV4cHJlc3Npb25O b2RlKiBsb2MsIE9wZXJhdG9yIG9wLCBFeHByZXNzaW9uTm9kZSogZXhwciwgYm9vbCBsb2NIYXNB c3NpZ25tZW50cywgYm9vbCBleHBySGFzQXNzaWdubWVudHMsIGludCBzdGFydCwgaW50IGRpdm90 LCBpbnQgZW5kKQogewotICAgIHVzZXNBc3NpZ25tZW50KCk7CiAgICAgaWYgKCFsb2MtPmlzTG9j YXRpb24oKSkKICAgICAgICAgcmV0dXJuIG5ldyAobV9nbG9iYWxEYXRhKSBBc3NpZ25FcnJvck5v ZGUobGluZU51bWJlciwgbG9jLCBvcCwgZXhwciwgZGl2b3QsIGRpdm90IC0gc3RhcnQsIGVuZCAt IGRpdm90KTsKIApAQCAtOTQyLDcgKzkzOCw2IEBAIEV4cHJlc3Npb25Ob2RlKiBBU1RCdWlsZGVy OjptYWtlQXNzaWduTm9kZShpbnQgbGluZU51bWJlciwgRXhwcmVzc2lvbk5vZGUqIGxvYywKIAog RXhwcmVzc2lvbk5vZGUqIEFTVEJ1aWxkZXI6Om1ha2VQcmVmaXhOb2RlKGludCBsaW5lTnVtYmVy LCBFeHByZXNzaW9uTm9kZSogZXhwciwgT3BlcmF0b3Igb3AsIGludCBzdGFydCwgaW50IGRpdm90 LCBpbnQgZW5kKQogewotICAgIHVzZXNBc3NpZ25tZW50KCk7CiAgICAgaWYgKCFleHByLT5pc0xv Y2F0aW9uKCkpCiAgICAgICAgIHJldHVybiBuZXcgKG1fZ2xvYmFsRGF0YSkgUHJlZml4RXJyb3JO b2RlKGxpbmVOdW1iZXIsIGV4cHIsIG9wLCBkaXZvdCwgZGl2b3QgLSBzdGFydCwgZW5kIC0gZGl2 b3QpOwogCkBAIC05NjUsNyArOTYwLDYgQEAgRXhwcmVzc2lvbk5vZGUqIEFTVEJ1aWxkZXI6Om1h a2VQcmVmaXhOb2RlKGludCBsaW5lTnVtYmVyLCBFeHByZXNzaW9uTm9kZSogZXhwciwKIAogRXhw cmVzc2lvbk5vZGUqIEFTVEJ1aWxkZXI6Om1ha2VQb3N0Zml4Tm9kZShpbnQgbGluZU51bWJlciwg RXhwcmVzc2lvbk5vZGUqIGV4cHIsIE9wZXJhdG9yIG9wLCBpbnQgc3RhcnQsIGludCBkaXZvdCwg aW50IGVuZCkKIHsKLSAgICB1c2VzQXNzaWdubWVudCgpOwogICAgIGlmICghZXhwci0+aXNMb2Nh dGlvbigpKQogICAgICAgICByZXR1cm4gbmV3IChtX2dsb2JhbERhdGEpIFBvc3RmaXhFcnJvck5v ZGUobGluZU51bWJlciwgZXhwciwgb3AsIGRpdm90LCBkaXZvdCAtIHN0YXJ0LCBlbmQgLSBkaXZv dCk7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvTm9kZXMuaCBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvTm9kZXMuaAppbmRleCAyNzhkMTdlZjQ4ZjY0 YzIwNzBlNmFhOGYwYzk1ZDUxYjQwYjA5MDliLi43Y2U0ZTdiYWU0YzI0OWY5MWU0MWVmYzU0MDYz ZDQwZTU1M2NmZDdmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL05v ZGVzLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9Ob2Rlcy5oCkBAIC01MSwx NyArNTEsMTQgQEAgbmFtZXNwYWNlIEpTQyB7CiAKICAgICBjb25zdCBDb2RlRmVhdHVyZXMgTm9G ZWF0dXJlcyA9IDA7CiAgICAgY29uc3QgQ29kZUZlYXR1cmVzIEV2YWxGZWF0dXJlID0gMSA8PCAw OwotICAgIGNvbnN0IENvZGVGZWF0dXJlcyBDbG9zdXJlRmVhdHVyZSA9IDEgPDwgMTsKLSAgICBj b25zdCBDb2RlRmVhdHVyZXMgQXNzaWduRmVhdHVyZSA9IDEgPDwgMjsKLSAgICBjb25zdCBDb2Rl RmVhdHVyZXMgQXJndW1lbnRzRmVhdHVyZSA9IDEgPDwgMzsKLSAgICBjb25zdCBDb2RlRmVhdHVy ZXMgV2l0aEZlYXR1cmUgPSAxIDw8IDQ7Ci0gICAgY29uc3QgQ29kZUZlYXR1cmVzIENhdGNoRmVh dHVyZSA9IDEgPDwgNTsKLSAgICBjb25zdCBDb2RlRmVhdHVyZXMgVGhpc0ZlYXR1cmUgPSAxIDw8 IDY7Ci0gICAgY29uc3QgQ29kZUZlYXR1cmVzIFN0cmljdE1vZGVGZWF0dXJlID0gMSA8PCA3Owot ICAgIGNvbnN0IENvZGVGZWF0dXJlcyBTaGFkb3dzQXJndW1lbnRzRmVhdHVyZSA9IDEgPDwgODsK KyAgICBjb25zdCBDb2RlRmVhdHVyZXMgQXJndW1lbnRzRmVhdHVyZSA9IDEgPDwgMTsKKyAgICBj b25zdCBDb2RlRmVhdHVyZXMgV2l0aEZlYXR1cmUgPSAxIDw8IDI7CisgICAgY29uc3QgQ29kZUZl YXR1cmVzIENhdGNoRmVhdHVyZSA9IDEgPDwgMzsKKyAgICBjb25zdCBDb2RlRmVhdHVyZXMgVGhp c0ZlYXR1cmUgPSAxIDw8IDQ7CisgICAgY29uc3QgQ29kZUZlYXR1cmVzIFN0cmljdE1vZGVGZWF0 dXJlID0gMSA8PCA1OworICAgIGNvbnN0IENvZGVGZWF0dXJlcyBTaGFkb3dzQXJndW1lbnRzRmVh dHVyZSA9IDEgPDwgNjsKICAgICAKLSAgICAKLSAgICBjb25zdCBDb2RlRmVhdHVyZXMgQWxsRmVh dHVyZXMgPSBFdmFsRmVhdHVyZSB8IENsb3N1cmVGZWF0dXJlIHwgQXNzaWduRmVhdHVyZSB8IEFy Z3VtZW50c0ZlYXR1cmUgfCBXaXRoRmVhdHVyZSB8IENhdGNoRmVhdHVyZSB8IFRoaXNGZWF0dXJl IHwgU3RyaWN0TW9kZUZlYXR1cmUgfCBTaGFkb3dzQXJndW1lbnRzRmVhdHVyZTsKKyAgICBjb25z dCBDb2RlRmVhdHVyZXMgQWxsRmVhdHVyZXMgPSBFdmFsRmVhdHVyZSB8IEFyZ3VtZW50c0ZlYXR1 cmUgfCBXaXRoRmVhdHVyZSB8IENhdGNoRmVhdHVyZSB8IFRoaXNGZWF0dXJlIHwgU3RyaWN0TW9k ZUZlYXR1cmUgfCBTaGFkb3dzQXJndW1lbnRzRmVhdHVyZTsKIAogICAgIGVudW0gT3BlcmF0b3Ig ewogICAgICAgICBPcEVxdWFsLAo=