78790 2012-02-16 02:05:56 -0800 Build Fix: R107894 breaks Chromium Linux Build. 2012-02-28 21:28:51 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 79865 1 yosin yosin dcheng noel.gordon tkent oldest_to_newest 557994 0 yosin 2012-02-16 02:05:56 -0800 http://trac.webkit.org/changeset/107894/trunk/Source/WebCore/platform/chromium/ChromiumDataObject.h This change is incompatible with this change: http://trac.webkit.org/browser/trunk/Source/WebKit/chromium/src/WebDragData.cpp?rev=107846 Build log http://webkit-commit-queue.appspot.com/results/11535094 558008 1 127333 yosin 2012-02-16 02:26:30 -0800 Created attachment 127333 Patch 1 558012 2 127334 yosin 2012-02-16 02:32:10 -0800 Created attachment 127334 Patch 2 558022 3 127334 tkent 2012-02-16 02:41:58 -0800 Comment on attachment 127334 Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=127334&action=review > Source/WebKit/chromium/src/WebDragData.cpp:72 > - const HashSet<String>& types = m_private->types(); > + const DOMStringList& types = *m_private->types(); We need to do: RefPtr<DOMStringList> types = m_private->types(); 558024 4 127342 yosin 2012-02-16 02:44:51 -0800 Created attachment 127342 Patch 3 558027 5 127342 tkent 2012-02-16 02:46:30 -0800 Comment on attachment 127342 Patch 3 Clearing flags on attachment: 127342 Committed r107917: <http://trac.webkit.org/changeset/107917> 558028 6 tkent 2012-02-16 02:46:36 -0800 All reviewed patches have been landed. Closing bug. 127333 2012-02-16 02:26:30 -0800 2012-02-16 02:32:05 -0800 Patch 1 bug-78790-20120216192629.patch text/plain 2760 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3OTEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGExYjRkMDQxMmJlZmUwYTgwZGNhZGQ5YjJjMGRmNmJmODZmOGUzNjguLmRjMmFhODJiOGNjMDEx NmFkNmM4M2JiNzU2OTMyNzVhMTgxMzk1MTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTItMDItMTYgIFlvc2lmdW1pIElub3VlICA8eW9zaW5AY2hyb21p dW0ub3JnPgorCisgICAgICAgIEJ1aWxkIEZpeDogUjEwNzg5NCBicmVha3MgQ2hyb21pdW0gTGlu dXggQnVpbGQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD03ODc5MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogc3JjL1dlYkRyYWdEYXRhLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViRHJhZ0RhdGE6Oml0 ZW1zKTogVXNlIERPTVN0cmluZ0xpc3QgcmF0aGVyIHRoYW4gSGFzaFNldDxTdHJpbmc+IGZvciB2 YWx1ZSBvZiBtX3ByaXZhdGUtPnR5cGVzKCkuCisKIDIwMTItMDItMTUgIFNhbWkgS3lvc3RpbGEg IDxza3lvc3RpbEBnb29nbGUuY29tPgogCiAgICAgICAgIEVuYWJsZSAtd2Via2l0LW92ZXJmbG93 LXNjcm9sbGluZyBDU1MgcHJvcGVydHkKQEAgLTMxNywzMCArMzI3LDEyIEBACiAgICAgICAgICog c3JjL1dlYlBhZ2VTZXJpYWxpemVySW1wbC5jcHA6CiAgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VT ZXJpYWxpemVySW1wbDo6YnVpbGRDb250ZW50Rm9yTm9kZSk6CiAKLTIwMTItMDItMTMgIE5pY28g V2ViZXIgIDx0aGFraXNAY2hyb21pdW0ub3JnPgotCi0gICAgICAgIFtjaHJvbWl1bV0gTGV0IFdl YktpdDo6aW5pdGlhbGl6ZSBjYWxsIEluaXRXZWJDb3JlU3lzdGVtSW50ZXJmYWNlIG9uIG1hYy4K LSAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc4MjQ2Ci0K LSAgICAgICAgVGhpcyBhbGxvd3MgcmVtb3ZpbmcgYSBidW5jaCBvZiBjb2RlIGluIGNocm9taXVt IGxhbmQgKGh0dHBzOi8vY2hyb21pdW1jb2RlcmV2aWV3LmFwcHNwb3QuY29tLzkzNzQwMjAvKSwK LSAgICAgICAgYW5kIGhlbHBzIHdpdGggdGhlIGNvbXBvbmVudCBidWlsZCBvbiBtYWMgKEluaXRX ZWJDb3JlU3lzdGVtSW50ZXJmYWNlIGlzIG5vdCBhbgotICAgICAgICBleHBvcnRlZCBmdW5jdGlv biwgYW5kIGl0IHNob3VsZG4ndCBiZSkuCi0KLSAgICAgICAgU291cmNlL1dlYktpdC9tYWMvV2Vi Q29yZVN1cHBvcnQvV2ViU3lzdGVtSW50ZXJmYWNlLm1tIGVhcmx5LXJldHVybnMgd2hlbiBpdCdz Ci0gICAgICAgIGNhbGxlZCB0d2ljZSwgc28gaXQncyBzYWZlIHRvIGxhbmQgdGhpcyBjaGFuZ2Us IGFuZCByZW1vdmUgdGhlIGNhbGxzIGluIGNsaWVudAotICAgICAgICBjb2RlIGluIGEgbGF0ZXIg Q0wuCi0KLSAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gRmlzaGVyLgotCi0gICAgICAgICogc3Jj L1dlYktpdC5jcHA6Ci0gICAgICAgIChXZWJLaXQ6OmluaXRpYWxpemVXaXRob3V0VjgpOgotCi0y MDEyLTAyLTEzICBZb3NpZnVtaSBJbm91ZSAgPHlvc2luQGNocm9taXVtLm9yZz4KKzIwMTEtMTIt MjUgIFlvc2lmdW1pIElub3VlICA8eW9zaW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtGb3Jt c10gVXNlIGVudW0gaW5zdGVhZCBvZiBib29sIGZvciBIVE1MSW5wdXRFbGVtZW50OjpzZXRWYWx1 ZQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzUyMTcK IAotICAgICAgICBSZXZpZXdlZCBieSBLZW50IFRhbXVyYS4KKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCiAKICAgICAgICAgKiBzcmMvV2ViSW5wdXRFbGVtZW50LmNwcDoKICAg ICAgICAgKFdlYktpdDo6V2ViSW5wdXRFbGVtZW50OjpzZXRWYWx1ZSk6IFVzZSBlbnVtIGZvciBI VE1MSW5wdXRFbGVtZW50OjpzZXRWYWx1ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9zcmMvV2ViRHJhZ0RhdGEuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2Vi RHJhZ0RhdGEuY3BwCmluZGV4IDc0MmRlNzk3ZTczMmZkZWY4MjQ5ZjI5MDc2Yjg3NjI2OGE3OGNj YWMuLjAxMmU1N2M1ZDFmNzRlYjQ0YjYwYTY4Y2U1ZGQ3MmM2YzgwN2Q0NjYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkRyYWdEYXRhLmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3NyYy9XZWJEcmFnRGF0YS5jcHAKQEAgLTY5LDcgKzY5LDcgQEAgdm9p ZCBXZWJEcmFnRGF0YTo6YXNzaWduKGNvbnN0IFdlYkRyYWdEYXRhJiBvdGhlcikKIFdlYlZlY3Rv cjxXZWJEcmFnRGF0YTo6SXRlbT4gV2ViRHJhZ0RhdGE6Oml0ZW1zKCkgY29uc3QKIHsKICAgICBW ZWN0b3I8SXRlbT4gaXRlbUxpc3Q7Ci0gICAgY29uc3QgSGFzaFNldDxTdHJpbmc+JiB0eXBlcyA9 IG1fcHJpdmF0ZS0+dHlwZXMoKTsKKyAgICBjb25zdCBET01TdHJpbmdMaXN0JiB0eXBlcyA9ICpt X3ByaXZhdGUtPnR5cGVzKCk7CiAgICAgaWYgKHR5cGVzLmNvbnRhaW5zKG1pbWVUeXBlVGV4dFBs YWluKSkgewogICAgICAgICBJdGVtIGl0ZW07CiAgICAgICAgIGl0ZW0uc3RvcmFnZVR5cGUgPSBJ dGVtOjpTdG9yYWdlVHlwZVN0cmluZzsK 127334 2012-02-16 02:32:10 -0800 2012-02-16 02:44:46 -0800 Patch 2 bug-78790-20120216193208.patch text/plain 1447 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3OTEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGExYjRkMDQxMmJlZmUwYTgwZGNhZGQ5YjJjMGRmNmJmODZmOGUzNjguLmI1MTUxNDA2NjQyMTAy M2NjNGU3M2FlZTVkYzE0ZjA5OGRiODFkMjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTItMDItMTYgIFlvc2lmdW1pIElub3VlICA8eW9zaW5AY2hyb21p dW0ub3JnPgorCisgICAgICAgIEJ1aWxkIEZpeDogUjEwNzg5NCBicmVha3MgQ2hyb21pdW0gTGlu dXggQnVpbGQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD03ODc5MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogc3JjL1dlYkRyYWdEYXRhLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViRHJhZ0RhdGE6Oml0 ZW1zKTogVXNlIERPTVN0cmluZ0xpc3QgcmF0aGVyIHRoYW4gSGFzaFNldDxTdHJpbmc+IGZvciB2 YWx1ZSBvZiBtX3ByaXZhdGUtPnR5cGVzKCkuCisKIDIwMTItMDItMTUgIFNhbWkgS3lvc3RpbGEg IDxza3lvc3RpbEBnb29nbGUuY29tPgogCiAgICAgICAgIEVuYWJsZSAtd2Via2l0LW92ZXJmbG93 LXNjcm9sbGluZyBDU1MgcHJvcGVydHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vc3JjL1dlYkRyYWdEYXRhLmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkRy YWdEYXRhLmNwcAppbmRleCA3NDJkZTc5N2U3MzJmZGVmODI0OWYyOTA3NmI4NzYyNjhhNzhjY2Fj Li4wMTJlNTdjNWQxZjc0ZWI0NGI2MGE2OGNlNWRkNzJjNmM4MDdkNDY2IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJEcmFnRGF0YS5jcHAKKysrIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9zcmMvV2ViRHJhZ0RhdGEuY3BwCkBAIC02OSw3ICs2OSw3IEBAIHZvaWQg V2ViRHJhZ0RhdGE6OmFzc2lnbihjb25zdCBXZWJEcmFnRGF0YSYgb3RoZXIpCiBXZWJWZWN0b3I8 V2ViRHJhZ0RhdGE6Okl0ZW0+IFdlYkRyYWdEYXRhOjppdGVtcygpIGNvbnN0CiB7CiAgICAgVmVj dG9yPEl0ZW0+IGl0ZW1MaXN0OwotICAgIGNvbnN0IEhhc2hTZXQ8U3RyaW5nPiYgdHlwZXMgPSBt X3ByaXZhdGUtPnR5cGVzKCk7CisgICAgY29uc3QgRE9NU3RyaW5nTGlzdCYgdHlwZXMgPSAqbV9w cml2YXRlLT50eXBlcygpOwogICAgIGlmICh0eXBlcy5jb250YWlucyhtaW1lVHlwZVRleHRQbGFp bikpIHsKICAgICAgICAgSXRlbSBpdGVtOwogICAgICAgICBpdGVtLnN0b3JhZ2VUeXBlID0gSXRl bTo6U3RvcmFnZVR5cGVTdHJpbmc7Cg== 127342 2012-02-16 02:44:51 -0800 2012-02-16 02:46:30 -0800 Patch 3 bug-78790-20120216194450.patch text/plain 2929 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3OTEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGExYjRkMDQxMmJlZmUwYTgwZGNhZGQ5YjJjMGRmNmJmODZmOGUzNjguLmJhNDQ3NjdkNGNkY2Y3 OGM2NWQ5ZGU2OTIzZDM4MmM0ZjNmNmExNzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTItMDItMTYgIFlvc2lmdW1pIElub3VlICA8eW9zaW5AY2hyb21p dW0ub3JnPgorCisgICAgICAgIEJ1aWxkIEZpeDogUjEwNzg5NCBicmVha3MgQ2hyb21pdW0gTGlu dXggQnVpbGQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD03ODc5MAorCisgICAgICAgIFdlYkRyYWdEYXRhUHJpdmF0ZTo6dHlwZXMsIGluaGVyaXRlZCBm cm9tIENocm9taXVtRGF0YU9iamVjdCwgcmV0dXJucyBQYXNzUmVmPERPTVN0cmluZ0xpc3Q+IHNp bmNlIHIxMDc4OTQuIEhvd2V2ZXIsIFdlYkRyYWdEYXRhIGV4cGVjdGVkIHRvIGdldCBvbGQgcmV0 dXJuIHZhbHVlIHR5cGUgSGFzaFNldDxTdHJpbmc+LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogc3JjL1dlYkRyYWdEYXRhLmNwcDoKKyAgICAgICAg KFdlYktpdDo6V2ViRHJhZ0RhdGE6Oml0ZW1zKTogVXNlIFJlZlB0cjxET01TdHJpbmdMaXN0PiBy YXRoZXIgdGhhbiBIYXNoU2V0PFN0cmluZz4gZm9yIHZhbHVlIG9mIG1fcHJpdmF0ZS0+dHlwZXMo KS4KKwogMjAxMi0wMi0xNSAgU2FtaSBLeW9zdGlsYSAgPHNreW9zdGlsQGdvb2dsZS5jb20+CiAK ICAgICAgICAgRW5hYmxlIC13ZWJraXQtb3ZlcmZsb3ctc2Nyb2xsaW5nIENTUyBwcm9wZXJ0eQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRHJhZ0RhdGEuY3BwIGIv U291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRHJhZ0RhdGEuY3BwCmluZGV4IDc0MmRlNzk3 ZTczMmZkZWY4MjQ5ZjI5MDc2Yjg3NjI2OGE3OGNjYWMuLjViOGJmYzQ3MGRjOTA0NGUzNjU3ODcw OWY0ZjQ0ZjdlM2U4OWVlMDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3Jj L1dlYkRyYWdEYXRhLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJEcmFn RGF0YS5jcHAKQEAgLTY5LDggKzY5LDggQEAgdm9pZCBXZWJEcmFnRGF0YTo6YXNzaWduKGNvbnN0 IFdlYkRyYWdEYXRhJiBvdGhlcikKIFdlYlZlY3RvcjxXZWJEcmFnRGF0YTo6SXRlbT4gV2ViRHJh Z0RhdGE6Oml0ZW1zKCkgY29uc3QKIHsKICAgICBWZWN0b3I8SXRlbT4gaXRlbUxpc3Q7Ci0gICAg Y29uc3QgSGFzaFNldDxTdHJpbmc+JiB0eXBlcyA9IG1fcHJpdmF0ZS0+dHlwZXMoKTsKLSAgICBp ZiAodHlwZXMuY29udGFpbnMobWltZVR5cGVUZXh0UGxhaW4pKSB7CisgICAgUmVmUHRyPERPTVN0 cmluZ0xpc3Q+IHR5cGVzID0gbV9wcml2YXRlLT50eXBlcygpOworICAgIGlmICh0eXBlcy0+Y29u dGFpbnMobWltZVR5cGVUZXh0UGxhaW4pKSB7CiAgICAgICAgIEl0ZW0gaXRlbTsKICAgICAgICAg aXRlbS5zdG9yYWdlVHlwZSA9IEl0ZW06OlN0b3JhZ2VUeXBlU3RyaW5nOwogICAgICAgICBpdGVt LnN0cmluZ1R5cGUgPSBTdHJpbmcobWltZVR5cGVUZXh0UGxhaW4pOwpAQCAtNzgsNyArNzgsNyBA QCBXZWJWZWN0b3I8V2ViRHJhZ0RhdGE6Okl0ZW0+IFdlYkRyYWdEYXRhOjppdGVtcygpIGNvbnN0 CiAgICAgICAgIGl0ZW0uc3RyaW5nRGF0YSA9IG1fcHJpdmF0ZS0+Z2V0RGF0YShtaW1lVHlwZVRl eHRQbGFpbiwgaWdub3JlZCk7CiAgICAgICAgIGl0ZW1MaXN0LmFwcGVuZChpdGVtKTsKICAgICB9 Ci0gICAgaWYgKHR5cGVzLmNvbnRhaW5zKG1pbWVUeXBlVGV4dFVSSUxpc3QpKSB7CisgICAgaWYg KHR5cGVzLT5jb250YWlucyhtaW1lVHlwZVRleHRVUklMaXN0KSkgewogICAgICAgICBJdGVtIGl0 ZW07CiAgICAgICAgIGl0ZW0uc3RvcmFnZVR5cGUgPSBJdGVtOjpTdG9yYWdlVHlwZVN0cmluZzsK ICAgICAgICAgaXRlbS5zdHJpbmdUeXBlID0gU3RyaW5nKG1pbWVUeXBlVGV4dFVSSUxpc3QpOwpA QCAtODcsNyArODcsNyBAQCBXZWJWZWN0b3I8V2ViRHJhZ0RhdGE6Okl0ZW0+IFdlYkRyYWdEYXRh OjppdGVtcygpIGNvbnN0CiAgICAgICAgIGl0ZW0udGl0bGUgPSBtX3ByaXZhdGUtPnVybFRpdGxl KCk7CiAgICAgICAgIGl0ZW1MaXN0LmFwcGVuZChpdGVtKTsKICAgICB9Ci0gICAgaWYgKHR5cGVz LmNvbnRhaW5zKG1pbWVUeXBlVGV4dEhUTUwpKSB7CisgICAgaWYgKHR5cGVzLT5jb250YWlucyht aW1lVHlwZVRleHRIVE1MKSkgewogICAgICAgICBJdGVtIGl0ZW07CiAgICAgICAgIGl0ZW0uc3Rv cmFnZVR5cGUgPSBJdGVtOjpTdG9yYWdlVHlwZVN0cmluZzsKICAgICAgICAgaXRlbS5zdHJpbmdU eXBlID0gU3RyaW5nKG1pbWVUeXBlVGV4dEhUTUwpOwpAQCAtOTYsNyArOTYsNyBAQCBXZWJWZWN0 b3I8V2ViRHJhZ0RhdGE6Okl0ZW0+IFdlYkRyYWdEYXRhOjppdGVtcygpIGNvbnN0CiAgICAgICAg IGl0ZW0uYmFzZVVSTCA9IG1fcHJpdmF0ZS0+aHRtbEJhc2VVcmwoKTsKICAgICAgICAgaXRlbUxp c3QuYXBwZW5kKGl0ZW0pOwogICAgIH0KLSAgICBpZiAodHlwZXMuY29udGFpbnMobWltZVR5cGVE b3dubG9hZFVSTCkpIHsKKyAgICBpZiAodHlwZXMtPmNvbnRhaW5zKG1pbWVUeXBlRG93bmxvYWRV UkwpKSB7CiAgICAgICAgIEl0ZW0gaXRlbTsKICAgICAgICAgaXRlbS5zdG9yYWdlVHlwZSA9IEl0 ZW06OlN0b3JhZ2VUeXBlU3RyaW5nOwogICAgICAgICBpdGVtLnN0cmluZ1R5cGUgPSBTdHJpbmco bWltZVR5cGVEb3dubG9hZFVSTCk7Cg==