78767 2012-02-15 17:57:37 -0800 REGRESSION (r90471) - iAd Producer 2.0.1 produces blank pages 2013-03-16 22:50:29 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Mac All RESOLVED FIXED P2 Normal --- 1 beidson beidson oldest_to_newest 557783 0 beidson 2012-02-15 17:57:37 -0800 REGRESSION (r90471) - iAd Producer 2.0.1 produces blank pages The subtle change to "isLoadingInAPISense" did in fact break at least one real world app. An app-specific quirk patch is coming soon. 557784 1 127286 beidson 2012-02-15 18:00:10 -0800 Created attachment 127286 Patch v1 - New setting and app-specific quirk 557795 2 127286 sam 2012-02-15 18:16:58 -0800 Comment on attachment 127286 Patch v1 - New setting and app-specific quirk View in context: https://bugs.webkit.org/attachment.cgi?id=127286&action=review > Source/WebCore/ChangeLog:12 > + (WebCore::DocumentLoader::isLoadingInAPISense): Return true if the app needs the quirk > + and there are outstanding subresource loads. Odd spacing here. > Source/WebCore/loader/DocumentLoader.cpp:452 > + if (m_frame->settings()->needsIsLoadingInAPISenseQuirk() && !m_subresourceLoaders.isEmpty()) > + return true; Why is this not using a check from RuntimeApplicationChecks.h? > Source/WebCore/page/Settings.h:530 > + void setNeedsIsLoadingInAPISenseQuirk(bool enabled) { m_needsIsLoadingInAPISenseQuirk = enabled; } > + bool needsIsLoadingInAPISenseQuirk() const { return m_needsIsLoadingInAPISenseQuirk; } Please add a comment indicating what this quirk is. 557800 3 beidson 2012-02-15 18:22:11 -0800 (In reply to comment #2) > (From update of attachment 127286 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=127286&action=review > > > Source/WebCore/ChangeLog:12 > > + (WebCore::DocumentLoader::isLoadingInAPISense): Return true if the app needs the quirk > > + and there are outstanding subresource loads. > > Odd spacing here. > > > Source/WebCore/loader/DocumentLoader.cpp:452 > > + if (m_frame->settings()->needsIsLoadingInAPISenseQuirk() && !m_subresourceLoaders.isEmpty()) > > + return true; > > Why is this not using a check from RuntimeApplicationChecks.h? We've never done version checks from WebCore before. While it's technically possible, I opted to stick with the pattern we've historically used to do version checks in WebKit/Mac. > > > Source/WebCore/page/Settings.h:530 > > + void setNeedsIsLoadingInAPISenseQuirk(bool enabled) { m_needsIsLoadingInAPISenseQuirk = enabled; } > > + bool needsIsLoadingInAPISenseQuirk() const { return m_needsIsLoadingInAPISenseQuirk; } > > Please add a comment indicating what this quirk is. Gotcha. Thanks! 856676 4 ap 2013-03-16 22:50:29 -0700 Looks like this was committed in <http://trac.webkit.org/changeset/107995>. 127286 2012-02-15 18:00:10 -0800 2012-02-15 18:16:58 -0800 Patch v1 - New setting and app-specific quirk patch.txt text/plain 5139 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAwYmUxMzNlLi5mYjdmMTBiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMg QEAKKzIwMTItMDItMTUgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS8xMDYxNjI4MD4gYW5kIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD03ODc2NworICAgICAgICBSRUdSRVNTSU9OIChyOTA0NzEpIC0gaUFk IFByb2R1Y2VyIDIuMC4xIHByb2R1Y2VzIGJsYW5rIHBhZ2VzCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiAoU3VidGxlIEFQSSBj aGFuZ2UgYXR0YWNoZWQgdG8gYSBzcGVjaWZpYyBhcHBsaWNhdGlvbikKKworICAgICAgICAqIGxv YWRlci9Eb2N1bWVudExvYWRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudExvYWRl cjo6aXNMb2FkaW5nSW5BUElTZW5zZSk6IFJldHVybiB0cnVlIGlmIHRoZSBhcHAgbmVlZHMgdGhl IHF1aXJrCisgICAgICAgICAgYW5kIHRoZXJlIGFyZSBvdXRzdGFuZGluZyBzdWJyZXNvdXJjZSBs b2Fkcy4KKworICAgICAgICAqIHBhZ2UvU2V0dGluZ3MuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 U2V0dGluZ3M6OlNldHRpbmdzKToKKyAgICAgICAgKiBwYWdlL1NldHRpbmdzLmg6CisgICAgICAg IChXZWJDb3JlOjpTZXR0aW5nczo6c2V0TmVlZHNJc0xvYWRpbmdJbkFQSVNlbnNlUXVpcmspOgor ICAgICAgICAoV2ViQ29yZTo6U2V0dGluZ3M6Om5lZWRzSXNMb2FkaW5nSW5BUElTZW5zZVF1aXJr KToKKyAgICAgICAgKFNldHRpbmdzKToKKwogMjAxMi0wMi0xNSAgRW5yaWNhIENhc3VjY2kgIDxl bnJpY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT046ICJDb3B5IGltYWdlIiBmYWls cy4uLmNvcGllcyBpbWFnZSBVUkwgaW5zdGVhZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2xvYWRlci9Eb2N1bWVudExvYWRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRG9jdW1l bnRMb2FkZXIuY3BwCmluZGV4IDM5ZjczMTMuLjdiMGJmOGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2xvYWRlci9Eb2N1bWVudExvYWRlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbG9h ZGVyL0RvY3VtZW50TG9hZGVyLmNwcApAQCAtNDQ4LDYgKzQ0OCw5IEBAIGJvb2wgRG9jdW1lbnRM b2FkZXI6OmlzTG9hZGluZ0luQVBJU2Vuc2UoKSBjb25zdAogICAgIC8vIE9uY2UgYSBmcmFtZSBo YXMgbG9hZGVkLCB3ZSBubyBsb25nZXIgbmVlZCB0byBjb25zaWRlciBzdWJyZXNvdXJjZXMsCiAg ICAgLy8gYnV0IHdlIHN0aWxsIG5lZWQgdG8gY29uc2lkZXIgc3ViZnJhbWVzLgogICAgIGlmIChm cmFtZUxvYWRlcigpLT5zdGF0ZSgpICE9IEZyYW1lU3RhdGVDb21wbGV0ZSkgeworICAgICAgICBp ZiAobV9mcmFtZS0+c2V0dGluZ3MoKS0+bmVlZHNJc0xvYWRpbmdJbkFQSVNlbnNlUXVpcmsoKSAm JiAhbV9zdWJyZXNvdXJjZUxvYWRlcnMuaXNFbXB0eSgpKQorICAgICAgICAgICAgcmV0dXJuIHRy dWU7CisgICAgCiAgICAgICAgIERvY3VtZW50KiBkb2MgPSBtX2ZyYW1lLT5kb2N1bWVudCgpOwog ICAgICAgICBpZiAoKCFtX3ByaW1hcnlMb2FkQ29tcGxldGUgfHwgIW1fZnJhbWUtPmRvY3VtZW50 KCktPmxvYWRFdmVudEZpbmlzaGVkKCkpICYmIGlzTG9hZGluZygpKQogICAgICAgICAgICAgcmV0 dXJuIHRydWU7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1NldHRpbmdzLmNwcCBi L1NvdXJjZS9XZWJDb3JlL3BhZ2UvU2V0dGluZ3MuY3BwCmluZGV4IGI1Y2I5NjMuLmY4M2YyN2Eg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvU2V0dGluZ3MuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BhZ2UvU2V0dGluZ3MuY3BwCkBAIC0yNDEsNiArMjQxLDcgQEAgU2V0dGluZ3M6 OlNldHRpbmdzKFBhZ2UqIHBhZ2UpCiAgICAgLCBtX3Njcm9sbGluZ0Nvb3JkaW5hdG9yRW5hYmxl ZChmYWxzZSkKICNlbmRpZgogICAgICwgbV9ub3RpZmljYXRpb25zRW5hYmxlZCh0cnVlKQorICAg ICwgbV9uZWVkc0lzTG9hZGluZ0luQVBJU2Vuc2VRdWlyayhmYWxzZSkKICNpZiBFTkFCTEUoVE9V Q0hfRVZFTlRTKQogICAgICwgbV90b3VjaEV2ZW50RW11bGF0aW9uRW5hYmxlZChmYWxzZSkKICNl bmRpZgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9TZXR0aW5ncy5oIGIvU291cmNl L1dlYkNvcmUvcGFnZS9TZXR0aW5ncy5oCmluZGV4IDNhMTQwNjYuLjhiMzBlYWEgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvU2V0dGluZ3MuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w YWdlL1NldHRpbmdzLmgKQEAgLTUyNiw2ICs1MjYsOSBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAg ICAgICAgIHZvaWQgc2V0Tm90aWZpY2F0aW9uc0VuYWJsZWQoYm9vbCBlbmFibGVkKSB7IG1fbm90 aWZpY2F0aW9uc0VuYWJsZWQgPSBlbmFibGVkOyB9CiAgICAgICAgIGJvb2wgbm90aWZpY2F0aW9u c0VuYWJsZWQoKSBjb25zdCB7IHJldHVybiBtX25vdGlmaWNhdGlvbnNFbmFibGVkOyB9CiAKKyAg ICAgICAgdm9pZCBzZXROZWVkc0lzTG9hZGluZ0luQVBJU2Vuc2VRdWlyayhib29sIGVuYWJsZWQp IHsgbV9uZWVkc0lzTG9hZGluZ0luQVBJU2Vuc2VRdWlyayA9IGVuYWJsZWQ7IH0KKyAgICAgICAg Ym9vbCBuZWVkc0lzTG9hZGluZ0luQVBJU2Vuc2VRdWlyaygpIGNvbnN0IHsgcmV0dXJuIG1fbmVl ZHNJc0xvYWRpbmdJbkFQSVNlbnNlUXVpcms7IH0KKwogI2lmIEVOQUJMRShUT1VDSF9FVkVOVFMp CiAgICAgICAgIHZvaWQgc2V0VG91Y2hFdmVudEVtdWxhdGlvbkVuYWJsZWQoYm9vbCBlbmFibGVk KSB7IG1fdG91Y2hFdmVudEVtdWxhdGlvbkVuYWJsZWQgPSBlbmFibGVkOyB9CiAgICAgICAgIGJv b2wgaXNUb3VjaEV2ZW50RW11bGF0aW9uRW5hYmxlZCgpIGNvbnN0IHsgcmV0dXJuIG1fdG91Y2hF dmVudEVtdWxhdGlvbkVuYWJsZWQ7IH0KQEAgLTY3Nyw2ICs2ODAsNyBAQCBuYW1lc3BhY2UgV2Vi Q29yZSB7CiAjZW5kaWYKIAogICAgICAgICBib29sIG1fbm90aWZpY2F0aW9uc0VuYWJsZWQgOiAx OworICAgICAgICBib29sIG1fbmVlZHNJc0xvYWRpbmdJbkFQSVNlbnNlUXVpcmsgOiAxOwogCiAj aWYgRU5BQkxFKFRPVUNIX0VWRU5UUykKICAgICAgICAgYm9vbCBtX3RvdWNoRXZlbnRFbXVsYXRp b25FbmFibGVkIDogMTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZyBi L1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwppbmRleCA4ZjVkODI3Li45Y2U0NGNlIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9t YWMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMDItMTUgIEJyYWR5IEVpZHNvbiAg PGJlaWRzb25AYXBwbGUuY29tPgorCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xMDYxNjI4MD4g YW5kIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03ODc2NworICAgICAg ICBSRUdSRVNTSU9OIChyOTA0NzEpIC0gaUFkIFByb2R1Y2VyIDIuMC4xIHByb2R1Y2VzIGJsYW5r IHBhZ2VzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBXZWJWaWV3L1dlYlZpZXcubW06CisgICAgICAgICgtW1dlYlZpZXcgX25lZWRzSXNMb2FkaW5n SW5BUElTZW5zZVF1aXJrXSk6CisgICAgICAgICgtW1dlYlZpZXcgX3ByZWZlcmVuY2VzQ2hhbmdl ZDpdKToKKwogMjAxMi0wMi0xNSAgRW5yaWNhIENhc3VjY2kgIDxlbnJpY2FAYXBwbGUuY29tPgog CiAgICAgICAgIFJlZmFjdG9yIENsaXBib2FyZE1hYyBjbGFzcyB0byB1c2UgUGxhdGZvcm1TdHJh dGVnaWVzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJWaWV3Lm1t IGIvU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJWaWV3Lm1tCmluZGV4IDRkZjc3NTguLjEw NmFiZDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViVmlldy5tbQor KysgYi9Tb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlZpZXcubW0KQEAgLTEzMjIsNiArMTMy MiwxMyBAQCAtIChCT09MKV9uZWVkc0xpbmtFbGVtZW50VGV4dENTU1F1aXJrCiAgICAgcmV0dXJu IG5lZWRzUXVpcms7CiB9CiAKKy0gKEJPT0wpX25lZWRzSXNMb2FkaW5nSW5BUElTZW5zZVF1aXJr Cit7CisgICAgc3RhdGljIEJPT0wgbmVlZHNRdWlyayA9IFdLQXBwVmVyc2lvbkNoZWNrTGVzc1Ro YW4oQCJjb20uYXBwbGUuaUFkUHJvZHVjZXIiLCAtMSwgMi4xKTsKKyAgICAKKyAgICByZXR1cm4g bmVlZHNRdWlyazsKK30KKwogLSAoQk9PTClfbmVlZHNLZXlib2FyZEV2ZW50RGlzYW1iaWd1YXRp b25RdWlya3MKIHsKICAgICBzdGF0aWMgQk9PTCBuZWVkc1F1aXJrcyA9ICFXZWJLaXRMaW5rZWRP bk9yQWZ0ZXIoV0VCS0lUX0ZJUlNUX1ZFUlNJT05fV0lUSF9JRV9DT01QQVRJQkxFX0tFWUJPQVJE X0VWRU5UX0RJU1BBVENIKSAmJiAhYXBwbGljYXRpb25Jc1NhZmFyaSgpOwpAQCAtMTUwOSw2ICsx NTE2LDggQEAgLSAodm9pZClfcHJlZmVyZW5jZXNDaGFuZ2VkOihXZWJQcmVmZXJlbmNlcyAqKXBy ZWZlcmVuY2VzCiAgICAgc2V0dGluZ3MtPnNldFNob3VsZERpc3BsYXlUZXh0RGVzY3JpcHRpb25z KFtwcmVmZXJlbmNlcyBzaG91bGREaXNwbGF5VGV4dERlc2NyaXB0aW9uc10pOwogI2VuZGlmCiAK KyAgICBzZXR0aW5ncy0+c2V0TmVlZHNJc0xvYWRpbmdJbkFQSVNlbnNlUXVpcmsoW3NlbGYgX25l ZWRzSXNMb2FkaW5nSW5BUElTZW5zZVF1aXJrXSk7CisKICAgICAvLyBBcHBsaWNhdGlvbiBDYWNo ZSBQcmVmZXJlbmNlcyBhcmUgc3RvcmVkIG9uIHRoZSBnbG9iYWwgY2FjaGUgc3RvcmFnZSBtYW5h Z2VyLCBub3QgaW4gU2V0dGluZ3MuCiAgICAgW1dlYkFwcGxpY2F0aW9uQ2FjaGUgc2V0RGVmYXVs dE9yaWdpblF1b3RhOltwcmVmZXJlbmNlcyBhcHBsaWNhdGlvbkNhY2hlRGVmYXVsdE9yaWdpblF1 b3RhXV07CiAK