78748 2012-02-15 14:51:39 -0800 Add style check for ctype functions that are generally frowned upon in WebKit 2012-02-15 19:18:45 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sam sam abarth webkit.review.bot oldest_to_newest 557586 0 sam 2012-02-15 14:51:39 -0800 Add style check for ctype functions that are generally frowned upon in WebKit 557591 1 127242 sam 2012-02-15 14:53:52 -0800 Created attachment 127242 Patch 557834 2 127242 webkit.review.bot 2012-02-15 19:18:41 -0800 Comment on attachment 127242 Patch Clearing flags on attachment: 127242 Committed r107872: <http://trac.webkit.org/changeset/107872> 557835 3 webkit.review.bot 2012-02-15 19:18:45 -0800 All reviewed patches have been landed. Closing bug. 127242 2012-02-15 14:53:52 -0800 2012-02-15 19:18:41 -0800 Patch bug-78748-20120215145401.patch text/plain 4644 sam U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3ODMxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZGViZjU2ZDllYzQwMzZjMWEyYjg1NThlY2U1NDA4ZDU5 ZjhjZTJjZi4uOTU3ZDFjMTk4YzE3OGI3ZWY4NDkzNGJhMTQ4NmI2M2Q5NzAxZjlmZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIz IEBACisyMDEyLTAyLTE1ICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CisKKyAgICAgICAg QWRkIHN0eWxlIGNoZWNrIGZvciBjdHlwZSBmdW5jdGlvbnMgdGhhdCBhcmUgZ2VuZXJhbGx5IGZy b3duZWQgdXBvbiBpbiBXZWJLaXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTc4NzQ4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgTm90IGV2ZXJ5IHBsYXRmb3JtIGhhcyBEaXNhbGxvd0NUeXBlLmggdG8gY2hl Y2sgZm9yIHVzZXMgb2YgdGhlIGN0eXBlLmgKKyAgICAgICAgZnVuY3Rpb25zLCBzbyBhZGQgYSBz dHlsZSBjaGVjayBmb3IgdGhlbSBhcyB3ZWxsLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRw eS9zdHlsZS9jaGVja2Vycy9jcHAucHk6CisgICAgICAgIChjaGVja19jdHlwZV9mdW5jdGlvbnMp OgorICAgICAgICAoY2hlY2tfc3R5bGUpOgorICAgICAgICAoQ3BwQ2hlY2tlcik6CisgICAgICAg IEFkZCBjaGVjay4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMv Y3BwX3VuaXR0ZXN0LnB5OgorICAgICAgICAoV2ViS2l0U3R5bGVUZXN0LnRlc3RfY3R5cGVfZnVj bnRpb24pOgorICAgICAgICBBZGQgY2hlY2tlci4KKwogMjAxMi0wMi0xNSAgTWljaGFlbCBCcsO8 bmluZyAgPG1pY2hhZWwuYnJ1bmluZ0Bub2tpYS5jb20+CiAKICAgICAgICAgW1F0XSBBZGQgVUkg Zm9yIEhUVFAgYXV0aGVudGljYXRpb24gaW4gdGhlIFF0IE1pbmlCcm93c2VyCmRpZmYgLS1naXQg YS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weSBiL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CmluZGV4IDAyNzg0ZTU5ZTRlNjVl NzYyNjM5ZGViZmQxNTVkYWRkODJlM2UyYmIuLmYyOTM2MTc2NjAzY2Y4OWY2YTUyNmZkZThkZWVi YTViM2RlM2VmYTkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hl Y2tlcnMvY3BwLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMv Y3BwLnB5CkBAIC0yMDc3LDYgKzIwNzcsMjkgQEAgZGVmIGNoZWNrX21heF9taW5fbWFjcm9zKGNs ZWFuX2xpbmVzLCBsaW5lX251bWJlciwgZmlsZV9zdGF0ZSwgZXJyb3IpOgogICAgICAgICAgICUg KG1heF9taW5fbWFjcm9fbG93ZXIsIG1heF9taW5fbWFjcm9fbG93ZXIsIG1heF9taW5fbWFjcm8p KQogCiAKK2RlZiBjaGVja19jdHlwZV9mdW5jdGlvbnMoY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVy LCBmaWxlX3N0YXRlLCBlcnJvcik6CisgICAgIiIiTG9va3MgZm9yIHVzZSBvZiB0aGUgc3RhbmRh cmQgZnVuY3Rpb25zIGluIGN0eXBlLmggYW5kIHN1Z2dlc3QgdGhleSBiZSByZXBsYWNlZAorICAg ICAgIGJ5IHVzZSBvZiBlcXVpdmlsZW50IG9uZXMgaW4gPHd0Zi9BU0NJSUNUeXBlLmg+Py4KKwor ICAgIEFyZ3M6CisgICAgICBjbGVhbl9saW5lczogQSBDbGVhbnNlZExpbmVzIGluc3RhbmNlIGNv bnRhaW5pbmcgdGhlIGZpbGUuCisgICAgICBsaW5lX251bWJlcjogVGhlIG51bWJlciBvZiB0aGUg bGluZSB0byBjaGVjay4KKyAgICAgIGZpbGVfc3RhdGU6IEEgX0ZpbGVTdGF0ZSBpbnN0YW5jZSB3 aGljaCBtYWludGFpbnMgaW5mb3JtYXRpb24gYWJvdXQKKyAgICAgICAgICAgICAgICAgIHRoZSBz dGF0ZSBvZiB0aGluZ3MgaW4gdGhlIGZpbGUuCisgICAgICBlcnJvcjogVGhlIGZ1bmN0aW9uIHRv IGNhbGwgd2l0aCBhbnkgZXJyb3JzIGZvdW5kLgorICAgICIiIgorCisgICAgbGluZSA9IGNsZWFu X2xpbmVzLmVsaWRlZFtsaW5lX251bWJlcl0gICMgR2V0IHJpZCBvZiBjb21tZW50cyBhbmQgc3Ry aW5ncy4KKworICAgIGN0eXBlX2Z1bmN0aW9uX3NlYXJjaCA9IHNlYXJjaChyJ1xiKD9QPGN0eXBl X2Z1bmN0aW9uPihpc2FsbnVtfGlzYWxwaGF8aXNhc2NpaXxpc2JsYW5rfGlzY250cmx8aXNkaWdp dHxpc2dyYXBofGlzbG93ZXJ8aXNwcmludHxpc3B1bmN0fGlzc3BhY2V8aXN1cHBlcnxpc3hkaWdp dHx0b2FzY2lpfHRvbG93ZXJ8dG91cHBlcikpXHMqXCgnLCBsaW5lKQorICAgIGlmIG5vdCBjdHlw ZV9mdW5jdGlvbl9zZWFyY2g6CisgICAgICAgIHJldHVybgorCisgICAgY3R5cGVfZnVuY3Rpb24g PSBjdHlwZV9mdW5jdGlvbl9zZWFyY2guZ3JvdXAoJ2N0eXBlX2Z1bmN0aW9uJykKKyAgICBlcnJv cihsaW5lX251bWJlciwgJ3J1bnRpbWUvY3R5cGVfZnVuY3Rpb24nLCA0LAorICAgICAgICAgICdV c2UgZXF1aXZlbGVudCBmdW5jdGlvbiBpbiA8d3RmL0FTQ0lJQ1R5cGUuaD4gaW5zdGVhZCBvZiB0 aGUgJXMoKSBmdW5jdGlvbi4nCisgICAgICAgICAgJSAoY3R5cGVfZnVuY3Rpb24pKQorCiBkZWYg Y2hlY2tfc3dpdGNoX2luZGVudGF0aW9uKGNsZWFuX2xpbmVzLCBsaW5lX251bWJlciwgZXJyb3Ip OgogICAgICIiIkxvb2tzIGZvciBpbmRlbnRhdGlvbiBlcnJvcnMgaW5zaWRlIG9mIHN3aXRjaCBz dGF0ZW1lbnRzLgogCkBAIC0yNTQwLDYgKzI1NjMsNyBAQCBkZWYgY2hlY2tfc3R5bGUoY2xlYW5f bGluZXMsIGxpbmVfbnVtYmVyLCBmaWxlX2V4dGVuc2lvbiwgY2xhc3Nfc3RhdGUsIGZpbGVfc3Rh dAogICAgIGNoZWNrX25hbWVzcGFjZV9pbmRlbnRhdGlvbihjbGVhbl9saW5lcywgbGluZV9udW1i ZXIsIGZpbGVfZXh0ZW5zaW9uLCBmaWxlX3N0YXRlLCBlcnJvcikKICAgICBjaGVja191c2luZ19z dGQoY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyLCBmaWxlX3N0YXRlLCBlcnJvcikKICAgICBjaGVj a19tYXhfbWluX21hY3JvcyhjbGVhbl9saW5lcywgbGluZV9udW1iZXIsIGZpbGVfc3RhdGUsIGVy cm9yKQorICAgIGNoZWNrX2N0eXBlX2Z1bmN0aW9ucyhjbGVhbl9saW5lcywgbGluZV9udW1iZXIs IGZpbGVfc3RhdGUsIGVycm9yKQogICAgIGNoZWNrX3N3aXRjaF9pbmRlbnRhdGlvbihjbGVhbl9s aW5lcywgbGluZV9udW1iZXIsIGVycm9yKQogICAgIGNoZWNrX2JyYWNlcyhjbGVhbl9saW5lcywg bGluZV9udW1iZXIsIGVycm9yKQogICAgIGNoZWNrX2V4aXRfc3RhdGVtZW50X3NpbXBsaWZpY2F0 aW9ucyhjbGVhbl9saW5lcywgbGluZV9udW1iZXIsIGVycm9yKQpAQCAtMzUyOCw2ICszNTUyLDcg QEAgY2xhc3MgQ3BwQ2hlY2tlcihvYmplY3QpOgogICAgICAgICAncnVudGltZS9hcnJheXMnLAog ICAgICAgICAncnVudGltZS9iaXRmaWVsZHMnLAogICAgICAgICAncnVudGltZS9jYXN0aW5nJywK KyAgICAgICAgJ3J1bnRpbWUvY3R5cGVfZnVuY3Rpb24nLAogICAgICAgICAncnVudGltZS9leHBs aWNpdCcsCiAgICAgICAgICdydW50aW1lL2luaXQnLAogICAgICAgICAncnVudGltZS9pbnQnLApk aWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5p dHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0 dGVzdC5weQppbmRleCAxN2IxNTkwOWMzMmY4NGM2YWQ4ZjVmZjM0Y2RiNjRlMGZjNjVmZjc1Li41 NDRlODMwYTI2YjIxMmQ1NzlhYWJmZmZiMTRkMTg0ZjI4YjAzZGMyIDEwMDY0NAotLS0gYS9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weQorKysgYi9U b29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weQpAQCAt NDM0Nyw2ICs0MzQ3LDEzIEBAIGNsYXNzIFdlYktpdFN0eWxlVGVzdChDcHBTdHlsZVRlc3RCYXNl KToKICAgICAgICAgICAgICcgIFtydW50aW1lL21heF9taW5fbWFjcm9zXSBbNF0nLAogICAgICAg ICAgICAgJ2Zvby5oJykKIAorICAgIGRlZiB0ZXN0X2N0eXBlX2Z1Y250aW9uKHNlbGYpOgorICAg ICAgICBzZWxmLmFzc2VydF9saW50KAorICAgICAgICAgICAgJ2ludCBpID0gaXNhc2NpaSg4KTsn LAorICAgICAgICAgICAgJ1VzZSBlcXVpdmVsZW50IGZ1bmN0aW9uIGluIDx3dGYvQVNDSUlDVHlw ZS5oPiBpbnN0ZWFkIG9mIHRoZSAnCisgICAgICAgICAgICAnaXNhc2NpaSgpIGZ1bmN0aW9uLiAg W3J1bnRpbWUvY3R5cGVfZnVuY3Rpb25dIFs0XScsCisgICAgICAgICAgICAnZm9vLmNwcCcpCisK ICAgICBkZWYgdGVzdF9uYW1lcyhzZWxmKToKICAgICAgICAgbmFtZV91bmRlcnNjb3JlX2Vycm9y X21lc3NhZ2UgPSAiIGlzIGluY29ycmVjdGx5IG5hbWVkLiBEb24ndCB1c2UgdW5kZXJzY29yZXMg aW4geW91ciBpZGVudGlmaWVyIG5hbWVzLiAgW3JlYWRhYmlsaXR5L25hbWluZ10gWzRdIgogICAg ICAgICBuYW1lX3Rvb3Nob3J0X2Vycm9yX21lc3NhZ2UgPSAiIGlzIGluY29ycmVjdGx5IG5hbWVk LiBEb24ndCB1c2UgdGhlIHNpbmdsZSBsZXR0ZXIgJ2wnIGFzIGFuIGlkZW50aWZpZXIgbmFtZS4g IFtyZWFkYWJpbGl0eS9uYW1pbmddIFs0XSIK