78722 2012-02-15 10:18:15 -0800 Expose Window constructor 2022-07-26 10:04:39 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED CONFIGURATION CHANGED http://www.whatwg.org/specs/web-apps/current-work/multipage/browsers.html#the-window-objecthttp://www.whatwg.org/specs/web-apps/current-work/multipage/browsers.html#the-window-object InRadar P2 Normal --- 1 arv arv abarth ahmad.saleem792 ap bfulgham ian ossy rniwa sam webkit-bug-importer webkit.review.bot oldest_to_newest 557351 0 arv 2012-02-15 10:18:15 -0800 We currently do not expose the Window constructor. Other browsers do. assertTrue(window.Window !== undefined) This is related to bug 78721 which is about renaming the constructor. 557422 1 ian 2012-02-15 11:32:06 -0800 Constructor? You mean prototype object, right? Window shouldn't be a constructor. 557430 2 arv 2012-02-15 11:49:29 -0800 (In reply to comment #1) > Constructor? You mean prototype object, right? Window shouldn't be a constructor. No. I mean constructor. It is not constructable but it is still a constructor. Just like Document and HTMLDocument are exposed. IE and Mozilla pass the following assertTrue(typeof Window !== 'undefined'); 557447 3 127211 arv 2012-02-15 12:10:19 -0800 Created attachment 127211 Patch 557813 4 127211 webkit.review.bot 2012-02-15 18:47:27 -0800 Comment on attachment 127211 Patch Clearing flags on attachment: 127211 Committed r107869: <http://trac.webkit.org/changeset/107869> 557814 5 webkit.review.bot 2012-02-15 18:47:32 -0800 All reviewed patches have been landed. Closing bug. 557988 6 ossy 2012-02-16 01:39:20 -0800 Reopen, because it broke 3 tests on Qt. I assume that on other platforms too, but unfortunately I can't check it, because build.webkit.org is unavailable. - fast/dom/Window/window-properties.html - http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r107900%20%2833816%29/fast/dom/Window/window-properties-pretty-diff.html - fast/dom/Window/window-property-descriptors.html - http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r107900%20(33816)/fast/dom/Window/window-property-descriptors-pretty-diff.html - fast/js/global-constructors.html - http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r107900%20%2833816%29/fast/js/global-constructors-pretty-diff.html I think the first two tests only needs to be rebaselined. But the third one seems an error: +FAIL Window.toString() should be [object WindowConstructor]. Was [object DOMWindowConstructor]. 558021 7 ossy 2012-02-16 02:40:09 -0800 I updated the 3 tests on Qt - http://trac.webkit.org/changeset/107916 Please check what should we do with the 3rd failing test. 558223 8 arv 2012-02-16 08:36:01 -0800 Sorry about that. These tests where in the test_expectation.txt for chromium. I should have realized it would change the expectations for JSC based platforms. (In reply to comment #7) > I updated the 3 tests on Qt - http://trac.webkit.org/changeset/107916 > Please check what should we do with the 3rd failing test. The FAIL in global-constructors-expected.txt is bug 78721 The changes to the Skipped file seems unrelated though. 1886797 9 ahmad.saleem792 2022-07-26 09:48:47 -0700 From WPT - Safari passes all "window constructor" events, do we need anything further? https://wpt.fyi/results/dom/events?label=master&label=experimental&aligned&q=constructor Please ignore my comment, if I incorrect or wrong and update latest status accordingly. Thanks! 1886802 10 rniwa 2022-07-26 10:03:51 -0700 We have window.Window now. 1886804 11 webkit-bug-importer 2022-07-26 10:04:39 -0700 <rdar://problem/97612310> 127211 2012-02-15 12:10:19 -0800 2012-02-15 18:47:27 -0800 Patch bug-78722-20120215121017.patch text/plain 3381 arv U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3NzQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzE3NjFlOTc5NjliMWEz YWVhZTEwNzJiNTdhNzc4M2NmZjQzYTYxOC4uZjAwODNmY2E5NTViNTA4NDM0YTU5NmMwMzkxMDEw ZDAwODYyNmRkZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTAyLTE1ICBFcmlr IEFydmlkc3NvbiAgPGFydkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgRXhwb3NlIFdpbmRvdyBj b25zdHJ1Y3RvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9Nzg3MjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUZXN0OiBmYXN0L2RvbS9XaW5kb3cvd2luZG93LWNvbnN0cnVjdG9yLXByZXNlbmNlLmh0bWwK KworICAgICAgICAqIHBhZ2UvRE9NV2luZG93LmlkbDoKKwogMjAxMi0wMi0xNCAgUmFteWEgQ2hh bmRyYXNla2FyYW4gIDxjcmFteWFAZ29vZ2xlLmNvbT4KIAogICAgICAgICBMYXN0IGNoYXJhY3Rl ciBkaXNwbGF5IGZvciBwYXNzd29yZHMgaW4gQW5kcm9pZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BhZ2UvRE9NV2luZG93LmlkbCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93 LmlkbAppbmRleCAzMzFlNjJjODFkNDY5NWRhZGMyNjc0MTQ5MjIwOGMwYTZjMDE3Y2Y1Li42NjZk N2QwMTJjYWNiNmY1YzU0MzBiZGJmN2I4NmM5ZTFjNmUxMTM2IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9ET01X aW5kb3cuaWRsCkBAIC00MDEsNiArNDAxLDcgQEAgbW9kdWxlIHdpbmRvdyB7CiAgICAgICAgIGF0 dHJpYnV0ZSBbQ29uZGl0aW9uYWw9U0hBRE9XX0RPTSwgVjhFbmFibGVkQXRSdW50aW1lPXNoYWRv d0RPTV0gU2hhZG93Um9vdENvbnN0cnVjdG9yIFdlYktpdFNoYWRvd1Jvb3Q7CiAKICAgICAgICAg YXR0cmlidXRlIEhUTUxEb2N1bWVudENvbnN0cnVjdG9yIEhUTUxEb2N1bWVudDsKKyAgICAgICAg YXR0cmlidXRlIERPTVdpbmRvd0NvbnN0cnVjdG9yIFdpbmRvdzsKIAogICAgICAgICBhdHRyaWJ1 dGUgSFRNTEVsZW1lbnRDb25zdHJ1Y3RvciBIVE1MRWxlbWVudDsKICAgICAgICAgYXR0cmlidXRl IEhUTUxBbmNob3JFbGVtZW50Q29uc3RydWN0b3IgSFRNTEFuY2hvckVsZW1lbnQ7CmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXgg YWEyMDMzODQ1YzZjYjk3ODZkNDg3NWUxNGEwNTBmNmRiNGFkMmUzOS4uYjU4ZDhlNDZhMzBhZmQ0 MGI4ODA1MTUyMmQ0ODI3M2U3NmEwMWYzOCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAy LTE1ICBFcmlrIEFydmlkc3NvbiAgPGFydkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgRXhwb3Nl IFdpbmRvdyBjb25zdHJ1Y3RvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9Nzg3MjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIGZhc3QvZG9tL1dpbmRvdy93aW5kb3ctY29uc3RydWN0b3ItcHJlc2VuY2Ut ZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2RvbS9XaW5kb3cvd2luZG93LWNv bnN0cnVjdG9yLXByZXNlbmNlLmh0bWw6IEFkZGVkLgorCiAyMDEyLTAyLTE0ICBBbWkgRmlzY2ht YW4gIDxmaXNjaG1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQ29udmVydCBhIGNvdXBsZSBv ZiBtZWRpYSBsYXlvdXR0ZXN0cyB0byBtb2NrIHNjcm9sbGJhcnMgJiByZWJhc2VsaW5lCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9XaW5kb3cvd2luZG93LWNvbnN0cnVjdG9yLXBy ZXNlbmNlLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL1dpbmRvdy93aW5kb3ct Y29uc3RydWN0b3ItcHJlc2VuY2UtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjFkNThlMWIyNjY0 Yjg0MTQ2MzVkNjdmNmVmM2FiMjYyOTMzNDY0MzgKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRU ZXN0cy9mYXN0L2RvbS9XaW5kb3cvd2luZG93LWNvbnN0cnVjdG9yLXByZXNlbmNlLWV4cGVjdGVk LnR4dApAQCAtMCwwICsxLDExIEBACitUZXN0cyB0aGF0IHRoZSBXaW5kb3cgY29uc3RydWN0b3Ig aXMgcHJlc2VudCBhbmQgdGhhdCB3aW5kb3cgaXMgYW4gaW5zdGFuY2VvZiBvZiBpdC4KKworT24g c3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93 ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK1BBU1MgdHlwZW9mIFdpbmRvdyBpcyBub3QgInVu ZGVmaW5lZCIKK1BBU1Mgd2luZG93IGluc3RhbmNlb2YgV2luZG93IGlzIHRydWUKK1BBU1Mgc3Vj Y2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9mYXN0L2RvbS9XaW5kb3cvd2luZG93LWNvbnN0cnVjdG9yLXByZXNlbmNlLmh0 bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9XaW5kb3cvd2luZG93LWNvbnN0cnVjdG9yLXByZXNl bmNlLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMC4uOGYxOGY0MDhkZDg4Nzc0OTFhYjAyNGE0Mzc2NTA1ZTlhNTY5 NzQwYwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL1dpbmRvdy93aW5k b3ctY29uc3RydWN0b3ItcHJlc2VuY2UuaHRtbApAQCAtMCwwICsxLDEzIEBACis8IURPQ1RZUEUg aHRtbD4KKzxib2R5PgorPHNjcmlwdCBzcmM9Ii4uLy4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXBy ZS5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0PgorCitkZXNjcmlwdGlvbignVGVzdHMgdGhhdCB0aGUg V2luZG93IGNvbnN0cnVjdG9yIGlzIHByZXNlbnQgYW5kIHRoYXQgd2luZG93IGlzIGFuIGluc3Rh bmNlb2Ygb2YgaXQuJyk7CisKK3Nob3VsZE5vdEJlKCd0eXBlb2YgV2luZG93JywgJyJ1bmRlZmlu ZWQiJyk7CitzaG91bGRCZVRydWUoJ3dpbmRvdyBpbnN0YW5jZW9mIFdpbmRvdycpOworCis8L3Nj cmlwdD4KKzxzY3JpcHQgc3JjPSIuLi8uLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48 L3NjcmlwdD4KKzwvYm9keT4K