78719 2012-02-15 08:31:11 -0800 [GTK] Document that local paths in html loaded with loadHTML might cause the web process to terminate 2012-02-16 00:26:44 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned gustavo pnormand webkit.review.bot oldest_to_newest 557296 0 cgarcia 2012-02-15 08:31:11 -0800 This happens when baseURL is provided and local paths point to a different directory than base URL. See bug #78227 for more details 557298 1 127188 cgarcia 2012-02-15 08:34:24 -0800 Created attachment 127188 Patch I hope it's clear enough 557300 2 webkit.review.bot 2012-02-15 08:35:28 -0800 Attachment 127188 did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9 Updating OpenSource First, rewinding head to replay your work on top of it... Applying: [Qt] Move Qt platform specific GL Context/Surface creation out of WebCore into WebKit Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging Source/WebCore/ChangeLog Auto-merging Source/WebCore/platform/graphics/GraphicsContext3D.h CONFLICT (content): Merge conflict in Source/WebCore/platform/graphics/GraphicsContext3D.h Auto-merging Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp CONFLICT (content): Merge conflict in Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp Auto-merging Source/WebKit/qt/ChangeLog CONFLICT (content): Merge conflict in Source/WebKit/qt/ChangeLog Auto-merging Source/WebKit/qt/WebCoreSupport/PageClientQt.cpp CONFLICT (content): Merge conflict in Source/WebKit/qt/WebCoreSupport/PageClientQt.cpp Failed to merge in the changes. Patch failed at 0001 [Qt] Move Qt platform specific GL Context/Surface creation out of WebCore into WebKit When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. If any of these errors are false positives, please file a bug against check-webkit-style. 557331 3 127188 mrobinson 2012-02-15 09:49:05 -0800 Comment on attachment 127188 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127188&action=review > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:890 > + * must be in the same directory than @base_uri. Asbolute local paths pointing to a > + * different directory than @base_uri will cause the web process to terminate. > + * If you need to include URLs in @content that are local paths in a different > + * directory than @base_uri you can build a data uri for them. When @base_uri is %NULL, Would a phrase like "Absolute local paths must be children of the @base_uri" be clearer? You might mention that this is for security reasons specifically. Asbolute -> Absolute :) 557965 4 cgarcia 2012-02-16 00:26:44 -0800 Committed r107904: <http://trac.webkit.org/changeset/107904> 127188 2012-02-15 08:34:24 -0800 2012-02-15 09:49:05 -0800 Patch wk2-doc-load-html-web-crash.diff text/plain 2145 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA1OGYyODZlLi40MGZkMWMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTItMDItMTUgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIERvY3VtZW50IHRoYXQgbG9jYWwgcGF0aHMgaW4gaHRtbCBsb2Fk ZWQgd2l0aCBsb2FkSFRNTCBtaWdodCBjYXVzZSB0aGUgd2ViIHByb2Nlc3MgdG8gdGVybWluYXRl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03ODcxOQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9j ZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlldy5jcHA6CisKIDIwMTItMDItMTMgIFcuIEphbWVzIE1h Y0xlYW4gIDx3am1hY2xlYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gUmVt b3ZlIG9ic29sZXRlIHpvb20gYW5pbWF0aW9uIHBhdGh3YXkuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3LmNwcCBiL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXcuY3BwCmluZGV4IDg4NjQ5OWEuLjQw NDQwNzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktp dFdlYlZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktp dFdlYlZpZXcuY3BwCkBAIC04ODIsMTAgKzg4MiwxNCBAQCB2b2lkIHdlYmtpdF93ZWJfdmlld19s b2FkX3VyaShXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3LCBjb25zdCBnY2hhciogdXJpKQogICogQGJh c2VfdXJpOiAoYWxsb3ctbm9uZSk6IFRoZSBiYXNlIFVSSSBmb3IgcmVsYXRpdmUgbG9jYXRpb25z IG9yICVOVUxMCiAgKgogICogTG9hZCB0aGUgZ2l2ZW4gQGNvbnRlbnQgc3RyaW5nIHdpdGggdGhl IHNwZWNpZmllZCBAYmFzZV91cmkuCi0gKiBSZWxhdGl2ZSBVUkxzIGluIHRoZSBAY29udGVudCB3 aWxsIGJlIHJlc29sdmVkIGFnYWluc3QgQGJhc2VfdXJpLgotICogV2hlbiBAYmFzZV91cmkgaXMg JU5VTEwsIGl0IGRlZmF1bHRzIHRvICJhYm91dDpibGFuayIuIFRoZSBtaW1lIHR5cGUKLSAqIG9m IHRoZSBkb2N1bWVudCB3aWxsIGJlICJ0ZXh0L2h0bWwiLiBZb3UgY2FuIG1vbml0b3IgdGhlIGxv YWQgb3BlcmF0aW9uCi0gKiBieSBjb25uZWN0aW5nIHRvICNXZWJLaXRXZWJWaWV3Ojpsb2FkLWNo YW5nZWQgc2lnbmFsLgorICogSWYgQGJhc2VfdXJpIGlzIG5vdCAlTlVMTCwgcmVsYXRpdmUgVVJM cyBpbiB0aGUgQGNvbnRlbnQgd2lsbCBiZQorICogcmVzb2x2ZWQgYWdhaW5zdCBAYmFzZV91cmkg YW5kIGFic29sdXRlIFVSTHMgcG9pbnRpbmcgdG8gYSBsb2NhbCBwYXRoCisgKiBtdXN0IGJlIGlu IHRoZSBzYW1lIGRpcmVjdG9yeSB0aGFuIEBiYXNlX3VyaS4gQXNib2x1dGUgbG9jYWwgcGF0aHMg cG9pbnRpbmcgdG8gYQorICogZGlmZmVyZW50IGRpcmVjdG9yeSB0aGFuIEBiYXNlX3VyaSB3aWxs IGNhdXNlIHRoZSB3ZWIgcHJvY2VzcyB0byB0ZXJtaW5hdGUuCisgKiBJZiB5b3UgbmVlZCB0byBp bmNsdWRlIFVSTHMgaW4gQGNvbnRlbnQgdGhhdCBhcmUgbG9jYWwgcGF0aHMgaW4gYSBkaWZmZXJl bnQKKyAqIGRpcmVjdG9yeSB0aGFuIEBiYXNlX3VyaSB5b3UgY2FuIGJ1aWxkIGEgZGF0YSB1cmkg Zm9yIHRoZW0uIFdoZW4gQGJhc2VfdXJpIGlzICVOVUxMLAorICogaXQgZGVmYXVsdHMgdG8gImFi b3V0OmJsYW5rIi4gVGhlIG1pbWUgdHlwZSBvZiB0aGUgZG9jdW1lbnQgd2lsbCBiZSAidGV4dC9o dG1sIi4KKyAqIFlvdSBjYW4gbW9uaXRvciB0aGUgbG9hZCBvcGVyYXRpb24gYnkgY29ubmVjdGlu ZyB0byAjV2ViS2l0V2ViVmlldzo6bG9hZC1jaGFuZ2VkIHNpZ25hbC4KICAqLwogdm9pZCB3ZWJr aXRfd2ViX3ZpZXdfbG9hZF9odG1sKFdlYktpdFdlYlZpZXcqIHdlYlZpZXcsIGNvbnN0IGdjaGFy KiBjb250ZW50LCBjb25zdCBnY2hhciogYmFzZVVSSSkKIHsK