78712 2012-02-15 06:55:47 -0800 [GTK] Page content is incorrectly translated whenh rendering pages for printing in WebKit2 2012-02-16 09:16:33 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned gustavo oldest_to_newest 557235 0 cgarcia 2012-02-15 06:55:47 -0800 I forgot to add cairo_save/restore when rendering every page. 557240 1 127178 cgarcia 2012-02-15 06:59:49 -0800 Created attachment 127178 Patch I've also simplified the code to select the printer as suggested by Martin and Gustavo in bug #76172 558260 2 cgarcia 2012-02-16 09:16:33 -0800 Committed r107948: <http://trac.webkit.org/changeset/107948> 127178 2012-02-15 06:59:49 -0800 2012-02-16 07:11:20 -0800 Patch wk2-save-restore-printing.diff text/plain 3103 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA1OGYyODZlLi42MDNkYzJhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTItMDItMTUgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIFBhZ2UgY29udGVudCBpcyBpbmNvcnJlY3RseSB0cmFuc2xhdGVk IHdoZW5oIHJlbmRlcmluZyBwYWdlcyBmb3IgcHJpbnRpbmcgaW4gV2ViS2l0MgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzg3MTIKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFn ZS9ndGsvV2ViUHJpbnRPcGVyYXRpb25HdGsuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQcmlu dE9wZXJhdGlvbkd0azo6ZW51bWVyYXRlUHJpbnRlcnNGdW5jdGlvbik6CisgICAgICAgIFNpbXBs aWZ5IHRoZSBjb2RlIHRvIHNlbGVjdCB0aGUgcHJpbnRlci4KKyAgICAgICAgKFdlYktpdDo6V2Vi UHJpbnRPcGVyYXRpb25HdGs6OnJlbmRlclBhZ2UpOiBDYWxsIGNhaXJvX3NhdmUoKQorICAgICAg ICBiZWZvcmUgcmVuZGVyaW5nIHRoZSBwYWdlIGFuZCBjYWlyb19yZXN0b3JlKCkgd2hlbiBwYWdl IGhhcyBiZWVuCisgICAgICAgIHJlbmRlcmVkLgorCiAyMDEyLTAyLTEzICBXLiBKYW1lcyBNYWNM ZWFuICA8d2ptYWNsZWFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIFJlbW92 ZSBvYnNvbGV0ZSB6b29tIGFuaW1hdGlvbiBwYXRod2F5LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL2d0ay9XZWJQcmludE9wZXJhdGlvbkd0ay5jcHAgYi9T b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvZ3RrL1dlYlByaW50T3BlcmF0aW9uR3Rr LmNwcAppbmRleCA3MDRhZGYzLi5hYzJlNzM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL1dlYlBhZ2UvZ3RrL1dlYlByaW50T3BlcmF0aW9uR3RrLmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvZ3RrL1dlYlByaW50T3BlcmF0aW9uR3RrLmNw cApAQCAtNTUsMjEgKzU1LDE1IEBAIHB1YmxpYzoKIAogICAgIHN0YXRpYyBnYm9vbGVhbiBlbnVt ZXJhdGVQcmludGVyc0Z1bmN0aW9uKEd0a1ByaW50ZXIqIHByaW50ZXIsIFdlYlByaW50T3BlcmF0 aW9uR3RrVW5peCogcHJpbnRPcGVyYXRpb24pCiAgICAgewotICAgICAgICBHdGtQcmludGVyKiBz ZWxlY3RlZFByaW50ZXIgPSAwOwogICAgICAgICBjb25zdCBjaGFyKiBwcmludGVyTmFtZSA9IGd0 a19wcmludF9zZXR0aW5nc19nZXRfcHJpbnRlcihwcmludE9wZXJhdGlvbi0+cHJpbnRTZXR0aW5n cygpKTsKLSAgICAgICAgaWYgKHByaW50ZXJOYW1lKSB7Ci0gICAgICAgICAgICBpZiAoIXN0cmNt cChwcmludGVyTmFtZSwgZ3RrX3ByaW50ZXJfZ2V0X25hbWUocHJpbnRlcikpKQotICAgICAgICAg ICAgICAgIHNlbGVjdGVkUHJpbnRlciA9IHByaW50ZXI7Ci0gICAgICAgIH0gZWxzZSBpZiAoZ3Rr X3ByaW50ZXJfaXNfZGVmYXVsdChwcmludGVyKSkKLSAgICAgICAgICAgIHNlbGVjdGVkUHJpbnRl ciA9IHByaW50ZXI7Ci0KLSAgICAgICAgaWYgKCFzZWxlY3RlZFByaW50ZXIpCisgICAgICAgIGlm ICgocHJpbnRlck5hbWUgJiYgc3RyY21wKHByaW50ZXJOYW1lLCBndGtfcHJpbnRlcl9nZXRfbmFt ZShwcmludGVyKSkpCisgICAgICAgICAgICB8fCAoIXByaW50ZXJOYW1lICYmICFndGtfcHJpbnRl cl9pc19kZWZhdWx0KHByaW50ZXIpKSkKICAgICAgICAgICAgIHJldHVybiBGQUxTRTsKIAogICAg ICAgICBzdGF0aWMgaW50IGpvYk51bWJlciA9IDA7CiAgICAgICAgIGNvbnN0IGNoYXIqIGFwcGxp Y2F0aW9uTmFtZSA9IGdfZ2V0X2FwcGxpY2F0aW9uX25hbWUoKTsKICAgICAgICAgR093blB0cjxj aGFyPmpvYk5hbWUoZ19zdHJkdXBfcHJpbnRmKCIlcyBqb2IgIyVkIiwgYXBwbGljYXRpb25OYW1l ID8gYXBwbGljYXRpb25OYW1lIDogIldlYktpdCIsICsram9iTnVtYmVyKSk7Ci0gICAgICAgIHBy aW50T3BlcmF0aW9uLT5tX3ByaW50Sm9iID0gYWRvcHRHUmVmKGd0a19wcmludF9qb2JfbmV3KGpv Yk5hbWUuZ2V0KCksIHNlbGVjdGVkUHJpbnRlciwKKyAgICAgICAgcHJpbnRPcGVyYXRpb24tPm1f cHJpbnRKb2IgPSBhZG9wdEdSZWYoZ3RrX3ByaW50X2pvYl9uZXcoam9iTmFtZS5nZXQoKSwgcHJp bnRlciwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgcHJpbnRPcGVyYXRpb24tPnByaW50U2V0dGluZ3MoKSwKICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg cHJpbnRPcGVyYXRpb24tPnBhZ2VTZXR1cCgpKSk7CiAgICAgICAgIHJldHVybiBUUlVFOwpAQCAt MzI3LDYgKzMyMSw3IEBAIHZvaWQgV2ViUHJpbnRPcGVyYXRpb25HdGs6OnJvdGF0ZVBhZ2UoKQog dm9pZCBXZWJQcmludE9wZXJhdGlvbkd0azo6cmVuZGVyUGFnZShpbnQgcGFnZU51bWJlcikKIHsK ICAgICBzdGFydFBhZ2UobV9jYWlyb0NvbnRleHQuZ2V0KCkpOworICAgIGNhaXJvX3NhdmUobV9j YWlyb0NvbnRleHQuZ2V0KCkpOwogCiAgICAgaWYgKG1fbmVlZHNSb3RhdGlvbikKICAgICAgICAg cm90YXRlUGFnZSgpOwpAQCAtMzQwLDYgKzMzNSw3IEBAIHZvaWQgV2ViUHJpbnRPcGVyYXRpb25H dGs6OnJlbmRlclBhZ2UoaW50IHBhZ2VOdW1iZXIpCiAgICAgV2ViQ29yZTo6R3JhcGhpY3NDb250 ZXh0IGdyYXBoaWNzQ29udGV4dCgmcGxhdGZvcm1Db250ZXh0KTsKICAgICBtX3ByaW50Q29udGV4 dC0+c3Bvb2xQYWdlKGdyYXBoaWNzQ29udGV4dCwgcGFnZU51bWJlciwgcGFnZVdpZHRoKTsKIAor ICAgIGNhaXJvX3Jlc3RvcmUobV9jYWlyb0NvbnRleHQuZ2V0KCkpOwogICAgIGVuZFBhZ2UobV9j YWlyb0NvbnRleHQuZ2V0KCkpOwogfQogCg==