78703 2012-02-15 05:31:26 -0800 Add script to determine which functions are affected by a patch 2012-11-22 03:49:16 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 78707 1 ossy webkit-unassigned ossy oldest_to_newest 557183 0 ossy 2012-02-15 05:31:26 -0800 It is needed for selective testing. 557237 1 127177 hnandor 2012-02-15 06:56:23 -0800 Created attachment 127177 Patch Determines the functions names with the help of prepare-ChangeLog. 557342 2 127177 darin 2012-02-15 10:00:48 -0800 Comment on attachment 127177 Patch The idea of this script seems fine. The name “generate functions” seems totally wrong though, since the script that does not generate functions. Maybe a name like “list modified functions”? 558013 3 127335 hnandor 2012-02-16 02:33:21 -0800 Created attachment 127335 Patch v2 (In reply to comment #10) Thank you for the comment, I have renamed it. 564447 4 127335 abarth 2012-02-24 10:41:51 -0800 Comment on attachment 127335 Patch v2 Why do we need a separate script for this? If you're planning to use this in webkitpy, we already have a function called changed_files which does this work. 773812 5 ossy 2012-11-22 03:49:16 -0800 You're right, we don't need separated script for this. 127177 2012-02-15 06:56:23 -0800 2012-02-16 02:33:21 -0800 Patch generatefunctions.diff text/plain 2345 hnandor ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhZTdm MGU0Li5mY2RlZGVhIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMDItMTUgIE7DoW5kb3IgSHVzemthICA8aHVz emthLm5hbmRvckBzdHVkLnUtc3plZ2VkLmh1PgorCisgICAgICAgIEFkZCBzY3JpcHQgdG8gZGV0 ZXJtaW5lIHdoaWNoIGZ1bmN0aW9ucyBhcmUgYWZmZWN0ZWQgYnkgYSBwYXRjaGFuYWx5c2lzdGFz aworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzg3MDMK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2VzIHRo ZSBwcmVwYXJlLUNoYW5nZUxvZydzIC0tbm8td3JpdGUgb3B0aW9uIHRvIGRldGVybWluZSB0aGUg bW9kaWZpZWQgZnVuY3Rpb25zLgorCisgICAgICAgICogU2NyaXB0cy9nZW5lcmF0ZS1mdW5jdGlv bnM6IEFkZGVkLgorCiAyMDEyLTAyLTE0ICBSYW15YSBDaGFuZHJhc2VrYXJhbiAgPGNyYW15YUBn b29nbGUuY29tPgogCiAgICAgICAgIExhc3QgY2hhcmFjdGVyIGRpc3BsYXkgZm9yIHBhc3N3b3Jk cyBpbiBBbmRyb2lkLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9nZW5lcmF0ZS1mdW5jdGlv bnMgYi9Ub29scy9TY3JpcHRzL2dlbmVyYXRlLWZ1bmN0aW9ucwpuZXcgZmlsZSBtb2RlIDEwMDc1 NQppbmRleCAwMDAwMDAwLi4yNzY1YjY2Ci0tLSAvZGV2L251bGwKKysrIGIvVG9vbHMvU2NyaXB0 cy9nZW5lcmF0ZS1mdW5jdGlvbnMKQEAgLTAsMCArMSwyNiBAQAorIyBDb3B5cmlnaHQgKEMpIDIw MTIgVW5pdmVyc2l0eSBvZiBTemVnZWQuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisjCisjIFJlZGlz dHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0 aG91dAorIyBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9s bG93aW5nIGNvbmRpdGlvbnMKKyMgYXJlIG1ldDoKKyMgMS4gUmVkaXN0cmlidXRpb25zIG9mIHNv dXJjZSBjb2RlIG11c3QgcmV0YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyMgICAgbm90aWNlLCB0 aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgorIyAy LiBSZWRpc3RyaWJ1dGlvbnMgaW4gYmluYXJ5IGZvcm0gbXVzdCByZXByb2R1Y2UgdGhlIGFib3Zl IGNvcHlyaWdodAorIyAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUg Zm9sbG93aW5nIGRpc2NsYWltZXIgaW4gdGhlCisjICAgIGRvY3VtZW50YXRpb24gYW5kL29yIG90 aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3aXRoIHRoZSBkaXN0cmlidXRpb24uCisjCisjIFRISVMg U09GVFdBUkUgSVMgUFJPVklERUQgQlkgVEhFIENPUFlSSUdIVCBIT0xERVJTIEFORCBDT05UUklC VVRPUlMKKyMgIkFTIElTIiBBTkQgQU5ZIEVYUFJFU1MgT1IgSU1QTElFRCBXQVJSQU5USUVTLCBJ TkNMVURJTkcsIEJVVCBOT1QKKyMgTElNSVRFRCBUTywgVEhFIElNUExJRUQgV0FSUkFOVElFUyBP RiBNRVJDSEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SCisjIEEgUEFSVElDVUxBUiBQVVJQT1NF IEFSRSBESVNDTEFJTUVELiBJTiBOTyBFVkVOVCBTSEFMTCBUSEUgQ09QWVJJR0hUCisjIE9XTkVS IE9SIENPTlRSSUJVVE9SUyBCRSBMSUFCTEUgRk9SIEFOWSBESVJFQ1QsIElORElSRUNULCBJTkNJ REVOVEFMLAorIyBTUEVDSUFMLCBFWEVNUExBUlksIE9SIENPTlNFUVVFTlRJQUwgREFNQUdFUyAo SU5DTFVESU5HLCBCVVQgTk9UCisjIExJTUlURUQgVE8sIFBST0NVUkVNRU5UIE9GIFNVQlNUSVRV VEUgR09PRFMgT1IgU0VSVklDRVM7IExPU1MgT0YgVVNFLAorIyBEQVRBLCBPUiBQUk9GSVRTOyBP UiBCVVNJTkVTUyBJTlRFUlJVUFRJT04pIEhPV0VWRVIgQ0FVU0VEIEFORCBPTiBBTlkKKyMgVEhF T1JZIE9GIExJQUJJTElUWSwgV0hFVEhFUiBJTiBDT05UUkFDVCwgU1RSSUNUIExJQUJJTElUWSwg T1IgVE9SVAorIyAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklTSU5HIElO IEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UKKyMgT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJ U0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KKworIyEvYmluL2Jhc2gKKwor ZWNobyBgVG9vbHMvU2NyaXB0cy9wcmVwYXJlLUNoYW5nZUxvZyAtLW5vLXdyaXRlIDI+JjEgfCBl Z3JlcCAiXCguKlwpXDoiIHwgc2VkICJzLygvL2ciIHwgc2VkICJzLyk6Ly9nImAgfCBzZWQgInMv IC9cbi9nIgo= 127335 2012-02-16 02:33:21 -0800 2012-02-24 10:41:50 -0800 Patch v2 listmodifiedfunctions.diff text/plain 2358 hnandor ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmZGEy YmIxLi4xZjc1NjlmIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMDItMTYgIE7DoW5kb3IgSHVzemthICA8aHVz emthLm5hbmRvckBzdHVkLnUtc3plZ2VkLmh1PgorCisgICAgICAgIEFkZCBzY3JpcHQgdG8gZGV0 ZXJtaW5lIHdoaWNoIGZ1bmN0aW9ucyBhcmUgYWZmZWN0ZWQgYnkgYSBwYXRjaGFuYWx5c2lzdGFz ay4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc4NzAz CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlcyB0 aGUgcHJlcGFyZS1DaGFuZ2VMb2cncyAtLW5vLXdyaXRlIG9wdGlvbiB0byBkZXRlcm1pbmUgdGhl IG1vZGlmaWVkIGZ1bmN0aW9ucy4KKworICAgICAgICAqIFNjcmlwdHMvbGlzdC1tb2RpZmllZC1m dW5jdGlvbnM6IEFkZGVkLgorCiAyMDEyLTAyLTE2ICBQYXRyaWNrIEdhbnN0ZXJlciAgPHBhcm9n YUB3ZWJraXQub3JnPgogCiAgICAgICAgIERpc2FibGUgaW5zcGVjdG9yIG9uIFdpbkNFLgpkaWZm IC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9saXN0LW1vZGlmaWVkLWZ1bmN0aW9ucyBiL1Rvb2xzL1Nj cmlwdHMvbGlzdC1tb2RpZmllZC1mdW5jdGlvbnMKaW5kZXggZTY5ZGUyOS4uMjc2NWI2NiAxMDA2 NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy9saXN0LW1vZGlmaWVkLWZ1bmN0aW9ucworKysgYi9Ub29s cy9TY3JpcHRzL2xpc3QtbW9kaWZpZWQtZnVuY3Rpb25zCkBAIC0wLDAgKzEsMjYgQEAKKyMgQ29w eXJpZ2h0IChDKSAyMDEyIFVuaXZlcnNpdHkgb2YgU3plZ2VkLiBBbGwgcmlnaHRzIHJlc2VydmVk LgorIworIyBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1z LCB3aXRoIG9yIHdpdGhvdXQKKyMgbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVk IHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCisjIGFyZSBtZXQ6CisjIDEuIFJlZGlzdHJp YnV0aW9ucyBvZiBzb3VyY2UgY29kZSBtdXN0IHJldGFpbiB0aGUgYWJvdmUgY29weXJpZ2h0Cisj ICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlz Y2xhaW1lci4KKyMgMi4gUmVkaXN0cmlidXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9k dWNlIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyMgICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0 aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyIGluIHRoZQorIyAgICBkb2N1bWVudGF0 aW9uIGFuZC9vciBvdGhlciBtYXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUgZGlzdHJpYnV0aW9u LgorIworIyBUSElTIFNPRlRXQVJFIElTIFBST1ZJREVEIEJZIFRIRSBDT1BZUklHSFQgSE9MREVS UyBBTkQgQ09OVFJJQlVUT1JTCisjICJBUyBJUyIgQU5EIEFOWSBFWFBSRVNTIE9SIElNUExJRUQg V0FSUkFOVElFUywgSU5DTFVESU5HLCBCVVQgTk9UCisjIExJTUlURUQgVE8sIFRIRSBJTVBMSUVE IFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFORCBGSVRORVNTIEZPUgorIyBBIFBBUlRJ Q1VMQVIgUFVSUE9TRSBBUkUgRElTQ0xBSU1FRC4gSU4gTk8gRVZFTlQgU0hBTEwgVEhFIENPUFlS SUdIVAorIyBPV05FUiBPUiBDT05UUklCVVRPUlMgQkUgTElBQkxFIEZPUiBBTlkgRElSRUNULCBJ TkRJUkVDVCwgSU5DSURFTlRBTCwKKyMgU1BFQ0lBTCwgRVhFTVBMQVJZLCBPUiBDT05TRVFVRU5U SUFMIERBTUFHRVMgKElOQ0xVRElORywgQlVUIE5PVAorIyBMSU1JVEVEIFRPLCBQUk9DVVJFTUVO VCBPRiBTVUJTVElUVVRFIEdPT0RTIE9SIFNFUlZJQ0VTOyBMT1NTIE9GIFVTRSwKKyMgREFUQSwg T1IgUFJPRklUUzsgT1IgQlVTSU5FU1MgSU5URVJSVVBUSU9OKSBIT1dFVkVSIENBVVNFRCBBTkQg T04gQU5ZCisjIFRIRU9SWSBPRiBMSUFCSUxJVFksIFdIRVRIRVIgSU4gQ09OVFJBQ1QsIFNUUklD VCBMSUFCSUxJVFksIE9SIFRPUlQKKyMgKElOQ0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lT RSkgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFCisjIE9GIFRISVMgU09GVFdBUkUs IEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCisKKyMh L2Jpbi9iYXNoCisKK2VjaG8gYFRvb2xzL1NjcmlwdHMvcHJlcGFyZS1DaGFuZ2VMb2cgLS1uby13 cml0ZSAyPiYxIHwgZWdyZXAgIlwoLipcKVw6IiB8IHNlZCAicy8oLy9nIiB8IHNlZCAicy8pOi8v ZyJgIHwgc2VkICJzLyAvXG4vZyIK