78683 2012-02-15 01:40:14 -0800 REGRESSION(r107518): DeviceOrientationController doesn't remove registered DOMWindows 2012-02-15 04:09:18 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 morrita morrita abarth haraken webkit.review.bot oldest_to_newest 557048 0 morrita 2012-02-15 01:40:14 -0800 Caught by http://crbug.com/113952 557072 1 127140 morrita 2012-02-15 02:21:57 -0800 Created attachment 127140 Patch 557073 2 morrita 2012-02-15 02:22:29 -0800 Haraken, could you rs? 557074 3 127140 haraken 2012-02-15 02:26:22 -0800 Comment on attachment 127140 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127140&action=review r=me > Source/WebCore/ChangeLog:8 > + A copy-n-paste disaster. This change fixed it by calling correct mehtods. Nit: mehtods => methods 557076 4 127141 morrita 2012-02-15 02:30:20 -0800 Created attachment 127141 Patch for landing 557077 5 morrita 2012-02-15 02:30:42 -0800 (In reply to comment #3) > (From update of attachment 127140 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=127140&action=review > > r=me > > > Source/WebCore/ChangeLog:8 > > + A copy-n-paste disaster. This change fixed it by calling correct mehtods. > > Nit: mehtods => methods Good catch! Fixed. 557114 6 127141 webkit.review.bot 2012-02-15 03:37:41 -0800 Comment on attachment 127141 Patch for landing Clearing flags on attachment: 127141 Committed r107799: <http://trac.webkit.org/changeset/107799> 557115 7 webkit.review.bot 2012-02-15 03:37:46 -0800 All reviewed patches have been landed. Closing bug. 557140 8 webkit.review.bot 2012-02-15 04:09:18 -0800 Attachment 127140 did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9 Updating OpenSource Index mismatch: 0dfd183742a71cb5de5dadc3ae177fc72b63a194 != 9cdcda984def14b8bf8a32b6da6784c8a6ef7b3a rereading 8567f8d3c2539a28a496edaf1048483e973975c2 M LayoutTests/fast/forms/radio-nested-labels.html M LayoutTests/ChangeLog 107798 = 3671b2d23de7ade4cb1d1e78a3f6f7673db6a6c9 already exists! Why are we refetching it? at /usr/lib/git-core/git-svn line 5210 Died at Tools/Scripts/update-webkit line 164. If any of these errors are false positives, please file a bug against check-webkit-style. 127140 2012-02-15 02:21:57 -0800 2012-02-15 02:30:14 -0800 Patch bug-78683-20120215192155.patch text/plain 3227 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3Nzc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWI0N2YwNzU0NzYwMjU4 MWIxNDE3YWI2NTM4NGUxMjgyN2U4NzFkZi4uYzFhYzAyNjNmMjIwYTQxMDM4NWJhYTZhN2YwOWY3 NWFlOTc4MGVhOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTAyLTE1ICBIYWpp bWUgTW9ycml0YSAgPG1vcnJpdGFAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04o cjEwNzUxOCk6IERldmljZU9yaWVudGF0aW9uQ29udHJvbGxlciBkb2Vzbid0IHJlbW92ZSByZWdp c3RlcmVkIERPTVdpbmRvd3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTc4NjgzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisg ICAgICAgIAorICAgICAgICBBIGNvcHktbi1wYXN0ZSBkaXNhc3Rlci4gVGhpcyBjaGFuZ2UgZml4 ZWQgaXQgYnkgY2FsbGluZyBjb3JyZWN0IG1laHRvZHMuCisKKyAgICAgICAgTm8gbmV3IHRlc3Rz LiBOZWVkcyBicm93c2VyIHNpZGUgbW9ja2luZyBmb3IgdGVzdGluZyB0aGlzLgorICAgICAgICBB IENocm9taXVtIGF1dG9tYXRlZCB0ZXN0IGNvdmVycyB0aGlzLgorCisgICAgICAgICogcGFnZS9E T01XaW5kb3cuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RE9NV2luZG93OjpyZW1vdmVBbGxFdmVu dExpc3RlbmVycyk6CisgICAgICAgICogcGFnZS9QYWdlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlBhZ2U6OnByb3ZpZGVTdXBwbGVtZW50KToKKyAgICAgICAgKFdlYkNvcmU6OlBhZ2U6OnJlcXVp cmVTdXBwbGVtZW50KToKKyAgICAgICAgKiBwYWdlL1BhZ2UuaDogRml4IHR5cG8uCisgICAgICAg IChQYWdlKToKKwogMjAxMi0wMi0xNCAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBn bWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjEwNzc2Ni4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmNwcCBiL1NvdXJjZS9XZWJD b3JlL3BhZ2UvRE9NV2luZG93LmNwcAppbmRleCAyMWM3YjA5MGFkMDBmZjNmZjMyYzU5YWNjNDI1 NzVhYjhjYjM3MmZhLi41NDEzYmRiZTYyNWEyY2JhMjQyZTYyNmRjNzQxMWE5Y2U2ZjM0MTIyIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcGFnZS9ET01XaW5kb3cuY3BwCkBAIC0xNjQ4LDkgKzE2NDgsOSBAQCB2b2lkIERP TVdpbmRvdzo6cmVtb3ZlQWxsRXZlbnRMaXN0ZW5lcnMoKQogCiAjaWYgRU5BQkxFKERFVklDRV9P UklFTlRBVElPTikKICAgICBpZiAoRGV2aWNlTW90aW9uQ29udHJvbGxlciogY29udHJvbGxlciA9 IERldmljZU1vdGlvbkNvbnRyb2xsZXI6OmZyb20oZnJhbWUoKSkpCi0gICAgICAgIGNvbnRyb2xs ZXItPmFkZExpc3RlbmVyKHRoaXMpOworICAgICAgICBjb250cm9sbGVyLT5yZW1vdmVBbGxMaXN0 ZW5lcnModGhpcyk7CiAgICAgaWYgKERldmljZU9yaWVudGF0aW9uQ29udHJvbGxlciogY29udHJv bGxlciA9IERldmljZU9yaWVudGF0aW9uQ29udHJvbGxlcjo6ZnJvbShmcmFtZSgpKSkKLSAgICAg ICAgY29udHJvbGxlci0+YWRkTGlzdGVuZXIodGhpcyk7CisgICAgICAgIGNvbnRyb2xsZXItPnJl bW92ZUFsbExpc3RlbmVycyh0aGlzKTsKICNlbmRpZgogCiAgICAgcmVtb3ZlQWxsVW5sb2FkRXZl bnRMaXN0ZW5lcnModGhpcyk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2Uu Y3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmNwcAppbmRleCAzOTA1NjE5OTQ4ODdkZGM4 NWNlNjhjYzEzMjhlZmU4NDhhY2FkOGQ1Li4yYzM1YjI2ZGQ4N2I0NThjNzU4YWEyZjU3MWVlZDcy ZTM4ZTZkYzkzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2UuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZS5jcHAKQEAgLTEwODcsMTMgKzEwODcsMTMgQEAgdm9p ZCBQYWdlOjphZGRSZWxldmFudFJlcGFpbnRlZE9iamVjdChSZW5kZXJPYmplY3QqIG9iamVjdCwg Y29uc3QgSW50UmVjdCYgb2JqZWMKIAogdm9pZCBQYWdlOjpwcm92aWRlU3VwcGxlbWVudChjb25z dCBBdG9taWNTdHJpbmcmIG5hbWUsIFBhc3NPd25QdHI8UGFnZVN1cHBsZW1lbnQ+IHN1cHBsZW1l bnQpCiB7Ci0gICAgQVNTRVJUKCFtX3N1cHBsaW1lbnRzLmdldChuYW1lLmltcGwoKSkpOwotICAg IG1fc3VwcGxpbWVudHMuc2V0KG5hbWUuaW1wbCgpLCBzdXBwbGVtZW50KTsKKyAgICBBU1NFUlQo IW1fc3VwcGxlbWVudHMuZ2V0KG5hbWUuaW1wbCgpKSk7CisgICAgbV9zdXBwbGVtZW50cy5zZXQo bmFtZS5pbXBsKCksIHN1cHBsZW1lbnQpOwogfQogCiBQYWdlU3VwcGxlbWVudCogUGFnZTo6cmVx dWlyZVN1cHBsZW1lbnQoY29uc3QgQXRvbWljU3RyaW5nJiBuYW1lKQogewotICAgIHJldHVybiBt X3N1cHBsaW1lbnRzLmdldChuYW1lLmltcGwoKSk7CisgICAgcmV0dXJuIG1fc3VwcGxlbWVudHMu Z2V0KG5hbWUuaW1wbCgpKTsKIH0KIAogUGFnZTo6UGFnZUNsaWVudHM6OlBhZ2VDbGllbnRzKCkK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZS5oIGIvU291cmNlL1dlYkNvcmUv cGFnZS9QYWdlLmgKaW5kZXggNzgxZmYwNTIwNzNlOTJkNzc0YWM4NmE3MjJiYTQ1OTVjNjJmMDk0 ZS4uNzdmMDc0ZjJmYzc2ZDRjMDEzMjZhODZmNDEwM2MzYmRmYWExZDgyMCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdl LmgKQEAgLTM1Miw3ICszNTIsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIHZvaWQg aW5pdEdyb3VwKCk7CiAKICAgICAgICAgdHlwZWRlZiBIYXNoTWFwPEF0b21pY1N0cmluZ0ltcGwq LCBPd25QdHI8UGFnZVN1cHBsZW1lbnQ+ID4gUGFnZVN1cHBsZW1lbnRNYXA7Ci0gICAgICAgIFBh Z2VTdXBwbGVtZW50TWFwIG1fc3VwcGxpbWVudHM7CisgICAgICAgIFBhZ2VTdXBwbGVtZW50TWFw IG1fc3VwcGxlbWVudHM7CiAKICNpZiBBU1NFUlRfRElTQUJMRUQKICAgICAgICAgdm9pZCBjaGVj a0ZyYW1lQ291bnRDb25zaXN0ZW5jeSgpIGNvbnN0IHsgfQo= 127141 2012-02-15 02:30:20 -0800 2012-02-15 03:37:41 -0800 Patch for landing bug-78683-20120215193018.patch text/plain 3225 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3Nzc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWI0N2YwNzU0NzYwMjU4 MWIxNDE3YWI2NTM4NGUxMjgyN2U4NzFkZi4uNjdlMGQyODQwZjQzN2JmMDJiNjU2MzZhNTE5ZTE4 ZWZhZWRkYTExZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTAyLTE1ICBIYWpp bWUgTW9ycml0YSAgPG1vcnJpdGFAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04o cjEwNzUxOCk6IERldmljZU9yaWVudGF0aW9uQ29udHJvbGxlciBkb2Vzbid0IHJlbW92ZSByZWdp c3RlcmVkIERPTVdpbmRvd3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTc4NjgzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgS2VudGFybyBIYXJhLgorICAg ICAgICAKKyAgICAgICAgQSBjb3B5LW4tcGFzdGUgZGlzYXN0ZXIuIFRoaXMgY2hhbmdlIGZpeGVk IGl0IGJ5IGNhbGxpbmcgY29ycmVjdCBtZXRob2RzLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4g TmVlZHMgYnJvd3NlciBzaWRlIG1vY2tpbmcgZm9yIHRlc3RpbmcgdGhpcy4KKyAgICAgICAgQSBD aHJvbWl1bSBhdXRvbWF0ZWQgdGVzdCBjb3ZlcnMgdGhpcy4KKworICAgICAgICAqIHBhZ2UvRE9N V2luZG93LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRPTVdpbmRvdzo6cmVtb3ZlQWxsRXZlbnRM aXN0ZW5lcnMpOgorICAgICAgICAqIHBhZ2UvUGFnZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQ YWdlOjpwcm92aWRlU3VwcGxlbWVudCk6CisgICAgICAgIChXZWJDb3JlOjpQYWdlOjpyZXF1aXJl U3VwcGxlbWVudCk6CisgICAgICAgICogcGFnZS9QYWdlLmg6IEZpeCB0eXBvLgorICAgICAgICAo UGFnZSk6CisKIDIwMTItMDItMTQgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21h aWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMDc3NjYuCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9wYWdlL0RPTVdpbmRvdy5jcHAKaW5kZXggMjFjN2IwOTBhZDAwZmYzZmYzMmM1OWFjYzQyNTc1 YWI4Y2IzNzJmYS4uNTQxM2JkYmU2MjVhMmNiYTI0MmU2MjZkYzc0MTFhOWNlNmYzNDEyMiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5kb3cuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BhZ2UvRE9NV2luZG93LmNwcApAQCAtMTY0OCw5ICsxNjQ4LDkgQEAgdm9pZCBET01X aW5kb3c6OnJlbW92ZUFsbEV2ZW50TGlzdGVuZXJzKCkKIAogI2lmIEVOQUJMRShERVZJQ0VfT1JJ RU5UQVRJT04pCiAgICAgaWYgKERldmljZU1vdGlvbkNvbnRyb2xsZXIqIGNvbnRyb2xsZXIgPSBE ZXZpY2VNb3Rpb25Db250cm9sbGVyOjpmcm9tKGZyYW1lKCkpKQotICAgICAgICBjb250cm9sbGVy LT5hZGRMaXN0ZW5lcih0aGlzKTsKKyAgICAgICAgY29udHJvbGxlci0+cmVtb3ZlQWxsTGlzdGVu ZXJzKHRoaXMpOwogICAgIGlmIChEZXZpY2VPcmllbnRhdGlvbkNvbnRyb2xsZXIqIGNvbnRyb2xs ZXIgPSBEZXZpY2VPcmllbnRhdGlvbkNvbnRyb2xsZXI6OmZyb20oZnJhbWUoKSkpCi0gICAgICAg IGNvbnRyb2xsZXItPmFkZExpc3RlbmVyKHRoaXMpOworICAgICAgICBjb250cm9sbGVyLT5yZW1v dmVBbGxMaXN0ZW5lcnModGhpcyk7CiAjZW5kaWYKIAogICAgIHJlbW92ZUFsbFVubG9hZEV2ZW50 TGlzdGVuZXJzKHRoaXMpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZS5jcHAKaW5kZXggMzkwNTYxOTk0ODg3ZGRjODVj ZTY4Y2MxMzI4ZWZlODQ4YWNhZDhkNS4uMmMzNWIyNmRkODdiNDU4Yzc1OGFhMmY1NzFlZWQ3MmUz OGU2ZGM5MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2UuY3BwCkBAIC0xMDg3LDEzICsxMDg3LDEzIEBAIHZvaWQg UGFnZTo6YWRkUmVsZXZhbnRSZXBhaW50ZWRPYmplY3QoUmVuZGVyT2JqZWN0KiBvYmplY3QsIGNv bnN0IEludFJlY3QmIG9iamVjCiAKIHZvaWQgUGFnZTo6cHJvdmlkZVN1cHBsZW1lbnQoY29uc3Qg QXRvbWljU3RyaW5nJiBuYW1lLCBQYXNzT3duUHRyPFBhZ2VTdXBwbGVtZW50PiBzdXBwbGVtZW50 KQogewotICAgIEFTU0VSVCghbV9zdXBwbGltZW50cy5nZXQobmFtZS5pbXBsKCkpKTsKLSAgICBt X3N1cHBsaW1lbnRzLnNldChuYW1lLmltcGwoKSwgc3VwcGxlbWVudCk7CisgICAgQVNTRVJUKCFt X3N1cHBsZW1lbnRzLmdldChuYW1lLmltcGwoKSkpOworICAgIG1fc3VwcGxlbWVudHMuc2V0KG5h bWUuaW1wbCgpLCBzdXBwbGVtZW50KTsKIH0KIAogUGFnZVN1cHBsZW1lbnQqIFBhZ2U6OnJlcXVp cmVTdXBwbGVtZW50KGNvbnN0IEF0b21pY1N0cmluZyYgbmFtZSkKIHsKLSAgICByZXR1cm4gbV9z dXBwbGltZW50cy5nZXQobmFtZS5pbXBsKCkpOworICAgIHJldHVybiBtX3N1cHBsZW1lbnRzLmdl dChuYW1lLmltcGwoKSk7CiB9CiAKIFBhZ2U6OlBhZ2VDbGllbnRzOjpQYWdlQ2xpZW50cygpCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2UuaCBiL1NvdXJjZS9XZWJDb3JlL3Bh Z2UvUGFnZS5oCmluZGV4IDc4MWZmMDUyMDczZTkyZDc3NGFjODZhNzIyYmE0NTk1YzYyZjA5NGUu Ljc3ZjA3NGYyZmM3NmQ0YzAxMzI2YTg2ZjQxMDNjM2JkZmFhMWQ4MjAgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BhZ2UvUGFnZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZS5o CkBAIC0zNTIsNyArMzUyLDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICB2b2lkIGlu aXRHcm91cCgpOwogCiAgICAgICAgIHR5cGVkZWYgSGFzaE1hcDxBdG9taWNTdHJpbmdJbXBsKiwg T3duUHRyPFBhZ2VTdXBwbGVtZW50PiA+IFBhZ2VTdXBwbGVtZW50TWFwOwotICAgICAgICBQYWdl U3VwcGxlbWVudE1hcCBtX3N1cHBsaW1lbnRzOworICAgICAgICBQYWdlU3VwcGxlbWVudE1hcCBt X3N1cHBsZW1lbnRzOwogCiAjaWYgQVNTRVJUX0RJU0FCTEVECiAgICAgICAgIHZvaWQgY2hlY2tG cmFtZUNvdW50Q29uc2lzdGVuY3koKSBjb25zdCB7IH0K