78668 2012-02-14 21:52:55 -0800 Remove an unnecessary public static factory function from ShadowRoot. 2012-02-15 00:22:32 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 63606 1 hayato hayato dglazkov dominicc morrita rolandsteiner shinyak webkit.review.bot oldest_to_newest 556924 0 hayato 2012-02-14 21:52:55 -0800 We don't have a client which calls the following public static function: static PassRefPtr<ShadowRoot> create(Document*); That should not be exposed. 556928 1 127114 hayato 2012-02-14 21:58:23 -0800 Created attachment 127114 remove a factory 556932 2 127114 tkent 2012-02-14 22:09:01 -0800 Comment on attachment 127114 remove a factory ok 556951 3 127120 hayato 2012-02-14 23:03:20 -0800 Created attachment 127120 Patch for landing 556972 4 127120 webkit.review.bot 2012-02-15 00:22:28 -0800 Comment on attachment 127120 Patch for landing Clearing flags on attachment: 127120 Committed r107786: <http://trac.webkit.org/changeset/107786> 556973 5 webkit.review.bot 2012-02-15 00:22:32 -0800 All reviewed patches have been landed. Closing bug. 127114 2012-02-14 21:58:23 -0800 2012-02-14 23:03:14 -0800 remove a factory bug-78668-20120215145822.patch text/plain 2468 hayato U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3NzcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTljMDAxYWQ4NzNlYjNl ZTlkZGQ0ZDA4YzYxNTQ0YTAzZmU4ODk0ZC4uOGUxMTQ1NTI2MTVhYTA4ODRmYjYyYmQ1MzAyNTI3 MWM0MWYyYTliYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAyLTE0ICBIYXlh dG8gSXRvICA8aGF5YXRvQGNocm9taXVtLm9yZz4KKworICAgICAgICBTaGFkb3dSb290OiBSZW1v dmUgYSBwdWJsaWMgc3RhdGljIGZhY3RvcnkgZnVuY3Rpb24gd2hpY2ggZG9uJ3QgaGF2ZSBhbnkg Y2FsbGVycy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTc4NjY4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Tm8gdGVzdHMuIE5vIGNoYW5nZSBpbiBiZWhhdmlvci4KKworICAgICAgICAqIGRvbS9TaGFkb3dS b290LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNoYWRvd1Jvb3Q6OmNyZWF0ZSk6CisgICAgICAg ICogZG9tL1NoYWRvd1Jvb3QuaDoKKyAgICAgICAgKFNoYWRvd1Jvb3QpOgorCiAyMDEyLTAyLTE0 ICBLZW50YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbSlNDXSBD YWNoZSB0aGUgbnVtYmVyIG9mIG5vbi1jdXN0b20gY29uc3RydWN0b3IgYXJndW1lbnRzCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vU2hhZG93Um9vdC5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9kb20vU2hhZG93Um9vdC5jcHAKaW5kZXggMGNiOGM5ZDBkNzY4ZDExOTc2ZmM5NTMwYWE0MWUx MmI1YTlhZTEyYi4uZWY5ZmYwMTQ5NjU0MmRjZTMzNDEwODdkMTM0NGJjZDIxM2QzMTFiZSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL1NoYWRvd1Jvb3QuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2RvbS9TaGFkb3dSb290LmNwcApAQCAtMTEwLDcgKzExMCw3IEBAIFBhc3NSZWZQdHI8 U2hhZG93Um9vdD4gU2hhZG93Um9vdDo6Y3JlYXRlKEVsZW1lbnQqIGVsZW1lbnQsIFNoYWRvd1Jv b3RDcmVhdGlvblB1CiAgICAgfQogCiAgICAgQVNTRVJUKHB1cnBvc2UgIT0gQ3JlYXRpbmdVc2Vy QWdlbnRTaGFkb3dSb290IHx8ICFlbGVtZW50LT5oYXNTaGFkb3dSb290KCkpOwotICAgIFJlZlB0 cjxTaGFkb3dSb290PiBzaGFkb3dSb290ID0gY3JlYXRlKGVsZW1lbnQtPmRvY3VtZW50KCkpOwor ICAgIFJlZlB0cjxTaGFkb3dSb290PiBzaGFkb3dSb290ID0gYWRvcHRSZWYobmV3IFNoYWRvd1Jv b3QoZWxlbWVudC0+ZG9jdW1lbnQoKSkpOwogCiAgICAgZWMgPSAwOwogICAgIGVsZW1lbnQtPnNl dFNoYWRvd1Jvb3Qoc2hhZG93Um9vdCwgZWMpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv ZG9tL1NoYWRvd1Jvb3QuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9TaGFkb3dSb290LmgKaW5kZXgg YmE0NTNhY2I5MGVhZWQ5M2JkMWNhYTdlM2UzMTRlZTcwMGM3YzI5Ny4uODNlMTcxMzQ5OTUyOWU0 NjRkOGMzNjA5OWJmZGQ1YmMxNWY0YzFlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9t L1NoYWRvd1Jvb3QuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vU2hhZG93Um9vdC5oCkBAIC00 MSw3ICs0MSw2IEBAIGNsYXNzIEhUTUxDb250ZW50U2VsZWN0b3I7CiBjbGFzcyBTaGFkb3dSb290 IDogcHVibGljIERvY3VtZW50RnJhZ21lbnQsIHB1YmxpYyBUcmVlU2NvcGUsIHB1YmxpYyBEb3Vi bHlMaW5rZWRMaXN0Tm9kZTxTaGFkb3dSb290PiB7CiAgICAgZnJpZW5kIGNsYXNzIFdURjo6RG91 Ymx5TGlua2VkTGlzdE5vZGU8U2hhZG93Um9vdD47CiBwdWJsaWM6Ci0gICAgc3RhdGljIFBhc3NS ZWZQdHI8U2hhZG93Um9vdD4gY3JlYXRlKERvY3VtZW50Kik7CiAgICAgc3RhdGljIFBhc3NSZWZQ dHI8U2hhZG93Um9vdD4gY3JlYXRlKEVsZW1lbnQqLCBFeGNlcHRpb25Db2RlJik7CiAKICAgICAv LyBGSVhNRTogV2Ugd2lsbCBzdXBwb3J0IG11bHRpcGxlIHNoYWRvdyBzdWJ0cmVlcywgaG93ZXZl ciBjdXJyZW50IGltcGxlbWVudGF0aW9uIGRvZXMgbm90IHdvcmsgd2VsbApAQCAtOTUsMTEgKzk0 LDYgQEAgcHJpdmF0ZToKICAgICBPd25QdHI8SFRNTENvbnRlbnRTZWxlY3Rvcj4gbV9zZWxlY3Rv cjsKIH07CiAKLWlubGluZSBQYXNzUmVmUHRyPFNoYWRvd1Jvb3Q+IFNoYWRvd1Jvb3Q6OmNyZWF0 ZShEb2N1bWVudCogZG9jdW1lbnQpCi17Ci0gICAgcmV0dXJuIGFkb3B0UmVmKG5ldyBTaGFkb3dS b290KGRvY3VtZW50KSk7Ci19Ci0KIGlubGluZSB2b2lkIFNoYWRvd1Jvb3Q6OmNsZWFyTmVlZHNS ZWF0dGFjaEhvc3RDaGlsZHJlbkFuZFNoYWRvdygpCiB7CiAgICAgbV9uZWVkc1JlY2FsY3VsYXRl Q29udGVudCA9IGZhbHNlOwo= 127120 2012-02-14 23:03:20 -0800 2012-02-15 00:22:28 -0800 Patch for landing bug-78668-20120215160318.patch text/plain 2467 hayato U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3NzcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTljMDAxYWQ4NzNlYjNl ZTlkZGQ0ZDA4YzYxNTQ0YTAzZmU4ODk0ZC4uMjgwMTg5Yjc4OTE5MWI3ZWM0Njg4OGE4Y2Y1NWU0 M2ZlYjJiYmExOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAyLTE0ICBIYXlh dG8gSXRvICA8aGF5YXRvQGNocm9taXVtLm9yZz4KKworICAgICAgICBTaGFkb3dSb290OiBSZW1v dmUgYSBwdWJsaWMgc3RhdGljIGZhY3RvcnkgZnVuY3Rpb24gd2hpY2ggZG9lc24ndCBoYXZlIGFu eSBjYWxsZXJzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9Nzg2NjgKKworICAgICAgICBSZXZpZXdlZCBieSBLZW50IFRhbXVyYS4KKworICAgICAgICBO byB0ZXN0cy4gTm8gY2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAgICAgICogZG9tL1NoYWRvd1Jv b3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2hhZG93Um9vdDo6Y3JlYXRlKToKKyAgICAgICAg KiBkb20vU2hhZG93Um9vdC5oOgorICAgICAgICAoU2hhZG93Um9vdCk6CisKIDIwMTItMDItMTQg IEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtKU0NdIENh Y2hlIHRoZSBudW1iZXIgb2Ygbm9uLWN1c3RvbSBjb25zdHJ1Y3RvciBhcmd1bWVudHMKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9TaGFkb3dSb290LmNwcCBiL1NvdXJjZS9XZWJDb3Jl L2RvbS9TaGFkb3dSb290LmNwcAppbmRleCAwY2I4YzlkMGQ3NjhkMTE5NzZmYzk1MzBhYTQxZTEy YjVhOWFlMTJiLi5lZjlmZjAxNDk2NTQyZGNlMzM0MTA4N2QxMzQ0YmNkMjEzZDMxMWJlIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vU2hhZG93Um9vdC5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvZG9tL1NoYWRvd1Jvb3QuY3BwCkBAIC0xMTAsNyArMTEwLDcgQEAgUGFzc1JlZlB0cjxT aGFkb3dSb290PiBTaGFkb3dSb290OjpjcmVhdGUoRWxlbWVudCogZWxlbWVudCwgU2hhZG93Um9v dENyZWF0aW9uUHUKICAgICB9CiAKICAgICBBU1NFUlQocHVycG9zZSAhPSBDcmVhdGluZ1VzZXJB Z2VudFNoYWRvd1Jvb3QgfHwgIWVsZW1lbnQtPmhhc1NoYWRvd1Jvb3QoKSk7Ci0gICAgUmVmUHRy PFNoYWRvd1Jvb3Q+IHNoYWRvd1Jvb3QgPSBjcmVhdGUoZWxlbWVudC0+ZG9jdW1lbnQoKSk7Cisg ICAgUmVmUHRyPFNoYWRvd1Jvb3Q+IHNoYWRvd1Jvb3QgPSBhZG9wdFJlZihuZXcgU2hhZG93Um9v dChlbGVtZW50LT5kb2N1bWVudCgpKSk7CiAKICAgICBlYyA9IDA7CiAgICAgZWxlbWVudC0+c2V0 U2hhZG93Um9vdChzaGFkb3dSb290LCBlYyk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9k b20vU2hhZG93Um9vdC5oIGIvU291cmNlL1dlYkNvcmUvZG9tL1NoYWRvd1Jvb3QuaAppbmRleCBi YTQ1M2FjYjkwZWFlZDkzYmQxY2FhN2UzZTMxNGVlNzAwYzdjMjk3Li44M2UxNzEzNDk5NTI5ZTQ2 NGQ4YzM2MDk5YmZkZDViYzE1ZjRjMWUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20v U2hhZG93Um9vdC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9TaGFkb3dSb290LmgKQEAgLTQx LDcgKzQxLDYgQEAgY2xhc3MgSFRNTENvbnRlbnRTZWxlY3RvcjsKIGNsYXNzIFNoYWRvd1Jvb3Qg OiBwdWJsaWMgRG9jdW1lbnRGcmFnbWVudCwgcHVibGljIFRyZWVTY29wZSwgcHVibGljIERvdWJs eUxpbmtlZExpc3ROb2RlPFNoYWRvd1Jvb3Q+IHsKICAgICBmcmllbmQgY2xhc3MgV1RGOjpEb3Vi bHlMaW5rZWRMaXN0Tm9kZTxTaGFkb3dSb290PjsKIHB1YmxpYzoKLSAgICBzdGF0aWMgUGFzc1Jl ZlB0cjxTaGFkb3dSb290PiBjcmVhdGUoRG9jdW1lbnQqKTsKICAgICBzdGF0aWMgUGFzc1JlZlB0 cjxTaGFkb3dSb290PiBjcmVhdGUoRWxlbWVudCosIEV4Y2VwdGlvbkNvZGUmKTsKIAogICAgIC8v IEZJWE1FOiBXZSB3aWxsIHN1cHBvcnQgbXVsdGlwbGUgc2hhZG93IHN1YnRyZWVzLCBob3dldmVy IGN1cnJlbnQgaW1wbGVtZW50YXRpb24gZG9lcyBub3Qgd29yayB3ZWxsCkBAIC05NSwxMSArOTQs NiBAQCBwcml2YXRlOgogICAgIE93blB0cjxIVE1MQ29udGVudFNlbGVjdG9yPiBtX3NlbGVjdG9y OwogfTsKIAotaW5saW5lIFBhc3NSZWZQdHI8U2hhZG93Um9vdD4gU2hhZG93Um9vdDo6Y3JlYXRl KERvY3VtZW50KiBkb2N1bWVudCkKLXsKLSAgICByZXR1cm4gYWRvcHRSZWYobmV3IFNoYWRvd1Jv b3QoZG9jdW1lbnQpKTsKLX0KLQogaW5saW5lIHZvaWQgU2hhZG93Um9vdDo6Y2xlYXJOZWVkc1Jl YXR0YWNoSG9zdENoaWxkcmVuQW5kU2hhZG93KCkKIHsKICAgICBtX25lZWRzUmVjYWxjdWxhdGVD b250ZW50ID0gZmFsc2U7Cg==