78659 2012-02-14 18:25:15 -0800 IndexedDB: webFrame isn't threadsafe, don't use it from a worker thread 2012-02-21 11:25:11 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dgrogan dgrogan jsbell michaeln tony webkit.review.bot oldest_to_newest 556850 0 dgrogan 2012-02-14 18:25:15 -0800 IndexedDB: webFrame isn't threadsafe, don't use it from a worker thread 556851 1 127095 dgrogan 2012-02-14 18:25:59 -0800 Created attachment 127095 Patch 556854 2 dgrogan 2012-02-14 18:27:57 -0800 Note to self: What does CurrentWorkerId() return when run from a shared worker's context thread? 557387 3 dgrogan 2012-02-15 10:48:12 -0800 This is the change Michael suggested in https://chromiumcodereview.appspot.com/9375024/#msg4 558391 4 jsbell 2012-02-16 11:42:20 -0800 lgtm 558757 5 127483 dgrogan 2012-02-16 17:45:43 -0800 Created attachment 127483 Patch 558758 6 dgrogan 2012-02-16 17:47:00 -0800 Tony, could you review yet another small indexed database patch? 560976 7 127483 tony 2012-02-21 09:58:20 -0800 Comment on attachment 127483 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127483&action=review > Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp:190 > + m_webIDBFactory->open(name, new WebIDBCallbacksImpl(callbacks), origin, /*webFrame*/0, dataDir); Nit: I'm not sure it's worth having the param inline comment. *shrug* 560987 8 127483 dgrogan 2012-02-21 10:14:18 -0800 Comment on attachment 127483 Patch Thanks for the review! 561070 9 127483 webkit.review.bot 2012-02-21 11:25:06 -0800 Comment on attachment 127483 Patch Clearing flags on attachment: 127483 Committed r108375: <http://trac.webkit.org/changeset/108375> 561071 10 webkit.review.bot 2012-02-21 11:25:11 -0800 All reviewed patches have been landed. Closing bug. 127095 2012-02-14 18:25:59 -0800 2012-02-16 17:45:41 -0800 Patch bug-78659-20120214182558.patch text/plain 1893 dgrogan U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3NzA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGM2ZWU4MTBjZmY5MWY4ZDU4ZTVhYTg0NGUwMzNkMGVmZGNiNjQ0M2QuLjYzNGYyYmYyM2E1OTRj ZjQzYjhjYzQ4YjQ2MDMxODA1NTk3MzQwODcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTItMDItMTQgIERhdmlkIEdyb2dhbiAgPGRncm9nYW5AY2hyb21p dW0ub3JnPgorCisgICAgICAgIEluZGV4ZWREQjogd2ViRnJhbWUgaXNuJ3QgdGhyZWFkc2FmZSwg ZG9uJ3QgdXNlIGl0IGZyb20gYSB3b3JrZXIgdGhyZWFkCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03ODY1OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogc3JjL0lEQkZhY3RvcnlCYWNrZW5kUHJveHkuY3Bw OgorICAgICAgICAoV2ViS2l0OjpJREJGYWN0b3J5QmFja2VuZFByb3h5OjpvcGVuRnJvbVdvcmtl cik6CisKIDIwMTItMDItMTQgIFZzZXZvbG9kIFZsYXNvdiAgPHZzZXZpa0BjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogTWFrZSBTY3JpcHRzTmF2aWdhdG9yIGRlZmF1bHQg ZmlsZSBzZWxlY3Rvci4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0lE QkZhY3RvcnlCYWNrZW5kUHJveHkuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvSURC RmFjdG9yeUJhY2tlbmRQcm94eS5jcHAKaW5kZXggNDI5NTM0MDI2NzJmYzMzMzk0ZmYyOWIxYzYy NDRhYjA5ZGE4MmY3Mi4uYTFjY2U0NWIwYjQ4NDkwNDcyNWU0ZWNhYTdiZmMxNzEwYzhlMjljMCAx MDA3NTUKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvSURCRmFjdG9yeUJhY2tlbmRQ cm94eS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvSURCRmFjdG9yeUJhY2tl bmRQcm94eS5jcHAKQEAgLTE4NywxNSArMTg3LDcgQEAgdm9pZCBJREJGYWN0b3J5QmFja2VuZFBy b3h5OjpvcGVuRnJvbVdvcmtlcihjb25zdCBTdHJpbmcmIG5hbWUsIElEQkNhbGxiYWNrcyogY2EK ICAgICAgICAgY2FsbGJhY2tzLT5vbkVycm9yKFdlYklEQkRhdGFiYXNlRXJyb3IoMCwgIlRoZSB1 c2VyIGRlbmllZCBwZXJtaXNzaW9uIHRvIGFjY2VzcyB0aGUgZGF0YWJhc2UuIikpOwogICAgICAg ICByZXR1cm47CiAgICAgfQotICAgIFdvcmtlckxvYWRlclByb3h5KiB3b3JrZXJMb2FkZXJQcm94 eSA9ICZjb250ZXh0LT50aHJlYWQoKS0+d29ya2VyTG9hZGVyUHJveHkoKTsKLSAgICBXZWJXb3Jr ZXJCYXNlKiB3ZWJXb3JrZXIgPSBzdGF0aWNfY2FzdDxXZWJXb3JrZXJCYXNlKj4od29ya2VyTG9h ZGVyUHJveHkpOwotICAgIFdlYlZpZXcqIHdlYlZpZXcgPSB3ZWJXb3JrZXItPnZpZXcoKTsKLSAg ICBpZiAoIXdlYlZpZXcpIHsKLSAgICAgICAgLy8gRnJhbWUgaXMgY2xvc2VkLCB3b3JrZXIgaXMg dGVybWluYXJpbmcuCi0gICAgICAgIHJldHVybjsKLSAgICB9Ci0gICAgV2ViRnJhbWUqIHdlYkZy YW1lID0gd2ViVmlldy0+bWFpbkZyYW1lKCk7Ci0gICAgbV93ZWJJREJGYWN0b3J5LT5vcGVuKG5h bWUsIG5ldyBXZWJJREJDYWxsYmFja3NJbXBsKGNhbGxiYWNrcyksIG9yaWdpbiwgd2ViRnJhbWUs IGRhdGFEaXIpOworICAgIG1fd2ViSURCRmFjdG9yeS0+b3BlbihuYW1lLCBuZXcgV2ViSURCQ2Fs bGJhY2tzSW1wbChjYWxsYmFja3MpLCBvcmlnaW4sIC8qd2ViRnJhbWUqLzAsIGRhdGFEaXIpOwog I2VuZGlmCiB9CiAK 127483 2012-02-16 17:45:43 -0800 2012-02-21 11:25:06 -0800 Patch bug-78659-20120216174542.patch text/plain 2109 dgrogan U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3NzA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGM2ZWU4MTBjZmY5MWY4ZDU4ZTVhYTg0NGUwMzNkMGVmZGNiNjQ0M2QuLjBhMThiMGMzZDllM2Yx MGQwOWJkNTg0ZDFjMTVhZDNjM2ZlOWIyOTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTItMDItMTQgIERhdmlkIEdyb2dhbiAgPGRncm9nYW5AY2hyb21p dW0ub3JnPgorCisgICAgICAgIEluZGV4ZWREQjogd2ViRnJhbWUgaXNuJ3QgdGhyZWFkc2FmZSwg ZG9uJ3QgdXNlIGl0IGZyb20gYSB3b3JrZXIgdGhyZWFkCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03ODY1OQorCisgICAgICAgIEFmdGVyIGNycmV2LmNv bS8xMjE2NjksIGluZGV4ZWQgZGIgZG9lc24ndCB1c2UgdGhlIHdlYiBmcmFtZSBmb3IKKyAgICAg ICAgYW55dGhpbmcgaWYgY2FsbGVkIGZyb20gYSB3ZWIgd29ya2VyLgorCisgICAgICAgIE5vIG5l dyB0ZXN0cyAtIHRoaXMgY2hlY2sgd2FzIGRlZmVuc2l2ZSBhbmQgcG9zc2libHkgbm90IGV2ZXIK KyAgICAgICAgdHJpZ2dlcmVkLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogc3JjL0lEQkZhY3RvcnlCYWNrZW5kUHJveHkuY3BwOgorICAgICAgICAo V2ViS2l0OjpJREJGYWN0b3J5QmFja2VuZFByb3h5OjpvcGVuRnJvbVdvcmtlcik6CisKIDIwMTIt MDItMTQgIFZzZXZvbG9kIFZsYXNvdiAgPHZzZXZpa0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg V2ViIEluc3BlY3RvcjogTWFrZSBTY3JpcHRzTmF2aWdhdG9yIGRlZmF1bHQgZmlsZSBzZWxlY3Rv ci4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0lEQkZhY3RvcnlCYWNr ZW5kUHJveHkuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvSURCRmFjdG9yeUJhY2tl bmRQcm94eS5jcHAKaW5kZXggNDI5NTM0MDI2NzJmYzMzMzk0ZmYyOWIxYzYyNDRhYjA5ZGE4MmY3 Mi4uYTFjY2U0NWIwYjQ4NDkwNDcyNWU0ZWNhYTdiZmMxNzEwYzhlMjljMCAxMDA3NTUKLS0tIGEv U291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvSURCRmFjdG9yeUJhY2tlbmRQcm94eS5jcHAKKysr IGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvSURCRmFjdG9yeUJhY2tlbmRQcm94eS5jcHAK QEAgLTE4NywxNSArMTg3LDcgQEAgdm9pZCBJREJGYWN0b3J5QmFja2VuZFByb3h5OjpvcGVuRnJv bVdvcmtlcihjb25zdCBTdHJpbmcmIG5hbWUsIElEQkNhbGxiYWNrcyogY2EKICAgICAgICAgY2Fs bGJhY2tzLT5vbkVycm9yKFdlYklEQkRhdGFiYXNlRXJyb3IoMCwgIlRoZSB1c2VyIGRlbmllZCBw ZXJtaXNzaW9uIHRvIGFjY2VzcyB0aGUgZGF0YWJhc2UuIikpOwogICAgICAgICByZXR1cm47CiAg ICAgfQotICAgIFdvcmtlckxvYWRlclByb3h5KiB3b3JrZXJMb2FkZXJQcm94eSA9ICZjb250ZXh0 LT50aHJlYWQoKS0+d29ya2VyTG9hZGVyUHJveHkoKTsKLSAgICBXZWJXb3JrZXJCYXNlKiB3ZWJX b3JrZXIgPSBzdGF0aWNfY2FzdDxXZWJXb3JrZXJCYXNlKj4od29ya2VyTG9hZGVyUHJveHkpOwot ICAgIFdlYlZpZXcqIHdlYlZpZXcgPSB3ZWJXb3JrZXItPnZpZXcoKTsKLSAgICBpZiAoIXdlYlZp ZXcpIHsKLSAgICAgICAgLy8gRnJhbWUgaXMgY2xvc2VkLCB3b3JrZXIgaXMgdGVybWluYXJpbmcu Ci0gICAgICAgIHJldHVybjsKLSAgICB9Ci0gICAgV2ViRnJhbWUqIHdlYkZyYW1lID0gd2ViVmll dy0+bWFpbkZyYW1lKCk7Ci0gICAgbV93ZWJJREJGYWN0b3J5LT5vcGVuKG5hbWUsIG5ldyBXZWJJ REJDYWxsYmFja3NJbXBsKGNhbGxiYWNrcyksIG9yaWdpbiwgd2ViRnJhbWUsIGRhdGFEaXIpOwor ICAgIG1fd2ViSURCRmFjdG9yeS0+b3BlbihuYW1lLCBuZXcgV2ViSURCQ2FsbGJhY2tzSW1wbChj YWxsYmFja3MpLCBvcmlnaW4sIC8qd2ViRnJhbWUqLzAsIGRhdGFEaXIpOwogI2VuZGlmCiB9CiAK